@atlaskit/react-ufo 4.14.6 → 4.14.8

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlaskit/ufo-interaction-ignore
 
+## 4.14.8
+
+### Patch Changes
+
+- [`60636efa6fba9`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/60636efa6fba9) -
+  exclude media mutation from ttvc if matching DnD style change, localId and contenteditable
+  attribute change, as they are non-visual changes
+
+## 4.14.7
+
+### Patch Changes
+
+- [`ae14db0f1f0c7`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ae14db0f1f0c7) -
+  Add isDnDStyleMutation back to attribute change detection in vc observer
+
 ## 4.14.6
 
 ### Patch Changes

package/dist/cjs/vc/vc-observer/observers/non-visual-styles/is-dnd-style-mutation.js

@@ -3,7 +3,9 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
+exports.containsDnDMutationInStyle = containsDnDMutationInStyle;
 exports.default = void 0;
+exports.isDnDStyleMutation = isDnDStyleMutation;
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
 function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
@@ -52,6 +54,16 @@ function isDnDStyleMutation(_ref) {
   if (!(target instanceof Element)) {
     return false;
   }
+  return containsDnDMutationInStyle({
+    attributeName: attributeName,
+    oldValue: oldValue,
+    newValue: newValue
+  });
+}
+function containsDnDMutationInStyle(_ref2) {
+  var attributeName = _ref2.attributeName,
+    oldValue = _ref2.oldValue,
+    newValue = _ref2.newValue;
   if (attributeName !== 'style') {
     return false;
   }

package/dist/cjs/vc/vc-observer-new/metric-calculator/fy25_03/index.js

@@ -11,6 +11,8 @@ var _possibleConstructorReturn2 = _interopRequireDefault(require("@babel/runtime
 var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/getPrototypeOf"));
 var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
+var _expVal = require("../../../expVal");
+var _isDndStyleMutation = require("../../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation");
 var _abstractBaseVcCalculator = _interopRequireDefault(require("../abstract-base-vc-calculator"));
 var _isEntrySmartAnswersInSearch = require("../utils/is-entry-smart-answers-in-search");
 var _isViewportEntryData = _interopRequireDefault(require("../utils/is-viewport-entry-data"));
@@ -63,9 +65,20 @@ var VCCalculator_FY25_03 = exports.default = /*#__PURE__*/function (_AbstractVCC
       if (entry.data.type === 'mutation:media' && (0, _platformFeatureFlags.fg)('media-perf-uplift-mutation-fix')) {
         var entryData = entry.data;
         var attributeName = entryData.attributeName;
-        if (attributeName && (/data-(test|file|context)-\S+/g.test(attributeName) || attributeName === 'alt')) {
+        if (attributeName && (/data-(test|file|context)-\S+/g.test(attributeName) || attributeName === 'alt' || (attributeName === 'localid' || attributeName === 'contenteditable' || attributeName === 'anchor-name') && (0, _expVal.expVal)('platform_editor_media_vc_fixes', 'isEnabled', false))) {
           return false;
         }
+
+        // special case for style attribute to ignore only anchor-name changes
+        if ((0, _expVal.expVal)('platform_editor_media_vc_fixes', 'isEnabled', false)) {
+          if ((0, _isDndStyleMutation.containsDnDMutationInStyle)({
+            attributeName: entryData.attributeName,
+            oldValue: entryData.oldValue,
+            newValue: entryData.newValue
+          })) {
+            return false;
+          }
+        }
       }
       if (entry.data.type === 'mutation:attribute') {
         var _entryData = entry.data;

package/dist/cjs/vc/vc-observer-new/viewport-observer/index.js

@@ -13,6 +13,7 @@ var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/creat
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _vcUtils = require("../../vc-observer/media-wrapper/vc-utils");
+var _isDndStyleMutation = _interopRequireDefault(require("../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation"));
 var _isNonVisualStyleMutation = _interopRequireDefault(require("../../vc-observer/observers/non-visual-styles/is-non-visual-style-mutation"));
 var _rllPlaceholders = require("../../vc-observer/observers/rll-placeholders");
 var _intersectionObserver = require("./intersection-observer");
@@ -317,6 +318,21 @@ var ViewportObserver = exports.default = /*#__PURE__*/function () {
             };
           }
         }
+        if ((0, _isDndStyleMutation.default)({
+          target: target,
+          attributeName: attributeName,
+          oldValue: oldValue,
+          newValue: newValue
+        })) {
+          return {
+            type: 'mutation:attribute:non-visual-style',
+            mutationData: {
+              attributeName: attributeName,
+              oldValue: oldValue,
+              newValue: newValue
+            }
+          };
+        }
         if ((0, _isNonVisualStyleMutation.default)({
           target: target,
           attributeName: attributeName,

package/dist/es2019/vc/vc-observer/observers/non-visual-styles/is-dnd-style-mutation.js

@@ -35,6 +35,17 @@ function isDnDStyleMutation({
   if (!(target instanceof Element)) {
     return false;
   }
+  return containsDnDMutationInStyle({
+    attributeName,
+    oldValue,
+    newValue
+  });
+}
+function containsDnDMutationInStyle({
+  attributeName,
+  oldValue,
+  newValue
+}) {
   if (attributeName !== 'style') {
     return false;
   }
@@ -59,4 +70,5 @@ function isDnDStyleMutation({
   }
   return isDnDMutation;
 }
-export default isDnDStyleMutation;
+export default isDnDStyleMutation;
+export { isDnDStyleMutation, containsDnDMutationInStyle };

package/dist/es2019/vc/vc-observer-new/metric-calculator/fy25_03/index.js

@@ -1,4 +1,6 @@
 import { fg } from '@atlaskit/platform-feature-flags';
+import { expVal } from '../../../expVal';
+import { containsDnDMutationInStyle } from '../../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation';
 import AbstractVCCalculatorBase from '../abstract-base-vc-calculator';
 import { isEntrySmartAnswersInSearch } from '../utils/is-entry-smart-answers-in-search';
 import isViewportEntryData from '../utils/is-viewport-entry-data';
@@ -45,9 +47,20 @@ export default class VCCalculator_FY25_03 extends AbstractVCCalculatorBase {
     if (entry.data.type === 'mutation:media' && fg('media-perf-uplift-mutation-fix')) {
       const entryData = entry.data;
       const attributeName = entryData.attributeName;
-      if (attributeName && (/data-(test|file|context)-\S+/g.test(attributeName) || attributeName === 'alt')) {
+      if (attributeName && (/data-(test|file|context)-\S+/g.test(attributeName) || attributeName === 'alt' || (attributeName === 'localid' || attributeName === 'contenteditable' || attributeName === 'anchor-name') && expVal('platform_editor_media_vc_fixes', 'isEnabled', false))) {
         return false;
       }
+
+      // special case for style attribute to ignore only anchor-name changes
+      if (expVal('platform_editor_media_vc_fixes', 'isEnabled', false)) {
+        if (containsDnDMutationInStyle({
+          attributeName: entryData.attributeName,
+          oldValue: entryData.oldValue,
+          newValue: entryData.newValue
+        })) {
+          return false;
+        }
+      }
     }
     if (entry.data.type === 'mutation:attribute') {
       const entryData = entry.data;

package/dist/es2019/vc/vc-observer-new/viewport-observer/index.js

@@ -1,6 +1,7 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 import { fg } from '@atlaskit/platform-feature-flags';
 import { isContainedWithinMediaWrapper } from '../../vc-observer/media-wrapper/vc-utils';
+import isDnDStyleMutation from '../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation';
 import isNonVisualStyleMutation from '../../vc-observer/observers/non-visual-styles/is-non-visual-style-mutation';
 import { RLLPlaceholderHandlers } from '../../vc-observer/observers/rll-placeholders';
 import { createIntersectionObserver } from './intersection-observer';
@@ -210,6 +211,21 @@ export default class ViewportObserver {
             };
           }
         }
+        if (isDnDStyleMutation({
+          target,
+          attributeName,
+          oldValue,
+          newValue
+        })) {
+          return {
+            type: 'mutation:attribute:non-visual-style',
+            mutationData: {
+              attributeName,
+              oldValue,
+              newValue
+            }
+          };
+        }
         if (isNonVisualStyleMutation({
           target,
           attributeName,

package/dist/esm/vc/vc-observer/observers/non-visual-styles/is-dnd-style-mutation.js

@@ -46,6 +46,16 @@ function isDnDStyleMutation(_ref) {
   if (!(target instanceof Element)) {
     return false;
   }
+  return containsDnDMutationInStyle({
+    attributeName: attributeName,
+    oldValue: oldValue,
+    newValue: newValue
+  });
+}
+function containsDnDMutationInStyle(_ref2) {
+  var attributeName = _ref2.attributeName,
+    oldValue = _ref2.oldValue,
+    newValue = _ref2.newValue;
   if (attributeName !== 'style') {
     return false;
   }
@@ -88,4 +98,5 @@ function isDnDStyleMutation(_ref) {
   }
   return isDnDMutation;
 }
-export default isDnDStyleMutation;
+export default isDnDStyleMutation;
+export { isDnDStyleMutation, containsDnDMutationInStyle };

package/dist/esm/vc/vc-observer-new/metric-calculator/fy25_03/index.js

@@ -6,6 +6,8 @@ import _inherits from "@babel/runtime/helpers/inherits";
 function _callSuper(t, o, e) { return o = _getPrototypeOf(o), _possibleConstructorReturn(t, _isNativeReflectConstruct() ? Reflect.construct(o, e || [], _getPrototypeOf(t).constructor) : o.apply(t, e)); }
 function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); }
 import { fg } from '@atlaskit/platform-feature-flags';
+import { expVal } from '../../../expVal';
+import { containsDnDMutationInStyle } from '../../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation';
 import AbstractVCCalculatorBase from '../abstract-base-vc-calculator';
 import { isEntrySmartAnswersInSearch } from '../utils/is-entry-smart-answers-in-search';
 import isViewportEntryData from '../utils/is-viewport-entry-data';
@@ -56,9 +58,20 @@ var VCCalculator_FY25_03 = /*#__PURE__*/function (_AbstractVCCalculator) {
       if (entry.data.type === 'mutation:media' && fg('media-perf-uplift-mutation-fix')) {
         var entryData = entry.data;
         var attributeName = entryData.attributeName;
-        if (attributeName && (/data-(test|file|context)-\S+/g.test(attributeName) || attributeName === 'alt')) {
+        if (attributeName && (/data-(test|file|context)-\S+/g.test(attributeName) || attributeName === 'alt' || (attributeName === 'localid' || attributeName === 'contenteditable' || attributeName === 'anchor-name') && expVal('platform_editor_media_vc_fixes', 'isEnabled', false))) {
           return false;
         }
+
+        // special case for style attribute to ignore only anchor-name changes
+        if (expVal('platform_editor_media_vc_fixes', 'isEnabled', false)) {
+          if (containsDnDMutationInStyle({
+            attributeName: entryData.attributeName,
+            oldValue: entryData.oldValue,
+            newValue: entryData.newValue
+          })) {
+            return false;
+          }
+        }
       }
       if (entry.data.type === 'mutation:attribute') {
         var _entryData = entry.data;

package/dist/esm/vc/vc-observer-new/viewport-observer/index.js

@@ -8,6 +8,7 @@ function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r)
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
 import { fg } from '@atlaskit/platform-feature-flags';
 import { isContainedWithinMediaWrapper } from '../../vc-observer/media-wrapper/vc-utils';
+import isDnDStyleMutation from '../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation';
 import isNonVisualStyleMutation from '../../vc-observer/observers/non-visual-styles/is-non-visual-style-mutation';
 import { RLLPlaceholderHandlers } from '../../vc-observer/observers/rll-placeholders';
 import { createIntersectionObserver } from './intersection-observer';
@@ -308,6 +309,21 @@ var ViewportObserver = /*#__PURE__*/function () {
             };
           }
         }
+        if (isDnDStyleMutation({
+          target: target,
+          attributeName: attributeName,
+          oldValue: oldValue,
+          newValue: newValue
+        })) {
+          return {
+            type: 'mutation:attribute:non-visual-style',
+            mutationData: {
+              attributeName: attributeName,
+              oldValue: oldValue,
+              newValue: newValue
+            }
+          };
+        }
         if (isNonVisualStyleMutation({
           target: target,
           attributeName: attributeName,

package/dist/types/vc/vc-observer/observers/non-visual-styles/is-dnd-style-mutation.d.ts

@@ -11,4 +11,10 @@ declare function isDnDStyleMutation({ target, attributeName, oldValue, newValue,
     oldValue?: string | undefined | null;
     newValue?: string | undefined | null;
 }): boolean;
+declare function containsDnDMutationInStyle({ attributeName, oldValue, newValue, }: {
+    attributeName?: string | null;
+    oldValue?: string | undefined | null;
+    newValue?: string | undefined | null;
+}): boolean;
 export default isDnDStyleMutation;
+export { isDnDStyleMutation, containsDnDMutationInStyle };

package/dist/types-ts4.5/vc/vc-observer/observers/non-visual-styles/is-dnd-style-mutation.d.ts

@@ -11,4 +11,10 @@ declare function isDnDStyleMutation({ target, attributeName, oldValue, newValue,
     oldValue?: string | undefined | null;
     newValue?: string | undefined | null;
 }): boolean;
+declare function containsDnDMutationInStyle({ attributeName, oldValue, newValue, }: {
+    attributeName?: string | null;
+    oldValue?: string | undefined | null;
+    newValue?: string | undefined | null;
+}): boolean;
 export default isDnDStyleMutation;
+export { isDnDStyleMutation, containsDnDMutationInStyle };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/react-ufo",
-	"version": "4.14.6",
+	"version": "4.14.8",
 	"description": "Parts of React UFO that are publicly available",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",