@atlaskit/react-ufo 4.12.0 → 4.12.2

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlaskit/ufo-interaction-ignore
 
+## 4.12.2
+
+### Patch Changes
+
+- [`62fd2a70c6b2a`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/62fd2a70c6b2a) -
+  FG cleanup - platform_ufo_vc_next_filter_ls_entries_same_rect
+
+## 4.12.1
+
+### Patch Changes
+
+- [`eec573b4a7a6a`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/eec573b4a7a6a) -
+  Excluded data-test* data-file* and data-context\* attributes from media fy25_03 as they are non
+  visual change required internally for testing and supporting copy and paste functionality
+
 ## 4.12.0
 
 ### Minor Changes

package/dist/cjs/vc/vc-observer-new/metric-calculator/fy25_03/index.js

@@ -19,12 +19,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
 var ABORTING_WINDOW_EVENT = ['wheel', 'scroll', 'keydown', 'resize'];
 var REVISION_NO = 'fy25.03';
 var getConsideredEntryTypes = function getConsideredEntryTypes(include3p) {
-  var entryTypes = ['mutation:child-element', 'mutation:element', 'mutation:attribute', 'layout-shift', 'window:event'];
-
-  // in rolling this out, still include it in TTVC v3
-  if ((0, _platformFeatureFlags.fg)('platform_ufo_vc_next_filter_ls_entries_same_rect')) {
-    entryTypes.push('layout-shift:same-rect');
-  }
+  var entryTypes = ['mutation:child-element', 'mutation:element', 'mutation:attribute', 'layout-shift', 'layout-shift:same-rect', 'window:event'];
 
   // If not exclude 3p elements from ttvc,
   // including the tags into the ConsideredEntryTypes so that it won't be ignored for TTVC calculation
@@ -64,13 +59,20 @@ var VCCalculator_FY25_03 = exports.default = /*#__PURE__*/function (_AbstractVCC
       if (excludeSmartAnswersInSearch && (0, _isEntrySmartAnswersInSearch.isEntrySmartAnswersInSearch)(entry)) {
         return false;
       }
-      if (entry.data.type === 'mutation:attribute') {
+      if (entry.data.type === 'mutation:media' && (0, _platformFeatureFlags.fg)('media-perf-uplift-mutation-fix')) {
         var entryData = entry.data;
         var attributeName = entryData.attributeName;
-        if (!attributeName || KNOWN_ATTRIBUTES_THAT_DOES_NOT_CAUSE_LAYOUT_SHIFTS.includes(attributeName)) {
+        if (attributeName && (/data-(test|file|context)-\S+/g.test(attributeName) || attributeName === 'alt')) {
+          return false;
+        }
+      }
+      if (entry.data.type === 'mutation:attribute') {
+        var _entryData = entry.data;
+        var _attributeName = _entryData.attributeName;
+        if (!_attributeName || KNOWN_ATTRIBUTES_THAT_DOES_NOT_CAUSE_LAYOUT_SHIFTS.includes(_attributeName)) {
           return false;
         }
-        if (attributeName.startsWith('data-test') || attributeName === 'data-aui-version' || attributeName === 'data-testid' || attributeName === 'data-vc' || attributeName === 'data-ssr-placeholder' || attributeName === 'data-ssr-placeholder-replace' || attributeName === 'data-vc-nvs' || attributeName === 'data-media-vc-wrapper' || attributeName === 'data-renderer-start-pos' || attributeName === 'data-table-local-id' || attributeName === 'spellcheck' || attributeName === 'data-auto-scrollable' || attributeName === 'id' || attributeName === 'tabindex' || attributeName === 'data-is-ttvc-ready' || attributeName === 'contenteditable' || attributeName === 'data-has-collab-initialised' || attributeName === 'translate' || NON_VISUAL_ARIA_ATTRIBUTES.includes(attributeName) || THIRD_PARTY_BROWSER_EXTENSION_ATTRIBUTES.includes(attributeName) && (0, _platformFeatureFlags.fg)('platform_ufo_exclude_3p_extensions_from_ttvc')) {
+        if (_attributeName.startsWith('data-test') || _attributeName === 'data-aui-version' || _attributeName === 'data-testid' || _attributeName === 'data-vc' || _attributeName === 'data-ssr-placeholder' || _attributeName === 'data-ssr-placeholder-replace' || _attributeName === 'data-vc-nvs' || _attributeName === 'data-media-vc-wrapper' || _attributeName === 'data-renderer-start-pos' || _attributeName === 'data-table-local-id' || _attributeName === 'spellcheck' || _attributeName === 'data-auto-scrollable' || _attributeName === 'id' || _attributeName === 'tabindex' || _attributeName === 'data-is-ttvc-ready' || _attributeName === 'contenteditable' || _attributeName === 'data-has-collab-initialised' || _attributeName === 'translate' || NON_VISUAL_ARIA_ATTRIBUTES.includes(_attributeName) || THIRD_PARTY_BROWSER_EXTENSION_ATTRIBUTES.includes(_attributeName) && (0, _platformFeatureFlags.fg)('platform_ufo_exclude_3p_extensions_from_ttvc')) {
           return false;
         }
         return true;

package/dist/cjs/vc/vc-observer-new/viewport-observer/index.js

@@ -11,7 +11,6 @@ var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/
 var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
 var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _vcUtils = require("../../vc-observer/media-wrapper/vc-utils");
 var _isDndStyleMutation = _interopRequireDefault(require("../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation"));
 var _isNonVisualStyleMutation = _interopRequireDefault(require("../../vc-observer/observers/non-visual-styles/is-non-visual-style-mutation"));
@@ -360,26 +359,15 @@ var ViewportObserver = exports.default = /*#__PURE__*/function () {
           var changedRect = _step3.value;
           var target = changedRect.node;
           if (target) {
-            if ((0, _platformFeatureFlags.fg)('platform_ufo_vc_next_filter_ls_entries_same_rect')) {
-              var isSameCurrentAndPreviousRects = (0, _isSameRectDimensions.isSameRectDimensions)(changedRect.rect, changedRect.previousRect);
-              _this.onChange({
-                time: time,
-                elementRef: new WeakRef(target),
-                visible: true,
-                rect: changedRect.rect,
-                previousRect: changedRect.previousRect,
-                type: isSameCurrentAndPreviousRects ? 'layout-shift:same-rect' : 'layout-shift'
-              });
-            } else {
-              _this.onChange({
-                time: time,
-                elementRef: new WeakRef(target),
-                visible: true,
-                rect: changedRect.rect,
-                previousRect: changedRect.previousRect,
-                type: 'layout-shift'
-              });
-            }
+            var isSameCurrentAndPreviousRects = (0, _isSameRectDimensions.isSameRectDimensions)(changedRect.rect, changedRect.previousRect);
+            _this.onChange({
+              time: time,
+              elementRef: new WeakRef(target),
+              visible: true,
+              rect: changedRect.rect,
+              previousRect: changedRect.previousRect,
+              type: isSameCurrentAndPreviousRects ? 'layout-shift:same-rect' : 'layout-shift'
+            });
           }
         }
       } catch (err) {

package/dist/es2019/vc/vc-observer-new/metric-calculator/fy25_03/index.js

@@ -5,12 +5,7 @@ import isViewportEntryData from '../utils/is-viewport-entry-data';
 const ABORTING_WINDOW_EVENT = ['wheel', 'scroll', 'keydown', 'resize'];
 const REVISION_NO = 'fy25.03';
 const getConsideredEntryTypes = include3p => {
-  const entryTypes = ['mutation:child-element', 'mutation:element', 'mutation:attribute', 'layout-shift', 'window:event'];
-
-  // in rolling this out, still include it in TTVC v3
-  if (fg('platform_ufo_vc_next_filter_ls_entries_same_rect')) {
-    entryTypes.push('layout-shift:same-rect');
-  }
+  const entryTypes = ['mutation:child-element', 'mutation:element', 'mutation:attribute', 'layout-shift', 'layout-shift:same-rect', 'window:event'];
 
   // If not exclude 3p elements from ttvc,
   // including the tags into the ConsideredEntryTypes so that it won't be ignored for TTVC calculation
@@ -46,6 +41,13 @@ export default class VCCalculator_FY25_03 extends AbstractVCCalculatorBase {
     if (excludeSmartAnswersInSearch && isEntrySmartAnswersInSearch(entry)) {
       return false;
     }
+    if (entry.data.type === 'mutation:media' && fg('media-perf-uplift-mutation-fix')) {
+      const entryData = entry.data;
+      const attributeName = entryData.attributeName;
+      if (attributeName && (/data-(test|file|context)-\S+/g.test(attributeName) || attributeName === 'alt')) {
+        return false;
+      }
+    }
     if (entry.data.type === 'mutation:attribute') {
       const entryData = entry.data;
       const attributeName = entryData.attributeName;

package/dist/es2019/vc/vc-observer-new/viewport-observer/index.js

@@ -1,5 +1,4 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
-import { fg } from '@atlaskit/platform-feature-flags';
 import { isContainedWithinMediaWrapper } from '../../vc-observer/media-wrapper/vc-utils';
 import isDnDStyleMutation from '../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation';
 import isNonVisualStyleMutation from '../../vc-observer/observers/non-visual-styles/is-non-visual-style-mutation';
@@ -263,26 +262,15 @@ export default class ViewportObserver {
       for (const changedRect of changedRects) {
         const target = changedRect.node;
         if (target) {
-          if (fg('platform_ufo_vc_next_filter_ls_entries_same_rect')) {
-            const isSameCurrentAndPreviousRects = isSameRectDimensions(changedRect.rect, changedRect.previousRect);
-            this.onChange({
-              time,
-              elementRef: new WeakRef(target),
-              visible: true,
-              rect: changedRect.rect,
-              previousRect: changedRect.previousRect,
-              type: isSameCurrentAndPreviousRects ? 'layout-shift:same-rect' : 'layout-shift'
-            });
-          } else {
-            this.onChange({
-              time,
-              elementRef: new WeakRef(target),
-              visible: true,
-              rect: changedRect.rect,
-              previousRect: changedRect.previousRect,
-              type: 'layout-shift'
-            });
-          }
+          const isSameCurrentAndPreviousRects = isSameRectDimensions(changedRect.rect, changedRect.previousRect);
+          this.onChange({
+            time,
+            elementRef: new WeakRef(target),
+            visible: true,
+            rect: changedRect.rect,
+            previousRect: changedRect.previousRect,
+            type: isSameCurrentAndPreviousRects ? 'layout-shift:same-rect' : 'layout-shift'
+          });
         }
       }
     });

package/dist/esm/vc/vc-observer-new/metric-calculator/fy25_03/index.js

@@ -12,12 +12,7 @@ import isViewportEntryData from '../utils/is-viewport-entry-data';
 var ABORTING_WINDOW_EVENT = ['wheel', 'scroll', 'keydown', 'resize'];
 var REVISION_NO = 'fy25.03';
 var getConsideredEntryTypes = function getConsideredEntryTypes(include3p) {
-  var entryTypes = ['mutation:child-element', 'mutation:element', 'mutation:attribute', 'layout-shift', 'window:event'];
-
-  // in rolling this out, still include it in TTVC v3
-  if (fg('platform_ufo_vc_next_filter_ls_entries_same_rect')) {
-    entryTypes.push('layout-shift:same-rect');
-  }
+  var entryTypes = ['mutation:child-element', 'mutation:element', 'mutation:attribute', 'layout-shift', 'layout-shift:same-rect', 'window:event'];
 
   // If not exclude 3p elements from ttvc,
   // including the tags into the ConsideredEntryTypes so that it won't be ignored for TTVC calculation
@@ -57,13 +52,20 @@ var VCCalculator_FY25_03 = /*#__PURE__*/function (_AbstractVCCalculator) {
       if (excludeSmartAnswersInSearch && isEntrySmartAnswersInSearch(entry)) {
         return false;
       }
-      if (entry.data.type === 'mutation:attribute') {
+      if (entry.data.type === 'mutation:media' && fg('media-perf-uplift-mutation-fix')) {
         var entryData = entry.data;
         var attributeName = entryData.attributeName;
-        if (!attributeName || KNOWN_ATTRIBUTES_THAT_DOES_NOT_CAUSE_LAYOUT_SHIFTS.includes(attributeName)) {
+        if (attributeName && (/data-(test|file|context)-\S+/g.test(attributeName) || attributeName === 'alt')) {
+          return false;
+        }
+      }
+      if (entry.data.type === 'mutation:attribute') {
+        var _entryData = entry.data;
+        var _attributeName = _entryData.attributeName;
+        if (!_attributeName || KNOWN_ATTRIBUTES_THAT_DOES_NOT_CAUSE_LAYOUT_SHIFTS.includes(_attributeName)) {
           return false;
         }
-        if (attributeName.startsWith('data-test') || attributeName === 'data-aui-version' || attributeName === 'data-testid' || attributeName === 'data-vc' || attributeName === 'data-ssr-placeholder' || attributeName === 'data-ssr-placeholder-replace' || attributeName === 'data-vc-nvs' || attributeName === 'data-media-vc-wrapper' || attributeName === 'data-renderer-start-pos' || attributeName === 'data-table-local-id' || attributeName === 'spellcheck' || attributeName === 'data-auto-scrollable' || attributeName === 'id' || attributeName === 'tabindex' || attributeName === 'data-is-ttvc-ready' || attributeName === 'contenteditable' || attributeName === 'data-has-collab-initialised' || attributeName === 'translate' || NON_VISUAL_ARIA_ATTRIBUTES.includes(attributeName) || THIRD_PARTY_BROWSER_EXTENSION_ATTRIBUTES.includes(attributeName) && fg('platform_ufo_exclude_3p_extensions_from_ttvc')) {
+        if (_attributeName.startsWith('data-test') || _attributeName === 'data-aui-version' || _attributeName === 'data-testid' || _attributeName === 'data-vc' || _attributeName === 'data-ssr-placeholder' || _attributeName === 'data-ssr-placeholder-replace' || _attributeName === 'data-vc-nvs' || _attributeName === 'data-media-vc-wrapper' || _attributeName === 'data-renderer-start-pos' || _attributeName === 'data-table-local-id' || _attributeName === 'spellcheck' || _attributeName === 'data-auto-scrollable' || _attributeName === 'id' || _attributeName === 'tabindex' || _attributeName === 'data-is-ttvc-ready' || _attributeName === 'contenteditable' || _attributeName === 'data-has-collab-initialised' || _attributeName === 'translate' || NON_VISUAL_ARIA_ATTRIBUTES.includes(_attributeName) || THIRD_PARTY_BROWSER_EXTENSION_ATTRIBUTES.includes(_attributeName) && fg('platform_ufo_exclude_3p_extensions_from_ttvc')) {
           return false;
         }
         return true;

package/dist/esm/vc/vc-observer-new/viewport-observer/index.js

@@ -6,7 +6,6 @@ import _regeneratorRuntime from "@babel/runtime/regenerator";
 function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
 function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
-import { fg } from '@atlaskit/platform-feature-flags';
 import { isContainedWithinMediaWrapper } from '../../vc-observer/media-wrapper/vc-utils';
 import isDnDStyleMutation from '../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation';
 import isNonVisualStyleMutation from '../../vc-observer/observers/non-visual-styles/is-non-visual-style-mutation';
@@ -351,26 +350,15 @@ var ViewportObserver = /*#__PURE__*/function () {
           var changedRect = _step3.value;
           var target = changedRect.node;
           if (target) {
-            if (fg('platform_ufo_vc_next_filter_ls_entries_same_rect')) {
-              var isSameCurrentAndPreviousRects = isSameRectDimensions(changedRect.rect, changedRect.previousRect);
-              _this.onChange({
-                time: time,
-                elementRef: new WeakRef(target),
-                visible: true,
-                rect: changedRect.rect,
-                previousRect: changedRect.previousRect,
-                type: isSameCurrentAndPreviousRects ? 'layout-shift:same-rect' : 'layout-shift'
-              });
-            } else {
-              _this.onChange({
-                time: time,
-                elementRef: new WeakRef(target),
-                visible: true,
-                rect: changedRect.rect,
-                previousRect: changedRect.previousRect,
-                type: 'layout-shift'
-              });
-            }
+            var isSameCurrentAndPreviousRects = isSameRectDimensions(changedRect.rect, changedRect.previousRect);
+            _this.onChange({
+              time: time,
+              elementRef: new WeakRef(target),
+              visible: true,
+              rect: changedRect.rect,
+              previousRect: changedRect.previousRect,
+              type: isSameCurrentAndPreviousRects ? 'layout-shift:same-rect' : 'layout-shift'
+            });
           }
         }
       } catch (err) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/react-ufo",
-	"version": "4.12.0",
+	"version": "4.12.2",
 	"description": "Parts of React UFO that are publicly available",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -85,9 +85,6 @@
 		"platform_ufo_canvas_heatmap_full_precision": {
 			"type": "boolean"
 		},
-		"platform_ufo_vc_next_filter_ls_entries_same_rect": {
-			"type": "boolean"
-		},
 		"platform_ufo_enable_media_for_ttvc_v3": {
 			"type": "boolean"
 		},
@@ -162,6 +159,9 @@
 		},
 		"platform_ufo_drop_prior_fg_interactions": {
 			"type": "boolean"
+		},
+		"media-perf-uplift-mutation-fix": {
+			"type": "boolean"
 		}
 	}
 }