@atlaskit/react-ufo 3.5.1 → 3.5.3

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/ufo-interaction-ignore
 
+## 3.5.3
+
+### Patch Changes
+
+- [#141178](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/141178)
+  [`c85827a02e305`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/c85827a02e305) -
+  clean up fg platform_ufo_vc_filter_ignored_items
+
+## 3.5.2
+
+### Patch Changes
+
+- [#140777](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/140777)
+  [`8fa57c7e71b24`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/8fa57c7e71b24) -
+  Filtering out assets with NaN values reported as file size
+
 ## 3.5.1
 
 ### Patch Changes

package/dist/cjs/assets/index.js

@@ -8,6 +8,7 @@ exports.CHRSummary = exports.CHRReporter = void 0;
 var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
 var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
 var _defineProperty4 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _selfMeasurements = require("../self-measurements");
 var _utils = require("./utils");
 var _CHRSummary;
@@ -69,8 +70,9 @@ var CHRReporter = exports.CHRReporter = /*#__PURE__*/function () {
           if (!(0, _utils.checkIfTimingsAvailable)(entry)) {
             return;
           }
-          if (entry.encodedSize === entry.decodedSize) {
-            // incorrectly reported size
+          var hasNanValues = (0, _platformFeatureFlags.fg)('platform_ufo_assets_check_for_nan') ? entry.encodedSize === undefined || entry.encodedSize === null : false;
+          if (entry.encodedSize === entry.decodedSize || hasNanValues) {
+            // incorrectly reported or lack of size
             return;
           }
           var type = (0, _utils.getTypeOfRequest)(entry);

package/dist/cjs/vc/vc-observer/index.js

@@ -708,7 +708,6 @@ _VCObserver = VCObserver;
 
   // eslint-disable-next-line @atlaskit/platform/ensure-feature-flag-prefix
   var isCalcSpeedIndexEnabled = (0, _platformFeatureFlags.fg)('ufo-calc-speed-index');
-  var isFilterIgnoredItemsEnabled = (0, _platformFeatureFlags.fg)('platform_ufo_vc_filter_ignored_items');
   entries.reduce(function () {
     var acc = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 0;
     var v = arguments.length > 1 ? arguments[1] : undefined;
@@ -721,32 +720,28 @@ _VCObserver = VCObserver;
     _VCObserver.VCParts.forEach(function (key) {
       var value = parseInt(key, 10);
       if ((VC[key] === null || VC[key] === undefined) && VCRatio >= value / 100) {
-        var _componentsLog$time, _componentsLog$time2;
+        var _componentsLog$time;
         VC[key] = time;
-        VCBox[key] = isFilterIgnoredItemsEnabled ? (0, _toConsumableArray2.default)(new Set((_componentsLog$time = componentsLog[time]) === null || _componentsLog$time === void 0 ? void 0 : _componentsLog$time.filter(function (v) {
+        VCBox[key] = (0, _toConsumableArray2.default)(new Set((_componentsLog$time = componentsLog[time]) === null || _componentsLog$time === void 0 ? void 0 : _componentsLog$time.filter(function (v) {
           return !v.ignoreReason;
         }).map(function (v) {
           return v.targetName;
-        }))) : (0, _toConsumableArray2.default)(new Set((_componentsLog$time2 = componentsLog[time]) === null || _componentsLog$time2 === void 0 ? void 0 : _componentsLog$time2.map(function (v) {
-          return v.targetName;
         })));
       }
     });
     return VCRatio;
   }, 0);
   var VCEntries = entries.reduce(function (acc, _ref16, i) {
-    var _acc$abs, _componentsLog$timest, _componentsLog$timest2, _acc$rel$vc, _acc$rel;
+    var _acc$abs, _componentsLog$timest, _acc$rel$vc, _acc$rel;
     var _ref17 = (0, _slicedToArray2.default)(_ref16, 2),
       timestamp = _ref17[0],
       entryPainted = _ref17[1];
     var currentlyPainted = entryPainted + (((_acc$abs = acc.abs[i - 1]) === null || _acc$abs === void 0 ? void 0 : _acc$abs[1]) || 0);
     var currentlyPaintedRatio = Math.round(currentlyPainted / totalPainted * 1000) / 10;
-    var logEntry = isFilterIgnoredItemsEnabled ? (0, _toConsumableArray2.default)(new Set((_componentsLog$timest = componentsLog[timestamp]) === null || _componentsLog$timest === void 0 ? void 0 : _componentsLog$timest.filter(function (v) {
+    var logEntry = (0, _toConsumableArray2.default)(new Set((_componentsLog$timest = componentsLog[timestamp]) === null || _componentsLog$timest === void 0 ? void 0 : _componentsLog$timest.filter(function (v) {
       return !v.ignoreReason;
     }).map(function (v) {
       return v.targetName;
-    }))) : (0, _toConsumableArray2.default)(new Set((_componentsLog$timest2 = componentsLog[timestamp]) === null || _componentsLog$timest2 === void 0 ? void 0 : _componentsLog$timest2.map(function (v) {
-      return v.targetName;
     })));
     var ratioDelta = (currentlyPaintedRatio - ((_acc$rel$vc = (_acc$rel = acc.rel[i - 1]) === null || _acc$rel === void 0 ? void 0 : _acc$rel.vc) !== null && _acc$rel$vc !== void 0 ? _acc$rel$vc : 0)) / 100;
     if (isCalcSpeedIndexEnabled) {

package/dist/es2019/assets/index.js

@@ -1,5 +1,6 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 var _CHRSummary;
+import { fg } from '@atlaskit/platform-feature-flags';
 import { withProfiling } from '../self-measurements';
 import { calculateTransferType, checkIfTimingsAvailable, DISK_KEY, getTypeOfRequest, MEMORY_KEY, NETWORK_KEY, round } from './utils';
 export class CHRSummary {
@@ -62,8 +63,9 @@ export class CHRReporter {
         if (!checkIfTimingsAvailable(entry)) {
           return;
         }
-        if (entry.encodedSize === entry.decodedSize) {
-          // incorrectly reported size
+        const hasNanValues = fg('platform_ufo_assets_check_for_nan') ? entry.encodedSize === undefined || entry.encodedSize === null : false;
+        if (entry.encodedSize === entry.decodedSize || hasNanValues) {
+          // incorrectly reported or lack of size
           return;
         }
         const type = getTypeOfRequest(entry);

package/dist/es2019/vc/vc-observer/index.js

@@ -693,7 +693,6 @@ _defineProperty(VCObserver, "calculateVC", withProfiling(function calculateVC({
 
   // eslint-disable-next-line @atlaskit/platform/ensure-feature-flag-prefix
   const isCalcSpeedIndexEnabled = fg('ufo-calc-speed-index');
-  const isFilterIgnoredItemsEnabled = fg('platform_ufo_vc_filter_ignored_items');
   entries.reduce((acc = 0, v) => {
     const currRatio = v[1] / totalPainted;
     let VCRatio = currRatio + acc;
@@ -704,18 +703,18 @@ _defineProperty(VCObserver, "calculateVC", withProfiling(function calculateVC({
     _VCObserver.VCParts.forEach(key => {
       const value = parseInt(key, 10);
       if ((VC[key] === null || VC[key] === undefined) && VCRatio >= value / 100) {
-        var _componentsLog$time, _componentsLog$time2;
+        var _componentsLog$time;
         VC[key] = time;
-        VCBox[key] = isFilterIgnoredItemsEnabled ? [...new Set((_componentsLog$time = componentsLog[time]) === null || _componentsLog$time === void 0 ? void 0 : _componentsLog$time.filter(v => !v.ignoreReason).map(v => v.targetName))] : [...new Set((_componentsLog$time2 = componentsLog[time]) === null || _componentsLog$time2 === void 0 ? void 0 : _componentsLog$time2.map(v => v.targetName))];
+        VCBox[key] = [...new Set((_componentsLog$time = componentsLog[time]) === null || _componentsLog$time === void 0 ? void 0 : _componentsLog$time.filter(v => !v.ignoreReason).map(v => v.targetName))];
       }
     });
     return VCRatio;
   }, 0);
   const VCEntries = entries.reduce((acc, [timestamp, entryPainted], i) => {
-    var _acc$abs, _componentsLog$timest, _componentsLog$timest2, _acc$rel$vc, _acc$rel;
+    var _acc$abs, _componentsLog$timest, _acc$rel$vc, _acc$rel;
     const currentlyPainted = entryPainted + (((_acc$abs = acc.abs[i - 1]) === null || _acc$abs === void 0 ? void 0 : _acc$abs[1]) || 0);
     const currentlyPaintedRatio = Math.round(currentlyPainted / totalPainted * 1000) / 10;
-    const logEntry = isFilterIgnoredItemsEnabled ? [...new Set((_componentsLog$timest = componentsLog[timestamp]) === null || _componentsLog$timest === void 0 ? void 0 : _componentsLog$timest.filter(v => !v.ignoreReason).map(v => v.targetName))] : [...new Set((_componentsLog$timest2 = componentsLog[timestamp]) === null || _componentsLog$timest2 === void 0 ? void 0 : _componentsLog$timest2.map(v => v.targetName))];
+    const logEntry = [...new Set((_componentsLog$timest = componentsLog[timestamp]) === null || _componentsLog$timest === void 0 ? void 0 : _componentsLog$timest.filter(v => !v.ignoreReason).map(v => v.targetName))];
     const ratioDelta = (currentlyPaintedRatio - ((_acc$rel$vc = (_acc$rel = acc.rel[i - 1]) === null || _acc$rel === void 0 ? void 0 : _acc$rel.vc) !== null && _acc$rel$vc !== void 0 ? _acc$rel$vc : 0)) / 100;
     if (isCalcSpeedIndexEnabled) {
       const speedIndex = timestamp * ratioDelta;

package/dist/esm/assets/index.js

@@ -2,6 +2,7 @@ import _classCallCheck from "@babel/runtime/helpers/classCallCheck";
 import _createClass from "@babel/runtime/helpers/createClass";
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 var _CHRSummary;
+import { fg } from '@atlaskit/platform-feature-flags';
 import { withProfiling } from '../self-measurements';
 import { calculateTransferType, checkIfTimingsAvailable, DISK_KEY, getTypeOfRequest, MEMORY_KEY, NETWORK_KEY, round } from './utils';
 export var CHRSummary = /*#__PURE__*/function () {
@@ -62,8 +63,9 @@ export var CHRReporter = /*#__PURE__*/function () {
           if (!checkIfTimingsAvailable(entry)) {
             return;
           }
-          if (entry.encodedSize === entry.decodedSize) {
-            // incorrectly reported size
+          var hasNanValues = fg('platform_ufo_assets_check_for_nan') ? entry.encodedSize === undefined || entry.encodedSize === null : false;
+          if (entry.encodedSize === entry.decodedSize || hasNanValues) {
+            // incorrectly reported or lack of size
             return;
           }
           var type = getTypeOfRequest(entry);

package/dist/esm/vc/vc-observer/index.js

@@ -701,7 +701,6 @@ _defineProperty(VCObserver, "calculateVC", withProfiling(function calculateVC(_r
 
   // eslint-disable-next-line @atlaskit/platform/ensure-feature-flag-prefix
   var isCalcSpeedIndexEnabled = fg('ufo-calc-speed-index');
-  var isFilterIgnoredItemsEnabled = fg('platform_ufo_vc_filter_ignored_items');
   entries.reduce(function () {
     var acc = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 0;
     var v = arguments.length > 1 ? arguments[1] : undefined;
@@ -714,32 +713,28 @@ _defineProperty(VCObserver, "calculateVC", withProfiling(function calculateVC(_r
     _VCObserver.VCParts.forEach(function (key) {
       var value = parseInt(key, 10);
       if ((VC[key] === null || VC[key] === undefined) && VCRatio >= value / 100) {
-        var _componentsLog$time, _componentsLog$time2;
+        var _componentsLog$time;
         VC[key] = time;
-        VCBox[key] = isFilterIgnoredItemsEnabled ? _toConsumableArray(new Set((_componentsLog$time = componentsLog[time]) === null || _componentsLog$time === void 0 ? void 0 : _componentsLog$time.filter(function (v) {
+        VCBox[key] = _toConsumableArray(new Set((_componentsLog$time = componentsLog[time]) === null || _componentsLog$time === void 0 ? void 0 : _componentsLog$time.filter(function (v) {
           return !v.ignoreReason;
         }).map(function (v) {
           return v.targetName;
-        }))) : _toConsumableArray(new Set((_componentsLog$time2 = componentsLog[time]) === null || _componentsLog$time2 === void 0 ? void 0 : _componentsLog$time2.map(function (v) {
-          return v.targetName;
         })));
       }
     });
     return VCRatio;
   }, 0);
   var VCEntries = entries.reduce(function (acc, _ref16, i) {
-    var _acc$abs, _componentsLog$timest, _componentsLog$timest2, _acc$rel$vc, _acc$rel;
+    var _acc$abs, _componentsLog$timest, _acc$rel$vc, _acc$rel;
     var _ref17 = _slicedToArray(_ref16, 2),
       timestamp = _ref17[0],
       entryPainted = _ref17[1];
     var currentlyPainted = entryPainted + (((_acc$abs = acc.abs[i - 1]) === null || _acc$abs === void 0 ? void 0 : _acc$abs[1]) || 0);
     var currentlyPaintedRatio = Math.round(currentlyPainted / totalPainted * 1000) / 10;
-    var logEntry = isFilterIgnoredItemsEnabled ? _toConsumableArray(new Set((_componentsLog$timest = componentsLog[timestamp]) === null || _componentsLog$timest === void 0 ? void 0 : _componentsLog$timest.filter(function (v) {
+    var logEntry = _toConsumableArray(new Set((_componentsLog$timest = componentsLog[timestamp]) === null || _componentsLog$timest === void 0 ? void 0 : _componentsLog$timest.filter(function (v) {
       return !v.ignoreReason;
     }).map(function (v) {
       return v.targetName;
-    }))) : _toConsumableArray(new Set((_componentsLog$timest2 = componentsLog[timestamp]) === null || _componentsLog$timest2 === void 0 ? void 0 : _componentsLog$timest2.map(function (v) {
-      return v.targetName;
     })));
     var ratioDelta = (currentlyPaintedRatio - ((_acc$rel$vc = (_acc$rel = acc.rel[i - 1]) === null || _acc$rel === void 0 ? void 0 : _acc$rel.vc) !== null && _acc$rel$vc !== void 0 ? _acc$rel$vc : 0)) / 100;
     if (isCalcSpeedIndexEnabled) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/react-ufo",
-	"version": "3.5.1",
+	"version": "3.5.3",
 	"description": "Parts of React UFO that are publicly available",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -178,10 +178,10 @@
 		"platform_ufo_disable_ttvc_v1": {
 			"type": "boolean"
 		},
-		"platform_ufo_vc_filter_ignored_items": {
+		"platform_ufo_vc_fix_ignore_image_mutation": {
 			"type": "boolean"
 		},
-		"platform_ufo_vc_fix_ignore_image_mutation": {
+		"platform_ufo_assets_check_for_nan": {
 			"type": "boolean"
 		},
 		"platform_ufo_log_attr_mutation_values": {