@atlaskit/react-ufo 3.4.8 → 3.4.10

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/ufo-interaction-ignore
 
+## 3.4.10
+
+### Patch Changes
+
+- [#134112](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/134112)
+  [`b993bf17b9c1b`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b993bf17b9c1b) -
+  Ignore same value attribute mutation
+
+## 3.4.9
+
+### Patch Changes
+
+- [#134300](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/134300)
+  [`5fb9bf529d095`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/5fb9bf529d095) -
+  SSR placeholder rectangle size comparison to ignore decimal places
+
 ## 3.4.8
 
 ### Patch Changes

package/dist/cjs/vc/vc-observer/observers/index.js

@@ -211,13 +211,27 @@ var Observers = exports.Observers = /*#__PURE__*/function () {
             });
           } else if (mutation.type === 'attributes') {
             if (mutation.target instanceof HTMLElement) {
-              if ((0, _platformFeatureFlags.fg)('platform-ufo-vc-observe-attributes')) {
+              if ((0, _platformFeatureFlags.fg)('platform_ufo_vc_ignore_same_value_mutation')) {
+                var _mutation$oldValue;
+                /*
+                		"MutationObserver was explicitly designed to work that way, but I can't now recall the reasoning.
+                		I think it might have been something along the lines that for consistency every setAttribute call should create a record.
+                		Conceptually there is after all a mutation: there is an old value replaced with a new one,
+                		and whether or not they are the same doesn't really matter.
+                		And Custom elements should work the same way as MutationObserver."
+                		https://github.com/whatwg/dom/issues/520#issuecomment-336574796
+                	*/
+                var oldValue = (_mutation$oldValue = mutation.oldValue) !== null && _mutation$oldValue !== void 0 ? _mutation$oldValue : undefined;
+                var newValue = mutation.attributeName ? mutation.target.getAttribute(mutation.attributeName) : undefined;
+                if (oldValue !== newValue) {
+                  _this2.observeElement(mutation.target, mutation, 'attr', ignoreReason);
+                }
+              } else {
                 _this2.observeElement(mutation.target, mutation, 'attr', ignoreReason);
               }
             }
           }
         });
-        _this2.measureStop();
       }) : null;
     }
   }, {

package/dist/cjs/vc/vc-observer/observers/ssr-placeholders/index.js

@@ -8,7 +8,7 @@ exports.SSRPlaceholderHandlers = void 0;
 var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
 var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
-var EQUALITY_THRESHOLD = 0.1;
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var ANCESTOR_LOOKUP_LIMIT = 10;
 var SSRPlaceholderHandlers = exports.SSRPlaceholderHandlers = /*#__PURE__*/function () {
   function SSRPlaceholderHandlers() {
@@ -18,6 +18,7 @@ var SSRPlaceholderHandlers = exports.SSRPlaceholderHandlers = /*#__PURE__*/funct
     (0, _defineProperty2.default)(this, "callbacks", new Map());
     (0, _defineProperty2.default)(this, "getSizeCallbacks", new Map());
     (0, _defineProperty2.default)(this, "reactValidateCallbacks", new Map());
+    (0, _defineProperty2.default)(this, "EQUALITY_THRESHOLD", (0, _platformFeatureFlags.fg)('platform_ufo_ssr_placeholder_round_rect_size_check') ? 1 : 0.1);
     (0, _defineProperty2.default)(this, "intersectionObserverCallback", function (_ref) {
       var _this$intersectionObs;
       var target = _ref.target,
@@ -197,7 +198,7 @@ var SSRPlaceholderHandlers = exports.SSRPlaceholderHandlers = /*#__PURE__*/funct
   }, {
     key: "hasSameSizePosition",
     value: function hasSameSizePosition(rect, boundingClientRect) {
-      return rect && Math.abs(rect.x - boundingClientRect.x) < EQUALITY_THRESHOLD && Math.abs(rect.y - boundingClientRect.y) < EQUALITY_THRESHOLD && Math.abs(rect.width - boundingClientRect.width) < EQUALITY_THRESHOLD && Math.abs(rect.height - boundingClientRect.height) < EQUALITY_THRESHOLD || false;
+      return rect && Math.abs(rect.x - boundingClientRect.x) < this.EQUALITY_THRESHOLD && Math.abs(rect.y - boundingClientRect.y) < this.EQUALITY_THRESHOLD && Math.abs(rect.width - boundingClientRect.width) < this.EQUALITY_THRESHOLD && Math.abs(rect.height - boundingClientRect.height) < this.EQUALITY_THRESHOLD || false;
     }
   }, {
     key: "isDummyRect",

package/dist/cjs/vc/vc-observer-new/viewport-observer/mutation-observer/index.js

@@ -4,6 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = createMutationObserver;
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
 function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
@@ -27,11 +28,32 @@ function createMutationObserver(_ref) {
           continue;
         }
         if (mut.type === 'attributes') {
-          var _mut$attributeName;
-          onAttributeMutation({
-            target: mut.target,
-            attributeName: (_mut$attributeName = mut.attributeName) !== null && _mut$attributeName !== void 0 ? _mut$attributeName : 'unknown'
-          });
+          if ((0, _platformFeatureFlags.fg)('platform_ufo_vc_ignore_same_value_mutation')) {
+            var _mut$oldValue;
+            /*
+            	"MutationObserver was explicitly designed to work that way, but I can't now recall the reasoning.
+            	I think it might have been something along the lines that for consistency every setAttribute call should create a record.
+            	Conceptually there is after all a mutation: there is an old value replaced with a new one,
+            	and whether or not they are the same doesn't really matter.
+            	And Custom elements should work the same way as MutationObserver."
+            	https://github.com/whatwg/dom/issues/520#issuecomment-336574796
+            */
+            var oldValue = (_mut$oldValue = mut.oldValue) !== null && _mut$oldValue !== void 0 ? _mut$oldValue : undefined;
+            var newValue = mut.attributeName ? mut.target.getAttribute(mut.attributeName) : undefined;
+            if (oldValue !== newValue) {
+              var _mut$attributeName;
+              onAttributeMutation({
+                target: mut.target,
+                attributeName: (_mut$attributeName = mut.attributeName) !== null && _mut$attributeName !== void 0 ? _mut$attributeName : 'unknown'
+              });
+            }
+          } else {
+            var _mut$attributeName2;
+            onAttributeMutation({
+              target: mut.target,
+              attributeName: (_mut$attributeName2 = mut.attributeName) !== null && _mut$attributeName2 !== void 0 ? _mut$attributeName2 : 'unknown'
+            });
+          }
           continue;
         } else if (mut.type === 'childList') {
           var _mut$addedNodes, _mut$removedNodes;

package/dist/es2019/vc/vc-observer/observers/index.js

@@ -183,13 +183,27 @@ export class Observers {
           });
         } else if (mutation.type === 'attributes') {
           if (mutation.target instanceof HTMLElement) {
-            if (fg('platform-ufo-vc-observe-attributes')) {
+            if (fg('platform_ufo_vc_ignore_same_value_mutation')) {
+              var _mutation$oldValue;
+              /*
+              		"MutationObserver was explicitly designed to work that way, but I can't now recall the reasoning.
+              		I think it might have been something along the lines that for consistency every setAttribute call should create a record.
+              		Conceptually there is after all a mutation: there is an old value replaced with a new one,
+              		and whether or not they are the same doesn't really matter.
+              		And Custom elements should work the same way as MutationObserver."
+              		https://github.com/whatwg/dom/issues/520#issuecomment-336574796
+              	*/
+              const oldValue = (_mutation$oldValue = mutation.oldValue) !== null && _mutation$oldValue !== void 0 ? _mutation$oldValue : undefined;
+              const newValue = mutation.attributeName ? mutation.target.getAttribute(mutation.attributeName) : undefined;
+              if (oldValue !== newValue) {
+                this.observeElement(mutation.target, mutation, 'attr', ignoreReason);
+              }
+            } else {
               this.observeElement(mutation.target, mutation, 'attr', ignoreReason);
             }
           }
         }
       });
-      this.measureStop();
     }) : null;
   }
   getElementName(element) {

package/dist/es2019/vc/vc-observer/observers/ssr-placeholders/index.js

@@ -1,5 +1,5 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
-const EQUALITY_THRESHOLD = 0.1;
+import { fg } from '@atlaskit/platform-feature-flags';
 const ANCESTOR_LOOKUP_LIMIT = 10;
 export class SSRPlaceholderHandlers {
   constructor() {
@@ -7,6 +7,7 @@ export class SSRPlaceholderHandlers {
     _defineProperty(this, "callbacks", new Map());
     _defineProperty(this, "getSizeCallbacks", new Map());
     _defineProperty(this, "reactValidateCallbacks", new Map());
+    _defineProperty(this, "EQUALITY_THRESHOLD", fg('platform_ufo_ssr_placeholder_round_rect_size_check') ? 1 : 0.1);
     _defineProperty(this, "intersectionObserverCallback", ({
       target,
       boundingClientRect
@@ -162,7 +163,7 @@ export class SSRPlaceholderHandlers {
     });
   }
   hasSameSizePosition(rect, boundingClientRect) {
-    return rect && Math.abs(rect.x - boundingClientRect.x) < EQUALITY_THRESHOLD && Math.abs(rect.y - boundingClientRect.y) < EQUALITY_THRESHOLD && Math.abs(rect.width - boundingClientRect.width) < EQUALITY_THRESHOLD && Math.abs(rect.height - boundingClientRect.height) < EQUALITY_THRESHOLD || false;
+    return rect && Math.abs(rect.x - boundingClientRect.x) < this.EQUALITY_THRESHOLD && Math.abs(rect.y - boundingClientRect.y) < this.EQUALITY_THRESHOLD && Math.abs(rect.width - boundingClientRect.width) < this.EQUALITY_THRESHOLD && Math.abs(rect.height - boundingClientRect.height) < this.EQUALITY_THRESHOLD || false;
   }
   isDummyRect(rect) {
     return rect && rect.width < 0 && rect.height < 0 || false;

package/dist/es2019/vc/vc-observer-new/viewport-observer/mutation-observer/index.js

@@ -1,3 +1,4 @@
+import { fg } from '@atlaskit/platform-feature-flags';
 export default function createMutationObserver({
   onAttributeMutation,
   onChildListMutation,
@@ -15,11 +16,32 @@ export default function createMutationObserver({
         continue;
       }
       if (mut.type === 'attributes') {
-        var _mut$attributeName;
-        onAttributeMutation({
-          target: mut.target,
-          attributeName: (_mut$attributeName = mut.attributeName) !== null && _mut$attributeName !== void 0 ? _mut$attributeName : 'unknown'
-        });
+        if (fg('platform_ufo_vc_ignore_same_value_mutation')) {
+          var _mut$oldValue;
+          /*
+          	"MutationObserver was explicitly designed to work that way, but I can't now recall the reasoning.
+          	I think it might have been something along the lines that for consistency every setAttribute call should create a record.
+          	Conceptually there is after all a mutation: there is an old value replaced with a new one,
+          	and whether or not they are the same doesn't really matter.
+          	And Custom elements should work the same way as MutationObserver."
+          	https://github.com/whatwg/dom/issues/520#issuecomment-336574796
+          */
+          const oldValue = (_mut$oldValue = mut.oldValue) !== null && _mut$oldValue !== void 0 ? _mut$oldValue : undefined;
+          const newValue = mut.attributeName ? mut.target.getAttribute(mut.attributeName) : undefined;
+          if (oldValue !== newValue) {
+            var _mut$attributeName;
+            onAttributeMutation({
+              target: mut.target,
+              attributeName: (_mut$attributeName = mut.attributeName) !== null && _mut$attributeName !== void 0 ? _mut$attributeName : 'unknown'
+            });
+          }
+        } else {
+          var _mut$attributeName2;
+          onAttributeMutation({
+            target: mut.target,
+            attributeName: (_mut$attributeName2 = mut.attributeName) !== null && _mut$attributeName2 !== void 0 ? _mut$attributeName2 : 'unknown'
+          });
+        }
         continue;
       } else if (mut.type === 'childList') {
         var _mut$addedNodes, _mut$removedNodes;

package/dist/esm/vc/vc-observer/observers/index.js

@@ -204,13 +204,27 @@ export var Observers = /*#__PURE__*/function () {
             });
           } else if (mutation.type === 'attributes') {
             if (mutation.target instanceof HTMLElement) {
-              if (fg('platform-ufo-vc-observe-attributes')) {
+              if (fg('platform_ufo_vc_ignore_same_value_mutation')) {
+                var _mutation$oldValue;
+                /*
+                		"MutationObserver was explicitly designed to work that way, but I can't now recall the reasoning.
+                		I think it might have been something along the lines that for consistency every setAttribute call should create a record.
+                		Conceptually there is after all a mutation: there is an old value replaced with a new one,
+                		and whether or not they are the same doesn't really matter.
+                		And Custom elements should work the same way as MutationObserver."
+                		https://github.com/whatwg/dom/issues/520#issuecomment-336574796
+                	*/
+                var oldValue = (_mutation$oldValue = mutation.oldValue) !== null && _mutation$oldValue !== void 0 ? _mutation$oldValue : undefined;
+                var newValue = mutation.attributeName ? mutation.target.getAttribute(mutation.attributeName) : undefined;
+                if (oldValue !== newValue) {
+                  _this2.observeElement(mutation.target, mutation, 'attr', ignoreReason);
+                }
+              } else {
                 _this2.observeElement(mutation.target, mutation, 'attr', ignoreReason);
               }
             }
           }
         });
-        _this2.measureStop();
       }) : null;
     }
   }, {

package/dist/esm/vc/vc-observer/observers/ssr-placeholders/index.js

@@ -1,7 +1,7 @@
 import _classCallCheck from "@babel/runtime/helpers/classCallCheck";
 import _createClass from "@babel/runtime/helpers/createClass";
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
-var EQUALITY_THRESHOLD = 0.1;
+import { fg } from '@atlaskit/platform-feature-flags';
 var ANCESTOR_LOOKUP_LIMIT = 10;
 export var SSRPlaceholderHandlers = /*#__PURE__*/function () {
   function SSRPlaceholderHandlers() {
@@ -11,6 +11,7 @@ export var SSRPlaceholderHandlers = /*#__PURE__*/function () {
     _defineProperty(this, "callbacks", new Map());
     _defineProperty(this, "getSizeCallbacks", new Map());
     _defineProperty(this, "reactValidateCallbacks", new Map());
+    _defineProperty(this, "EQUALITY_THRESHOLD", fg('platform_ufo_ssr_placeholder_round_rect_size_check') ? 1 : 0.1);
     _defineProperty(this, "intersectionObserverCallback", function (_ref) {
       var _this$intersectionObs;
       var target = _ref.target,
@@ -190,7 +191,7 @@ export var SSRPlaceholderHandlers = /*#__PURE__*/function () {
   }, {
     key: "hasSameSizePosition",
     value: function hasSameSizePosition(rect, boundingClientRect) {
-      return rect && Math.abs(rect.x - boundingClientRect.x) < EQUALITY_THRESHOLD && Math.abs(rect.y - boundingClientRect.y) < EQUALITY_THRESHOLD && Math.abs(rect.width - boundingClientRect.width) < EQUALITY_THRESHOLD && Math.abs(rect.height - boundingClientRect.height) < EQUALITY_THRESHOLD || false;
+      return rect && Math.abs(rect.x - boundingClientRect.x) < this.EQUALITY_THRESHOLD && Math.abs(rect.y - boundingClientRect.y) < this.EQUALITY_THRESHOLD && Math.abs(rect.width - boundingClientRect.width) < this.EQUALITY_THRESHOLD && Math.abs(rect.height - boundingClientRect.height) < this.EQUALITY_THRESHOLD || false;
     }
   }, {
     key: "isDummyRect",

package/dist/esm/vc/vc-observer-new/viewport-observer/mutation-observer/index.js

@@ -1,6 +1,7 @@
 function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
 function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
+import { fg } from '@atlaskit/platform-feature-flags';
 export default function createMutationObserver(_ref) {
   var onAttributeMutation = _ref.onAttributeMutation,
     onChildListMutation = _ref.onChildListMutation,
@@ -21,11 +22,32 @@ export default function createMutationObserver(_ref) {
           continue;
         }
         if (mut.type === 'attributes') {
-          var _mut$attributeName;
-          onAttributeMutation({
-            target: mut.target,
-            attributeName: (_mut$attributeName = mut.attributeName) !== null && _mut$attributeName !== void 0 ? _mut$attributeName : 'unknown'
-          });
+          if (fg('platform_ufo_vc_ignore_same_value_mutation')) {
+            var _mut$oldValue;
+            /*
+            	"MutationObserver was explicitly designed to work that way, but I can't now recall the reasoning.
+            	I think it might have been something along the lines that for consistency every setAttribute call should create a record.
+            	Conceptually there is after all a mutation: there is an old value replaced with a new one,
+            	and whether or not they are the same doesn't really matter.
+            	And Custom elements should work the same way as MutationObserver."
+            	https://github.com/whatwg/dom/issues/520#issuecomment-336574796
+            */
+            var oldValue = (_mut$oldValue = mut.oldValue) !== null && _mut$oldValue !== void 0 ? _mut$oldValue : undefined;
+            var newValue = mut.attributeName ? mut.target.getAttribute(mut.attributeName) : undefined;
+            if (oldValue !== newValue) {
+              var _mut$attributeName;
+              onAttributeMutation({
+                target: mut.target,
+                attributeName: (_mut$attributeName = mut.attributeName) !== null && _mut$attributeName !== void 0 ? _mut$attributeName : 'unknown'
+              });
+            }
+          } else {
+            var _mut$attributeName2;
+            onAttributeMutation({
+              target: mut.target,
+              attributeName: (_mut$attributeName2 = mut.attributeName) !== null && _mut$attributeName2 !== void 0 ? _mut$attributeName2 : 'unknown'
+            });
+          }
           continue;
         } else if (mut.type === 'childList') {
           var _mut$addedNodes, _mut$removedNodes;

package/dist/types/vc/vc-observer/observers/ssr-placeholders/index.d.ts

@@ -10,6 +10,7 @@ export declare class SSRPlaceholderHandlers {
     private getSizeCallbacks;
     private reactValidateCallbacks;
     private intersectionObserver;
+    private EQUALITY_THRESHOLD;
     constructor();
     clear(): void;
     isPlaceholder(element: HTMLElement): boolean;

package/dist/types-ts4.5/vc/vc-observer/observers/ssr-placeholders/index.d.ts

@@ -10,6 +10,7 @@ export declare class SSRPlaceholderHandlers {
     private getSizeCallbacks;
     private reactValidateCallbacks;
     private intersectionObserver;
+    private EQUALITY_THRESHOLD;
     constructor();
     clear(): void;
     isPlaceholder(element: HTMLElement): boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/react-ufo",
-	"version": "3.4.8",
+	"version": "3.4.10",
 	"description": "Parts of React UFO that are publicly available",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -183,6 +183,12 @@
 		},
 		"ufo_payload_use_idle_callback": {
 			"type": "boolean"
+		},
+		"platform_ufo_ssr_placeholder_round_rect_size_check": {
+			"type": "boolean"
+		},
+		"platform_ufo_vc_ignore_same_value_mutation": {
+			"type": "boolean"
 		}
 	}
 }