@atlaskit/react-ufo 3.12.0 → 3.12.2

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/ufo-interaction-ignore
 
+## 3.12.2
+
+### Patch Changes
+
+- [#152526](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/152526)
+  [`418c1f18e4a6e`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/418c1f18e4a6e) -
+  FG cleanup for platform_ufo_set_event_failed_status_in_client and
+  platform_ufo_ignore_bm3_tti_event_status
+
+## 3.12.1
+
+### Patch Changes
+
+- [#155148](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/155148)
+  [`ae195d27027a7`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ae195d27027a7) -
+  [HOT-117381] Remove circular dependency on HTMLElement by using an array of WeakRef
+
 ## 3.12.0
 
 ### Minor Changes

package/dist/cjs/create-payload/utils/get-interaction-status.js

@@ -4,40 +4,15 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
-/**
- * Determines the interaction status based on abort reason and BM3 TTI presence.
- *
- * @param {InteractionMetrics} interaction - The interaction metrics object containing abort reason and apdex data
- * @returns {{
- *   originalInteractionStatus: 'ABORTED' | 'SUCCEEDED',
- *   overrideStatus: 'ABORTED' | 'SUCCEEDED'
- * }} An object containing both the original and override status
- *
- * @description
- * This function evaluates the interaction status in two ways:
- * 1. originalInteractionStatus: Based on whether there's an abort reason
- * 2. overrideStatus: Based on the presence of BM3 TTI (apdex data)
- *
- * @example
- * const interaction = {
- *   abortReason: null,
- *   apdex: [1, 2, 3]
- * };
- * const result = getInteractionStatus(interaction);
- * // Returns: { originalInteractionStatus: 'SUCCEEDED', overrideStatus: 'SUCCEEDED' }
- */
 function getInteractionStatus(interaction) {
   var originalInteractionStatus = interaction.abortReason ? 'ABORTED' : 'SUCCEEDED';
   var hasErrors = interaction.errors.length > 0;
-  if ((0, _platformFeatureFlags.fg)('platform_ufo_set_event_failed_status_in_client')) {
-    originalInteractionStatus = hasErrors ? 'FAILED' : originalInteractionStatus;
-  }
-  var hasBm3TTI = interaction.apdex.length > 0;
-  var overrideStatus = hasBm3TTI && !(0, _platformFeatureFlags.fg)('platform_ufo_ignore_bm3_tti_event_status') ? 'SUCCEEDED' : originalInteractionStatus;
+  originalInteractionStatus = hasErrors ? 'FAILED' : originalInteractionStatus;
+
+  // `overrideStatus` is to be deprecated - https://product-fabric.atlassian.net/browse/AFO-3760
   return {
     originalInteractionStatus: originalInteractionStatus,
-    overrideStatus: overrideStatus
+    overrideStatus: originalInteractionStatus
   };
 }
 var _default = exports.default = getInteractionStatus;

package/dist/cjs/vc/vc-observer-new/viewport-observer/index.js

@@ -87,12 +87,24 @@ var ViewportObserver = exports.default = /*#__PURE__*/function () {
     (0, _defineProperty2.default)(this, "handleChildListMutation", function (_ref4) {
       var addedNodes = _ref4.addedNodes,
         removedNodes = _ref4.removedNodes;
-      var removedNodeRects = removedNodes.map(function (n) {
+      var removedNodeRects = removedNodes.map(function (ref) {
+        var n = ref.deref();
+        if (!n) {
+          return;
+        }
         return _this.mapVisibleNodeRects.get(n);
       });
-      addedNodes.forEach(function (addedNode) {
+      addedNodes.forEach(function (addedNodeRef) {
         var _this$intersectionObs3;
-        var sameDeletedNode = removedNodes.find(function (n) {
+        var addedNode = addedNodeRef.deref();
+        if (!addedNode) {
+          return;
+        }
+        var sameDeletedNode = removedNodes.find(function (ref) {
+          var n = ref.deref();
+          if (!n || !addedNode) {
+            return false;
+          }
           return n.isEqualNode(addedNode);
         });
         if (sameDeletedNode) {

package/dist/cjs/vc/vc-observer-new/viewport-observer/mutation-observer/index.js

@@ -50,12 +50,12 @@ function createMutationObserver(_ref) {
           var _mut$addedNodes, _mut$removedNodes;
           ((_mut$addedNodes = mut.addedNodes) !== null && _mut$addedNodes !== void 0 ? _mut$addedNodes : []).forEach(function (node) {
             if (node instanceof HTMLElement) {
-              addedNodes.push(node);
+              addedNodes.push(new WeakRef(node));
             }
           });
           ((_mut$removedNodes = mut.removedNodes) !== null && _mut$removedNodes !== void 0 ? _mut$removedNodes : []).forEach(function (node) {
             if (node instanceof HTMLElement) {
-              removedNodes.push(node);
+              removedNodes.push(new WeakRef(node));
             }
           });
         }

package/dist/es2019/create-payload/utils/get-interaction-status.js

@@ -1,37 +1,12 @@
-import { fg } from '@atlaskit/platform-feature-flags';
-/**
- * Determines the interaction status based on abort reason and BM3 TTI presence.
- *
- * @param {InteractionMetrics} interaction - The interaction metrics object containing abort reason and apdex data
- * @returns {{
- *   originalInteractionStatus: 'ABORTED' | 'SUCCEEDED',
- *   overrideStatus: 'ABORTED' | 'SUCCEEDED'
- * }} An object containing both the original and override status
- *
- * @description
- * This function evaluates the interaction status in two ways:
- * 1. originalInteractionStatus: Based on whether there's an abort reason
- * 2. overrideStatus: Based on the presence of BM3 TTI (apdex data)
- *
- * @example
- * const interaction = {
- *   abortReason: null,
- *   apdex: [1, 2, 3]
- * };
- * const result = getInteractionStatus(interaction);
- * // Returns: { originalInteractionStatus: 'SUCCEEDED', overrideStatus: 'SUCCEEDED' }
- */
 function getInteractionStatus(interaction) {
   let originalInteractionStatus = interaction.abortReason ? 'ABORTED' : 'SUCCEEDED';
   const hasErrors = interaction.errors.length > 0;
-  if (fg('platform_ufo_set_event_failed_status_in_client')) {
-    originalInteractionStatus = hasErrors ? 'FAILED' : originalInteractionStatus;
-  }
-  const hasBm3TTI = interaction.apdex.length > 0;
-  const overrideStatus = hasBm3TTI && !fg('platform_ufo_ignore_bm3_tti_event_status') ? 'SUCCEEDED' : originalInteractionStatus;
+  originalInteractionStatus = hasErrors ? 'FAILED' : originalInteractionStatus;
+
+  // `overrideStatus` is to be deprecated - https://product-fabric.atlassian.net/browse/AFO-3760
   return {
     originalInteractionStatus,
-    overrideStatus
+    overrideStatus: originalInteractionStatus
   };
 }
 export default getInteractionStatus;

package/dist/es2019/vc/vc-observer-new/viewport-observer/index.js

@@ -73,10 +73,26 @@ export default class ViewportObserver {
       addedNodes,
       removedNodes
     }) => {
-      const removedNodeRects = removedNodes.map(n => this.mapVisibleNodeRects.get(n));
-      addedNodes.forEach(addedNode => {
+      const removedNodeRects = removedNodes.map(ref => {
+        const n = ref.deref();
+        if (!n) {
+          return;
+        }
+        return this.mapVisibleNodeRects.get(n);
+      });
+      addedNodes.forEach(addedNodeRef => {
         var _this$intersectionObs3;
-        const sameDeletedNode = removedNodes.find(n => n.isEqualNode(addedNode));
+        const addedNode = addedNodeRef.deref();
+        if (!addedNode) {
+          return;
+        }
+        const sameDeletedNode = removedNodes.find(ref => {
+          const n = ref.deref();
+          if (!n || !addedNode) {
+            return false;
+          }
+          return n.isEqualNode(addedNode);
+        });
         if (sameDeletedNode) {
           var _this$intersectionObs;
           (_this$intersectionObs = this.intersectionObserver) === null || _this$intersectionObs === void 0 ? void 0 : _this$intersectionObs.watchAndTag(addedNode, 'mutation:remount');

package/dist/es2019/vc/vc-observer-new/viewport-observer/mutation-observer/index.js

@@ -38,12 +38,12 @@ function createMutationObserver({
         var _mut$addedNodes, _mut$removedNodes;
         ((_mut$addedNodes = mut.addedNodes) !== null && _mut$addedNodes !== void 0 ? _mut$addedNodes : []).forEach(node => {
           if (node instanceof HTMLElement) {
-            addedNodes.push(node);
+            addedNodes.push(new WeakRef(node));
           }
         });
         ((_mut$removedNodes = mut.removedNodes) !== null && _mut$removedNodes !== void 0 ? _mut$removedNodes : []).forEach(node => {
           if (node instanceof HTMLElement) {
-            removedNodes.push(node);
+            removedNodes.push(new WeakRef(node));
           }
         });
       }

package/dist/esm/create-payload/utils/get-interaction-status.js

@@ -1,37 +1,12 @@
-import { fg } from '@atlaskit/platform-feature-flags';
-/**
- * Determines the interaction status based on abort reason and BM3 TTI presence.
- *
- * @param {InteractionMetrics} interaction - The interaction metrics object containing abort reason and apdex data
- * @returns {{
- *   originalInteractionStatus: 'ABORTED' | 'SUCCEEDED',
- *   overrideStatus: 'ABORTED' | 'SUCCEEDED'
- * }} An object containing both the original and override status
- *
- * @description
- * This function evaluates the interaction status in two ways:
- * 1. originalInteractionStatus: Based on whether there's an abort reason
- * 2. overrideStatus: Based on the presence of BM3 TTI (apdex data)
- *
- * @example
- * const interaction = {
- *   abortReason: null,
- *   apdex: [1, 2, 3]
- * };
- * const result = getInteractionStatus(interaction);
- * // Returns: { originalInteractionStatus: 'SUCCEEDED', overrideStatus: 'SUCCEEDED' }
- */
 function getInteractionStatus(interaction) {
   var originalInteractionStatus = interaction.abortReason ? 'ABORTED' : 'SUCCEEDED';
   var hasErrors = interaction.errors.length > 0;
-  if (fg('platform_ufo_set_event_failed_status_in_client')) {
-    originalInteractionStatus = hasErrors ? 'FAILED' : originalInteractionStatus;
-  }
-  var hasBm3TTI = interaction.apdex.length > 0;
-  var overrideStatus = hasBm3TTI && !fg('platform_ufo_ignore_bm3_tti_event_status') ? 'SUCCEEDED' : originalInteractionStatus;
+  originalInteractionStatus = hasErrors ? 'FAILED' : originalInteractionStatus;
+
+  // `overrideStatus` is to be deprecated - https://product-fabric.atlassian.net/browse/AFO-3760
   return {
     originalInteractionStatus: originalInteractionStatus,
-    overrideStatus: overrideStatus
+    overrideStatus: originalInteractionStatus
   };
 }
 export default getInteractionStatus;

package/dist/esm/vc/vc-observer-new/viewport-observer/index.js

@@ -80,12 +80,24 @@ var ViewportObserver = /*#__PURE__*/function () {
     _defineProperty(this, "handleChildListMutation", function (_ref4) {
       var addedNodes = _ref4.addedNodes,
         removedNodes = _ref4.removedNodes;
-      var removedNodeRects = removedNodes.map(function (n) {
+      var removedNodeRects = removedNodes.map(function (ref) {
+        var n = ref.deref();
+        if (!n) {
+          return;
+        }
         return _this.mapVisibleNodeRects.get(n);
       });
-      addedNodes.forEach(function (addedNode) {
+      addedNodes.forEach(function (addedNodeRef) {
         var _this$intersectionObs3;
-        var sameDeletedNode = removedNodes.find(function (n) {
+        var addedNode = addedNodeRef.deref();
+        if (!addedNode) {
+          return;
+        }
+        var sameDeletedNode = removedNodes.find(function (ref) {
+          var n = ref.deref();
+          if (!n || !addedNode) {
+            return false;
+          }
           return n.isEqualNode(addedNode);
         });
         if (sameDeletedNode) {

package/dist/esm/vc/vc-observer-new/viewport-observer/mutation-observer/index.js

@@ -44,12 +44,12 @@ function createMutationObserver(_ref) {
           var _mut$addedNodes, _mut$removedNodes;
           ((_mut$addedNodes = mut.addedNodes) !== null && _mut$addedNodes !== void 0 ? _mut$addedNodes : []).forEach(function (node) {
             if (node instanceof HTMLElement) {
-              addedNodes.push(node);
+              addedNodes.push(new WeakRef(node));
             }
           });
           ((_mut$removedNodes = mut.removedNodes) !== null && _mut$removedNodes !== void 0 ? _mut$removedNodes : []).forEach(function (node) {
             if (node instanceof HTMLElement) {
-              removedNodes.push(node);
+              removedNodes.push(new WeakRef(node));
             }
           });
         }

package/dist/types/create-payload/utils/get-interaction-status.d.ts

@@ -1,26 +1,4 @@
 import type { InteractionMetrics } from '../../common';
-/**
- * Determines the interaction status based on abort reason and BM3 TTI presence.
- *
- * @param {InteractionMetrics} interaction - The interaction metrics object containing abort reason and apdex data
- * @returns {{
- *   originalInteractionStatus: 'ABORTED' | 'SUCCEEDED',
- *   overrideStatus: 'ABORTED' | 'SUCCEEDED'
- * }} An object containing both the original and override status
- *
- * @description
- * This function evaluates the interaction status in two ways:
- * 1. originalInteractionStatus: Based on whether there's an abort reason
- * 2. overrideStatus: Based on the presence of BM3 TTI (apdex data)
- *
- * @example
- * const interaction = {
- *   abortReason: null,
- *   apdex: [1, 2, 3]
- * };
- * const result = getInteractionStatus(interaction);
- * // Returns: { originalInteractionStatus: 'SUCCEEDED', overrideStatus: 'SUCCEEDED' }
- */
 declare function getInteractionStatus(interaction: InteractionMetrics): {
     readonly originalInteractionStatus: string;
     readonly overrideStatus: string;

package/dist/types/vc/vc-observer-new/viewport-observer/mutation-observer/index.d.ts

@@ -7,8 +7,8 @@ export type CreateMutationObserverProps = {
         targets: Array<HTMLElement>;
     }) => void;
     onChildListMutation: (props: {
-        addedNodes: ReadonlyArray<HTMLElement>;
-        removedNodes: ReadonlyArray<HTMLElement>;
+        addedNodes: ReadonlyArray<WeakRef<HTMLElement>>;
+        removedNodes: ReadonlyArray<WeakRef<HTMLElement>>;
     }) => void;
 };
 declare function createMutationObserver({ onAttributeMutation, onChildListMutation, onMutationFinished, }: CreateMutationObserverProps): MutationObserver | null;

package/dist/types-ts4.5/create-payload/utils/get-interaction-status.d.ts

@@ -1,26 +1,4 @@
 import type { InteractionMetrics } from '../../common';
-/**
- * Determines the interaction status based on abort reason and BM3 TTI presence.
- *
- * @param {InteractionMetrics} interaction - The interaction metrics object containing abort reason and apdex data
- * @returns {{
- *   originalInteractionStatus: 'ABORTED' | 'SUCCEEDED',
- *   overrideStatus: 'ABORTED' | 'SUCCEEDED'
- * }} An object containing both the original and override status
- *
- * @description
- * This function evaluates the interaction status in two ways:
- * 1. originalInteractionStatus: Based on whether there's an abort reason
- * 2. overrideStatus: Based on the presence of BM3 TTI (apdex data)
- *
- * @example
- * const interaction = {
- *   abortReason: null,
- *   apdex: [1, 2, 3]
- * };
- * const result = getInteractionStatus(interaction);
- * // Returns: { originalInteractionStatus: 'SUCCEEDED', overrideStatus: 'SUCCEEDED' }
- */
 declare function getInteractionStatus(interaction: InteractionMetrics): {
     readonly originalInteractionStatus: string;
     readonly overrideStatus: string;

package/dist/types-ts4.5/vc/vc-observer-new/viewport-observer/mutation-observer/index.d.ts

@@ -7,8 +7,8 @@ export type CreateMutationObserverProps = {
         targets: Array<HTMLElement>;
     }) => void;
     onChildListMutation: (props: {
-        addedNodes: ReadonlyArray<HTMLElement>;
-        removedNodes: ReadonlyArray<HTMLElement>;
+        addedNodes: ReadonlyArray<WeakRef<HTMLElement>>;
+        removedNodes: ReadonlyArray<WeakRef<HTMLElement>>;
     }) => void;
 };
 declare function createMutationObserver({ onAttributeMutation, onChildListMutation, onMutationFinished, }: CreateMutationObserverProps): MutationObserver | null;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/react-ufo",
-	"version": "3.12.0",
+	"version": "3.12.2",
 	"description": "Parts of React UFO that are publicly available",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -154,12 +154,6 @@
 		"platform_ufo_no_vc_on_aborted": {
 			"type": "boolean"
 		},
-		"platform_ufo_set_event_failed_status_in_client": {
-			"type": "boolean"
-		},
-		"platform_ufo_ignore_bm3_tti_event_status": {
-			"type": "boolean"
-		},
 		"ufo_payload_use_idle_callback": {
 			"type": "boolean"
 		},