@atlaskit/profilecard 16.4.3 → 16.4.6

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/profilecard
 
+## 16.4.6
+
+### Patch Changes
+
+- [`386249e4be4`](https://bitbucket.org/atlassian/atlassian-frontend/commits/386249e4be4) - [ux] Fix hide handler when the profile card is triggered via click
+
+## 16.4.5
+
+### Patch Changes
+
+- [`18ab5ef3325`](https://bitbucket.org/atlassian/atlassian-frontend/commits/18ab5ef3325) - Filter out certain types of failures for team profilecard data fetch
+
+## 16.4.4
+
+### Patch Changes
+
+- [`b876346271a`](https://bitbucket.org/atlassian/atlassian-frontend/commits/b876346271a) - Ensure that component wrapping a ProfileCardTrigger is not clicked when clicking the trigger
+
 ## 16.4.3
 
 ### Patch Changes

package/dist/cjs/client/TeamProfileCardClient.js

@@ -43,6 +43,12 @@ var buildTeamQuery = function buildTeamQuery(teamId, orgId) {
   };
 };
 
+var IGNORED_ERRORS = ['NotPermitted', 'Gone'];
+
+function isRealError(error) {
+  return !IGNORED_ERRORS.includes(error.reason);
+}
+
 var TeamProfileCardClient = /*#__PURE__*/function (_CachingClient) {
   (0, _inherits2.default)(TeamProfileCardClient, _CachingClient);
 
@@ -116,7 +122,7 @@ var TeamProfileCardClient = /*#__PURE__*/function (_CachingClient) {
 
           resolve(data);
         }).catch(function (error) {
-          if (analytics) {
+          if (analytics && isRealError(error)) {
             analytics((0, _analytics.teamRequestAnalytics)('failed', {
               duration: (0, _performance.getPageTime)() - startTime,
               errorStatus: error.code,

package/dist/cjs/components/User/ProfileCardTrigger.js

@@ -99,11 +99,19 @@ var ProfilecardTrigger = /*#__PURE__*/function (_React$PureComponent) {
         }
       }, _this.showDelay);
     });
+    (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "onClick", function (event) {
+      // If the user clicks on the trigger then we don't want that click event to
+      // propagate out to parent containers. For example when clicking a mention
+      // lozenge in an inline-edit.
+      event.stopPropagation();
+
+      _this.showProfilecard();
+    });
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "containerListeners", _this.props.trigger === 'hover' ? {
       onMouseEnter: _this.showProfilecard,
       onMouseLeave: _this.hideProfilecard
     } : {
-      onClick: _this.showProfilecard
+      onClick: _this.onClick
     });
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "layerListeners", {
       handleClickOutside: _this.hideProfilecard,
@@ -256,7 +264,8 @@ var ProfilecardTrigger = /*#__PURE__*/function (_React$PureComponent) {
             "data-testid": _this2.props.testId
           }), _this2.props.children);
         },
-        zIndex: _constants.layers.modal()
+        zIndex: _constants.layers.modal(),
+        shouldUseCaptureOnOutsideClick: true
       });
     }
   }, {

package/dist/cjs/util/analytics.js

@@ -56,7 +56,7 @@ var createEvent = function createEvent(eventType, action, actionSubject, actionS
     actionSubjectId: actionSubjectId,
     attributes: _objectSpread(_objectSpread({
       packageName: "@atlaskit/profilecard",
-      packageVersion: "16.4.3"
+      packageVersion: "16.4.6"
     }, attributes), {}, {
       firedAt: (0, _performance.getPageTime)()
     })

package/dist/cjs/version.json

@@ -1,4 +1,4 @@
 {
 	"name": "@atlaskit/profilecard",
-	"version": "16.4.3"
+	"version": "16.4.6"
 }

package/dist/es2019/client/TeamProfileCardClient.js

@@ -28,6 +28,12 @@ const buildTeamQuery = (teamId, orgId) => ({
   }
 });
 
+const IGNORED_ERRORS = ['NotPermitted', 'Gone'];
+
+function isRealError(error) {
+  return !IGNORED_ERRORS.includes(error.reason);
+}
+
 export default class TeamProfileCardClient extends CachingClient {
   constructor(options) {
     super(options);
@@ -85,7 +91,7 @@ export default class TeamProfileCardClient extends CachingClient {
 
         resolve(data);
       }).catch(error => {
-        if (analytics) {
+        if (analytics && isRealError(error)) {
           analytics(teamRequestAnalytics('failed', {
             duration: getPageTime() - startTime,
             errorStatus: error.code,

package/dist/es2019/components/User/ProfileCardTrigger.js

@@ -46,11 +46,19 @@ class ProfilecardTrigger extends React.PureComponent {
       }, this.showDelay);
     });
 
+    _defineProperty(this, "onClick", event => {
+      // If the user clicks on the trigger then we don't want that click event to
+      // propagate out to parent containers. For example when clicking a mention
+      // lozenge in an inline-edit.
+      event.stopPropagation();
+      this.showProfilecard();
+    });
+
     _defineProperty(this, "containerListeners", this.props.trigger === 'hover' ? {
       onMouseEnter: this.showProfilecard,
       onMouseLeave: this.hideProfilecard
     } : {
-      onClick: this.showProfilecard
+      onClick: this.onClick
     });
 
     _defineProperty(this, "layerListeners", {
@@ -198,7 +206,8 @@ class ProfilecardTrigger extends React.PureComponent {
           "data-testid": this.props.testId
         }), this.props.children);
       },
-      zIndex: layers.modal()
+      zIndex: layers.modal(),
+      shouldUseCaptureOnOutsideClick: true
     });
   }
 

package/dist/es2019/util/analytics.js

@@ -35,7 +35,7 @@ const createEvent = (eventType, action, actionSubject, actionSubjectId, attribut
   actionSubjectId,
   attributes: {
     packageName: "@atlaskit/profilecard",
-    packageVersion: "16.4.3",
+    packageVersion: "16.4.6",
     ...attributes,
     firedAt: getPageTime()
   }

package/dist/es2019/version.json

@@ -1,4 +1,4 @@
 {
 	"name": "@atlaskit/profilecard",
-	"version": "16.4.3"
+	"version": "16.4.6"
 }

package/dist/esm/client/TeamProfileCardClient.js

@@ -25,6 +25,12 @@ var buildTeamQuery = function buildTeamQuery(teamId, orgId) {
   };
 };
 
+var IGNORED_ERRORS = ['NotPermitted', 'Gone'];
+
+function isRealError(error) {
+  return !IGNORED_ERRORS.includes(error.reason);
+}
+
 var TeamProfileCardClient = /*#__PURE__*/function (_CachingClient) {
   _inherits(TeamProfileCardClient, _CachingClient);
 
@@ -99,7 +105,7 @@ var TeamProfileCardClient = /*#__PURE__*/function (_CachingClient) {
 
           resolve(data);
         }).catch(function (error) {
-          if (analytics) {
+          if (analytics && isRealError(error)) {
             analytics(teamRequestAnalytics('failed', {
               duration: getPageTime() - startTime,
               errorStatus: error.code,

package/dist/esm/components/User/ProfileCardTrigger.js

@@ -76,11 +76,20 @@ var ProfilecardTrigger = /*#__PURE__*/function (_React$PureComponent) {
       }, _this.showDelay);
     });
 
+    _defineProperty(_assertThisInitialized(_this), "onClick", function (event) {
+      // If the user clicks on the trigger then we don't want that click event to
+      // propagate out to parent containers. For example when clicking a mention
+      // lozenge in an inline-edit.
+      event.stopPropagation();
+
+      _this.showProfilecard();
+    });
+
     _defineProperty(_assertThisInitialized(_this), "containerListeners", _this.props.trigger === 'hover' ? {
       onMouseEnter: _this.showProfilecard,
       onMouseLeave: _this.hideProfilecard
     } : {
-      onClick: _this.showProfilecard
+      onClick: _this.onClick
     });
 
     _defineProperty(_assertThisInitialized(_this), "layerListeners", {
@@ -239,7 +248,8 @@ var ProfilecardTrigger = /*#__PURE__*/function (_React$PureComponent) {
             "data-testid": _this2.props.testId
           }), _this2.props.children);
         },
-        zIndex: layers.modal()
+        zIndex: layers.modal(),
+        shouldUseCaptureOnOutsideClick: true
       });
     }
   }, {

package/dist/esm/util/analytics.js

@@ -45,7 +45,7 @@ var createEvent = function createEvent(eventType, action, actionSubject, actionS
     actionSubjectId: actionSubjectId,
     attributes: _objectSpread(_objectSpread({
       packageName: "@atlaskit/profilecard",
-      packageVersion: "16.4.3"
+      packageVersion: "16.4.6"
     }, attributes), {}, {
       firedAt: getPageTime()
     })

package/dist/esm/version.json

@@ -1,4 +1,4 @@
 {
 	"name": "@atlaskit/profilecard",
-	"version": "16.4.3"
+	"version": "16.4.6"
 }

package/dist/types/components/User/ProfileCardTrigger.d.ts

@@ -9,12 +9,13 @@ declare class ProfilecardTrigger extends React.PureComponent<ProfileCardTriggerP
     hideTimer: number;
     hideProfilecard: () => void;
     showProfilecard: () => void;
+    onClick: (event: React.MouseEvent) => void;
     containerListeners: {
         onMouseEnter: () => void;
         onMouseLeave: () => void;
         onClick?: undefined;
     } | {
-        onClick: () => void;
+        onClick: (event: React.MouseEvent) => void;
         onMouseEnter?: undefined;
         onMouseLeave?: undefined;
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/profilecard",
-  "version": "16.4.3",
+  "version": "16.4.6",
   "description": "A React component to display a card with user information.",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"