@atlaskit/primitives 1.2.2 → 1.2.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/primitives
 
+## 1.2.3
+
+### Patch Changes
+
+- [`dfd014c15b3`](https://bitbucket.org/atlassian/atlassian-frontend/commits/dfd014c15b3) - [ux] Pressable primitive: Adds missing cursor style `not-allowed` for disabled buttons
+
 ## 1.2.2
 
 ### Patch Changes

package/dist/cjs/components/pressable.js

@@ -15,10 +15,6 @@ var _box = _interopRequireDefault(require("./box"));
 var _excluded = ["children", "backgroundColor", "padding", "paddingBlock", "paddingBlockStart", "paddingBlockEnd", "paddingInline", "paddingInlineStart", "paddingInlineEnd", "isDisabled", "type", "testId", "xcss"];
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
-var defaultStyles = (0, _xcss.xcss)({
-  cursor: 'pointer'
-});
-
 // TODO: Duplicated FocusRing styles due to lack of `xcss` support
 // and to prevent additional dependency
 var baseFocusRingStyles = {
@@ -67,9 +63,12 @@ var UNSAFE_PRESSABLE = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref)
     xcssStyles = _ref.xcss,
     htmlAttributes = (0, _objectWithoutProperties2.default)(_ref, _excluded);
   // Combine default styles with supplied styles. XCSS does not support deep nested arrays
-  var styles = [defaultStyles, focusRingStyles];
+  var styles = [(0, _xcss.xcss)({
+    cursor: isDisabled ? 'not-allowed' : 'pointer'
+  }), focusRingStyles];
   styles = Array.isArray(xcssStyles) ? [].concat((0, _toConsumableArray2.default)(styles), (0, _toConsumableArray2.default)(xcssStyles)) : [].concat((0, _toConsumableArray2.default)(styles), [xcssStyles]);
   return /*#__PURE__*/_react.default.createElement(_box.default, (0, _extends2.default)({}, htmlAttributes, {
+    as: "button",
     ref: ref,
     testId: testId,
     type: type,
@@ -80,8 +79,7 @@ var UNSAFE_PRESSABLE = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref)
     paddingBlockEnd: paddingBlockEnd,
     paddingInline: paddingInline,
     paddingInlineStart: paddingInlineStart,
-    paddingInlineEnd: paddingInlineEnd,
-    as: "button"
+    paddingInlineEnd: paddingInlineEnd
     // eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage
     ,
     xcss: styles,

package/dist/es2019/components/pressable.js

@@ -2,10 +2,6 @@ import _extends from "@babel/runtime/helpers/extends";
 import React, { forwardRef } from 'react';
 import { xcss } from '../xcss/xcss';
 import Box from './box';
-const defaultStyles = xcss({
-  cursor: 'pointer'
-});
-
 // TODO: Duplicated FocusRing styles due to lack of `xcss` support
 // and to prevent additional dependency
 const baseFocusRingStyles = {
@@ -54,9 +50,12 @@ const UNSAFE_PRESSABLE = /*#__PURE__*/forwardRef(({
   ...htmlAttributes
 }, ref) => {
   // Combine default styles with supplied styles. XCSS does not support deep nested arrays
-  let styles = [defaultStyles, focusRingStyles];
+  let styles = [xcss({
+    cursor: isDisabled ? 'not-allowed' : 'pointer'
+  }), focusRingStyles];
   styles = Array.isArray(xcssStyles) ? [...styles, ...xcssStyles] : [...styles, xcssStyles];
   return /*#__PURE__*/React.createElement(Box, _extends({}, htmlAttributes, {
+    as: "button",
     ref: ref,
     testId: testId,
     type: type,
@@ -67,8 +66,7 @@ const UNSAFE_PRESSABLE = /*#__PURE__*/forwardRef(({
     paddingBlockEnd: paddingBlockEnd,
     paddingInline: paddingInline,
     paddingInlineStart: paddingInlineStart,
-    paddingInlineEnd: paddingInlineEnd,
-    as: "button"
+    paddingInlineEnd: paddingInlineEnd
     // eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage
     ,
     xcss: styles,

package/dist/esm/components/pressable.js

@@ -5,10 +5,6 @@ var _excluded = ["children", "backgroundColor", "padding", "paddingBlock", "padd
 import React, { forwardRef } from 'react';
 import { xcss } from '../xcss/xcss';
 import Box from './box';
-var defaultStyles = xcss({
-  cursor: 'pointer'
-});
-
 // TODO: Duplicated FocusRing styles due to lack of `xcss` support
 // and to prevent additional dependency
 var baseFocusRingStyles = {
@@ -57,9 +53,12 @@ var UNSAFE_PRESSABLE = /*#__PURE__*/forwardRef(function (_ref, ref) {
     xcssStyles = _ref.xcss,
     htmlAttributes = _objectWithoutProperties(_ref, _excluded);
   // Combine default styles with supplied styles. XCSS does not support deep nested arrays
-  var styles = [defaultStyles, focusRingStyles];
+  var styles = [xcss({
+    cursor: isDisabled ? 'not-allowed' : 'pointer'
+  }), focusRingStyles];
   styles = Array.isArray(xcssStyles) ? [].concat(_toConsumableArray(styles), _toConsumableArray(xcssStyles)) : [].concat(_toConsumableArray(styles), [xcssStyles]);
   return /*#__PURE__*/React.createElement(Box, _extends({}, htmlAttributes, {
+    as: "button",
     ref: ref,
     testId: testId,
     type: type,
@@ -70,8 +69,7 @@ var UNSAFE_PRESSABLE = /*#__PURE__*/forwardRef(function (_ref, ref) {
     paddingBlockEnd: paddingBlockEnd,
     paddingInline: paddingInline,
     paddingInlineStart: paddingInlineStart,
-    paddingInlineEnd: paddingInlineEnd,
-    as: "button"
+    paddingInlineEnd: paddingInlineEnd
     // eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage
     ,
     xcss: styles,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/primitives",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Primitives are token-backed low-level building blocks.",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"