@atlaskit/popup 8.0.0 → 9.0.0

package/CHANGELOG.md

@@ -1,5 +1,26 @@
 # @atlaskit/popup
 
+## 9.0.0
+
+### Major Changes
+
+- [`d562a51283c05`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/d562a51283c05) -
+  Widen Popup and Dropdown Menu trigger `aria-haspopup` types to include valid popup kinds,
+  including `menu`. Consumers with explicitly narrow render-prop annotations may need to accept the
+  additional values.
+
+### Patch Changes
+
+- Updated dependencies
+
+## 8.1.0
+
+### Minor Changes
+
+- [`f0b2e3b3c48b2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/f0b2e3b3c48b2) -
+  Export `TriggerAriaProps` from `@atlaskit/popup/types` for components that accept Popup's trigger
+  ARIA attributes.
+
 ## 8.0.0
 
 ### Major Changes

package/dist/cjs/popup-top-layer.js

@@ -211,13 +211,6 @@ var PopupTopLayer = exports.PopupTopLayer = /*#__PURE__*/(0, _react.memo)(functi
     'aria-controls': ariaAttributes['aria-controls'],
     // `aria-expanded` reflects current open state.
     'aria-expanded': ariaAttributes['aria-expanded'],
-    // FUDGE(top-layer-api): cast to the narrow public TriggerProps['aria-haspopup'] union.
-    // `getAriaForTrigger` derives `aria-haspopup` from the content's role and types it
-    // as the wider WAI-ARIA union (boolean | 'dialog' | 'menu' | 'listbox' | 'tree' | 'grid').
-    // We keep the public popup TriggerProps narrow (boolean | 'dialog') because the
-    // top-layer API surface is not yet settled. Widening adopter types now would commit
-    // us to a public surface we may revisit. The runtime value is unchanged; only the
-    // TypeScript-visible type is narrowed at this boundary.
     'aria-haspopup': ariaAttributes['aria-haspopup']
   };
   return /*#__PURE__*/React.createElement(_react.Fragment, null, trigger(triggerProps), /*#__PURE__*/React.createElement(_popover.Popover, (0, _extends2.default)({

package/dist/es2019/popup-top-layer.js

@@ -223,13 +223,6 @@ export const PopupTopLayer = /*#__PURE__*/memo(function PopupTopLayer({
     'aria-controls': ariaAttributes['aria-controls'],
     // `aria-expanded` reflects current open state.
     'aria-expanded': ariaAttributes['aria-expanded'],
-    // FUDGE(top-layer-api): cast to the narrow public TriggerProps['aria-haspopup'] union.
-    // `getAriaForTrigger` derives `aria-haspopup` from the content's role and types it
-    // as the wider WAI-ARIA union (boolean | 'dialog' | 'menu' | 'listbox' | 'tree' | 'grid').
-    // We keep the public popup TriggerProps narrow (boolean | 'dialog') because the
-    // top-layer API surface is not yet settled. Widening adopter types now would commit
-    // us to a public surface we may revisit. The runtime value is unchanged; only the
-    // TypeScript-visible type is narrowed at this boundary.
     'aria-haspopup': ariaAttributes['aria-haspopup']
   };
   return /*#__PURE__*/React.createElement(Fragment, null, trigger(triggerProps), /*#__PURE__*/React.createElement(Popover, _extends({

package/dist/esm/popup-top-layer.js

@@ -202,13 +202,6 @@ export var PopupTopLayer = /*#__PURE__*/memo(function PopupTopLayer(_ref) {
     'aria-controls': ariaAttributes['aria-controls'],
     // `aria-expanded` reflects current open state.
     'aria-expanded': ariaAttributes['aria-expanded'],
-    // FUDGE(top-layer-api): cast to the narrow public TriggerProps['aria-haspopup'] union.
-    // `getAriaForTrigger` derives `aria-haspopup` from the content's role and types it
-    // as the wider WAI-ARIA union (boolean | 'dialog' | 'menu' | 'listbox' | 'tree' | 'grid').
-    // We keep the public popup TriggerProps narrow (boolean | 'dialog') because the
-    // top-layer API surface is not yet settled. Widening adopter types now would commit
-    // us to a public surface we may revisit. The runtime value is unchanged; only the
-    // TypeScript-visible type is narrowed at this boundary.
     'aria-haspopup': ariaAttributes['aria-haspopup']
   };
   return /*#__PURE__*/React.createElement(Fragment, null, trigger(triggerProps), /*#__PURE__*/React.createElement(Popover, _extends({

package/dist/types/types.d.ts

@@ -1,11 +1,7 @@
 import { type ComponentType, type CSSProperties, type Dispatch, type PropsWithChildren, type default as React, type ReactNode, type Ref, type SetStateAction } from 'react';
 import { type StrictXCSSProp } from '@atlaskit/css';
 import type { Modifier, Placement, PopperChildrenProps } from '@atlaskit/popper/main';
-export interface TriggerProps {
-    /**
-     * React ref that will be attached to the trigger element.
-     */
-    ref: Ref<any>;
+export interface TriggerAriaProps {
     /**
      * Identifies the popup element that the trigger controls.
      * Should match the `id` of the popup content for screen readers to understand the relationship.
@@ -18,7 +14,13 @@ export interface TriggerProps {
     /**
      * Informs assistive technology that this element triggers a popup.
      */
-    'aria-haspopup': boolean | 'dialog';
+    'aria-haspopup': boolean | 'menu' | 'listbox' | 'tree' | 'grid' | 'dialog';
+}
+export interface TriggerProps extends TriggerAriaProps {
+    /**
+     * React ref that will be attached to the trigger element.
+     */
+    ref: Ref<any>;
     'data-ds--level'?: string;
 }
 export type PopupRef = HTMLDivElement | null;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/popup",
-	"version": "8.0.0",
+	"version": "9.0.0",
 	"description": "A popup displays brief content in an overlay.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -37,14 +37,14 @@
 		"@atlaskit/css": "^1.1.0",
 		"@atlaskit/ds-lib": "^8.0.0",
 		"@atlaskit/layering": "^6.0.0",
-		"@atlaskit/motion": "^9.0.0",
+		"@atlaskit/motion": "^9.1.0",
 		"@atlaskit/platform-feature-flags": "^2.2.0",
 		"@atlaskit/popper": "^9.4.0",
 		"@atlaskit/portal": "^7.0.0",
 		"@atlaskit/primitives": "^22.5.0",
 		"@atlaskit/react-compiler-gating": "^0.2.0",
 		"@atlaskit/tokens": "^20.1.0",
-		"@atlaskit/top-layer": "^6.0.0",
+		"@atlaskit/top-layer": "^6.1.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^1.0.2",
 		"bind-event-listener": "^3.0.0",
@@ -65,7 +65,7 @@
 		"@atlaskit/code": "^20.0.0",
 		"@atlaskit/datetime-picker": "^19.0.0",
 		"@atlaskit/docs": "^12.3.0",
-		"@atlaskit/dropdown-menu": "^20.0.0",
+		"@atlaskit/dropdown-menu": "^21.0.0",
 		"@atlaskit/form": "^18.0.0",
 		"@atlaskit/heading": "^8.0.0",
 		"@atlaskit/icon": "^38.0.0",