@atlaskit/popup 7.0.0 → 8.1.0

package/CHANGELOG.md

@@ -1,5 +1,36 @@
 # @atlaskit/popup
 
+## 8.1.0
+
+### Minor Changes
+
+- [`f0b2e3b3c48b2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/f0b2e3b3c48b2) -
+  Export `TriggerAriaProps` from `@atlaskit/popup/types` for components that accept Popup's trigger
+  ARIA attributes.
+
+## 8.0.0
+
+### Major Changes
+
+- [`ae5c32fe7bfd6`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ae5c32fe7bfd6) -
+  Record the rollback of the DSP-25935 popup trigger type expansion in PR #487935. This restores
+  compatibility with existing consumers, including Jira Assets audit logs and linked objects.
+
+  Popup's `aria-haspopup` trigger contract returns to `boolean | 'dialog'`. The affected public
+  trigger props in Dropdown Menu, Avatar, Lozenge, Universal Create, Rovo Pins, and Navigation
+  System also return to their earlier contracts. Consumers using the newly added role-specific
+  string values must return to values supported by those earlier contracts. Popup no longer exports
+  `AriaHasPopup` or `TriggerAriaProps`; use `TriggerProps['aria-haspopup']` and
+  `Pick<TriggerProps, 'aria-controls' | 'aria-expanded' | 'aria-haspopup'>` instead.
+
+  Popup and Dropdown Menu retain their existing top-layer runtime ARIA values through the prior
+  compatibility adapters. Conversation Assistant returns to its previous internal trigger type
+  annotation without changing its public API.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 7.0.0
 
 ### Major Changes

package/dist/cjs/popup-top-layer.js

@@ -211,6 +211,13 @@ var PopupTopLayer = exports.PopupTopLayer = /*#__PURE__*/(0, _react.memo)(functi
     'aria-controls': ariaAttributes['aria-controls'],
     // `aria-expanded` reflects current open state.
     'aria-expanded': ariaAttributes['aria-expanded'],
+    // FUDGE(top-layer-api): cast to the narrow public TriggerProps['aria-haspopup'] union.
+    // `getAriaForTrigger` derives `aria-haspopup` from the content's role and types it
+    // as the wider WAI-ARIA union (boolean | 'dialog' | 'menu' | 'listbox' | 'tree' | 'grid').
+    // We keep the public popup TriggerProps narrow (boolean | 'dialog') because the
+    // top-layer API surface is not yet settled. Widening adopter types now would commit
+    // us to a public surface we may revisit. The runtime value is unchanged; only the
+    // TypeScript-visible type is narrowed at this boundary.
     'aria-haspopup': ariaAttributes['aria-haspopup']
   };
   return /*#__PURE__*/React.createElement(_react.Fragment, null, trigger(triggerProps), /*#__PURE__*/React.createElement(_popover.Popover, (0, _extends2.default)({

package/dist/es2019/popup-top-layer.js

@@ -223,6 +223,13 @@ export const PopupTopLayer = /*#__PURE__*/memo(function PopupTopLayer({
     'aria-controls': ariaAttributes['aria-controls'],
     // `aria-expanded` reflects current open state.
     'aria-expanded': ariaAttributes['aria-expanded'],
+    // FUDGE(top-layer-api): cast to the narrow public TriggerProps['aria-haspopup'] union.
+    // `getAriaForTrigger` derives `aria-haspopup` from the content's role and types it
+    // as the wider WAI-ARIA union (boolean | 'dialog' | 'menu' | 'listbox' | 'tree' | 'grid').
+    // We keep the public popup TriggerProps narrow (boolean | 'dialog') because the
+    // top-layer API surface is not yet settled. Widening adopter types now would commit
+    // us to a public surface we may revisit. The runtime value is unchanged; only the
+    // TypeScript-visible type is narrowed at this boundary.
     'aria-haspopup': ariaAttributes['aria-haspopup']
   };
   return /*#__PURE__*/React.createElement(Fragment, null, trigger(triggerProps), /*#__PURE__*/React.createElement(Popover, _extends({

package/dist/esm/popup-top-layer.js

@@ -202,6 +202,13 @@ export var PopupTopLayer = /*#__PURE__*/memo(function PopupTopLayer(_ref) {
     'aria-controls': ariaAttributes['aria-controls'],
     // `aria-expanded` reflects current open state.
     'aria-expanded': ariaAttributes['aria-expanded'],
+    // FUDGE(top-layer-api): cast to the narrow public TriggerProps['aria-haspopup'] union.
+    // `getAriaForTrigger` derives `aria-haspopup` from the content's role and types it
+    // as the wider WAI-ARIA union (boolean | 'dialog' | 'menu' | 'listbox' | 'tree' | 'grid').
+    // We keep the public popup TriggerProps narrow (boolean | 'dialog') because the
+    // top-layer API surface is not yet settled. Widening adopter types now would commit
+    // us to a public surface we may revisit. The runtime value is unchanged; only the
+    // TypeScript-visible type is narrowed at this boundary.
     'aria-haspopup': ariaAttributes['aria-haspopup']
   };
   return /*#__PURE__*/React.createElement(Fragment, null, trigger(triggerProps), /*#__PURE__*/React.createElement(Popover, _extends({

package/dist/types/types.d.ts

@@ -1,7 +1,6 @@
 import { type ComponentType, type CSSProperties, type Dispatch, type PropsWithChildren, type default as React, type ReactNode, type Ref, type SetStateAction } from 'react';
 import { type StrictXCSSProp } from '@atlaskit/css';
 import type { Modifier, Placement, PopperChildrenProps } from '@atlaskit/popper/main';
-export type AriaHasPopup = boolean | 'menu' | 'listbox' | 'tree' | 'grid' | 'dialog';
 export interface TriggerAriaProps {
     /**
      * Identifies the popup element that the trigger controls.
@@ -15,7 +14,7 @@ export interface TriggerAriaProps {
     /**
      * Informs assistive technology that this element triggers a popup.
      */
-    'aria-haspopup': AriaHasPopup;
+    'aria-haspopup': boolean | 'dialog';
 }
 export interface TriggerProps extends TriggerAriaProps {
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/popup",
-	"version": "7.0.0",
+	"version": "8.1.0",
 	"description": "A popup displays brief content in an overlay.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -65,7 +65,7 @@
 		"@atlaskit/code": "^20.0.0",
 		"@atlaskit/datetime-picker": "^19.0.0",
 		"@atlaskit/docs": "^12.3.0",
-		"@atlaskit/dropdown-menu": "^19.0.0",
+		"@atlaskit/dropdown-menu": "^20.0.0",
 		"@atlaskit/form": "^18.0.0",
 		"@atlaskit/heading": "^8.0.0",
 		"@atlaskit/icon": "^38.0.0",