@atlaskit/popup 5.1.0 → 5.1.1

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/popup
 
+## 5.1.1
+
+### Patch Changes
+
+- [`662546a79c2bc`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/662546a79c2bc) -
+  Guard the `update()` call in `RepositionOnUpdate` so it is only invoked when the Popper
+  render-prop `update` is a function. On Safari the Popper instance can be undefined when the layout
+  effect fires, which previously threw `TypeError: e.update is not a function` and left consumers
+  (such as the Jira status transition popup) stuck with an indefinite spinner.
+
 ## 5.1.0
 
 ### Minor Changes

package/compass.yml

@@ -0,0 +1,38 @@
+configVersion: 1
+id: ari:cloud:compass:a436116f-02ce-4520-8fbb-7301462a1674:component/c5751cc6-3513-4070-9deb-af31e86aed34/80e5b53f-4a74-4009-bfc1-2c8685b672be
+name: '@atlaskit/popup'
+ownerId: ari:cloud:identity::team/be19136e-6275-419f-be0c-fcee844b8684 # Design System Engineers
+labels:
+  - platform-code
+  - platform-afm
+typeId: OTHER
+fields:
+  tier: 4
+  lifecycle: Active
+  isMonorepoProject: true
+links:
+  - name: Root Repository
+    type: REPOSITORY
+    url: https://bitbucket.org/atlassian/atlassian-frontend-monorepo/src/master
+  - name: Slack Channel
+    type: CHAT_CHANNEL
+    url: https://atlassian.enterprise.slack.com/archives/CFJ9DU39U # #help-design-system
+  - name: Popup
+    type: REPOSITORY
+    url: https://bitbucket.org/atlassian/atlassian-frontend-monorepo/src/master/platform/packages/design-system/popup
+customFields:
+  - name: Department
+    type: text
+    value: Eng - Design System Fundamentals
+  - name: Technical Owner
+    type: user
+    value: ari:cloud:identity::user/557058:86a9b692-7997-49cb-9984-080801b1de91 # Jared Crowe
+  - name: Required Reviewers Opt In
+    type: boolean
+    value: true
+  - name: Reviewer Selection Mechanism
+    type: text
+    value: random(3)
+  - name: Required Reviewer Approvals
+    type: number
+    value: 1

package/dist/cjs/reposition-on-update.js

@@ -18,8 +18,14 @@ var RepositionOnUpdate = exports.RepositionOnUpdate = function RepositionOnUpdat
       isFirstRenderRef.current = false;
       return;
     }
-    // callback function from popper that repositions pop-up on content Update
-    update();
+    // callback function from popper that repositions pop-up on content Update.
+    // Guard against `update` being undefined: on Safari the Popper instance may
+    // not be fully initialised when this layout effect fires, in which case the
+    // render-prop `update` is undefined and calling it throws
+    // `TypeError: e.update is not a function`.
+    if (typeof update === 'function') {
+      update();
+    }
   }, [update]);
 
   // wrapping in fragment to make TS happy (known issue with FC returning children)

package/dist/es2019/reposition-on-update.js

@@ -11,8 +11,14 @@ export const RepositionOnUpdate = ({
       isFirstRenderRef.current = false;
       return;
     }
-    // callback function from popper that repositions pop-up on content Update
-    update();
+    // callback function from popper that repositions pop-up on content Update.
+    // Guard against `update` being undefined: on Safari the Popper instance may
+    // not be fully initialised when this layout effect fires, in which case the
+    // render-prop `update` is undefined and calling it throws
+    // `TypeError: e.update is not a function`.
+    if (typeof update === 'function') {
+      update();
+    }
   }, [update]);
 
   // wrapping in fragment to make TS happy (known issue with FC returning children)

package/dist/esm/reposition-on-update.js

@@ -10,8 +10,14 @@ export var RepositionOnUpdate = function RepositionOnUpdate(_ref) {
       isFirstRenderRef.current = false;
       return;
     }
-    // callback function from popper that repositions pop-up on content Update
-    update();
+    // callback function from popper that repositions pop-up on content Update.
+    // Guard against `update` being undefined: on Safari the Popper instance may
+    // not be fully initialised when this layout effect fires, in which case the
+    // render-prop `update` is undefined and calling it throws
+    // `TypeError: e.update is not a function`.
+    if (typeof update === 'function') {
+      update();
+    }
   }, [update]);
 
   // wrapping in fragment to make TS happy (known issue with FC returning children)

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/popup",
-	"version": "5.1.0",
+	"version": "5.1.1",
 	"description": "A popup displays brief content in an overlay.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -38,9 +38,9 @@
 		"@atlaskit/platform-feature-flags": "^2.0.0",
 		"@atlaskit/popper": "^8.2.0",
 		"@atlaskit/portal": "^6.1.0",
-		"@atlaskit/primitives": "^20.1.0",
+		"@atlaskit/primitives": "^20.3.0",
 		"@atlaskit/react-compiler-gating": "^0.2.0",
-		"@atlaskit/tokens": "^15.1.0",
+		"@atlaskit/tokens": "^15.3.0",
 		"@atlaskit/top-layer": "^1.2.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^0.20.0",
@@ -57,7 +57,7 @@
 		"@af/accessibility-testing": "workspace:^",
 		"@af/integration-testing": "workspace:^",
 		"@af/visual-regression": "workspace:^",
-		"@atlaskit/button": "^24.2.0",
+		"@atlaskit/button": "^24.3.0",
 		"@atlaskit/code": "^18.2.0",
 		"@atlaskit/docs": "^12.0.0",
 		"@atlaskit/form": "^16.1.0",