@atlaskit/popup 5.0.1 → 5.1.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,11 +1,39 @@
1
1
  # @atlaskit/popup
2
2
 
3
+ ## 5.1.1
4
+
5
+ ### Patch Changes
6
+
7
+ - [`662546a79c2bc`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/662546a79c2bc) -
8
+ Guard the `update()` call in `RepositionOnUpdate` so it is only invoked when the Popper
9
+ render-prop `update` is a function. On Safari the Popper instance can be undefined when the layout
10
+ effect fires, which previously threw `TypeError: e.update is not a function` and left consumers
11
+ (such as the Jira status transition popup) stuck with an indefinite spinner.
12
+
13
+ ## 5.1.0
14
+
15
+ ### Minor Changes
16
+
17
+ - [`cd097a2111788`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/cd097a2111788) -
18
+ Republish packages depending on `@atlaskit/react-compiler-gating` so their published dependency
19
+ reference is updated to the renamed `@atlaskit/react-compiler-gating` scope.
20
+
21
+ The earlier rename of `@atlassian/react-compiler-gating` to `@atlaskit/react-compiler-gating` only
22
+ bumped the renamed package itself, so dependent packages were never republished and their
23
+ published versions still referenced the old `@atlassian/react-compiler-gating` name, which is not
24
+ available in the public npm registry. This minor bump republishes all affected packages with the
25
+ corrected dependency.
26
+
27
+ ### Patch Changes
28
+
29
+ - Updated dependencies
30
+
3
31
  ## 5.0.1
4
32
 
5
33
  ### Patch Changes
6
34
 
7
35
  - [`ee28cf33718b0`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ee28cf33718b0) -
8
- Add @atlassian/react-compiler-gating as a runtime dependency to enable React Compiler platform
36
+ Add @atlaskit/react-compiler-gating as a runtime dependency to enable React Compiler platform
9
37
  gating.
10
38
  - Updated dependencies
11
39
 
package/compass.yml ADDED
@@ -0,0 +1,38 @@
1
+ configVersion: 1
2
+ id: ari:cloud:compass:a436116f-02ce-4520-8fbb-7301462a1674:component/c5751cc6-3513-4070-9deb-af31e86aed34/80e5b53f-4a74-4009-bfc1-2c8685b672be
3
+ name: '@atlaskit/popup'
4
+ ownerId: ari:cloud:identity::team/be19136e-6275-419f-be0c-fcee844b8684 # Design System Engineers
5
+ labels:
6
+ - platform-code
7
+ - platform-afm
8
+ typeId: OTHER
9
+ fields:
10
+ tier: 4
11
+ lifecycle: Active
12
+ isMonorepoProject: true
13
+ links:
14
+ - name: Root Repository
15
+ type: REPOSITORY
16
+ url: https://bitbucket.org/atlassian/atlassian-frontend-monorepo/src/master
17
+ - name: Slack Channel
18
+ type: CHAT_CHANNEL
19
+ url: https://atlassian.enterprise.slack.com/archives/CFJ9DU39U # #help-design-system
20
+ - name: Popup
21
+ type: REPOSITORY
22
+ url: https://bitbucket.org/atlassian/atlassian-frontend-monorepo/src/master/platform/packages/design-system/popup
23
+ customFields:
24
+ - name: Department
25
+ type: text
26
+ value: Eng - Design System Fundamentals
27
+ - name: Technical Owner
28
+ type: user
29
+ value: ari:cloud:identity::user/557058:86a9b692-7997-49cb-9984-080801b1de91 # Jared Crowe
30
+ - name: Required Reviewers Opt In
31
+ type: boolean
32
+ value: true
33
+ - name: Reviewer Selection Mechanism
34
+ type: text
35
+ value: random(3)
36
+ - name: Required Reviewer Approvals
37
+ type: number
38
+ value: 1
@@ -18,8 +18,14 @@ var RepositionOnUpdate = exports.RepositionOnUpdate = function RepositionOnUpdat
18
18
  isFirstRenderRef.current = false;
19
19
  return;
20
20
  }
21
- // callback function from popper that repositions pop-up on content Update
22
- update();
21
+ // callback function from popper that repositions pop-up on content Update.
22
+ // Guard against `update` being undefined: on Safari the Popper instance may
23
+ // not be fully initialised when this layout effect fires, in which case the
24
+ // render-prop `update` is undefined and calling it throws
25
+ // `TypeError: e.update is not a function`.
26
+ if (typeof update === 'function') {
27
+ update();
28
+ }
23
29
  }, [update]);
24
30
 
25
31
  // wrapping in fragment to make TS happy (known issue with FC returning children)
@@ -11,8 +11,14 @@ export const RepositionOnUpdate = ({
11
11
  isFirstRenderRef.current = false;
12
12
  return;
13
13
  }
14
- // callback function from popper that repositions pop-up on content Update
15
- update();
14
+ // callback function from popper that repositions pop-up on content Update.
15
+ // Guard against `update` being undefined: on Safari the Popper instance may
16
+ // not be fully initialised when this layout effect fires, in which case the
17
+ // render-prop `update` is undefined and calling it throws
18
+ // `TypeError: e.update is not a function`.
19
+ if (typeof update === 'function') {
20
+ update();
21
+ }
16
22
  }, [update]);
17
23
 
18
24
  // wrapping in fragment to make TS happy (known issue with FC returning children)
@@ -10,8 +10,14 @@ export var RepositionOnUpdate = function RepositionOnUpdate(_ref) {
10
10
  isFirstRenderRef.current = false;
11
11
  return;
12
12
  }
13
- // callback function from popper that repositions pop-up on content Update
14
- update();
13
+ // callback function from popper that repositions pop-up on content Update.
14
+ // Guard against `update` being undefined: on Safari the Popper instance may
15
+ // not be fully initialised when this layout effect fires, in which case the
16
+ // render-prop `update` is undefined and calling it throws
17
+ // `TypeError: e.update is not a function`.
18
+ if (typeof update === 'function') {
19
+ update();
20
+ }
15
21
  }, [update]);
16
22
 
17
23
  // wrapping in fragment to make TS happy (known issue with FC returning children)
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/popup",
3
- "version": "5.0.1",
3
+ "version": "5.1.1",
4
4
  "description": "A popup displays brief content in an overlay.",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -20,7 +20,7 @@
20
20
  "react-compiler": {
21
21
  "enabled": true,
22
22
  "gating": {
23
- "source": "@atlassian/react-compiler-gating",
23
+ "source": "@atlaskit/react-compiler-gating",
24
24
  "importSpecifierName": "isReactCompilerActivePlatform"
25
25
  }
26
26
  },
@@ -33,15 +33,15 @@
33
33
  "dependencies": {
34
34
  "@atlaskit/css": "^1.0.0",
35
35
  "@atlaskit/ds-lib": "^8.0.0",
36
- "@atlaskit/layering": "^4.0.0",
37
- "@atlaskit/motion": "^7.1.0",
36
+ "@atlaskit/layering": "^4.1.0",
37
+ "@atlaskit/motion": "^7.2.0",
38
38
  "@atlaskit/platform-feature-flags": "^2.0.0",
39
- "@atlaskit/popper": "^8.0.0",
40
- "@atlaskit/portal": "^6.0.0",
41
- "@atlaskit/primitives": "^20.0.0",
42
- "@atlaskit/tokens": "^15.0.0",
43
- "@atlaskit/top-layer": "^1.0.0",
44
- "@atlassian/react-compiler-gating": "^0.2.0",
39
+ "@atlaskit/popper": "^8.2.0",
40
+ "@atlaskit/portal": "^6.1.0",
41
+ "@atlaskit/primitives": "^20.3.0",
42
+ "@atlaskit/react-compiler-gating": "^0.2.0",
43
+ "@atlaskit/tokens": "^15.3.0",
44
+ "@atlaskit/top-layer": "^1.2.0",
45
45
  "@babel/runtime": "^7.0.0",
46
46
  "@compiled/react": "^0.20.0",
47
47
  "bind-event-listener": "^3.0.0",
@@ -57,21 +57,21 @@
57
57
  "@af/accessibility-testing": "workspace:^",
58
58
  "@af/integration-testing": "workspace:^",
59
59
  "@af/visual-regression": "workspace:^",
60
- "@atlaskit/button": "^24.1.0",
61
- "@atlaskit/code": "^18.0.0",
60
+ "@atlaskit/button": "^24.3.0",
61
+ "@atlaskit/code": "^18.2.0",
62
62
  "@atlaskit/docs": "^12.0.0",
63
- "@atlaskit/form": "^16.0.0",
64
- "@atlaskit/heading": "^6.0.0",
65
- "@atlaskit/icon": "^36.0.0",
66
- "@atlaskit/link": "^4.0.0",
67
- "@atlaskit/modal-dialog": "^16.0.0",
68
- "@atlaskit/section-message": "^9.1.0",
69
- "@atlaskit/textfield": "^9.0.0",
70
- "@atlaskit/toggle": "^17.0.0",
63
+ "@atlaskit/form": "^16.1.0",
64
+ "@atlaskit/heading": "^6.1.0",
65
+ "@atlaskit/icon": "^36.1.0",
66
+ "@atlaskit/link": "^4.1.0",
67
+ "@atlaskit/modal-dialog": "^16.1.0",
68
+ "@atlaskit/section-message": "^9.2.0",
69
+ "@atlaskit/textfield": "^9.1.0",
70
+ "@atlaskit/toggle": "^17.1.0",
71
71
  "@atlassian/feature-flags-test-utils": "^1.1.0",
72
72
  "@atlassian/ssr-tests": "workspace:^",
73
73
  "@atlassian/structured-docs-types": "workspace:^",
74
- "@atlassian/testing-library": "^0.6.0",
74
+ "@atlassian/testing-library": "^0.7.0",
75
75
  "@testing-library/react": "^16.3.0",
76
76
  "@testing-library/user-event": "^14.4.3",
77
77
  "ast-types": "^0.13.3",