@atlaskit/popup 4.26.0 → 5.0.0

package/CHANGELOG.md

@@ -1,5 +1,36 @@
 # @atlaskit/popup
 
+## 5.0.0
+
+### Major Changes
+
+- [`f2dc9097319f0`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/f2dc9097319f0) - ###
+  Dropped support for _legacy_ Typescript 4 types. **Typescript 5 is now the new minimum**.
+
+  Removes the `typesVersions` property and `dist/types-ts4.5` directory from the dist.
+
+  Types are now exclusively via the `"types": "dist/types/index.d.ts"` property.
+
+  ```diff
+  - "typesVersions": {
+  -    ">=4.5 <4.9": {
+  -        "*": [
+  -            "dist/types-ts4.5/*",
+  -            "dist/types-ts4.5/index.d.ts"
+  -        ]
+  -    }
+  - },
+  ```
+
+### Minor Changes
+
+- [`2e61d5c836f8f`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/2e61d5c836f8f) -
+  Internal cleanup of open-layer observer registration in the top-layer Popup adapters.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 4.26.0
 
 ### Minor Changes

package/dist/cjs/compositional/popup-content-top-layer.js

@@ -13,7 +13,6 @@ var React = _react;
 var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 var _runtime = require("@compiled/react/runtime");
 var _noop = _interopRequireDefault(require("@atlaskit/ds-lib/noop"));
-var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
 var _animations = require("@atlaskit/top-layer/animations");
 var _placementMap = require("@atlaskit/top-layer/placement-map");
 var _popover = require("@atlaskit/top-layer/popover");
@@ -183,33 +182,6 @@ function PopupContentTopLayer(_ref) {
     isOpen: isOpen
   });
 
-  /**
-   * Register with the open-layer observer as a `popup` while open.
-   *
-   * The legacy compositional `PopupContent` registered every open
-   * popup with the observer regardless of role, and product surfaces
-   * such as the side-nav panel splitter rely on this signal to detect
-   * open popups via `getCount({ type: 'popup' }) > 0`. The underlying
-   * top-layer `Popover` only self-registers when its role is one of
-   * `menu | listbox | dialog | alertdialog | tree | grid`, which would
-   * miss role-less popups and silently regress the splitter.
-   *
-   * Registering here unconditionally preserves the legacy contract.
-   * When the role does opt the `Popover` into observer registration
-   * the count is incremented twice, which is safe because every known
-   * consumer treats the count as a boolean (`> 0` / `=== 0`).
-   */
-  var handleObserverClose = (0, _react.useCallback)(function () {
-    onClose === null || onClose === void 0 || onClose((0, _popover.createPopoverCloseEvent)({
-      reason: 'programmatic'
-    }));
-  }, [onClose]);
-  (0, _openLayerObserver.useNotifyOpenLayerObserver)({
-    type: 'popup',
-    isOpen: isOpen,
-    onClose: handleObserverClose
-  });
-
   // Narrow to ForwardRefExoticComponent so JSX accepts the ref prop.
   // All popupComponent implementations use forwardRef per the PopupComponentProps contract.
   var Container = PopupContainer;

package/dist/cjs/popup-top-layer.js

@@ -13,7 +13,6 @@ var React = _react;
 var _runtime = require("@compiled/react/runtime");
 var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 var _noop = _interopRequireDefault(require("@atlaskit/ds-lib/noop"));
-var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
 var _animations = require("@atlaskit/top-layer/animations");
 var _getAriaForTrigger = require("@atlaskit/top-layer/get-aria-for-trigger");
 var _placementMap = require("@atlaskit/top-layer/placement-map");
@@ -164,33 +163,6 @@ var PopupTopLayer = exports.PopupTopLayer = /*#__PURE__*/(0, _react.memo)(functi
     isOpen: isOpen
   });
 
-  /**
-   * Register with the open-layer observer as a `popup` while open.
-   *
-   * The legacy `Popup` registered every open popup with the observer
-   * regardless of role, and product surfaces such as the side-nav
-   * panel splitter rely on this signal to detect open popups via
-   * `getCount({ type: 'popup' }) > 0`. The underlying top-layer
-   * `Popover` only self-registers when its role is one of
-   * `menu | listbox | dialog | alertdialog | tree | grid`, which would
-   * miss role-less popups and silently regress the splitter.
-   *
-   * Registering here unconditionally preserves the legacy contract.
-   * When the role does opt the `Popover` into observer registration
-   * the count is incremented twice, which is safe because every known
-   * consumer treats the count as a boolean (`> 0` / `=== 0`).
-   */
-  var handleObserverClose = (0, _react.useCallback)(function () {
-    onClose === null || onClose === void 0 || onClose((0, _popover.createPopoverCloseEvent)({
-      reason: 'programmatic'
-    }));
-  }, [onClose]);
-  (0, _openLayerObserver.useNotifyOpenLayerObserver)({
-    type: 'popup',
-    isOpen: isOpen,
-    onClose: handleObserverClose
-  });
-
   // onClose bridge.
   // Translates top-layer's { reason: TPopoverCloseReason } into legacy
   // onClose(event, currentLevel?) by synthesizing DOM events.

package/dist/es2019/compositional/popup-content-top-layer.js

@@ -5,7 +5,6 @@ import * as React from 'react';
 import { useCallback, useContext, useEffect, useMemo, useRef } from 'react';
 import { ax, ix } from '@compiled/react/runtime';
 import noop from '@atlaskit/ds-lib/noop';
-import { useNotifyOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
 import { popupMotion } from '@atlaskit/top-layer/animations';
 import { fromLegacyPlacement } from '@atlaskit/top-layer/placement-map';
 import { createPopoverCloseEvent, Popover } from '@atlaskit/top-layer/popover';
@@ -191,33 +190,6 @@ export function PopupContentTopLayer({
     isOpen
   });
 
-  /**
-   * Register with the open-layer observer as a `popup` while open.
-   *
-   * The legacy compositional `PopupContent` registered every open
-   * popup with the observer regardless of role, and product surfaces
-   * such as the side-nav panel splitter rely on this signal to detect
-   * open popups via `getCount({ type: 'popup' }) > 0`. The underlying
-   * top-layer `Popover` only self-registers when its role is one of
-   * `menu | listbox | dialog | alertdialog | tree | grid`, which would
-   * miss role-less popups and silently regress the splitter.
-   *
-   * Registering here unconditionally preserves the legacy contract.
-   * When the role does opt the `Popover` into observer registration
-   * the count is incremented twice, which is safe because every known
-   * consumer treats the count as a boolean (`> 0` / `=== 0`).
-   */
-  const handleObserverClose = useCallback(() => {
-    onClose === null || onClose === void 0 ? void 0 : onClose(createPopoverCloseEvent({
-      reason: 'programmatic'
-    }));
-  }, [onClose]);
-  useNotifyOpenLayerObserver({
-    type: 'popup',
-    isOpen,
-    onClose: handleObserverClose
-  });
-
   // Narrow to ForwardRefExoticComponent so JSX accepts the ref prop.
   // All popupComponent implementations use forwardRef per the PopupComponentProps contract.
   const Container = PopupContainer;

package/dist/es2019/popup-top-layer.js

@@ -5,7 +5,6 @@ import * as React from 'react';
 import { ax, ix } from "@compiled/react/runtime";
 import { Fragment, memo, useCallback, useEffect, useMemo, useRef } from 'react';
 import noop from '@atlaskit/ds-lib/noop';
-import { useNotifyOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
 import { popupMotion } from '@atlaskit/top-layer/animations';
 import { getAriaForTrigger } from '@atlaskit/top-layer/get-aria-for-trigger';
 import { fromLegacyPlacement } from '@atlaskit/top-layer/placement-map';
@@ -175,33 +174,6 @@ export const PopupTopLayer = /*#__PURE__*/memo(function PopupTopLayer({
     isOpen
   });
 
-  /**
-   * Register with the open-layer observer as a `popup` while open.
-   *
-   * The legacy `Popup` registered every open popup with the observer
-   * regardless of role, and product surfaces such as the side-nav
-   * panel splitter rely on this signal to detect open popups via
-   * `getCount({ type: 'popup' }) > 0`. The underlying top-layer
-   * `Popover` only self-registers when its role is one of
-   * `menu | listbox | dialog | alertdialog | tree | grid`, which would
-   * miss role-less popups and silently regress the splitter.
-   *
-   * Registering here unconditionally preserves the legacy contract.
-   * When the role does opt the `Popover` into observer registration
-   * the count is incremented twice, which is safe because every known
-   * consumer treats the count as a boolean (`> 0` / `=== 0`).
-   */
-  const handleObserverClose = useCallback(() => {
-    onClose === null || onClose === void 0 ? void 0 : onClose(createPopoverCloseEvent({
-      reason: 'programmatic'
-    }));
-  }, [onClose]);
-  useNotifyOpenLayerObserver({
-    type: 'popup',
-    isOpen,
-    onClose: handleObserverClose
-  });
-
   // onClose bridge.
   // Translates top-layer's { reason: TPopoverCloseReason } into legacy
   // onClose(event, currentLevel?) by synthesizing DOM events.

package/dist/esm/compositional/popup-content-top-layer.js

@@ -5,7 +5,6 @@ import * as React from 'react';
 import { useCallback, useContext, useEffect, useMemo, useRef } from 'react';
 import { ax, ix } from '@compiled/react/runtime';
 import noop from '@atlaskit/ds-lib/noop';
-import { useNotifyOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
 import { popupMotion } from '@atlaskit/top-layer/animations';
 import { fromLegacyPlacement } from '@atlaskit/top-layer/placement-map';
 import { createPopoverCloseEvent, Popover } from '@atlaskit/top-layer/popover';
@@ -174,33 +173,6 @@ export function PopupContentTopLayer(_ref) {
     isOpen: isOpen
   });
 
-  /**
-   * Register with the open-layer observer as a `popup` while open.
-   *
-   * The legacy compositional `PopupContent` registered every open
-   * popup with the observer regardless of role, and product surfaces
-   * such as the side-nav panel splitter rely on this signal to detect
-   * open popups via `getCount({ type: 'popup' }) > 0`. The underlying
-   * top-layer `Popover` only self-registers when its role is one of
-   * `menu | listbox | dialog | alertdialog | tree | grid`, which would
-   * miss role-less popups and silently regress the splitter.
-   *
-   * Registering here unconditionally preserves the legacy contract.
-   * When the role does opt the `Popover` into observer registration
-   * the count is incremented twice, which is safe because every known
-   * consumer treats the count as a boolean (`> 0` / `=== 0`).
-   */
-  var handleObserverClose = useCallback(function () {
-    onClose === null || onClose === void 0 || onClose(createPopoverCloseEvent({
-      reason: 'programmatic'
-    }));
-  }, [onClose]);
-  useNotifyOpenLayerObserver({
-    type: 'popup',
-    isOpen: isOpen,
-    onClose: handleObserverClose
-  });
-
   // Narrow to ForwardRefExoticComponent so JSX accepts the ref prop.
   // All popupComponent implementations use forwardRef per the PopupComponentProps contract.
   var Container = PopupContainer;

package/dist/esm/popup-top-layer.js

@@ -5,7 +5,6 @@ import * as React from 'react';
 import { ax, ix } from "@compiled/react/runtime";
 import { Fragment, memo, useCallback, useEffect, useMemo, useRef } from 'react';
 import noop from '@atlaskit/ds-lib/noop';
-import { useNotifyOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
 import { popupMotion } from '@atlaskit/top-layer/animations';
 import { getAriaForTrigger } from '@atlaskit/top-layer/get-aria-for-trigger';
 import { fromLegacyPlacement } from '@atlaskit/top-layer/placement-map';
@@ -155,33 +154,6 @@ export var PopupTopLayer = /*#__PURE__*/memo(function PopupTopLayer(_ref) {
     isOpen: isOpen
   });
 
-  /**
-   * Register with the open-layer observer as a `popup` while open.
-   *
-   * The legacy `Popup` registered every open popup with the observer
-   * regardless of role, and product surfaces such as the side-nav
-   * panel splitter rely on this signal to detect open popups via
-   * `getCount({ type: 'popup' }) > 0`. The underlying top-layer
-   * `Popover` only self-registers when its role is one of
-   * `menu | listbox | dialog | alertdialog | tree | grid`, which would
-   * miss role-less popups and silently regress the splitter.
-   *
-   * Registering here unconditionally preserves the legacy contract.
-   * When the role does opt the `Popover` into observer registration
-   * the count is incremented twice, which is safe because every known
-   * consumer treats the count as a boolean (`> 0` / `=== 0`).
-   */
-  var handleObserverClose = useCallback(function () {
-    onClose === null || onClose === void 0 || onClose(createPopoverCloseEvent({
-      reason: 'programmatic'
-    }));
-  }, [onClose]);
-  useNotifyOpenLayerObserver({
-    type: 'popup',
-    isOpen: isOpen,
-    onClose: handleObserverClose
-  });
-
   // onClose bridge.
   // Translates top-layer's { reason: TPopoverCloseReason } into legacy
   // onClose(event, currentLevel?) by synthesizing DOM events.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/popup",
-	"version": "4.26.0",
+	"version": "5.0.0",
 	"description": "A popup displays brief content in an overlay.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -12,14 +12,6 @@
 	"module": "dist/esm/index.js",
 	"module:es2019": "dist/es2019/index.js",
 	"types": "dist/types/index.d.ts",
-	"typesVersions": {
-		">=4.5 <4.9": {
-			"*": [
-				"dist/types-ts4.5/*",
-				"dist/types-ts4.5/index.d.ts"
-			]
-		}
-	},
 	"sideEffects": [
 		"**/*.compiled.css"
 	],
@@ -39,16 +31,16 @@
 		}
 	},
 	"dependencies": {
-		"@atlaskit/css": "^0.19.0",
-		"@atlaskit/ds-lib": "^7.0.0",
-		"@atlaskit/layering": "^3.8.0",
-		"@atlaskit/motion": "^6.2.0",
-		"@atlaskit/platform-feature-flags": "^1.1.0",
-		"@atlaskit/popper": "^7.2.0",
-		"@atlaskit/portal": "^5.5.0",
-		"@atlaskit/primitives": "^19.0.0",
-		"@atlaskit/tokens": "^13.4.0",
-		"@atlaskit/top-layer": "^0.18.0",
+		"@atlaskit/css": "^1.0.0",
+		"@atlaskit/ds-lib": "^8.0.0",
+		"@atlaskit/layering": "^4.0.0",
+		"@atlaskit/motion": "^7.0.0",
+		"@atlaskit/platform-feature-flags": "^2.0.0",
+		"@atlaskit/popper": "^8.0.0",
+		"@atlaskit/portal": "^6.0.0",
+		"@atlaskit/primitives": "^20.0.0",
+		"@atlaskit/tokens": "^14.0.0",
+		"@atlaskit/top-layer": "^1.0.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^0.20.0",
 		"bind-event-listener": "^3.0.0",
@@ -64,17 +56,17 @@
 		"@af/accessibility-testing": "workspace:^",
 		"@af/integration-testing": "workspace:^",
 		"@af/visual-regression": "workspace:^",
-		"@atlaskit/button": "^23.11.0",
-		"@atlaskit/code": "^17.5.0",
-		"@atlaskit/docs": "^11.8.0",
-		"@atlaskit/form": "^15.5.0",
-		"@atlaskit/heading": "^5.4.0",
-		"@atlaskit/icon": "^35.4.0",
-		"@atlaskit/link": "^3.4.0",
-		"@atlaskit/modal-dialog": "^15.3.0",
-		"@atlaskit/section-message": "^8.13.0",
-		"@atlaskit/textfield": "^8.3.0",
-		"@atlaskit/toggle": "^16.1.0",
+		"@atlaskit/button": "^24.0.0",
+		"@atlaskit/code": "^18.0.0",
+		"@atlaskit/docs": "^12.0.0",
+		"@atlaskit/form": "^16.0.0",
+		"@atlaskit/heading": "^6.0.0",
+		"@atlaskit/icon": "^36.0.0",
+		"@atlaskit/link": "^4.0.0",
+		"@atlaskit/modal-dialog": "^16.0.0",
+		"@atlaskit/section-message": "^9.0.0",
+		"@atlaskit/textfield": "^9.0.0",
+		"@atlaskit/toggle": "^17.0.0",
 		"@atlassian/feature-flags-test-utils": "^1.1.0",
 		"@atlassian/react-compiler-gating": "workspace:^",
 		"@atlassian/ssr-tests": "workspace:^",