@atlaskit/popup 2.0.1 → 2.0.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/popup
 
+## 2.0.2
+
+### Patch Changes
+
+- [#121410](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/121410)
+  [`b26d53ac2517a`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b26d53ac2517a) -
+  Prevent onClick handler gets called when popup is open on Firefox
+
 ## 2.0.1
 
 ### Patch Changes

package/dist/cjs/use-close-manager.js

@@ -188,16 +188,32 @@ var useCloseManager = exports.useCloseManager = function useCloseManager(_ref) {
         }
       });
     }
-    var unbind = (0, _bindEventListener.bindAll)(window, [{
-      type: 'click',
-      listener: onClick,
-      options: {
-        capture: capture
-      }
-    }, {
-      type: 'keydown',
-      listener: onKeyDown
-    }]);
+    var unbind = _noop.default;
+    if ((0, _platformFeatureFlags.fg)('popup-onclose-fix')) {
+      setTimeout(function () {
+        unbind = (0, _bindEventListener.bindAll)(window, [{
+          type: 'click',
+          listener: onClick,
+          options: {
+            capture: capture
+          }
+        }, {
+          type: 'keydown',
+          listener: onKeyDown
+        }]);
+      }, 0);
+    } else {
+      unbind = (0, _bindEventListener.bindAll)(window, [{
+        type: 'click',
+        listener: onClick,
+        options: {
+          capture: capture
+        }
+      }, {
+        type: 'keydown',
+        listener: onKeyDown
+      }]);
+    }
 
     // bind onBlur event listener to fix popup not close when clicking on iframe outside
     var unbindBlur = _noop.default;
@@ -212,8 +228,14 @@ var useCloseManager = exports.useCloseManager = function useCloseManager(_ref) {
     });
     return function () {
       var _parentUnbind;
+      if ((0, _platformFeatureFlags.fg)('popup-onclose-fix')) {
+        setTimeout(function () {
+          unbind();
+        }, 0);
+      } else {
+        unbind();
+      }
       cancelAllFrames();
-      unbind();
       (_parentUnbind = parentUnbind) === null || _parentUnbind === void 0 || _parentUnbind();
       unbindBlur();
     };

package/dist/es2019/use-close-manager.js

@@ -189,16 +189,32 @@ export const useCloseManager = ({
         }
       });
     }
-    const unbind = bindAll(window, [{
-      type: 'click',
-      listener: onClick,
-      options: {
-        capture
-      }
-    }, {
-      type: 'keydown',
-      listener: onKeyDown
-    }]);
+    let unbind = noop;
+    if (fg('popup-onclose-fix')) {
+      setTimeout(() => {
+        unbind = bindAll(window, [{
+          type: 'click',
+          listener: onClick,
+          options: {
+            capture
+          }
+        }, {
+          type: 'keydown',
+          listener: onKeyDown
+        }]);
+      }, 0);
+    } else {
+      unbind = bindAll(window, [{
+        type: 'click',
+        listener: onClick,
+        options: {
+          capture
+        }
+      }, {
+        type: 'keydown',
+        listener: onKeyDown
+      }]);
+    }
 
     // bind onBlur event listener to fix popup not close when clicking on iframe outside
     let unbindBlur = noop;
@@ -213,8 +229,14 @@ export const useCloseManager = ({
     });
     return () => {
       var _parentUnbind;
+      if (fg('popup-onclose-fix')) {
+        setTimeout(() => {
+          unbind();
+        }, 0);
+      } else {
+        unbind();
+      }
       cancelAllFrames();
-      unbind();
       (_parentUnbind = parentUnbind) === null || _parentUnbind === void 0 ? void 0 : _parentUnbind();
       unbindBlur();
     };

package/dist/esm/use-close-manager.js

@@ -180,16 +180,32 @@ export var useCloseManager = function useCloseManager(_ref) {
         }
       });
     }
-    var unbind = bindAll(window, [{
-      type: 'click',
-      listener: onClick,
-      options: {
-        capture: capture
-      }
-    }, {
-      type: 'keydown',
-      listener: onKeyDown
-    }]);
+    var unbind = noop;
+    if (fg('popup-onclose-fix')) {
+      setTimeout(function () {
+        unbind = bindAll(window, [{
+          type: 'click',
+          listener: onClick,
+          options: {
+            capture: capture
+          }
+        }, {
+          type: 'keydown',
+          listener: onKeyDown
+        }]);
+      }, 0);
+    } else {
+      unbind = bindAll(window, [{
+        type: 'click',
+        listener: onClick,
+        options: {
+          capture: capture
+        }
+      }, {
+        type: 'keydown',
+        listener: onKeyDown
+      }]);
+    }
 
     // bind onBlur event listener to fix popup not close when clicking on iframe outside
     var unbindBlur = noop;
@@ -204,8 +220,14 @@ export var useCloseManager = function useCloseManager(_ref) {
     });
     return function () {
       var _parentUnbind;
+      if (fg('popup-onclose-fix')) {
+        setTimeout(function () {
+          unbind();
+        }, 0);
+      } else {
+        unbind();
+      }
       cancelAllFrames();
-      unbind();
       (_parentUnbind = parentUnbind) === null || _parentUnbind === void 0 || _parentUnbind();
       unbindBlur();
     };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/popup",
-	"version": "2.0.1",
+	"version": "2.0.2",
 	"description": "A popup displays brief content in an overlay.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -47,7 +47,7 @@
 		"@atlaskit/portal": "^5.0.0",
 		"@atlaskit/primitives": "^14.1.0",
 		"@atlaskit/theme": "^17.0.0",
-		"@atlaskit/tokens": "^4.2.0",
+		"@atlaskit/tokens": "^4.3.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
 		"bind-event-listener": "^3.0.0",
@@ -130,6 +130,9 @@
 		},
 		"fix-dropdown-close-outside-iframe": {
 			"type": "boolean"
+		},
+		"popup-onclose-fix": {
+			"type": "boolean"
 		}
 	},
 	"homepage": "https://atlassian.design/components/popup/"