@atlaskit/popup 1.6.3 → 1.7.0

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/popup
 
+## 1.7.0
+
+### Minor Changes
+
+- [`eca89633804`](https://bitbucket.org/atlassian/atlassian-frontend/commits/eca89633804) - Add a new prop `shouldRenderToParent` to allow render popup into a DOM node within the parent DOM hierarchy instead of React portal.
+
+## 1.6.4
+
+### Patch Changes
+
+- [`e2a6337bb05`](https://bitbucket.org/atlassian/atlassian-frontend/commits/e2a6337bb05) - Reverts changes 1.6.3 in @atlaskit/popup, reverts disabling pointer events on iframes when popup is open.
+
 ## 1.6.3
 
 ### Patch Changes

package/dist/cjs/popper-wrapper.js

@@ -30,16 +30,6 @@ var popupStyles = (0, _react2.css)({
     outline: 'none'
   }
 });
-
-// disables iframe pointer events while popup is open, except if iframe is nested inside popup
-// solves an issue of popup not being closed on iframe click
-// @ts-expect-error adding `!important` to style rules is currently a type error
-var blockPointerEventsOnExternalIframeStyles = (0, _react2.css)({
-  // eslint-disable-next-line @repo/internal/styles/no-nested-styles
-  'iframe:not([data-ds--popup] iframe)': {
-    pointerEvents: 'none !important'
-  }
-});
 var DefaultPopupComponent = /*#__PURE__*/(0, _react.forwardRef)(function (props, ref) {
   return (0, _react2.jsx)("div", (0, _extends2.default)({
     css: popupStyles
@@ -109,7 +99,6 @@ function PopperWrapper(_ref) {
       id: id,
       "data-placement": placement,
       "data-testid": testId,
-      "data-ds--popup": "true",
       ref: function ref(node) {
         if (node) {
           if (typeof _ref3 === 'function') {
@@ -125,9 +114,7 @@ function PopperWrapper(_ref) {
       // first on the browser address bar when using keyboard
       ,
       tabIndex: autoFocus ? 0 : undefined
-    }, (0, _react2.jsx)(_react2.Global, {
-      styles: blockPointerEventsOnExternalIframeStyles
-    }), (0, _react2.jsx)(_repositionOnUpdate.RepositionOnUpdate, {
+    }, (0, _react2.jsx)(_repositionOnUpdate.RepositionOnUpdate, {
       update: update
     }, content({
       update: update,

package/dist/cjs/popup.js

@@ -8,6 +8,7 @@ exports.default = exports.Popup = void 0;
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = require("react");
 var _react2 = require("@emotion/react");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _popper = require("@atlaskit/popper");
 var _portal = _interopRequireDefault(require("@atlaskit/portal"));
 var _constants = require("@atlaskit/theme/constants");
@@ -38,11 +39,32 @@ var Popup = /*#__PURE__*/(0, _react.memo)(function (_ref) {
     _ref$zIndex = _ref.zIndex,
     zIndex = _ref$zIndex === void 0 ? defaultLayer : _ref$zIndex,
     _ref$shouldUseCapture = _ref.shouldUseCaptureOnOutsideClick,
-    shouldUseCaptureOnOutsideClick = _ref$shouldUseCapture === void 0 ? false : _ref$shouldUseCapture;
+    shouldUseCaptureOnOutsideClick = _ref$shouldUseCapture === void 0 ? false : _ref$shouldUseCapture,
+    _ref$shouldRenderToPa = _ref.shouldRenderToParent,
+    shouldRenderToParent = _ref$shouldRenderToPa === void 0 ? false : _ref$shouldRenderToPa;
   var _useState = (0, _react.useState)(null),
     _useState2 = (0, _slicedToArray2.default)(_useState, 2),
     triggerRef = _useState2[0],
     setTriggerRef = _useState2[1];
+  var renderPopperWrapper = function renderPopperWrapper() {
+    return (0, _react2.jsx)(_popperWrapper.default, {
+      content: content,
+      isOpen: isOpen,
+      placement: placement,
+      fallbackPlacements: fallbackPlacements,
+      boundary: boundary,
+      rootBoundary: rootBoundary,
+      shouldFlip: shouldFlip,
+      offset: offset,
+      popupComponent: PopupContainer,
+      id: id,
+      testId: testId,
+      onClose: onClose,
+      autoFocus: autoFocus,
+      shouldUseCaptureOnOutsideClick: shouldUseCaptureOnOutsideClick,
+      triggerRef: triggerRef
+    });
+  };
   return (0, _react2.jsx)(_popper.Manager, null, (0, _react2.jsx)(_popper.Reference, null, function (_ref2) {
     var _ref3 = _ref2.ref;
     return trigger({
@@ -60,25 +82,11 @@ var Popup = /*#__PURE__*/(0, _react.memo)(function (_ref) {
       'aria-expanded': isOpen,
       'aria-haspopup': true
     });
-  }), isOpen && (0, _react2.jsx)(_portal.default, {
+  }), isOpen && ((0, _platformFeatureFlags.getBooleanFF)('platform.design-system-team.render-popup-in-parent_f73ij') ? shouldRenderToParent ? renderPopperWrapper() : (0, _react2.jsx)(_portal.default, {
+    zIndex: zIndex
+  }, renderPopperWrapper()) : (0, _react2.jsx)(_portal.default, {
     zIndex: zIndex
-  }, (0, _react2.jsx)(_popperWrapper.default, {
-    content: content,
-    isOpen: isOpen,
-    placement: placement,
-    fallbackPlacements: fallbackPlacements,
-    boundary: boundary,
-    rootBoundary: rootBoundary,
-    shouldFlip: shouldFlip,
-    offset: offset,
-    popupComponent: PopupContainer,
-    id: id,
-    testId: testId,
-    onClose: onClose,
-    autoFocus: autoFocus,
-    shouldUseCaptureOnOutsideClick: shouldUseCaptureOnOutsideClick,
-    triggerRef: triggerRef
-  })));
+  }, renderPopperWrapper())));
 });
 exports.Popup = Popup;
 var _default = Popup;

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/popup",
-	"version": "1.6.3",
+	"version": "1.7.0",
 	"sideEffects": false
 }

package/dist/es2019/popper-wrapper.js

@@ -1,7 +1,7 @@
 import _extends from "@babel/runtime/helpers/extends";
 /** @jsx jsx */
 import { forwardRef, useMemo, useState } from 'react';
-import { css, Global, jsx } from '@emotion/react';
+import { css, jsx } from '@emotion/react';
 import { Popper } from '@atlaskit/popper';
 import { N0, N50A, N60A } from '@atlaskit/theme/colors';
 import { borderRadius, layers } from '@atlaskit/theme/constants';
@@ -21,16 +21,6 @@ const popupStyles = css({
     outline: 'none'
   }
 });
-
-// disables iframe pointer events while popup is open, except if iframe is nested inside popup
-// solves an issue of popup not being closed on iframe click
-// @ts-expect-error adding `!important` to style rules is currently a type error
-const blockPointerEventsOnExternalIframeStyles = css({
-  // eslint-disable-next-line @repo/internal/styles/no-nested-styles
-  'iframe:not([data-ds--popup] iframe)': {
-    pointerEvents: 'none !important'
-  }
-});
 const DefaultPopupComponent = /*#__PURE__*/forwardRef((props, ref) => jsx("div", _extends({
   css: popupStyles
 }, props, {
@@ -89,7 +79,6 @@ function PopperWrapper({
       id: id,
       "data-placement": placement,
       "data-testid": testId,
-      "data-ds--popup": "true",
       ref: node => {
         if (node) {
           if (typeof ref === 'function') {
@@ -105,9 +94,7 @@ function PopperWrapper({
       // first on the browser address bar when using keyboard
       ,
       tabIndex: autoFocus ? 0 : undefined
-    }, jsx(Global, {
-      styles: blockPointerEventsOnExternalIframeStyles
-    }), jsx(RepositionOnUpdate, {
+    }, jsx(RepositionOnUpdate, {
       update: update
     }, content({
       update,

package/dist/es2019/popup.js

@@ -2,6 +2,7 @@
 /** @jsx jsx */
 import { memo, useState } from 'react';
 import { jsx } from '@emotion/react';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { Manager, Reference } from '@atlaskit/popper';
 import Portal from '@atlaskit/portal';
 import { layers } from '@atlaskit/theme/constants';
@@ -23,9 +24,27 @@ export const Popup = /*#__PURE__*/memo(({
   popupComponent: PopupContainer,
   autoFocus = true,
   zIndex = defaultLayer,
-  shouldUseCaptureOnOutsideClick = false
+  shouldUseCaptureOnOutsideClick = false,
+  shouldRenderToParent = false
 }) => {
   const [triggerRef, setTriggerRef] = useState(null);
+  const renderPopperWrapper = () => jsx(PopperWrapper, {
+    content: content,
+    isOpen: isOpen,
+    placement: placement,
+    fallbackPlacements: fallbackPlacements,
+    boundary: boundary,
+    rootBoundary: rootBoundary,
+    shouldFlip: shouldFlip,
+    offset: offset,
+    popupComponent: PopupContainer,
+    id: id,
+    testId: testId,
+    onClose: onClose,
+    autoFocus: autoFocus,
+    shouldUseCaptureOnOutsideClick: shouldUseCaptureOnOutsideClick,
+    triggerRef: triggerRef
+  });
   return jsx(Manager, null, jsx(Reference, null, ({
     ref
   }) => {
@@ -44,24 +63,10 @@ export const Popup = /*#__PURE__*/memo(({
       'aria-expanded': isOpen,
       'aria-haspopup': true
     });
-  }), isOpen && jsx(Portal, {
+  }), isOpen && (getBooleanFF('platform.design-system-team.render-popup-in-parent_f73ij') ? shouldRenderToParent ? renderPopperWrapper() : jsx(Portal, {
     zIndex: zIndex
-  }, jsx(PopperWrapper, {
-    content: content,
-    isOpen: isOpen,
-    placement: placement,
-    fallbackPlacements: fallbackPlacements,
-    boundary: boundary,
-    rootBoundary: rootBoundary,
-    shouldFlip: shouldFlip,
-    offset: offset,
-    popupComponent: PopupContainer,
-    id: id,
-    testId: testId,
-    onClose: onClose,
-    autoFocus: autoFocus,
-    shouldUseCaptureOnOutsideClick: shouldUseCaptureOnOutsideClick,
-    triggerRef: triggerRef
-  })));
+  }, renderPopperWrapper()) : jsx(Portal, {
+    zIndex: zIndex
+  }, renderPopperWrapper())));
 });
 export default Popup;

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/popup",
-	"version": "1.6.3",
+	"version": "1.7.0",
 	"sideEffects": false
 }

package/dist/esm/popper-wrapper.js

@@ -2,7 +2,7 @@ import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import _extends from "@babel/runtime/helpers/extends";
 /** @jsx jsx */
 import { forwardRef, useMemo, useState } from 'react';
-import { css, Global, jsx } from '@emotion/react';
+import { css, jsx } from '@emotion/react';
 import { Popper } from '@atlaskit/popper';
 import { N0, N50A, N60A } from '@atlaskit/theme/colors';
 import { borderRadius, layers } from '@atlaskit/theme/constants';
@@ -22,16 +22,6 @@ var popupStyles = css({
     outline: 'none'
   }
 });
-
-// disables iframe pointer events while popup is open, except if iframe is nested inside popup
-// solves an issue of popup not being closed on iframe click
-// @ts-expect-error adding `!important` to style rules is currently a type error
-var blockPointerEventsOnExternalIframeStyles = css({
-  // eslint-disable-next-line @repo/internal/styles/no-nested-styles
-  'iframe:not([data-ds--popup] iframe)': {
-    pointerEvents: 'none !important'
-  }
-});
 var DefaultPopupComponent = /*#__PURE__*/forwardRef(function (props, ref) {
   return jsx("div", _extends({
     css: popupStyles
@@ -101,7 +91,6 @@ function PopperWrapper(_ref) {
       id: id,
       "data-placement": placement,
       "data-testid": testId,
-      "data-ds--popup": "true",
       ref: function ref(node) {
         if (node) {
           if (typeof _ref3 === 'function') {
@@ -117,9 +106,7 @@ function PopperWrapper(_ref) {
       // first on the browser address bar when using keyboard
       ,
       tabIndex: autoFocus ? 0 : undefined
-    }, jsx(Global, {
-      styles: blockPointerEventsOnExternalIframeStyles
-    }), jsx(RepositionOnUpdate, {
+    }, jsx(RepositionOnUpdate, {
       update: update
     }, content({
       update: update,

package/dist/esm/popup.js

@@ -3,6 +3,7 @@ import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 /** @jsx jsx */
 import { memo, useState } from 'react';
 import { jsx } from '@emotion/react';
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { Manager, Reference } from '@atlaskit/popper';
 import Portal from '@atlaskit/portal';
 import { layers } from '@atlaskit/theme/constants';
@@ -30,11 +31,32 @@ export var Popup = /*#__PURE__*/memo(function (_ref) {
     _ref$zIndex = _ref.zIndex,
     zIndex = _ref$zIndex === void 0 ? defaultLayer : _ref$zIndex,
     _ref$shouldUseCapture = _ref.shouldUseCaptureOnOutsideClick,
-    shouldUseCaptureOnOutsideClick = _ref$shouldUseCapture === void 0 ? false : _ref$shouldUseCapture;
+    shouldUseCaptureOnOutsideClick = _ref$shouldUseCapture === void 0 ? false : _ref$shouldUseCapture,
+    _ref$shouldRenderToPa = _ref.shouldRenderToParent,
+    shouldRenderToParent = _ref$shouldRenderToPa === void 0 ? false : _ref$shouldRenderToPa;
   var _useState = useState(null),
     _useState2 = _slicedToArray(_useState, 2),
     triggerRef = _useState2[0],
     setTriggerRef = _useState2[1];
+  var renderPopperWrapper = function renderPopperWrapper() {
+    return jsx(PopperWrapper, {
+      content: content,
+      isOpen: isOpen,
+      placement: placement,
+      fallbackPlacements: fallbackPlacements,
+      boundary: boundary,
+      rootBoundary: rootBoundary,
+      shouldFlip: shouldFlip,
+      offset: offset,
+      popupComponent: PopupContainer,
+      id: id,
+      testId: testId,
+      onClose: onClose,
+      autoFocus: autoFocus,
+      shouldUseCaptureOnOutsideClick: shouldUseCaptureOnOutsideClick,
+      triggerRef: triggerRef
+    });
+  };
   return jsx(Manager, null, jsx(Reference, null, function (_ref2) {
     var _ref3 = _ref2.ref;
     return trigger({
@@ -52,24 +74,10 @@ export var Popup = /*#__PURE__*/memo(function (_ref) {
       'aria-expanded': isOpen,
       'aria-haspopup': true
     });
-  }), isOpen && jsx(Portal, {
+  }), isOpen && (getBooleanFF('platform.design-system-team.render-popup-in-parent_f73ij') ? shouldRenderToParent ? renderPopperWrapper() : jsx(Portal, {
+    zIndex: zIndex
+  }, renderPopperWrapper()) : jsx(Portal, {
     zIndex: zIndex
-  }, jsx(PopperWrapper, {
-    content: content,
-    isOpen: isOpen,
-    placement: placement,
-    fallbackPlacements: fallbackPlacements,
-    boundary: boundary,
-    rootBoundary: rootBoundary,
-    shouldFlip: shouldFlip,
-    offset: offset,
-    popupComponent: PopupContainer,
-    id: id,
-    testId: testId,
-    onClose: onClose,
-    autoFocus: autoFocus,
-    shouldUseCaptureOnOutsideClick: shouldUseCaptureOnOutsideClick,
-    triggerRef: triggerRef
-  })));
+  }, renderPopperWrapper())));
 });
 export default Popup;

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/popup",
-	"version": "1.6.3",
+	"version": "1.7.0",
 	"sideEffects": false
 }

package/dist/types/types.d.ts

@@ -147,6 +147,11 @@ export interface PopupProps extends BaseProps {
      * Defaults to `layers.layer()` from `@atlaskit/theme`.
      */
     zIndex?: number;
+    /**
+     * The root element where the popup should be rendered.
+     * Defaults to `false`.
+     */
+    shouldRenderToParent?: boolean;
 }
 export interface PopperWrapperProps extends BaseProps {
     triggerRef: TriggerRef;

package/dist/types-ts4.5/types.d.ts

@@ -150,6 +150,11 @@ export interface PopupProps extends BaseProps {
      * Defaults to `layers.layer()` from `@atlaskit/theme`.
      */
     zIndex?: number;
+    /**
+     * The root element where the popup should be rendered.
+     * Defaults to `false`.
+     */
+    shouldRenderToParent?: boolean;
 }
 export interface PopperWrapperProps extends BaseProps {
     triggerRef: TriggerRef;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/popup",
-  "version": "1.6.3",
+  "version": "1.7.0",
   "description": "A popup displays brief content in an overlay.",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -28,7 +28,7 @@
   },
   "atlassian": {
     "team": "Design System Team",
-    "releaseModel": "scheduled",
+    "releaseModel": "continuous",
     "website": {
       "name": "Popup",
       "category": "Components"
@@ -36,10 +36,11 @@
   },
   "dependencies": {
     "@atlaskit/ds-lib": "^2.2.0",
+    "@atlaskit/platform-feature-flags": "^0.2.0",
     "@atlaskit/popper": "^5.5.0",
     "@atlaskit/portal": "^4.3.0",
     "@atlaskit/theme": "^12.5.0",
-    "@atlaskit/tokens": "^1.4.0",
+    "@atlaskit/tokens": "^1.5.0",
     "@babel/runtime": "^7.0.0",
     "@emotion/react": "^11.7.1",
     "bind-event-listener": "^2.1.1",
@@ -54,18 +55,17 @@
     "@atlaskit/docs": "*",
     "@atlaskit/icon": "^21.12.0",
     "@atlaskit/menu": "^1.7.0",
-    "@atlaskit/page-layout": "^1.6.0",
     "@atlaskit/radio": "^5.6.0",
     "@atlaskit/section-message": "^6.4.0",
-    "@atlaskit/select": "^16.4.0",
+    "@atlaskit/select": "^16.5.0",
     "@atlaskit/ssr": "*",
     "@atlaskit/textfield": "^5.5.0",
     "@atlaskit/toggle": "^12.6.0",
     "@atlaskit/visual-regression": "*",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
+    "@atlassian/feature-flags-test-utils": "*",
     "@testing-library/dom": "^8.17.1",
     "@testing-library/react": "^12.1.5",
-    "@testing-library/user-event": "^14.4.3",
     "ast-types": "^0.13.3",
     "jest-axe": "^4.0.0",
     "jscodeshift": "^0.13.0",
@@ -101,5 +101,10 @@
     }
   },
   "homepage": "https://atlassian.design/components/popup/",
-  "prettier": "@atlassian/atlassian-frontend-prettier-config-1.0.1"
+  "prettier": "@atlassian/atlassian-frontend-prettier-config-1.0.1",
+  "platform-feature-flags": {
+    "platform.design-system-team.render-popup-in-parent_f73ij": {
+      "type": "boolean"
+    }
+  }
 }

package/report.api.md

@@ -8,6 +8,7 @@
 ### Table of contents
 
 - [Main Entry Types](#main-entry-types)
+- [Peer Dependencies](#peer-dependencies)
 
 ### Main Entry Types
 
@@ -69,6 +70,7 @@ export interface PopupComponentProps {
 
 // @public (undocumented)
 export interface PopupProps extends BaseProps {
+  shouldRenderToParent?: boolean;
   trigger: (props: TriggerProps) => React_2.ReactNode;
   zIndex?: number;
 }
@@ -89,3 +91,16 @@ export interface TriggerProps {
 ```
 
 <!--SECTION END: Main Entry Types-->
+
+### Peer Dependencies
+
+<!--SECTION START: Peer Dependencies-->
+
+```json
+{
+  "react": "^16.8.0",
+  "react-dom": "^16.8.0"
+}
+```
+
+<!--SECTION END: Peer Dependencies-->

package/tmp/api-report-tmp.d.ts

@@ -0,0 +1,81 @@
+## API Report File for "@atlaskit/popup"
+
+> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
+
+```ts
+
+import { ComponentType } from 'react';
+import { CSSProperties } from 'react';
+import { Dispatch } from 'react';
+import { FC } from 'react';
+import { Placement } from '@atlaskit/popper';
+import { PopperChildrenProps } from '@atlaskit/popper';
+import { default as React_2 } from 'react';
+import { ReactNode } from 'react';
+import { Ref } from 'react';
+import { SetStateAction } from 'react';
+
+// @public (undocumented)
+interface BaseProps {
+    autoFocus?: boolean;
+    boundary?: 'clippingParents' | HTMLElement;
+    content: (props: ContentProps) => React_2.ReactNode;
+    fallbackPlacements?: Placement[];
+    id?: string;
+    isOpen: boolean;
+    offset?: [number, number];
+    onClose?(event: Event | React_2.KeyboardEvent | React_2.MouseEvent): void;
+    placement?: Placement;
+    popupComponent?: ComponentType<PopupComponentProps>;
+    rootBoundary?: 'document' | 'viewport';
+    shouldFlip?: boolean;
+    shouldUseCaptureOnOutsideClick?: boolean;
+    testId?: string;
+}
+
+// @public (undocumented)
+export interface ContentProps {
+    isOpen: boolean;
+    onClose?: BaseProps['onClose'];
+    setInitialFocusRef: Dispatch<SetStateAction<HTMLElement | null>>;
+    update: PopperChildrenProps['update'];
+}
+
+// @public (undocumented)
+const Popup: FC<PopupProps>;
+export { Popup }
+export default Popup;
+
+// @public (undocumented)
+export interface PopupComponentProps {
+    'data-placement': Placement;
+    'data-testid'?: string;
+    children: ReactNode;
+    id?: string;
+    ref: Ref<HTMLDivElement>;
+    style: CSSProperties;
+    tabIndex: number | undefined;
+}
+
+// @public (undocumented)
+export interface PopupProps extends BaseProps {
+    shouldRenderToParent?: boolean;
+    trigger: (props: TriggerProps) => React_2.ReactNode;
+    zIndex?: number;
+}
+
+// @public (undocumented)
+export interface TriggerProps {
+    // (undocumented)
+    'aria-controls'?: string;
+    // (undocumented)
+    'aria-expanded': boolean;
+    // (undocumented)
+    'aria-haspopup': boolean;
+    // (undocumented)
+    ref: Ref<any>;
+}
+
+// (No @packageDocumentation comment for this package)
+
+```