@atlaskit/page-layout 2.0.0 → 2.0.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/page-layout
 
+## 2.0.1
+
+### Patch Changes
+
+- [#58110](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/58110) [`9e7a86f76af4`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/9e7a86f76af4) - Resizing the Sidebar can now only be triggered via left-click (main button click). This prevents situations where right-clicking the resize button unexpectedly starts resizing the Sidebar.
+
 ## 2.0.0
 
 ### Major Changes

package/__perf__/utils/product-integration/atlassian-navigation.tsx

@@ -19,6 +19,13 @@ import { HelpPopup } from './help-popup';
 import { NotificationsPopup } from './notifications-popup';
 import { ProfilePopup } from './profile-popup';
 
+const drawerLabelText = {
+  search: 'Search drawer',
+  settings: 'Settings drawer',
+};
+
+const { search, settings } = drawerLabelText;
+
 const ProductHomeExample = () => (
   <ProductHome icon={JiraIcon} logo={JiraLogo} siteTitle="Extranet" />
 );
@@ -43,8 +50,8 @@ const SearchDrawer = () => {
         tooltip="Search"
         label="Search"
       />
-      <Drawer isOpen={isOpen} onClose={onClose}>
-        <div>search drawer</div>
+      <Drawer label={search} isOpen={isOpen} onClose={onClose}>
+        <div>{search}</div>
       </Drawer>
     </Fragment>
   );
@@ -64,8 +71,8 @@ const SettingsDrawer = () => {
   return (
     <Fragment>
       <Settings isSelected={isOpen} onClick={onClick} tooltip="Settings" />
-      <Drawer isOpen={isOpen} onClose={onClose}>
-        settings drawer
+      <Drawer label={settings} isOpen={isOpen} onClose={onClose}>
+        {settings}
       </Drawer>
     </Fragment>
   );

package/dist/cjs/components/resize-control/index.js

@@ -104,8 +104,11 @@ var ResizeControl = function ResizeControl(_ref) {
       return;
     }
 
-    // TODO: should only a primary pointer be able to start a resize?
-    // Keeping as is for now, but worth considering
+    // Only allow left (primary) clicks to trigger resize as we've received
+    // bug reports about right click unexpectedly beginning a resize.
+    if (event.button !== 0) {
+      return;
+    }
 
     // It is possible for a mousedown to fire during a resize
     // Example: the user presses another pointer button while dragging

package/dist/es2019/components/resize-control/index.js

@@ -96,8 +96,11 @@ const ResizeControl = ({
       return;
     }
 
-    // TODO: should only a primary pointer be able to start a resize?
-    // Keeping as is for now, but worth considering
+    // Only allow left (primary) clicks to trigger resize as we've received
+    // bug reports about right click unexpectedly beginning a resize.
+    if (event.button !== 0) {
+      return;
+    }
 
     // It is possible for a mousedown to fire during a resize
     // Example: the user presses another pointer button while dragging

package/dist/esm/components/resize-control/index.js

@@ -100,8 +100,11 @@ var ResizeControl = function ResizeControl(_ref) {
       return;
     }
 
-    // TODO: should only a primary pointer be able to start a resize?
-    // Keeping as is for now, but worth considering
+    // Only allow left (primary) clicks to trigger resize as we've received
+    // bug reports about right click unexpectedly beginning a resize.
+    if (event.button !== 0) {
+      return;
+    }
 
     // It is possible for a mousedown to fire during a resize
     // Example: the user presses another pointer button while dragging

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/page-layout",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "A collection of components which let you compose an application's page layout.",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -40,7 +40,7 @@
     "@atlaskit/icon": "^22.0.0",
     "@atlaskit/motion": "^1.5.0",
     "@atlaskit/platform-feature-flags": "^0.2.0",
-    "@atlaskit/primitives": "^1.12.0",
+    "@atlaskit/primitives": "^1.13.0",
     "@atlaskit/theme": "^12.6.0",
     "@atlaskit/tokens": "^1.29.0",
     "@babel/runtime": "^7.0.0",
@@ -54,7 +54,8 @@
   },
   "devDependencies": {
     "@af/accessibility-testing": "*",
-    "@atlaskit/atlassian-navigation": "^2.9.0",
+    "@af/integration-testing": "*",
+    "@atlaskit/atlassian-navigation": "^2.10.0",
     "@atlaskit/atlassian-notifications": "^0.4.0",
     "@atlaskit/drawer": "^7.6.0",
     "@atlaskit/logo": "^13.14.0",