@atlaskit/node-data-provider 6.4.0 → 7.1.0

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/node-data-provider
 
+## 7.1.0
+
+### Minor Changes
+
+- [`be97f10bf8de4`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/be97f10bf8de4) -
+  [https://product-fabric.atlassian.net/browse/ED-29464](ED-29464) - change findNodesToPrefetch
+  algorithm to DFS
+
+### Patch Changes
+
+- Updated dependencies
+
+## 7.0.0
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 6.4.0
 
 ### Minor Changes

package/dist/cjs/utils/find-nodes-to-prefetch.js

@@ -1,13 +1,12 @@
 "use strict";
 
-var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.findNodesToPrefetch = findNodesToPrefetch;
-var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers/toConsumableArray"));
 /**
  * Finds nodes in the document that are supported by the given providers, up to a maximum number of nodes.
+ * Uses iterative Depth-First Search (DFS) to traverse the document.
  *
  * @param doc The document to search for nodes.
  * @param providers An array of providers with their maximum nodes to prefetch.
@@ -44,15 +43,19 @@ function findNodesToPrefetch(doc, providers, maxNodesToVisit) {
     };
   });
 
-  // Queue for the breadth-first search (BFS), starting with the root document node.
+  // Stack for the depth-first search (DFS), starting with the root document node.
   var nodesToVisit = [doc];
-  var currentIndex = 0;
+
   // The loop continues as long as there are nodes to visit, providers to look for,
   // and the visited nodes limit has not been reached.
-  while (currentIndex < nodesToVisit.length && providersToLookup.length > 0 && totalVisitedNodesCount < maxNodesToVisit) {
+  while (nodesToVisit.length > 0 && providersToLookup.length > 0 && totalVisitedNodesCount < maxNodesToVisit) {
     totalVisitedNodesCount += 1;
-    var currentNode = nodesToVisit[currentIndex];
-    currentIndex++;
+    // Pop from the end to maintain DFS order (LIFO - Last In, First Out)
+    var currentNode = nodesToVisit.pop();
+    if (!currentNode) {
+      // This should never happen because of the loop condition, but we check to satisfy TypeScript.
+      continue;
+    }
 
     // Using a reverse loop to avoid issues with array mutation (when removing elements).
     for (var i = providersToLookup.length - 1; i >= 0; i--) {
@@ -72,11 +75,17 @@ function findNodesToPrefetch(doc, providers, maxNodesToVisit) {
       }
     }
 
-    // If the current node has children, add them to the queue to be visited.
+    // If the current node has children, add them to the stack in reverse order
+    // to maintain left-to-right traversal when popping from the stack,
+    // because it's LIFO.
     if (currentNode.content) {
-      nodesToVisit.push.apply(nodesToVisit, (0, _toConsumableArray2.default)(currentNode.content.filter(function (node) {
-        return node !== undefined;
-      })));
+      // Push children in reverse order to maintain correct DFS traversal order
+      for (var _i = currentNode.content.length - 1; _i >= 0; _i--) {
+        var node = currentNode.content[_i];
+        if (node) {
+          nodesToVisit.push(node);
+        }
+      }
     }
   }
 

package/dist/es2019/utils/find-nodes-to-prefetch.js

@@ -1,5 +1,6 @@
 /**
  * Finds nodes in the document that are supported by the given providers, up to a maximum number of nodes.
+ * Uses iterative Depth-First Search (DFS) to traverse the document.
  *
  * @param doc The document to search for nodes.
  * @param providers An array of providers with their maximum nodes to prefetch.
@@ -35,15 +36,19 @@ export function findNodesToPrefetch(doc, providers, maxNodesToVisit) {
     foundNodes: 0 // Counter for nodes found for each provider.
   }));
 
-  // Queue for the breadth-first search (BFS), starting with the root document node.
+  // Stack for the depth-first search (DFS), starting with the root document node.
   const nodesToVisit = [doc];
-  let currentIndex = 0;
+
   // The loop continues as long as there are nodes to visit, providers to look for,
   // and the visited nodes limit has not been reached.
-  while (currentIndex < nodesToVisit.length && providersToLookup.length > 0 && totalVisitedNodesCount < maxNodesToVisit) {
+  while (nodesToVisit.length > 0 && providersToLookup.length > 0 && totalVisitedNodesCount < maxNodesToVisit) {
     totalVisitedNodesCount += 1;
-    const currentNode = nodesToVisit[currentIndex];
-    currentIndex++;
+    // Pop from the end to maintain DFS order (LIFO - Last In, First Out)
+    const currentNode = nodesToVisit.pop();
+    if (!currentNode) {
+      // This should never happen because of the loop condition, but we check to satisfy TypeScript.
+      continue;
+    }
 
     // Using a reverse loop to avoid issues with array mutation (when removing elements).
     for (let i = providersToLookup.length - 1; i >= 0; i--) {
@@ -63,9 +68,17 @@ export function findNodesToPrefetch(doc, providers, maxNodesToVisit) {
       }
     }
 
-    // If the current node has children, add them to the queue to be visited.
+    // If the current node has children, add them to the stack in reverse order
+    // to maintain left-to-right traversal when popping from the stack,
+    // because it's LIFO.
     if (currentNode.content) {
-      nodesToVisit.push(...currentNode.content.filter(node => node !== undefined));
+      // Push children in reverse order to maintain correct DFS traversal order
+      for (let i = currentNode.content.length - 1; i >= 0; i--) {
+        const node = currentNode.content[i];
+        if (node) {
+          nodesToVisit.push(node);
+        }
+      }
     }
   }
 

package/dist/esm/utils/find-nodes-to-prefetch.js

@@ -1,6 +1,6 @@
-import _toConsumableArray from "@babel/runtime/helpers/toConsumableArray";
 /**
  * Finds nodes in the document that are supported by the given providers, up to a maximum number of nodes.
+ * Uses iterative Depth-First Search (DFS) to traverse the document.
  *
  * @param doc The document to search for nodes.
  * @param providers An array of providers with their maximum nodes to prefetch.
@@ -37,15 +37,19 @@ export function findNodesToPrefetch(doc, providers, maxNodesToVisit) {
     };
   });
 
-  // Queue for the breadth-first search (BFS), starting with the root document node.
+  // Stack for the depth-first search (DFS), starting with the root document node.
   var nodesToVisit = [doc];
-  var currentIndex = 0;
+
   // The loop continues as long as there are nodes to visit, providers to look for,
   // and the visited nodes limit has not been reached.
-  while (currentIndex < nodesToVisit.length && providersToLookup.length > 0 && totalVisitedNodesCount < maxNodesToVisit) {
+  while (nodesToVisit.length > 0 && providersToLookup.length > 0 && totalVisitedNodesCount < maxNodesToVisit) {
     totalVisitedNodesCount += 1;
-    var currentNode = nodesToVisit[currentIndex];
-    currentIndex++;
+    // Pop from the end to maintain DFS order (LIFO - Last In, First Out)
+    var currentNode = nodesToVisit.pop();
+    if (!currentNode) {
+      // This should never happen because of the loop condition, but we check to satisfy TypeScript.
+      continue;
+    }
 
     // Using a reverse loop to avoid issues with array mutation (when removing elements).
     for (var i = providersToLookup.length - 1; i >= 0; i--) {
@@ -65,11 +69,17 @@ export function findNodesToPrefetch(doc, providers, maxNodesToVisit) {
       }
     }
 
-    // If the current node has children, add them to the queue to be visited.
+    // If the current node has children, add them to the stack in reverse order
+    // to maintain left-to-right traversal when popping from the stack,
+    // because it's LIFO.
     if (currentNode.content) {
-      nodesToVisit.push.apply(nodesToVisit, _toConsumableArray(currentNode.content.filter(function (node) {
-        return node !== undefined;
-      })));
+      // Push children in reverse order to maintain correct DFS traversal order
+      for (var _i = currentNode.content.length - 1; _i >= 0; _i--) {
+        var node = currentNode.content[_i];
+        if (node) {
+          nodesToVisit.push(node);
+        }
+      }
     }
   }
 

package/dist/types/utils/find-nodes-to-prefetch.d.ts

@@ -8,6 +8,7 @@ interface ProviderWithNodes {
 }
 /**
  * Finds nodes in the document that are supported by the given providers, up to a maximum number of nodes.
+ * Uses iterative Depth-First Search (DFS) to traverse the document.
  *
  * @param doc The document to search for nodes.
  * @param providers An array of providers with their maximum nodes to prefetch.

package/dist/types-ts4.5/utils/find-nodes-to-prefetch.d.ts

@@ -8,6 +8,7 @@ interface ProviderWithNodes {
 }
 /**
  * Finds nodes in the document that are supported by the given providers, up to a maximum number of nodes.
+ * Uses iterative Depth-First Search (DFS) to traverse the document.
  *
  * @param doc The document to search for nodes.
  * @param providers An array of providers with their maximum nodes to prefetch.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/node-data-provider",
-	"version": "6.4.0",
+	"version": "7.1.0",
 	"description": "Node data provider for @atlaskit/editor-core plugins and @atlaskit/renderer",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -26,7 +26,7 @@
 		"@babel/runtime": "^7.0.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^109.16.0"
+		"@atlaskit/editor-common": "^110.4.0"
 	},
 	"techstack": {
 		"@atlassian/frontend": {