@atlaskit/navigation-system 9.1.1 → 9.2.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,19 @@
1
1
  # @atlassian/navigation-system
2
2
 
3
+ ## 9.2.0
4
+
5
+ ### Minor Changes
6
+
7
+ - [`b46825ac6c66c`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b46825ac6c66c) -
8
+ Cleans up the `platform_dst_nav4_top_nav_increase_height` feature gate. The top nav height is now
9
+ always 56px when the full-height sidebar is enabled.
10
+
11
+ ## 9.1.2
12
+
13
+ ### Patch Changes
14
+
15
+ - Updated dependencies
16
+
3
17
  ## 9.1.1
4
18
 
5
19
  ### Patch Changes
@@ -125,8 +125,8 @@ var MaybeTooltip = function MaybeTooltip(_ref2) {
125
125
  mousePosition: "right",
126
126
  isScreenReaderAnnouncementDisabled: true,
127
127
  component: PanelSplitterTooltip,
128
- UNSAFE_shouldAlwaysFadeIn: true,
129
- UNSAFE_shouldRenderToParent: true
128
+ shouldAlwaysFadeIn: true,
129
+ shouldRenderToParent: true
130
130
  }, children);
131
131
  }
132
132
  return children;
@@ -20,7 +20,6 @@ var _analyticsNext = require("@atlaskit/analytics-next");
20
20
  var _mergeRefs = _interopRequireDefault(require("@atlaskit/ds-lib/merge-refs"));
21
21
  var _useStableRef = _interopRequireDefault(require("@atlaskit/ds-lib/use-stable-ref"));
22
22
  var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
23
- var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
24
23
  var _adapter = require("@atlaskit/pragmatic-drag-and-drop/element/adapter");
25
24
  var _responsive = require("@atlaskit/primitives/responsive");
26
25
  var _useSkipLinkInternal = require("../../../context/skip-links/use-skip-link-internal");
@@ -358,23 +357,14 @@ function SideNavInternal(_ref) {
358
357
 
359
358
  // Sync the visibility in context (provided in `<Root>`) with the local `defaultCollapsed` prop provided to `SideNav`
360
359
  // after SSR hydration. This should only run once, after the initial render on the client.
361
- if ((0, _platformFeatureFlags.fg)('navx-4418-fix-effect-state-updates-in-gsn')) {
362
- (0, _react.startTransition)(function () {
363
- setSideNavState({
364
- desktop: initialDefaultCollapsed ? 'collapsed' : 'expanded',
365
- mobile: 'collapsed',
366
- flyout: 'closed',
367
- lastTrigger: null
368
- });
369
- });
370
- } else {
360
+ (0, _react.startTransition)(function () {
371
361
  setSideNavState({
372
362
  desktop: initialDefaultCollapsed ? 'collapsed' : 'expanded',
373
363
  mobile: 'collapsed',
374
364
  flyout: 'closed',
375
365
  lastTrigger: null
376
366
  });
377
- }
367
+ });
378
368
  }, [initialDefaultCollapsed, setSideNavState, sideNavState]);
379
369
  var handleExpand = (0, _react.useCallback)(function (_ref2) {
380
370
  var screen = _ref2.screen,
@@ -61,8 +61,7 @@ function TopNavOld(_ref) {
61
61
  label: skipLinkLabel,
62
62
  isHidden: (0, _platformFeatureFlags.fg)('platform_dst_nav4_skip_link_a11y_1')
63
63
  });
64
- var hasIncreasedDefaultHeight = isFhsEnabled && (0, _platformFeatureFlags.fg)('platform_dst_nav4_top_nav_increase_height');
65
- var height = heightProp !== null && heightProp !== void 0 ? heightProp : hasIncreasedDefaultHeight ? 56 : 48;
64
+ var height = heightProp !== null && heightProp !== void 0 ? heightProp : isFhsEnabled ? 56 : 48;
66
65
  var customTheme = (0, _useCustomTheme.useCustomTheme)(customThemeConfig);
67
66
  var _useSideNavVisibility = (0, _useSideNavVisibility3.useSideNavVisibility)(),
68
67
  isExpandedOnDesktop = _useSideNavVisibility.isExpandedOnDesktop;
@@ -114,8 +113,7 @@ function TopNavNew(_ref2) {
114
113
  label: skipLinkLabel,
115
114
  isHidden: (0, _platformFeatureFlags.fg)('platform_dst_nav4_skip_link_a11y_1')
116
115
  });
117
- var hasIncreasedDefaultHeight = isFhsEnabled && (0, _platformFeatureFlags.fg)('platform_dst_nav4_top_nav_increase_height');
118
- var height = heightProp !== null && heightProp !== void 0 ? heightProp : hasIncreasedDefaultHeight ? 56 : 48;
116
+ var height = heightProp !== null && heightProp !== void 0 ? heightProp : isFhsEnabled ? 56 : 48;
119
117
  var customTheme = (0, _useCustomThemeNew.useCustomThemeNew)(customThemeConfig);
120
118
  var hasDefaultBackground = customTheme.isEnabled ? customTheme.hasDefaultBackground : true;
121
119
  var _useSideNavVisibility2 = (0, _useSideNavVisibility3.useSideNavVisibility)(),
@@ -113,8 +113,8 @@ const MaybeTooltip = ({
113
113
  mousePosition: "right",
114
114
  isScreenReaderAnnouncementDisabled: true,
115
115
  component: PanelSplitterTooltip,
116
- UNSAFE_shouldAlwaysFadeIn: true,
117
- UNSAFE_shouldRenderToParent: true
116
+ shouldAlwaysFadeIn: true,
117
+ shouldRenderToParent: true
118
118
  }, children);
119
119
  }
120
120
  return children;
@@ -9,7 +9,6 @@ import { useAnalyticsEvents } from '@atlaskit/analytics-next';
9
9
  import mergeRefs from '@atlaskit/ds-lib/merge-refs';
10
10
  import useStableRef from '@atlaskit/ds-lib/use-stable-ref';
11
11
  import { OpenLayerObserverNamespaceProvider, useOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
12
- import { fg } from '@atlaskit/platform-feature-flags';
13
12
  import { monitorForElements } from '@atlaskit/pragmatic-drag-and-drop/element/adapter';
14
13
  import { media } from '@atlaskit/primitives/responsive';
15
14
  import { useSkipLinkInternal } from '../../../context/skip-links/use-skip-link-internal';
@@ -339,23 +338,14 @@ function SideNavInternal({
339
338
 
340
339
  // Sync the visibility in context (provided in `<Root>`) with the local `defaultCollapsed` prop provided to `SideNav`
341
340
  // after SSR hydration. This should only run once, after the initial render on the client.
342
- if (fg('navx-4418-fix-effect-state-updates-in-gsn')) {
343
- startTransition(() => {
344
- setSideNavState({
345
- desktop: initialDefaultCollapsed ? 'collapsed' : 'expanded',
346
- mobile: 'collapsed',
347
- flyout: 'closed',
348
- lastTrigger: null
349
- });
350
- });
351
- } else {
341
+ startTransition(() => {
352
342
  setSideNavState({
353
343
  desktop: initialDefaultCollapsed ? 'collapsed' : 'expanded',
354
344
  mobile: 'collapsed',
355
345
  flyout: 'closed',
356
346
  lastTrigger: null
357
347
  });
358
- }
348
+ });
359
349
  }, [initialDefaultCollapsed, setSideNavState, sideNavState]);
360
350
  const handleExpand = useCallback(({
361
351
  screen,
@@ -54,8 +54,7 @@ function TopNavOld({
54
54
  label: skipLinkLabel,
55
55
  isHidden: fg('platform_dst_nav4_skip_link_a11y_1')
56
56
  });
57
- const hasIncreasedDefaultHeight = isFhsEnabled && fg('platform_dst_nav4_top_nav_increase_height');
58
- const height = heightProp !== null && heightProp !== void 0 ? heightProp : hasIncreasedDefaultHeight ? 56 : 48;
57
+ const height = heightProp !== null && heightProp !== void 0 ? heightProp : isFhsEnabled ? 56 : 48;
59
58
  const customTheme = useCustomTheme(customThemeConfig);
60
59
  const {
61
60
  isExpandedOnDesktop
@@ -108,8 +107,7 @@ function TopNavNew({
108
107
  label: skipLinkLabel,
109
108
  isHidden: fg('platform_dst_nav4_skip_link_a11y_1')
110
109
  });
111
- const hasIncreasedDefaultHeight = isFhsEnabled && fg('platform_dst_nav4_top_nav_increase_height');
112
- const height = heightProp !== null && heightProp !== void 0 ? heightProp : hasIncreasedDefaultHeight ? 56 : 48;
110
+ const height = heightProp !== null && heightProp !== void 0 ? heightProp : isFhsEnabled ? 56 : 48;
113
111
  const customTheme = useCustomThemeNew(customThemeConfig);
114
112
  const hasDefaultBackground = customTheme.isEnabled ? customTheme.hasDefaultBackground : true;
115
113
  const {
@@ -116,8 +116,8 @@ var MaybeTooltip = function MaybeTooltip(_ref2) {
116
116
  mousePosition: "right",
117
117
  isScreenReaderAnnouncementDisabled: true,
118
118
  component: PanelSplitterTooltip,
119
- UNSAFE_shouldAlwaysFadeIn: true,
120
- UNSAFE_shouldRenderToParent: true
119
+ shouldAlwaysFadeIn: true,
120
+ shouldRenderToParent: true
121
121
  }, children);
122
122
  }
123
123
  return children;
@@ -13,7 +13,6 @@ import { useAnalyticsEvents } from '@atlaskit/analytics-next';
13
13
  import mergeRefs from '@atlaskit/ds-lib/merge-refs';
14
14
  import useStableRef from '@atlaskit/ds-lib/use-stable-ref';
15
15
  import { OpenLayerObserverNamespaceProvider, useOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
16
- import { fg } from '@atlaskit/platform-feature-flags';
17
16
  import { monitorForElements } from '@atlaskit/pragmatic-drag-and-drop/element/adapter';
18
17
  import { media } from '@atlaskit/primitives/responsive';
19
18
  import { useSkipLinkInternal } from '../../../context/skip-links/use-skip-link-internal';
@@ -348,23 +347,14 @@ function SideNavInternal(_ref) {
348
347
 
349
348
  // Sync the visibility in context (provided in `<Root>`) with the local `defaultCollapsed` prop provided to `SideNav`
350
349
  // after SSR hydration. This should only run once, after the initial render on the client.
351
- if (fg('navx-4418-fix-effect-state-updates-in-gsn')) {
352
- startTransition(function () {
353
- setSideNavState({
354
- desktop: initialDefaultCollapsed ? 'collapsed' : 'expanded',
355
- mobile: 'collapsed',
356
- flyout: 'closed',
357
- lastTrigger: null
358
- });
359
- });
360
- } else {
350
+ startTransition(function () {
361
351
  setSideNavState({
362
352
  desktop: initialDefaultCollapsed ? 'collapsed' : 'expanded',
363
353
  mobile: 'collapsed',
364
354
  flyout: 'closed',
365
355
  lastTrigger: null
366
356
  });
367
- }
357
+ });
368
358
  }, [initialDefaultCollapsed, setSideNavState, sideNavState]);
369
359
  var handleExpand = useCallback(function (_ref2) {
370
360
  var screen = _ref2.screen,
@@ -54,8 +54,7 @@ function TopNavOld(_ref) {
54
54
  label: skipLinkLabel,
55
55
  isHidden: fg('platform_dst_nav4_skip_link_a11y_1')
56
56
  });
57
- var hasIncreasedDefaultHeight = isFhsEnabled && fg('platform_dst_nav4_top_nav_increase_height');
58
- var height = heightProp !== null && heightProp !== void 0 ? heightProp : hasIncreasedDefaultHeight ? 56 : 48;
57
+ var height = heightProp !== null && heightProp !== void 0 ? heightProp : isFhsEnabled ? 56 : 48;
59
58
  var customTheme = useCustomTheme(customThemeConfig);
60
59
  var _useSideNavVisibility = useSideNavVisibility(),
61
60
  isExpandedOnDesktop = _useSideNavVisibility.isExpandedOnDesktop;
@@ -107,8 +106,7 @@ function TopNavNew(_ref2) {
107
106
  label: skipLinkLabel,
108
107
  isHidden: fg('platform_dst_nav4_skip_link_a11y_1')
109
108
  });
110
- var hasIncreasedDefaultHeight = isFhsEnabled && fg('platform_dst_nav4_top_nav_increase_height');
111
- var height = heightProp !== null && heightProp !== void 0 ? heightProp : hasIncreasedDefaultHeight ? 56 : 48;
109
+ var height = heightProp !== null && heightProp !== void 0 ? heightProp : isFhsEnabled ? 56 : 48;
112
110
  var customTheme = useCustomThemeNew(customThemeConfig);
113
111
  var hasDefaultBackground = customTheme.isEnabled ? customTheme.hasDefaultBackground : true;
114
112
  var _useSideNavVisibility2 = useSideNavVisibility(),
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/navigation-system",
3
- "version": "9.1.1",
3
+ "version": "9.2.0",
4
4
  "description": "The latest navigation system for Atlassian apps.",
5
5
  "repository": "https://bitbucket.org/atlassian/atlassian-frontend-mirror",
6
6
  "author": "Atlassian Pty Ltd",
@@ -86,7 +86,7 @@
86
86
  "@atlaskit/primitives": "^19.0.0",
87
87
  "@atlaskit/side-nav-items": "^1.13.0",
88
88
  "@atlaskit/tokens": "^13.0.0",
89
- "@atlaskit/tooltip": "^21.2.0",
89
+ "@atlaskit/tooltip": "^22.0.0",
90
90
  "@atlaskit/visually-hidden": "^3.1.0",
91
91
  "@babel/runtime": "^7.0.0",
92
92
  "@compiled/react": "^0.20.0",
@@ -153,9 +153,6 @@
153
153
  }
154
154
  },
155
155
  "platform-feature-flags": {
156
- "platform_dst_nav4_top_nav_increase_height": {
157
- "type": "boolean"
158
- },
159
156
  "platform-component-visual-refresh": {
160
157
  "type": "boolean",
161
158
  "referenceOnly": true
@@ -172,9 +169,6 @@
172
169
  "platform_dst_nav4_flyout_menu_slots_close_button": {
173
170
  "type": "boolean"
174
171
  },
175
- "navx-4418-fix-effect-state-updates-in-gsn": {
176
- "type": "boolean"
177
- },
178
172
  "platform_dst_nav4_custom_theming_fhs_1": {
179
173
  "type": "boolean"
180
174
  },