@atlaskit/navigation-system 5.38.1 → 5.39.0

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlassian/navigation-system
 
+## 5.39.0
+
+### Minor Changes
+
+- [`c987f6814195b`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/c987f6814195b) -
+  Fixes a bug where the panel splitter would not be resizable when some browser extensions were
+  installed. This change was previousuly behind the feature flag
+  `platform-dst-panel-splitter-drag-start-client-x`, which has now been cleaned up.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 5.38.1
 
 ### Patch Changes

package/dist/cjs/ui/page-layout/panel-splitter/get-width.js

@@ -4,10 +4,9 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.getWidthFromDragLocation = exports.getPixelWidth = void 0;
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 /**
- * ⚠️ Note: We are not using the location.initial.input client locations because some browser extensions
- * can cause the client locations (e.g. clientX) in the `dragstart` event to incorrectly return 0.
+ * ⚠️ Note: We are using the initial client location captured from the mousedown event, not from the dragstart event.
+ * Some browser extensions can cause the client locations (e.g. clientX) in the `dragstart` event to incorrectly return 0.
  */
 var getWidthFromDragLocation = exports.getWidthFromDragLocation = function getWidthFromDragLocation(_ref) {
   var initialWidth = _ref.initialWidth,
@@ -15,7 +14,7 @@ var getWidthFromDragLocation = exports.getWidthFromDragLocation = function getWi
     initialClientX = _ref.initialClientX,
     direction = _ref.direction,
     position = _ref.position;
-  var diffX = location.current.input.clientX - ((0, _platformFeatureFlags.fg)('platform-dst-panel-splitter-drag-start-client-x') ? initialClientX : location.initial.input.clientX);
+  var diffX = location.current.input.clientX - initialClientX;
 
   // Resize line is positioned at the inline-end (right) of the element.
   // If the direction is left-to-right, the width will increase when the mouse is moved to the right, and vice versa.

package/dist/cjs/ui/page-layout/panel-splitter/panel-splitter.js

@@ -19,7 +19,6 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _bindEventListener = require("bind-event-listener");
 var _reactDom = require("react-dom");
 var _tinyInvariant = _interopRequireDefault(require("tiny-invariant"));
-var _noop = _interopRequireDefault(require("@atlaskit/ds-lib/noop"));
 var _useId = require("@atlaskit/ds-lib/use-id");
 var _useStableRef = _interopRequireDefault(require("@atlaskit/ds-lib/use-stable-ref"));
 var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
@@ -210,12 +209,12 @@ var PortaledPanelSplitter = function PortaledPanelSplitter(_ref3) {
      * I also tried only binding an event listener inside pragmatic-drag-and-drop's `onDragStart`, which seemd to work
      * but did not feel as robust, and might have timing issues as it happens slightly later.
      */
-    (0, _platformFeatureFlags.fg)('platform-dst-panel-splitter-drag-start-client-x') ? (0, _bindEventListener.bind)(splitter, {
+    (0, _bindEventListener.bind)(splitter, {
       type: 'mousedown',
       listener: function listener(event) {
         initialClientXRef.current = event.clientX;
       }
-    }) : _noop.default, (0, _adapter.draggable)({
+    }), (0, _adapter.draggable)({
       element: splitter,
       onGenerateDragPreview: function onGenerateDragPreview(_ref4) {
         var nativeSetDragImage = _ref4.nativeSetDragImage;
@@ -272,9 +271,7 @@ var PortaledPanelSplitter = function PortaledPanelSplitter(_ref3) {
           initialWidth = _source$data.initialWidth,
           resizeBounds = _source$data.resizeBounds,
           direction = _source$data.direction;
-        if ((0, _platformFeatureFlags.fg)('platform-dst-panel-splitter-drag-start-client-x')) {
-          (0, _tinyInvariant.default)(initialClientXRef.current !== null, 'initialClientX must be set');
-        }
+        (0, _tinyInvariant.default)(initialClientXRef.current !== null, 'initialClientX must be set');
 
         /**
          * How wide the element would be if there were no width constraints,

package/dist/es2019/ui/page-layout/panel-splitter/get-width.js

@@ -1,7 +1,6 @@
-import { fg } from '@atlaskit/platform-feature-flags';
 /**
- * ⚠️ Note: We are not using the location.initial.input client locations because some browser extensions
- * can cause the client locations (e.g. clientX) in the `dragstart` event to incorrectly return 0.
+ * ⚠️ Note: We are using the initial client location captured from the mousedown event, not from the dragstart event.
+ * Some browser extensions can cause the client locations (e.g. clientX) in the `dragstart` event to incorrectly return 0.
  */
 export const getWidthFromDragLocation = ({
   initialWidth,
@@ -10,7 +9,7 @@ export const getWidthFromDragLocation = ({
   direction,
   position
 }) => {
-  const diffX = location.current.input.clientX - (fg('platform-dst-panel-splitter-drag-start-client-x') ? initialClientX : location.initial.input.clientX);
+  const diffX = location.current.input.clientX - initialClientX;
 
   // Resize line is positioned at the inline-end (right) of the element.
   // If the direction is left-to-right, the width will increase when the mouse is moved to the right, and vice versa.

package/dist/es2019/ui/page-layout/panel-splitter/panel-splitter.js

@@ -7,7 +7,6 @@ import { forwardRef, useCallback, useContext, useEffect, useMemo, useRef, useSta
 import { bind } from 'bind-event-listener';
 import { createPortal } from 'react-dom';
 import invariant from 'tiny-invariant';
-import noop from '@atlaskit/ds-lib/noop';
 import { useId } from '@atlaskit/ds-lib/use-id';
 import useStableRef from '@atlaskit/ds-lib/use-stable-ref';
 import { useOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
@@ -193,12 +192,12 @@ const PortaledPanelSplitter = ({
      * I also tried only binding an event listener inside pragmatic-drag-and-drop's `onDragStart`, which seemd to work
      * but did not feel as robust, and might have timing issues as it happens slightly later.
      */
-    fg('platform-dst-panel-splitter-drag-start-client-x') ? bind(splitter, {
+    bind(splitter, {
       type: 'mousedown',
       listener: event => {
         initialClientXRef.current = event.clientX;
       }
-    }) : noop, draggable({
+    }), draggable({
       element: splitter,
       onGenerateDragPreview: ({
         nativeSetDragImage
@@ -259,9 +258,7 @@ const PortaledPanelSplitter = ({
           resizeBounds,
           direction
         } = source.data;
-        if (fg('platform-dst-panel-splitter-drag-start-client-x')) {
-          invariant(initialClientXRef.current !== null, 'initialClientX must be set');
-        }
+        invariant(initialClientXRef.current !== null, 'initialClientX must be set');
 
         /**
          * How wide the element would be if there were no width constraints,

package/dist/esm/ui/page-layout/panel-splitter/get-width.js

@@ -1,7 +1,6 @@
-import { fg } from '@atlaskit/platform-feature-flags';
 /**
- * ⚠️ Note: We are not using the location.initial.input client locations because some browser extensions
- * can cause the client locations (e.g. clientX) in the `dragstart` event to incorrectly return 0.
+ * ⚠️ Note: We are using the initial client location captured from the mousedown event, not from the dragstart event.
+ * Some browser extensions can cause the client locations (e.g. clientX) in the `dragstart` event to incorrectly return 0.
  */
 export var getWidthFromDragLocation = function getWidthFromDragLocation(_ref) {
   var initialWidth = _ref.initialWidth,
@@ -9,7 +8,7 @@ export var getWidthFromDragLocation = function getWidthFromDragLocation(_ref) {
     initialClientX = _ref.initialClientX,
     direction = _ref.direction,
     position = _ref.position;
-  var diffX = location.current.input.clientX - (fg('platform-dst-panel-splitter-drag-start-client-x') ? initialClientX : location.initial.input.clientX);
+  var diffX = location.current.input.clientX - initialClientX;
 
   // Resize line is positioned at the inline-end (right) of the element.
   // If the direction is left-to-right, the width will increase when the mouse is moved to the right, and vice versa.

package/dist/esm/ui/page-layout/panel-splitter/panel-splitter.js

@@ -13,7 +13,6 @@ import { forwardRef, useCallback, useContext, useEffect, useMemo, useRef, useSta
 import { bind } from 'bind-event-listener';
 import { createPortal } from 'react-dom';
 import invariant from 'tiny-invariant';
-import noop from '@atlaskit/ds-lib/noop';
 import { useId } from '@atlaskit/ds-lib/use-id';
 import useStableRef from '@atlaskit/ds-lib/use-stable-ref';
 import { useOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
@@ -200,12 +199,12 @@ var PortaledPanelSplitter = function PortaledPanelSplitter(_ref3) {
      * I also tried only binding an event listener inside pragmatic-drag-and-drop's `onDragStart`, which seemd to work
      * but did not feel as robust, and might have timing issues as it happens slightly later.
      */
-    fg('platform-dst-panel-splitter-drag-start-client-x') ? bind(splitter, {
+    bind(splitter, {
       type: 'mousedown',
       listener: function listener(event) {
         initialClientXRef.current = event.clientX;
       }
-    }) : noop, draggable({
+    }), draggable({
       element: splitter,
       onGenerateDragPreview: function onGenerateDragPreview(_ref4) {
         var nativeSetDragImage = _ref4.nativeSetDragImage;
@@ -262,9 +261,7 @@ var PortaledPanelSplitter = function PortaledPanelSplitter(_ref3) {
           initialWidth = _source$data.initialWidth,
           resizeBounds = _source$data.resizeBounds,
           direction = _source$data.direction;
-        if (fg('platform-dst-panel-splitter-drag-start-client-x')) {
-          invariant(initialClientXRef.current !== null, 'initialClientX must be set');
-        }
+        invariant(initialClientXRef.current !== null, 'initialClientX must be set');
 
         /**
          * How wide the element would be if there were no width constraints,

package/dist/types/ui/page-layout/panel-splitter/get-width.d.ts

@@ -1,7 +1,7 @@
 import type { DragLocationHistory } from '@atlaskit/pragmatic-drag-and-drop/types';
 /**
- * ⚠️ Note: We are not using the location.initial.input client locations because some browser extensions
- * can cause the client locations (e.g. clientX) in the `dragstart` event to incorrectly return 0.
+ * ⚠️ Note: We are using the initial client location captured from the mousedown event, not from the dragstart event.
+ * Some browser extensions can cause the client locations (e.g. clientX) in the `dragstart` event to incorrectly return 0.
  */
 export declare const getWidthFromDragLocation: ({ initialWidth, location, initialClientX, direction, position, }: {
     initialWidth: number;

package/dist/types-ts4.5/ui/page-layout/panel-splitter/get-width.d.ts

@@ -1,7 +1,7 @@
 import type { DragLocationHistory } from '@atlaskit/pragmatic-drag-and-drop/types';
 /**
- * ⚠️ Note: We are not using the location.initial.input client locations because some browser extensions
- * can cause the client locations (e.g. clientX) in the `dragstart` event to incorrectly return 0.
+ * ⚠️ Note: We are using the initial client location captured from the mousedown event, not from the dragstart event.
+ * Some browser extensions can cause the client locations (e.g. clientX) in the `dragstart` event to incorrectly return 0.
  */
 export declare const getWidthFromDragLocation: ({ initialWidth, location, initialClientX, direction, position, }: {
     initialWidth: number;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/navigation-system",
-	"version": "5.38.1",
+	"version": "5.39.0",
 	"description": "The latest navigation system for Atlassian apps.",
 	"repository": "https://bitbucket.org/atlassian/atlassian-frontend-mirror",
 	"author": "Atlassian Pty Ltd",
@@ -189,9 +189,6 @@
 		},
 		"platform_dst_nav4_flyout_menu_slots_close_button": {
 			"type": "boolean"
-		},
-		"platform-dst-panel-splitter-drag-start-client-x": {
-			"type": "boolean"
 		}
 	},
 	"homepage": "https://atlassian.design/components/navigation-system"