@atlaskit/navigation-system 5.3.4 → 5.4.0

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlassian/navigation-system
 
+## 5.4.0
+
+### Minor Changes
+
+- [`05dd9b7db95b7`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/05dd9b7db95b7) -
+  The built-in keyboard shortcut for toggling the side nav will check if there are any open modals
+  and ignore the shortcut if there are.
+
+  This check was previously behind the feature gate `platform-dst-open-layer-observer-layer-type`,
+  which has now been removed.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 5.3.4
 
 ### Patch Changes

package/dist/cjs/ui/page-layout/side-nav/use-side-nav-toggle-keyboard-shortcut.js

@@ -45,10 +45,8 @@ function useSideNavToggleKeyboardShortcut(_ref) {
           }
           if (openLayerObserver.getCount({
             type: 'modal'
-          }) > 0 && (0, _platformFeatureFlags.fg)('platform-dst-open-layer-observer-layer-type')) {
+          }) > 0) {
             // Return early if there are any open modals
-            // This check is behind the layer type FG, as `getCount` will return the count of all layers when
-            // the FG is disabled - meaning we would ignore the shortcut if there is any open layer (not just modals).
             return;
           }
           toggleVisibilityByShortcut();

package/dist/es2019/ui/page-layout/side-nav/use-side-nav-toggle-keyboard-shortcut.js

@@ -40,10 +40,8 @@ export function useSideNavToggleKeyboardShortcut({
           }
           if (openLayerObserver.getCount({
             type: 'modal'
-          }) > 0 && fg('platform-dst-open-layer-observer-layer-type')) {
+          }) > 0) {
             // Return early if there are any open modals
-            // This check is behind the layer type FG, as `getCount` will return the count of all layers when
-            // the FG is disabled - meaning we would ignore the shortcut if there is any open layer (not just modals).
             return;
           }
           toggleVisibilityByShortcut();

package/dist/esm/ui/page-layout/side-nav/use-side-nav-toggle-keyboard-shortcut.js

@@ -39,10 +39,8 @@ export function useSideNavToggleKeyboardShortcut(_ref) {
           }
           if (openLayerObserver.getCount({
             type: 'modal'
-          }) > 0 && fg('platform-dst-open-layer-observer-layer-type')) {
+          }) > 0) {
             // Return early if there are any open modals
-            // This check is behind the layer type FG, as `getCount` will return the count of all layers when
-            // the FG is disabled - meaning we would ignore the shortcut if there is any open layer (not just modals).
             return;
           }
           toggleVisibilityByShortcut();

package/dist/types/ui/page-layout/root.d.ts

@@ -55,8 +55,7 @@ export declare function Root({ children, xcss, UNSAFE_dangerouslyHoistSlotSizes,
      *
      * The shortcut is not enabled by default.
      *
-     * The shortcut will also be ignored if there are any open ADS modal dialogs (`@atlaskit/modal-dialog`). This is behind
-     * the `platform-dst-open-layer-observer-layer-type` feature flag.
+     * The shortcut will also be ignored if there are any open ADS modal dialogs (`@atlaskit/modal-dialog`).
      *
      * `SideNav` has another prop `canToggleWithShortcut()` that can be used to run additional checks after the shortcut
      * is pressed, before the SideNav is toggled. You can use this to conditionally disable the shortcut based on your

package/dist/types-ts4.5/ui/page-layout/root.d.ts

@@ -55,8 +55,7 @@ export declare function Root({ children, xcss, UNSAFE_dangerouslyHoistSlotSizes,
      *
      * The shortcut is not enabled by default.
      *
-     * The shortcut will also be ignored if there are any open ADS modal dialogs (`@atlaskit/modal-dialog`). This is behind
-     * the `platform-dst-open-layer-observer-layer-type` feature flag.
+     * The shortcut will also be ignored if there are any open ADS modal dialogs (`@atlaskit/modal-dialog`).
      *
      * `SideNav` has another prop `canToggleWithShortcut()` that can be used to run additional checks after the shortcut
      * is pressed, before the SideNav is toggled. You can use this to conditionally disable the shortcut based on your

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/navigation-system",
-	"version": "5.3.4",
+	"version": "5.4.0",
 	"description": "The latest navigation system for Atlassian apps.",
 	"repository": "https://bitbucket.org/atlassian/atlassian-frontend-mirror",
 	"author": "Atlassian Pty Ltd",
@@ -72,7 +72,7 @@
 		"@atlaskit/css": "^0.15.0",
 		"@atlaskit/ds-lib": "^5.2.0",
 		"@atlaskit/icon": "^29.0.0",
-		"@atlaskit/layering": "^3.2.0",
+		"@atlaskit/layering": "^3.3.0",
 		"@atlaskit/logo": "^19.9.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/popup": "^4.6.0",
@@ -107,7 +107,7 @@
 		"@atlaskit/link": "^3.2.0",
 		"@atlaskit/lozenge": "^13.1.0",
 		"@atlaskit/menu": "^8.4.0",
-		"@atlaskit/modal-dialog": "^14.6.0",
+		"@atlaskit/modal-dialog": "^14.7.0",
 		"@atlaskit/onboarding": "^14.4.0",
 		"@atlaskit/page-header": "^12.1.0",
 		"@atlaskit/page-layout": "^4.2.0",
@@ -117,8 +117,9 @@
 		"@atlaskit/textfield": "^8.0.0",
 		"@atlassian/feature-flags-test-utils": "^1.0.0",
 		"@atlassian/gemini": "^1.20.0",
-		"@atlassian/search-dialog": "^9.8.0",
+		"@atlassian/search-dialog": "^9.9.0",
 		"@atlassian/ssr-tests": "workspace:^",
+		"@atlassian/test-utils": "^1.0.0",
 		"@atlassian/testing-library": "^0.4.0",
 		"@axe-core/playwright": "^4.8.0",
 		"@testing-library/react": "^13.4.0",
@@ -184,9 +185,6 @@
 		"platform_dst_side_nav_remove_custom_tooltip": {
 			"type": "boolean"
 		},
-		"platform-dst-open-layer-observer-layer-type": {
-			"type": "boolean"
-		},
 		"platform_themed_button_use_icon_renderer": {
 			"type": "boolean"
 		},