@atlaskit/navigation-system 5.17.0 → 5.18.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (36) hide show
  1. package/CHANGELOG.md +21 -0
  2. package/dist/cjs/ui/page-layout/constants.js +8 -2
  3. package/dist/cjs/ui/page-layout/panel-splitter/side-nav-panel-splitter.js +20 -50
  4. package/dist/cjs/ui/page-layout/side-nav/side-nav.js +7 -0
  5. package/dist/cjs/ui/page-layout/top-nav/top-nav-end.compiled.css +1 -1
  6. package/dist/cjs/ui/page-layout/top-nav/top-nav-end.js +18 -11
  7. package/dist/cjs/ui/page-layout/top-nav/top-nav-middle.js +5 -1
  8. package/dist/cjs/ui/page-layout/top-nav/top-nav-start.compiled.css +1 -1
  9. package/dist/cjs/ui/page-layout/top-nav/top-nav-start.js +7 -5
  10. package/dist/cjs/ui/page-layout/top-nav/top-nav.js +14 -33
  11. package/dist/cjs/ui/page-layout/use-open-layer-count.js +59 -0
  12. package/dist/es2019/ui/page-layout/constants.js +7 -1
  13. package/dist/es2019/ui/page-layout/panel-splitter/side-nav-panel-splitter.js +23 -48
  14. package/dist/es2019/ui/page-layout/side-nav/side-nav.js +7 -0
  15. package/dist/es2019/ui/page-layout/top-nav/top-nav-end.compiled.css +1 -1
  16. package/dist/es2019/ui/page-layout/top-nav/top-nav-end.js +13 -5
  17. package/dist/es2019/ui/page-layout/top-nav/top-nav-middle.js +5 -1
  18. package/dist/es2019/ui/page-layout/top-nav/top-nav-start.compiled.css +1 -1
  19. package/dist/es2019/ui/page-layout/top-nav/top-nav-start.js +8 -6
  20. package/dist/es2019/ui/page-layout/top-nav/top-nav.js +17 -31
  21. package/dist/es2019/ui/page-layout/use-open-layer-count.js +44 -0
  22. package/dist/esm/ui/page-layout/constants.js +7 -1
  23. package/dist/esm/ui/page-layout/panel-splitter/side-nav-panel-splitter.js +23 -52
  24. package/dist/esm/ui/page-layout/side-nav/side-nav.js +7 -0
  25. package/dist/esm/ui/page-layout/top-nav/top-nav-end.compiled.css +1 -1
  26. package/dist/esm/ui/page-layout/top-nav/top-nav-end.js +18 -11
  27. package/dist/esm/ui/page-layout/top-nav/top-nav-middle.js +5 -1
  28. package/dist/esm/ui/page-layout/top-nav/top-nav-start.compiled.css +1 -1
  29. package/dist/esm/ui/page-layout/top-nav/top-nav-start.js +8 -6
  30. package/dist/esm/ui/page-layout/top-nav/top-nav.js +17 -35
  31. package/dist/esm/ui/page-layout/use-open-layer-count.js +53 -0
  32. package/dist/types/ui/page-layout/constants.d.ts +3 -1
  33. package/dist/types/ui/page-layout/use-open-layer-count.d.ts +8 -0
  34. package/dist/types-ts4.5/ui/page-layout/constants.d.ts +3 -1
  35. package/dist/types-ts4.5/ui/page-layout/use-open-layer-count.d.ts +8 -0
  36. package/package.json +7 -7
package/CHANGELOG.md CHANGED
@@ -1,5 +1,26 @@
1
1
  # @atlassian/navigation-system
2
2
 
3
+ ## 5.18.1
4
+
5
+ ### Patch Changes
6
+
7
+ - [`d5e528e62f16d`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/d5e528e62f16d) -
8
+ clean up fg: team25-eu-jira-logo-updates-csm-jsm
9
+
10
+ ## 5.18.0
11
+
12
+ ### Minor Changes
13
+
14
+ - [`67509a09876ad`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/67509a09876ad) -
15
+ The side nav will no longer peek when a popup is open in `TopNavStart`, such as the app switcher.
16
+
17
+ This change is behind the `platform_dst_nav4_side_nav_resize_tooltip_feedback` and
18
+ `platform-dst-side-nav-layering-fixes` feature flags, when full height sidebar is enabled.
19
+
20
+ ### Patch Changes
21
+
22
+ - Updated dependencies
23
+
3
24
  ## 5.17.0
4
25
 
5
26
  ### Minor Changes
@@ -3,7 +3,7 @@
3
3
  Object.defineProperty(exports, "__esModule", {
4
4
  value: true
5
5
  });
6
- exports.topNavMountedVar = exports.sideNavVar = exports.sideNavPanelSplitterId = exports.sideNavLiveWidthVar = exports.sideNavContentScrollTimelineVar = exports.panelVar = exports.panelPanelSplitterId = exports.openLayerObserverTopNavNamespace = exports.openLayerObserverSideNavNamespace = exports.localSlotLayers = exports.contentInsetBlockStart = exports.contentHeightWhenFixed = exports.bannerMountedVar = exports.asideVar = exports.asidePanelSplitterId = exports.UNSAFE_topNavVar = exports.UNSAFE_sideNavLayoutVar = exports.UNSAFE_panelLayoutVar = exports.UNSAFE_bannerVar = exports.UNSAFE_asideLayoutVar = exports.UNSAFE_MAIN_INLINE_START_FOR_LEGACY_PAGES_ONLY = exports.UNSAFE_MAIN_INLINE_END_FOR_LEGACY_PAGES_ONLY = exports.UNSAFE_MAIN_BLOCK_START_FOR_LEGACY_PAGES_ONLY = void 0;
6
+ exports.topNavMountedVar = exports.sideNavVar = exports.sideNavPanelSplitterId = exports.sideNavLiveWidthVar = exports.sideNavContentScrollTimelineVar = exports.panelVar = exports.panelPanelSplitterId = exports.openLayerObserverTopNavStartNamespace = exports.openLayerObserverTopNavMiddleNamespace = exports.openLayerObserverTopNavEndNamespace = exports.openLayerObserverSideNavNamespace = exports.localSlotLayers = exports.contentInsetBlockStart = exports.contentHeightWhenFixed = exports.bannerMountedVar = exports.asideVar = exports.asidePanelSplitterId = exports.UNSAFE_topNavVar = exports.UNSAFE_sideNavLayoutVar = exports.UNSAFE_panelLayoutVar = exports.UNSAFE_bannerVar = exports.UNSAFE_asideLayoutVar = exports.UNSAFE_MAIN_INLINE_START_FOR_LEGACY_PAGES_ONLY = exports.UNSAFE_MAIN_INLINE_END_FOR_LEGACY_PAGES_ONLY = exports.UNSAFE_MAIN_BLOCK_START_FOR_LEGACY_PAGES_ONLY = void 0;
7
7
  /**
8
8
  * These variables are shared across the different page layout slots.
9
9
  * This violates the [UI styling standard](https://atlassian.design/components/eslint-plugin-ui-styling-standard/no-imported-style-values/usage).
@@ -66,7 +66,13 @@ var localSlotLayers = exports.localSlotLayers = {
66
66
  panelSmallViewports: 1
67
67
  };
68
68
  var openLayerObserverSideNavNamespace = exports.openLayerObserverSideNavNamespace = 'side-nav';
69
- var openLayerObserverTopNavNamespace = exports.openLayerObserverTopNavNamespace = 'top-nav';
69
+ // We have separate OpenLayerObserver namespaces for each top nav layout area, instead of a single namespace for the entire top nav,
70
+ // as we need to know if there are open layers in TopNavStart specifically to prevent the side nav from peeking.
71
+ // The OpenLayerObserver doesn't support nested namespaces. We could update it, but for now it's simple enough to just have separate
72
+ // namespaces.
73
+ var openLayerObserverTopNavStartNamespace = exports.openLayerObserverTopNavStartNamespace = 'top-nav-start';
74
+ var openLayerObserverTopNavMiddleNamespace = exports.openLayerObserverTopNavMiddleNamespace = 'top-nav-middle';
75
+ var openLayerObserverTopNavEndNamespace = exports.openLayerObserverTopNavEndNamespace = 'top-nav-end';
70
76
 
71
77
  /**
72
78
  * CSS scroll timeline variable for the side nav content scroll indicator.
@@ -6,17 +6,30 @@ Object.defineProperty(exports, "__esModule", {
6
6
  value: true
7
7
  });
8
8
  exports.SideNavPanelSplitter = void 0;
9
- var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
10
9
  var _react = _interopRequireWildcard(require("react"));
11
10
  var _tinyInvariant = _interopRequireDefault(require("tiny-invariant"));
12
- var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
13
11
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
14
12
  var _useIsFhsEnabled = require("../../fhs-rollout/use-is-fhs-enabled");
15
13
  var _constants = require("../constants");
16
14
  var _useToggleSideNav = require("../side-nav/use-toggle-side-nav");
15
+ var _useOpenLayerCount = require("../use-open-layer-count");
17
16
  var _context = require("./context");
18
17
  var _panelSplitter = require("./panel-splitter");
19
18
  function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
19
+ /**
20
+ * Namespaces to check for open layers that would interfere with the panel splitter.
21
+ *
22
+ * Placed outside the component for stability, as the list is used as an effect dependency.
23
+ */
24
+ var openLayerNamespacesToCheck = [
25
+ // We don't technically need to check the side nav for open layers, as they wouldn't overlay the
26
+ // panel splitter, as it sits within the same stacking context as the side nav. For consistency however,
27
+ // we check it as well.
28
+ _constants.openLayerObserverSideNavNamespace,
29
+ // When there is an open layer in the top nav, the top nav is given a higher z-index than the side nav.
30
+ // This means the part of the side nav panel splitter that was sitting above the top nav will no longer
31
+ // be interactive (as it is now behind the top nav). So, we need to disable the entire panel splitter.
32
+ _constants.openLayerObserverTopNavStartNamespace, _constants.openLayerObserverTopNavMiddleNamespace, _constants.openLayerObserverTopNavEndNamespace];
20
33
  /**
21
34
  * _SideNavPanelSplitter_
22
35
  *
@@ -48,54 +61,11 @@ var SideNavPanelSplitter = exports.SideNavPanelSplitter = function SideNavPanelS
48
61
  // The logic and state for disabling the panel splitter when there are open popups
49
62
  // in the side nav or top nav is being placed here, instead of in `SideNav`, to prevent
50
63
  // re-rendering the side nav anytime the number of open popups changes.
51
- var _useState = (0, _react.useState)(true),
52
- _useState2 = (0, _slicedToArray2.default)(_useState, 2),
53
- isEnabled = _useState2[0],
54
- setIsEnabled = _useState2[1];
55
- var openLayerObserver = (0, _openLayerObserver.useOpenLayerObserver)();
56
- (0, _react.useEffect)(function () {
57
- if (!openLayerObserver || !isFhsEnabled || !(0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes')) {
58
- return;
59
- }
60
- function checkAndSetState() {
61
- if (!openLayerObserver) {
62
- return;
63
- }
64
-
65
- // We don't technically need to check the side nav for open layers, as they wouldn't overlay the
66
- // panel splitter, as it sits within the same stacking context as the side nav. For consistency however,
67
- // we check it as well.
68
- var openPopupsInSideNav = openLayerObserver.getCount({
69
- namespace: _constants.openLayerObserverSideNavNamespace,
70
- type: 'popup'
71
- });
72
-
73
- // When there is an open layer in the top nav, the top nav is given a higher z-index than the side nav.
74
- // This means the part of the side nav panel splitter that was sitting above the top nav will no longer
75
- // be interactive (as it is now behind the top nav). So, we need to disable the entire panel splitter.
76
- var openPopupsInTopNav = openLayerObserver.getCount({
77
- namespace: _constants.openLayerObserverTopNavNamespace,
78
- type: 'popup'
79
- });
80
- setIsEnabled(openPopupsInSideNav + openPopupsInTopNav === 0);
81
- }
82
-
83
- // Initial check, in case the app has loaded with an open popup.
84
- checkAndSetState();
85
-
86
- // Creating separate listeners for each namespace, to avoid running them when layers in other parts of the app change.
87
- var cleanupSideNavListener = openLayerObserver.onChange(checkAndSetState, {
88
- namespace: _constants.openLayerObserverSideNavNamespace
89
- });
90
- var cleanupTopNavListener = openLayerObserver.onChange(checkAndSetState, {
91
- namespace: _constants.openLayerObserverTopNavNamespace
92
- });
93
- return function cleanup() {
94
- cleanupSideNavListener();
95
- cleanupTopNavListener();
96
- };
97
- }, [isFhsEnabled, openLayerObserver]);
98
- if (!isEnabled && isFhsEnabled && (0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes')) {
64
+ var hasOpenLayers = (0, _useOpenLayerCount.useHasOpenLayers)({
65
+ namespaces: openLayerNamespacesToCheck,
66
+ type: 'popup'
67
+ });
68
+ if (hasOpenLayers && isFhsEnabled && (0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes')) {
99
69
  return null;
100
70
  }
101
71
  return /*#__PURE__*/_react.default.createElement(_context.OnDoubleClickContext.Provider, {
@@ -220,6 +220,13 @@ function SideNavInternal(_ref) {
220
220
  }
221
221
  }
222
222
  function open() {
223
+ // Prevent the flyout from being opened if there are any open layers in the top nav start
224
+ if (openLayerObserver && openLayerObserver.getCount({
225
+ namespace: 'top-nav-start',
226
+ type: 'popup'
227
+ }) > 0 && (0, _platformFeatureFlags.fg)('platform_dst_nav4_side_nav_resize_tooltip_feedback')) {
228
+ return;
229
+ }
223
230
  var prevFlyoutState = flyoutStateRef.current;
224
231
  tryAbortPendingClose();
225
232
  flyoutStateRef.current = {
@@ -9,4 +9,4 @@
9
9
  ._lcxv1wug{pointer-events:auto}
10
10
  ._y4tiutpp{padding-inline-end:var(--ds-space-150,9pt)}
11
11
  @media (min-width:48rem){._181n1txw{display:flex}._1d2y1ris{min-width:max-content}}
12
- @media (min-width:64rem){._15rip2n4{min-width:330px}._glte1ris{width:max-content}._15ri1mjv{min-width:300px}._1gs5usvi{box-sizing:border-box}._ndwch9n0{justify-self:end}}
12
+ @media (min-width:64rem){._glte1ris{width:max-content}._15rip2n4{min-width:330px}._1gs5usvi{box-sizing:border-box}._ndwch9n0{justify-self:end}}
@@ -15,6 +15,7 @@ var _react = _interopRequireWildcard(require("react"));
15
15
  var _react2 = require("@compiled/react");
16
16
  var _useLayoutEffect = require("@atlaskit/ds-lib/use-layout-effect");
17
17
  var _showMoreHorizontal = _interopRequireDefault(require("@atlaskit/icon/core/show-more-horizontal"));
18
+ var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
18
19
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
19
20
  var _popup = _interopRequireDefault(require("@atlaskit/popup"));
20
21
  var _compiled = require("@atlaskit/primitives/compiled");
@@ -22,10 +23,10 @@ var _list = require("../../../components/list");
22
23
  var _useIsFhsEnabled = require("../../fhs-rollout/use-is-fhs-enabled");
23
24
  var _hasCustomThemeContext = require("../../top-nav-items/themed/has-custom-theme-context");
24
25
  var _migration = require("../../top-nav-items/themed/migration");
26
+ var _constants = require("../constants");
25
27
  function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
26
28
  var containerStyles = {
27
- root: "_yyhy11wp _1e0c1txw _1bahh9n0 _1ul9zwfg _1d2y1ris _glte1ris _15ri1mjv _1gs5usvi _ndwch9n0",
28
- jiraProductLogoUpdate: "_15rip2n4",
29
+ root: "_yyhy11wp _1e0c1txw _1bahh9n0 _1ul9zwfg _1d2y1ris _glte1ris _15rip2n4 _1gs5usvi _ndwch9n0",
29
30
  fullHeightSidebar: "_y4tiutpp _lcxv1wug",
30
31
  fullHeightSidebarWithLayeringFixes: "_y4tiutpp"
31
32
  };
@@ -34,6 +35,12 @@ var listStyles = {
34
35
  hideOnSmallViewport: "_1e0cglyw _181n1txw",
35
36
  popupContainer: "_1yt4u2gc"
36
37
  };
38
+ function OpenLayerObserverNamespaceProviderBehindFG(_ref) {
39
+ var children = _ref.children;
40
+ return (0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') ? /*#__PURE__*/_react.default.createElement(_openLayerObserver.OpenLayerObserverNamespaceProvider, {
41
+ namespace: _constants.openLayerObserverTopNavEndNamespace
42
+ }, children) : children;
43
+ }
37
44
 
38
45
  /**
39
46
  * __TopNavEnd__
@@ -43,12 +50,12 @@ var listStyles = {
43
50
  * On small viewports, the children will be placed inside a popup, and a button will be rendered to open the popup.
44
51
  * This is to prevent the actions from overflowing the top navigation.
45
52
  */
46
- function TopNavEnd(_ref) {
47
- var children = _ref.children,
48
- _ref$label = _ref.label,
49
- label = _ref$label === void 0 ? 'Actions' : _ref$label,
50
- _ref$showMoreButtonLa = _ref.showMoreButtonLabel,
51
- showMoreButtonLabel = _ref$showMoreButtonLa === void 0 ? 'Show more' : _ref$showMoreButtonLa;
53
+ function TopNavEnd(_ref2) {
54
+ var children = _ref2.children,
55
+ _ref2$label = _ref2.label,
56
+ label = _ref2$label === void 0 ? 'Actions' : _ref2$label,
57
+ _ref2$showMoreButtonL = _ref2.showMoreButtonLabel,
58
+ showMoreButtonLabel = _ref2$showMoreButtonL === void 0 ? 'Show more' : _ref2$showMoreButtonL;
52
59
  var isFhsEnabled = (0, _useIsFhsEnabled.useIsFhsEnabled)();
53
60
  var _useState = (0, _react.useState)(false),
54
61
  _useState2 = (0, _slicedToArray2.default)(_useState, 2),
@@ -74,7 +81,7 @@ function TopNavEnd(_ref) {
74
81
  }, [query]);
75
82
  return /*#__PURE__*/_react.default.createElement("nav", {
76
83
  "aria-label": label,
77
- className: (0, _runtime.ax)([containerStyles.root, isFhsEnabled && !(0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') && containerStyles.fullHeightSidebar, isFhsEnabled && (0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') && containerStyles.fullHeightSidebarWithLayeringFixes, (0, _platformFeatureFlags.fg)('team25-eu-jira-logo-updates-csm-jsm') && containerStyles.jiraProductLogoUpdate])
84
+ className: (0, _runtime.ax)([containerStyles.root, isFhsEnabled && !(0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') && containerStyles.fullHeightSidebar, isFhsEnabled && (0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') && containerStyles.fullHeightSidebarWithLayeringFixes])
78
85
  }, isMobile ? /*#__PURE__*/_react.default.createElement(_popup.default, {
79
86
  isOpen: isOpen,
80
87
  onClose: function onClose() {
@@ -87,7 +94,7 @@ function TopNavEnd(_ref) {
87
94
  value: false
88
95
  }, /*#__PURE__*/_react.default.createElement(_list.List, {
89
96
  xcss: (0, _react2.cx)(listStyles.root, listStyles.popupContainer)
90
- }, children));
97
+ }, /*#__PURE__*/_react.default.createElement(OpenLayerObserverNamespaceProviderBehindFG, null, children)));
91
98
  },
92
99
  trigger: function trigger(triggerProps) {
93
100
  return /*#__PURE__*/_react.default.createElement(_migration.IconButton, (0, _extends2.default)({}, triggerProps, {
@@ -102,5 +109,5 @@ function TopNavEnd(_ref) {
102
109
  }
103
110
  }) : /*#__PURE__*/_react.default.createElement(_list.List, {
104
111
  xcss: (0, _react2.cx)(listStyles.root, listStyles.hideOnSmallViewport)
105
- }, children));
112
+ }, /*#__PURE__*/_react.default.createElement(OpenLayerObserverNamespaceProviderBehindFG, null, children)));
106
113
  }
@@ -9,8 +9,10 @@ exports.TopNavMiddle = TopNavMiddle;
9
9
  require("./top-nav-middle.compiled.css");
10
10
  var _runtime = require("@compiled/react/runtime");
11
11
  var _react = _interopRequireDefault(require("react"));
12
+ var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
12
13
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
13
14
  var _useIsFhsEnabled = require("../../fhs-rollout/use-is-fhs-enabled");
15
+ var _constants = require("../constants");
14
16
  var styles = {
15
17
  root: "_zulpu2gc _yyhycs5v _1bsb1osq _4cvr1h6o _1e0c1txw _1bahh9n0 _181n11p5 _1j8b15b0 _lagd1bp4 _1t4c1ris _12e8h9n0",
16
18
  fullHeightSidebar: "_lcxv1wug"
@@ -29,5 +31,7 @@ function TopNavMiddle(_ref) {
29
31
  var isFhsEnabled = (0, _useIsFhsEnabled.useIsFhsEnabled)();
30
32
  return /*#__PURE__*/_react.default.createElement("div", {
31
33
  className: (0, _runtime.ax)([styles.root, isFhsEnabled && !(0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') && styles.fullHeightSidebar])
32
- }, children);
34
+ }, (0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') ? /*#__PURE__*/_react.default.createElement(_openLayerObserver.OpenLayerObserverNamespaceProvider, {
35
+ namespace: _constants.openLayerObserverTopNavMiddleNamespace
36
+ }, children) : children);
33
37
  }
@@ -13,5 +13,5 @@
13
13
  ._vchhusvi{box-sizing:border-box}
14
14
  [dir=rtl] ._65m41mrw{--animation-direction:-1}
15
15
  @media (prefers-reduced-motion:no-preference){._10t81e03{transition-property:transform}._10t81rjc{transition-property:transform,opacity}._1xq51ytf{transition-timing-function:ease-in-out}._1xq55ucs{transition-timing-function:ease}._mjvc1efy{transform:translateX(calc(100%*var(--animation-direction)))}._bgpzidpf{opacity:0}._mjvc1p9u{transform:translateX(calc(-100%*var(--animation-direction)))}._mjvco0k7{transform:translateX(calc((-2rem + var(--ds-space-050, 4px)*-1)*var(--animation-direction)))}._mjvcyrjp{transform:translateX(calc((2rem + var(--ds-space-050, 4px))*var(--animation-direction)))}._mjvcz12g{transform:translateX(0)}._xrrpfnf5{transition-duration:.2s}._bgpzkb7n{opacity:1}}
16
- @media (min-width:64rem){._13wnh2mm{position:relative}._1l3vb3bt:after{content:""}._juxdstnw:after{position:absolute}._1vinidpf:after{inset-block-start:0}._1719idpf:after{inset-block-end:0}._e6znidpf:after{inset-inline-end:0}._1kyhe4h9:after{border-inline-end-width:var(--ds-border-width,1px)}._4cwynqa1:after{border-inline-end-style:solid}._435s1l7x:after{border-inline-end-color:var(--ds-border,#0b120e24)}._m7c3idpf:after{opacity:0}._15rin7od{min-width:unset}._glte1osq{width:100%}._15rip2n4{min-width:330px}@supports (scroll-timeline-axis:block){html:not(:has([data-private-side-nav-header])) ._1kilgc9s{animation-timeline:--sNcst}html:not(:has([data-private-side-nav-header])) ._1m3l1ybg{animation-name:khj1qz3}html:not(:has([data-private-side-nav-header])) ._12g81hrf{animation-fill-mode:both}}._4ap3vuon{background-color:var(--ds-surface,#fff)}._m7c3kb7n:after{opacity:1}._glte1ris{width:max-content}._15ri1mjv{min-width:300px}._1gs5usvi{box-sizing:border-box}._glte93mn{width:var(--n_sNvlw,100%)}._exxmpxbi{padding-inline-end:var(--ds-space-200,1pc)}@supports (scroll-timeline-axis:block){@keyframes khj1qz3{0%{box-shadow:inset 0 -1px 0 0 transparent}0.1%{box-shadow:inset 0 -1px 0 0 var(--ds-border,#0b120e24)}to{box-shadow:inset 0 -1px 0 0 var(--ds-border,#0b120e24)}}}}
16
+ @media (min-width:64rem){._13wnh2mm{position:relative}._1l3vb3bt:after{content:""}._juxdstnw:after{position:absolute}._1vinidpf:after{inset-block-start:0}._1719idpf:after{inset-block-end:0}._e6znidpf:after{inset-inline-end:0}._1kyhe4h9:after{border-inline-end-width:var(--ds-border-width,1px)}._4cwynqa1:after{border-inline-end-style:solid}._435s1l7x:after{border-inline-end-color:var(--ds-border,#0b120e24)}._m7c3idpf:after{opacity:0}._15rin7od{min-width:unset}._glte1osq{width:100%}@supports (scroll-timeline-axis:block){html:not(:has([data-private-side-nav-header])) ._1kilgc9s{animation-timeline:--sNcst}html:not(:has([data-private-side-nav-header])) ._1m3l1ybg{animation-name:khj1qz3}html:not(:has([data-private-side-nav-header])) ._12g81hrf{animation-fill-mode:both}}._4ap3vuon{background-color:var(--ds-surface,#fff)}._m7c3kb7n:after{opacity:1}._glte1ris{width:max-content}._15rip2n4{min-width:330px}._1gs5usvi{box-sizing:border-box}._glte93mn{width:var(--n_sNvlw,100%)}._exxmpxbi{padding-inline-end:var(--ds-space-200,1pc)}@supports (scroll-timeline-axis:block){@keyframes khj1qz3{0%{box-shadow:inset 0 -1px 0 0 transparent}0.1%{box-shadow:inset 0 -1px 0 0 var(--ds-border,#0b120e24)}to{box-shadow:inset 0 -1px 0 0 var(--ds-border,#0b120e24)}}}}
17
17
  @media (prefers-reduced-motion:no-preference) and (min-width:64rem){._n8qabrmi:after{transition-property:opacity}._wc72fnf5:after{transition-duration:.2s}._j3mr1v42:after{transition-timing-function:ease-in}}
@@ -12,6 +12,7 @@ var _runtime = require("@compiled/react/runtime");
12
12
  var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
13
13
  var _react = _interopRequireWildcard(require("react"));
14
14
  var _useStableRef = _interopRequireDefault(require("@atlaskit/ds-lib/use-stable-ref"));
15
+ var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
15
16
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
16
17
  var _compiled = require("@atlaskit/primitives/compiled");
17
18
  var _topNavStartContext = require("../../../context/top-nav-start/top-nav-start-context");
@@ -39,8 +40,7 @@ var flexGap = "var(--ds-space-050, 4px)";
39
40
  * which re-enables pointer events.
40
41
  */
41
42
  var innerStyles = {
42
- root: "_zulp1b66 _yyhykb7n _4t3i1osq _4cvr1h6o _1e0c1txw _glte1ris _15ri1mjv _1gs5usvi",
43
- jiraProductLogoUpdate: "_15rip2n4",
43
+ root: "_zulp1b66 _yyhykb7n _4t3i1osq _4cvr1h6o _1e0c1txw _glte1ris _15rip2n4 _1gs5usvi",
44
44
  fullHeightSidebar: "_lcxv1wug",
45
45
  fullHeightSidebarExpanded: "_15rin7od _glte1osq"
46
46
  };
@@ -117,7 +117,7 @@ var TopNavStartInnerOld = /*#__PURE__*/(0, _react.forwardRef)(function TopNavSta
117
117
  return /*#__PURE__*/_react.default.createElement("div", {
118
118
  ref: ref,
119
119
  "data-testid": testId,
120
- className: (0, _runtime.ax)([innerStyles.root, (0, _platformFeatureFlags.fg)('team25-eu-jira-logo-updates-csm-jsm') && innerStyles.jiraProductLogoUpdate])
120
+ className: (0, _runtime.ax)([innerStyles.root])
121
121
  }, children);
122
122
  });
123
123
  var TopNavStartInnerFHS = /*#__PURE__*/(0, _react.forwardRef)(function TopNavStartInnerFHS(_ref2, ref) {
@@ -152,8 +152,10 @@ var TopNavStartInnerFHS = /*#__PURE__*/(0, _react.forwardRef)(function TopNavSta
152
152
  }, /*#__PURE__*/_react.default.createElement("div", {
153
153
  ref: ref,
154
154
  "data-testid": testId,
155
- className: (0, _runtime.ax)([innerStyles.root, !(0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') && innerStyles.fullHeightSidebar, (0, _platformFeatureFlags.fg)('team25-eu-jira-logo-updates-csm-jsm') && innerStyles.jiraProductLogoUpdate, isExpandedOnDesktop && innerStyles.fullHeightSidebarExpanded])
156
- }, children));
155
+ className: (0, _runtime.ax)([innerStyles.root, !(0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') && innerStyles.fullHeightSidebar, isExpandedOnDesktop && innerStyles.fullHeightSidebarExpanded])
156
+ }, (0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') ? /*#__PURE__*/_react.default.createElement(_openLayerObserver.OpenLayerObserverNamespaceProvider, {
157
+ namespace: _constants.openLayerObserverTopNavStartNamespace
158
+ }, children) : children));
157
159
  });
158
160
 
159
161
  /**
@@ -11,9 +11,7 @@ require("./top-nav.compiled.css");
11
11
  var _react = _interopRequireWildcard(require("react"));
12
12
  var React = _react;
13
13
  var _runtime = require("@compiled/react/runtime");
14
- var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
15
14
  var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
16
- var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
17
15
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
18
16
  var _skipLinksContext = require("../../../context/skip-links/skip-links-context");
19
17
  var _useIsFhsEnabled = require("../../fhs-rollout/use-is-fhs-enabled");
@@ -24,6 +22,7 @@ var _hoistSlotSizesContext = require("../hoist-slot-sizes-context");
24
22
  var _hoistUtils = require("../hoist-utils");
25
23
  var _idUtils = require("../id-utils");
26
24
  var _useSideNavVisibility2 = require("../side-nav/use-side-nav-visibility");
25
+ var _useOpenLayerCount = require("../use-open-layer-count");
27
26
  var _excluded = ["backgroundColor"];
28
27
  function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
29
28
  /**
@@ -52,6 +51,14 @@ var backgroundStyles = {
52
51
  sideNavExpanded: "_hyzqcs5v"
53
52
  };
54
53
 
54
+ /**
55
+ * Namespaces to check for open layers within the top nav.
56
+ * When there is an open layer in the top nav, the top nav is given a higher z-index than the side nav.
57
+ *
58
+ * Placed outside the component for stability, as the list is used as an effect dependency.
59
+ */
60
+ var topNavOpenLayerNamespaces = [_constants.openLayerObserverTopNavStartNamespace, _constants.openLayerObserverTopNavMiddleNamespace, _constants.openLayerObserverTopNavEndNamespace];
61
+
55
62
  /**
56
63
  * The top nav layout area. It will display at the top of the screen, below the banner if one is present.
57
64
  */
@@ -103,34 +110,10 @@ function TopNav(_ref) {
103
110
  foregroundStyle = _useMemo.foregroundStyle;
104
111
  var _useSideNavVisibility = (0, _useSideNavVisibility2.useSideNavVisibility)(),
105
112
  isExpandedOnDesktop = _useSideNavVisibility.isExpandedOnDesktop;
106
- var openLayerObserver = (0, _openLayerObserver.useOpenLayerObserver)();
107
- // Setting the initial state to false, as it is unlikely that the top nav would have an open popup when the app starts.
108
- var _useState = (0, _react.useState)(false),
109
- _useState2 = (0, _slicedToArray2.default)(_useState, 2),
110
- hasOpenPopup = _useState2[0],
111
- setHasOpenPopup = _useState2[1];
112
- (0, _react.useLayoutEffect)(function () {
113
- if (!openLayerObserver || !isFhsEnabled || !(0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes')) {
114
- return;
115
- }
116
- function checkAndSetState() {
117
- if (!openLayerObserver) {
118
- return;
119
- }
120
- setHasOpenPopup(openLayerObserver.getCount({
121
- namespace: _constants.openLayerObserverTopNavNamespace,
122
- type: 'popup'
123
- }) > 0);
124
- }
125
-
126
- // Initial check
127
- checkAndSetState();
128
-
129
- // Check again whenever number of layers in the top nav change
130
- return openLayerObserver.onChange(checkAndSetState, {
131
- namespace: _constants.openLayerObserverTopNavNamespace
132
- });
133
- }, [isFhsEnabled, openLayerObserver]);
113
+ var hasOpenPopup = (0, _useOpenLayerCount.useHasOpenLayers)({
114
+ namespaces: topNavOpenLayerNamespaces,
115
+ type: 'popup'
116
+ });
134
117
  return /*#__PURE__*/React.createElement(_hasCustomThemeContext.HasCustomThemeContext.Provider, {
135
118
  value: customTheme.isEnabled
136
119
  }, isFhsEnabled && !(0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') && /*#__PURE__*/React.createElement("div", {
@@ -163,7 +146,5 @@ function TopNav(_ref) {
163
146
  value: height
164
147
  })
165
148
  // ------ END UNSAFE STYLES ------
166
- , (0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes') ? /*#__PURE__*/React.createElement(_openLayerObserver.OpenLayerObserverNamespaceProvider, {
167
- namespace: _constants.openLayerObserverTopNavNamespace
168
- }, children) : children));
149
+ , children));
169
150
  }
@@ -0,0 +1,59 @@
1
+ "use strict";
2
+
3
+ var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
4
+ Object.defineProperty(exports, "__esModule", {
5
+ value: true
6
+ });
7
+ exports.useHasOpenLayers = useHasOpenLayers;
8
+ var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
9
+ var _react = require("react");
10
+ var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
11
+ var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
12
+ var _useIsFhsEnabled = require("../fhs-rollout/use-is-fhs-enabled");
13
+ /**
14
+ * Returns whether there are any open layers across the specified namespaces, optionally filtered by type.
15
+ */
16
+ function useHasOpenLayers(_ref) {
17
+ var namespaces = _ref.namespaces,
18
+ type = _ref.type;
19
+ var isFhsEnabled = (0, _useIsFhsEnabled.useIsFhsEnabled)();
20
+ var openLayerObserver = (0, _openLayerObserver.useOpenLayerObserver)();
21
+ // Setting the initial state to false, as it is unlikely that there would be any open layers when the app starts.
22
+ var _useState = (0, _react.useState)(false),
23
+ _useState2 = (0, _slicedToArray2.default)(_useState, 2),
24
+ hasOpenLayers = _useState2[0],
25
+ setHasOpenLayers = _useState2[1];
26
+ (0, _react.useEffect)(function () {
27
+ if (!openLayerObserver || !isFhsEnabled || !(0, _platformFeatureFlags.fg)('platform-dst-side-nav-layering-fixes')) {
28
+ return;
29
+ }
30
+ function updateState() {
31
+ if (!openLayerObserver) {
32
+ return;
33
+ }
34
+ var hasAnyOpenLayers = namespaces.some(function (namespace) {
35
+ return openLayerObserver.getCount({
36
+ namespace: namespace,
37
+ type: type
38
+ }) > 0;
39
+ });
40
+ setHasOpenLayers(hasAnyOpenLayers);
41
+ }
42
+
43
+ // Initial check
44
+ updateState();
45
+
46
+ // Subscribe to each namespace
47
+ var cleanups = namespaces.map(function (namespace) {
48
+ return openLayerObserver.onChange(updateState, {
49
+ namespace: namespace
50
+ });
51
+ });
52
+ return function cleanupHook() {
53
+ cleanups.forEach(function (cleanup) {
54
+ return cleanup();
55
+ });
56
+ };
57
+ }, [isFhsEnabled, openLayerObserver, namespaces, type]);
58
+ return hasOpenLayers;
59
+ }
@@ -60,7 +60,13 @@ export const localSlotLayers = {
60
60
  panelSmallViewports: 1
61
61
  };
62
62
  export const openLayerObserverSideNavNamespace = 'side-nav';
63
- export const openLayerObserverTopNavNamespace = 'top-nav';
63
+ // We have separate OpenLayerObserver namespaces for each top nav layout area, instead of a single namespace for the entire top nav,
64
+ // as we need to know if there are open layers in TopNavStart specifically to prevent the side nav from peeking.
65
+ // The OpenLayerObserver doesn't support nested namespaces. We could update it, but for now it's simple enough to just have separate
66
+ // namespaces.
67
+ export const openLayerObserverTopNavStartNamespace = 'top-nav-start';
68
+ export const openLayerObserverTopNavMiddleNamespace = 'top-nav-middle';
69
+ export const openLayerObserverTopNavEndNamespace = 'top-nav-end';
64
70
 
65
71
  /**
66
72
  * CSS scroll timeline variable for the side nav content scroll indicator.
@@ -1,12 +1,27 @@
1
- import React, { useContext, useEffect, useState } from 'react';
1
+ import React, { useContext } from 'react';
2
2
  import invariant from 'tiny-invariant';
3
- import { useOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
4
3
  import { fg } from '@atlaskit/platform-feature-flags';
5
4
  import { useIsFhsEnabled } from '../../fhs-rollout/use-is-fhs-enabled';
6
- import { openLayerObserverSideNavNamespace, openLayerObserverTopNavNamespace, sideNavPanelSplitterId } from '../constants';
5
+ import { openLayerObserverSideNavNamespace, openLayerObserverTopNavEndNamespace, openLayerObserverTopNavMiddleNamespace, openLayerObserverTopNavStartNamespace, sideNavPanelSplitterId } from '../constants';
7
6
  import { useToggleSideNav } from '../side-nav/use-toggle-side-nav';
7
+ import { useHasOpenLayers } from '../use-open-layer-count';
8
8
  import { OnDoubleClickContext, PanelSplitterContext } from './context';
9
9
  import { PanelSplitter } from './panel-splitter';
10
+
11
+ /**
12
+ * Namespaces to check for open layers that would interfere with the panel splitter.
13
+ *
14
+ * Placed outside the component for stability, as the list is used as an effect dependency.
15
+ */
16
+ const openLayerNamespacesToCheck = [
17
+ // We don't technically need to check the side nav for open layers, as they wouldn't overlay the
18
+ // panel splitter, as it sits within the same stacking context as the side nav. For consistency however,
19
+ // we check it as well.
20
+ openLayerObserverSideNavNamespace,
21
+ // When there is an open layer in the top nav, the top nav is given a higher z-index than the side nav.
22
+ // This means the part of the side nav panel splitter that was sitting above the top nav will no longer
23
+ // be interactive (as it is now behind the top nav). So, we need to disable the entire panel splitter.
24
+ openLayerObserverTopNavStartNamespace, openLayerObserverTopNavMiddleNamespace, openLayerObserverTopNavEndNamespace];
10
25
  /**
11
26
  * _SideNavPanelSplitter_
12
27
  *
@@ -38,51 +53,11 @@ export const SideNavPanelSplitter = ({
38
53
  // The logic and state for disabling the panel splitter when there are open popups
39
54
  // in the side nav or top nav is being placed here, instead of in `SideNav`, to prevent
40
55
  // re-rendering the side nav anytime the number of open popups changes.
41
- const [isEnabled, setIsEnabled] = useState(true);
42
- const openLayerObserver = useOpenLayerObserver();
43
- useEffect(() => {
44
- if (!openLayerObserver || !isFhsEnabled || !fg('platform-dst-side-nav-layering-fixes')) {
45
- return;
46
- }
47
- function checkAndSetState() {
48
- if (!openLayerObserver) {
49
- return;
50
- }
51
-
52
- // We don't technically need to check the side nav for open layers, as they wouldn't overlay the
53
- // panel splitter, as it sits within the same stacking context as the side nav. For consistency however,
54
- // we check it as well.
55
- const openPopupsInSideNav = openLayerObserver.getCount({
56
- namespace: openLayerObserverSideNavNamespace,
57
- type: 'popup'
58
- });
59
-
60
- // When there is an open layer in the top nav, the top nav is given a higher z-index than the side nav.
61
- // This means the part of the side nav panel splitter that was sitting above the top nav will no longer
62
- // be interactive (as it is now behind the top nav). So, we need to disable the entire panel splitter.
63
- const openPopupsInTopNav = openLayerObserver.getCount({
64
- namespace: openLayerObserverTopNavNamespace,
65
- type: 'popup'
66
- });
67
- setIsEnabled(openPopupsInSideNav + openPopupsInTopNav === 0);
68
- }
69
-
70
- // Initial check, in case the app has loaded with an open popup.
71
- checkAndSetState();
72
-
73
- // Creating separate listeners for each namespace, to avoid running them when layers in other parts of the app change.
74
- const cleanupSideNavListener = openLayerObserver.onChange(checkAndSetState, {
75
- namespace: openLayerObserverSideNavNamespace
76
- });
77
- const cleanupTopNavListener = openLayerObserver.onChange(checkAndSetState, {
78
- namespace: openLayerObserverTopNavNamespace
79
- });
80
- return function cleanup() {
81
- cleanupSideNavListener();
82
- cleanupTopNavListener();
83
- };
84
- }, [isFhsEnabled, openLayerObserver]);
85
- if (!isEnabled && isFhsEnabled && fg('platform-dst-side-nav-layering-fixes')) {
56
+ const hasOpenLayers = useHasOpenLayers({
57
+ namespaces: openLayerNamespacesToCheck,
58
+ type: 'popup'
59
+ });
60
+ if (hasOpenLayers && isFhsEnabled && fg('platform-dst-side-nav-layering-fixes')) {
86
61
  return null;
87
62
  }
88
63
  return /*#__PURE__*/React.createElement(OnDoubleClickContext.Provider, {
@@ -199,6 +199,13 @@ function SideNavInternal({
199
199
  }
200
200
  }
201
201
  function open() {
202
+ // Prevent the flyout from being opened if there are any open layers in the top nav start
203
+ if (openLayerObserver && openLayerObserver.getCount({
204
+ namespace: 'top-nav-start',
205
+ type: 'popup'
206
+ }) > 0 && fg('platform_dst_nav4_side_nav_resize_tooltip_feedback')) {
207
+ return;
208
+ }
202
209
  const prevFlyoutState = flyoutStateRef.current;
203
210
  tryAbortPendingClose();
204
211
  flyoutStateRef.current = {
@@ -9,4 +9,4 @@
9
9
  ._lcxv1wug{pointer-events:auto}
10
10
  ._y4tiutpp{padding-inline-end:var(--ds-space-150,9pt)}
11
11
  @media (min-width:48rem){._181n1txw{display:flex}._1d2y1ris{min-width:max-content}}
12
- @media (min-width:64rem){._15rip2n4{min-width:330px}._glte1ris{width:max-content}._15ri1mjv{min-width:300px}._1gs5usvi{box-sizing:border-box}._ndwch9n0{justify-self:end}}
12
+ @media (min-width:64rem){._glte1ris{width:max-content}._15rip2n4{min-width:330px}._1gs5usvi{box-sizing:border-box}._ndwch9n0{justify-self:end}}