@atlaskit/navigation-system 5.16.0 → 5.18.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (44) hide show
  1. package/CHANGELOG.md +30 -0
  2. package/dist/cjs/ui/menu-item/flyout-menu-item/flyout-header.js +3 -1
  3. package/dist/cjs/ui/menu-item/flyout-menu-item/flyout-menu-item-content.js +8 -3
  4. package/dist/cjs/ui/menu-item/flyout-menu-item/flyout-menu-item-context.js +21 -2
  5. package/dist/cjs/ui/menu-item/flyout-menu-item/flyout-menu-item.js +3 -1
  6. package/dist/cjs/ui/page-layout/constants.js +8 -2
  7. package/dist/cjs/ui/page-layout/panel-splitter/side-nav-panel-splitter.js +20 -50
  8. package/dist/cjs/ui/page-layout/side-nav/side-nav.js +7 -0
  9. package/dist/cjs/ui/page-layout/top-nav/top-nav-end.js +16 -8
  10. package/dist/cjs/ui/page-layout/top-nav/top-nav-middle.js +5 -1
  11. package/dist/cjs/ui/page-layout/top-nav/top-nav-start.js +4 -1
  12. package/dist/cjs/ui/page-layout/top-nav/top-nav.js +14 -33
  13. package/dist/cjs/ui/page-layout/use-open-layer-count.js +59 -0
  14. package/dist/es2019/ui/menu-item/flyout-menu-item/flyout-header.js +4 -2
  15. package/dist/es2019/ui/menu-item/flyout-menu-item/flyout-menu-item-content.js +10 -5
  16. package/dist/es2019/ui/menu-item/flyout-menu-item/flyout-menu-item-context.js +18 -1
  17. package/dist/es2019/ui/menu-item/flyout-menu-item/flyout-menu-item.js +3 -1
  18. package/dist/es2019/ui/page-layout/constants.js +7 -1
  19. package/dist/es2019/ui/page-layout/panel-splitter/side-nav-panel-splitter.js +23 -48
  20. package/dist/es2019/ui/page-layout/side-nav/side-nav.js +7 -0
  21. package/dist/es2019/ui/page-layout/top-nav/top-nav-end.js +11 -2
  22. package/dist/es2019/ui/page-layout/top-nav/top-nav-middle.js +5 -1
  23. package/dist/es2019/ui/page-layout/top-nav/top-nav-start.js +5 -2
  24. package/dist/es2019/ui/page-layout/top-nav/top-nav.js +17 -31
  25. package/dist/es2019/ui/page-layout/use-open-layer-count.js +44 -0
  26. package/dist/esm/ui/menu-item/flyout-menu-item/flyout-header.js +4 -2
  27. package/dist/esm/ui/menu-item/flyout-menu-item/flyout-menu-item-content.js +10 -5
  28. package/dist/esm/ui/menu-item/flyout-menu-item/flyout-menu-item-context.js +20 -1
  29. package/dist/esm/ui/menu-item/flyout-menu-item/flyout-menu-item.js +3 -1
  30. package/dist/esm/ui/page-layout/constants.js +7 -1
  31. package/dist/esm/ui/page-layout/panel-splitter/side-nav-panel-splitter.js +23 -52
  32. package/dist/esm/ui/page-layout/side-nav/side-nav.js +7 -0
  33. package/dist/esm/ui/page-layout/top-nav/top-nav-end.js +16 -8
  34. package/dist/esm/ui/page-layout/top-nav/top-nav-middle.js +5 -1
  35. package/dist/esm/ui/page-layout/top-nav/top-nav-start.js +5 -2
  36. package/dist/esm/ui/page-layout/top-nav/top-nav.js +17 -35
  37. package/dist/esm/ui/page-layout/use-open-layer-count.js +53 -0
  38. package/dist/types/ui/menu-item/flyout-menu-item/flyout-menu-item-context.d.ts +15 -0
  39. package/dist/types/ui/page-layout/constants.d.ts +3 -1
  40. package/dist/types/ui/page-layout/use-open-layer-count.d.ts +8 -0
  41. package/dist/types-ts4.5/ui/menu-item/flyout-menu-item/flyout-menu-item-context.d.ts +15 -0
  42. package/dist/types-ts4.5/ui/page-layout/constants.d.ts +3 -1
  43. package/dist/types-ts4.5/ui/page-layout/use-open-layer-count.d.ts +8 -0
  44. package/package.json +9 -6
@@ -60,7 +60,13 @@ export const localSlotLayers = {
60
60
  panelSmallViewports: 1
61
61
  };
62
62
  export const openLayerObserverSideNavNamespace = 'side-nav';
63
- export const openLayerObserverTopNavNamespace = 'top-nav';
63
+ // We have separate OpenLayerObserver namespaces for each top nav layout area, instead of a single namespace for the entire top nav,
64
+ // as we need to know if there are open layers in TopNavStart specifically to prevent the side nav from peeking.
65
+ // The OpenLayerObserver doesn't support nested namespaces. We could update it, but for now it's simple enough to just have separate
66
+ // namespaces.
67
+ export const openLayerObserverTopNavStartNamespace = 'top-nav-start';
68
+ export const openLayerObserverTopNavMiddleNamespace = 'top-nav-middle';
69
+ export const openLayerObserverTopNavEndNamespace = 'top-nav-end';
64
70
 
65
71
  /**
66
72
  * CSS scroll timeline variable for the side nav content scroll indicator.
@@ -1,12 +1,27 @@
1
- import React, { useContext, useEffect, useState } from 'react';
1
+ import React, { useContext } from 'react';
2
2
  import invariant from 'tiny-invariant';
3
- import { useOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
4
3
  import { fg } from '@atlaskit/platform-feature-flags';
5
4
  import { useIsFhsEnabled } from '../../fhs-rollout/use-is-fhs-enabled';
6
- import { openLayerObserverSideNavNamespace, openLayerObserverTopNavNamespace, sideNavPanelSplitterId } from '../constants';
5
+ import { openLayerObserverSideNavNamespace, openLayerObserverTopNavEndNamespace, openLayerObserverTopNavMiddleNamespace, openLayerObserverTopNavStartNamespace, sideNavPanelSplitterId } from '../constants';
7
6
  import { useToggleSideNav } from '../side-nav/use-toggle-side-nav';
7
+ import { useHasOpenLayers } from '../use-open-layer-count';
8
8
  import { OnDoubleClickContext, PanelSplitterContext } from './context';
9
9
  import { PanelSplitter } from './panel-splitter';
10
+
11
+ /**
12
+ * Namespaces to check for open layers that would interfere with the panel splitter.
13
+ *
14
+ * Placed outside the component for stability, as the list is used as an effect dependency.
15
+ */
16
+ const openLayerNamespacesToCheck = [
17
+ // We don't technically need to check the side nav for open layers, as they wouldn't overlay the
18
+ // panel splitter, as it sits within the same stacking context as the side nav. For consistency however,
19
+ // we check it as well.
20
+ openLayerObserverSideNavNamespace,
21
+ // When there is an open layer in the top nav, the top nav is given a higher z-index than the side nav.
22
+ // This means the part of the side nav panel splitter that was sitting above the top nav will no longer
23
+ // be interactive (as it is now behind the top nav). So, we need to disable the entire panel splitter.
24
+ openLayerObserverTopNavStartNamespace, openLayerObserverTopNavMiddleNamespace, openLayerObserverTopNavEndNamespace];
10
25
  /**
11
26
  * _SideNavPanelSplitter_
12
27
  *
@@ -38,51 +53,11 @@ export const SideNavPanelSplitter = ({
38
53
  // The logic and state for disabling the panel splitter when there are open popups
39
54
  // in the side nav or top nav is being placed here, instead of in `SideNav`, to prevent
40
55
  // re-rendering the side nav anytime the number of open popups changes.
41
- const [isEnabled, setIsEnabled] = useState(true);
42
- const openLayerObserver = useOpenLayerObserver();
43
- useEffect(() => {
44
- if (!openLayerObserver || !isFhsEnabled || !fg('platform-dst-side-nav-layering-fixes')) {
45
- return;
46
- }
47
- function checkAndSetState() {
48
- if (!openLayerObserver) {
49
- return;
50
- }
51
-
52
- // We don't technically need to check the side nav for open layers, as they wouldn't overlay the
53
- // panel splitter, as it sits within the same stacking context as the side nav. For consistency however,
54
- // we check it as well.
55
- const openPopupsInSideNav = openLayerObserver.getCount({
56
- namespace: openLayerObserverSideNavNamespace,
57
- type: 'popup'
58
- });
59
-
60
- // When there is an open layer in the top nav, the top nav is given a higher z-index than the side nav.
61
- // This means the part of the side nav panel splitter that was sitting above the top nav will no longer
62
- // be interactive (as it is now behind the top nav). So, we need to disable the entire panel splitter.
63
- const openPopupsInTopNav = openLayerObserver.getCount({
64
- namespace: openLayerObserverTopNavNamespace,
65
- type: 'popup'
66
- });
67
- setIsEnabled(openPopupsInSideNav + openPopupsInTopNav === 0);
68
- }
69
-
70
- // Initial check, in case the app has loaded with an open popup.
71
- checkAndSetState();
72
-
73
- // Creating separate listeners for each namespace, to avoid running them when layers in other parts of the app change.
74
- const cleanupSideNavListener = openLayerObserver.onChange(checkAndSetState, {
75
- namespace: openLayerObserverSideNavNamespace
76
- });
77
- const cleanupTopNavListener = openLayerObserver.onChange(checkAndSetState, {
78
- namespace: openLayerObserverTopNavNamespace
79
- });
80
- return function cleanup() {
81
- cleanupSideNavListener();
82
- cleanupTopNavListener();
83
- };
84
- }, [isFhsEnabled, openLayerObserver]);
85
- if (!isEnabled && isFhsEnabled && fg('platform-dst-side-nav-layering-fixes')) {
56
+ const hasOpenLayers = useHasOpenLayers({
57
+ namespaces: openLayerNamespacesToCheck,
58
+ type: 'popup'
59
+ });
60
+ if (hasOpenLayers && isFhsEnabled && fg('platform-dst-side-nav-layering-fixes')) {
86
61
  return null;
87
62
  }
88
63
  return /*#__PURE__*/React.createElement(OnDoubleClickContext.Provider, {
@@ -199,6 +199,13 @@ function SideNavInternal({
199
199
  }
200
200
  }
201
201
  function open() {
202
+ // Prevent the flyout from being opened if there are any open layers in the top nav start
203
+ if (openLayerObserver && openLayerObserver.getCount({
204
+ namespace: 'top-nav-start',
205
+ type: 'popup'
206
+ }) > 0 && fg('platform_dst_nav4_side_nav_resize_tooltip_feedback')) {
207
+ return;
208
+ }
202
209
  const prevFlyoutState = flyoutStateRef.current;
203
210
  tryAbortPendingClose();
204
211
  flyoutStateRef.current = {
@@ -6,6 +6,7 @@ import React, { useState } from 'react';
6
6
  import { cx } from '@compiled/react';
7
7
  import { useLayoutEffect } from '@atlaskit/ds-lib/use-layout-effect';
8
8
  import ShowMoreHorizontalIcon from '@atlaskit/icon/core/show-more-horizontal';
9
+ import { OpenLayerObserverNamespaceProvider } from '@atlaskit/layering/experimental/open-layer-observer';
9
10
  import { fg } from '@atlaskit/platform-feature-flags';
10
11
  import Popup from '@atlaskit/popup';
11
12
  import { UNSAFE_useMediaQuery as useMediaQuery } from '@atlaskit/primitives/compiled';
@@ -13,6 +14,7 @@ import { List } from '../../../components/list';
13
14
  import { useIsFhsEnabled } from '../../fhs-rollout/use-is-fhs-enabled';
14
15
  import { HasCustomThemeContext } from '../../top-nav-items/themed/has-custom-theme-context';
15
16
  import { IconButton } from '../../top-nav-items/themed/migration';
17
+ import { openLayerObserverTopNavEndNamespace } from '../constants';
16
18
  const containerStyles = {
17
19
  root: "_yyhy11wp _1e0c1txw _1bahh9n0 _1ul9zwfg _1d2y1ris _glte1ris _15ri1mjv _1gs5usvi _ndwch9n0",
18
20
  jiraProductLogoUpdate: "_15rip2n4",
@@ -24,6 +26,13 @@ const listStyles = {
24
26
  hideOnSmallViewport: "_1e0cglyw _181n1txw",
25
27
  popupContainer: "_1yt4u2gc"
26
28
  };
29
+ function OpenLayerObserverNamespaceProviderBehindFG({
30
+ children
31
+ }) {
32
+ return fg('platform-dst-side-nav-layering-fixes') ? /*#__PURE__*/React.createElement(OpenLayerObserverNamespaceProvider, {
33
+ namespace: openLayerObserverTopNavEndNamespace
34
+ }, children) : children;
35
+ }
27
36
 
28
37
  /**
29
38
  * __TopNavEnd__
@@ -67,7 +76,7 @@ export function TopNavEnd({
67
76
  value: false
68
77
  }, /*#__PURE__*/React.createElement(List, {
69
78
  xcss: cx(listStyles.root, listStyles.popupContainer)
70
- }, children)),
79
+ }, /*#__PURE__*/React.createElement(OpenLayerObserverNamespaceProviderBehindFG, null, children))),
71
80
  trigger: triggerProps => /*#__PURE__*/React.createElement(IconButton, _extends({}, triggerProps, {
72
81
  label: showMoreButtonLabel,
73
82
  isSelected: isOpen,
@@ -77,5 +86,5 @@ export function TopNavEnd({
77
86
  }))
78
87
  }) : /*#__PURE__*/React.createElement(List, {
79
88
  xcss: cx(listStyles.root, listStyles.hideOnSmallViewport)
80
- }, children));
89
+ }, /*#__PURE__*/React.createElement(OpenLayerObserverNamespaceProviderBehindFG, null, children)));
81
90
  }
@@ -2,8 +2,10 @@
2
2
  import "./top-nav-middle.compiled.css";
3
3
  import { ax, ix } from "@compiled/react/runtime";
4
4
  import React from 'react';
5
+ import { OpenLayerObserverNamespaceProvider } from '@atlaskit/layering/experimental/open-layer-observer';
5
6
  import { fg } from '@atlaskit/platform-feature-flags';
6
7
  import { useIsFhsEnabled } from '../../fhs-rollout/use-is-fhs-enabled';
8
+ import { openLayerObserverTopNavMiddleNamespace } from '../constants';
7
9
  const styles = {
8
10
  root: "_zulpu2gc _yyhycs5v _1bsb1osq _4cvr1h6o _1e0c1txw _1bahh9n0 _181n11p5 _1j8b15b0 _lagd1bp4 _1t4c1ris _12e8h9n0",
9
11
  fullHeightSidebar: "_lcxv1wug"
@@ -23,5 +25,7 @@ export function TopNavMiddle({
23
25
  const isFhsEnabled = useIsFhsEnabled();
24
26
  return /*#__PURE__*/React.createElement("div", {
25
27
  className: ax([styles.root, isFhsEnabled && !fg('platform-dst-side-nav-layering-fixes') && styles.fullHeightSidebar])
26
- }, children);
28
+ }, fg('platform-dst-side-nav-layering-fixes') ? /*#__PURE__*/React.createElement(OpenLayerObserverNamespaceProvider, {
29
+ namespace: openLayerObserverTopNavMiddleNamespace
30
+ }, children) : children);
27
31
  }
@@ -3,11 +3,12 @@ import "./top-nav-start.compiled.css";
3
3
  import { ax, ix } from "@compiled/react/runtime";
4
4
  import React, { forwardRef, useContext, useEffect, useLayoutEffect, useRef, useState } from 'react';
5
5
  import useStableRef from '@atlaskit/ds-lib/use-stable-ref';
6
+ import { OpenLayerObserverNamespaceProvider } from '@atlaskit/layering/experimental/open-layer-observer';
6
7
  import { fg } from '@atlaskit/platform-feature-flags';
7
8
  import { UNSAFE_useMediaQuery } from '@atlaskit/primitives/compiled';
8
9
  import { TopNavStartAttachRef } from '../../../context/top-nav-start/top-nav-start-context';
9
10
  import { useIsFhsEnabled } from '../../fhs-rollout/use-is-fhs-enabled';
10
- import { sideNavContentScrollTimelineVar } from '../constants';
11
+ import { openLayerObserverTopNavStartNamespace, sideNavContentScrollTimelineVar } from '../constants';
11
12
  import { useSideNavVisibility } from '../side-nav/use-side-nav-visibility';
12
13
  import { SideNavVisibilityState } from '../side-nav/visibility-context';
13
14
 
@@ -147,7 +148,9 @@ const TopNavStartInnerFHS = /*#__PURE__*/forwardRef(function TopNavStartInnerFHS
147
148
  ref: ref,
148
149
  "data-testid": testId,
149
150
  className: ax([innerStyles.root, !fg('platform-dst-side-nav-layering-fixes') && innerStyles.fullHeightSidebar, fg('team25-eu-jira-logo-updates-csm-jsm') && innerStyles.jiraProductLogoUpdate, isExpandedOnDesktop && innerStyles.fullHeightSidebarExpanded])
150
- }, children));
151
+ }, fg('platform-dst-side-nav-layering-fixes') ? /*#__PURE__*/React.createElement(OpenLayerObserverNamespaceProvider, {
152
+ namespace: openLayerObserverTopNavStartNamespace
153
+ }, children) : children));
151
154
  });
152
155
 
153
156
  /**
@@ -2,18 +2,19 @@
2
2
  import "./top-nav.compiled.css";
3
3
  import * as React from 'react';
4
4
  import { ax, ix } from "@compiled/react/runtime";
5
- import { useContext, useLayoutEffect, useMemo, useState } from 'react';
6
- import { OpenLayerObserverNamespaceProvider, useOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
5
+ import { useContext, useMemo } from 'react';
7
6
  import { fg } from '@atlaskit/platform-feature-flags';
8
7
  import { useSkipLink } from '../../../context/skip-links/skip-links-context';
9
8
  import { useIsFhsEnabled } from '../../fhs-rollout/use-is-fhs-enabled';
10
9
  import { HasCustomThemeContext } from '../../top-nav-items/themed/has-custom-theme-context';
11
10
  import { useCustomTheme } from '../../top-nav-items/themed/use-custom-theme';
12
- import { bannerMountedVar, localSlotLayers, openLayerObserverTopNavNamespace, sideNavLiveWidthVar, topNavMountedVar, UNSAFE_topNavVar } from '../constants';
11
+ import { bannerMountedVar, localSlotLayers, openLayerObserverTopNavEndNamespace, openLayerObserverTopNavMiddleNamespace, openLayerObserverTopNavStartNamespace, sideNavLiveWidthVar, topNavMountedVar, UNSAFE_topNavVar } from '../constants';
13
12
  import { DangerouslyHoistSlotSizes } from '../hoist-slot-sizes-context';
14
13
  import { DangerouslyHoistCssVarToDocumentRoot, HoistCssVarToLocalGrid } from '../hoist-utils';
15
14
  import { useLayoutId } from '../id-utils';
16
15
  import { useSideNavVisibility } from '../side-nav/use-side-nav-visibility';
16
+ import { useHasOpenLayers } from '../use-open-layer-count';
17
+
17
18
  /**
18
19
  * Styles for the container for the top nav items.
19
20
  *
@@ -40,6 +41,14 @@ const backgroundStyles = {
40
41
  sideNavExpanded: "_hyzqcs5v"
41
42
  };
42
43
 
44
+ /**
45
+ * Namespaces to check for open layers within the top nav.
46
+ * When there is an open layer in the top nav, the top nav is given a higher z-index than the side nav.
47
+ *
48
+ * Placed outside the component for stability, as the list is used as an effect dependency.
49
+ */
50
+ const topNavOpenLayerNamespaces = [openLayerObserverTopNavStartNamespace, openLayerObserverTopNavMiddleNamespace, openLayerObserverTopNavEndNamespace];
51
+
43
52
  /**
44
53
  * The top nav layout area. It will display at the top of the screen, below the banner if one is present.
45
54
  */
@@ -93,31 +102,10 @@ export function TopNav({
93
102
  const {
94
103
  isExpandedOnDesktop
95
104
  } = useSideNavVisibility();
96
- const openLayerObserver = useOpenLayerObserver();
97
- // Setting the initial state to false, as it is unlikely that the top nav would have an open popup when the app starts.
98
- const [hasOpenPopup, setHasOpenPopup] = useState(false);
99
- useLayoutEffect(() => {
100
- if (!openLayerObserver || !isFhsEnabled || !fg('platform-dst-side-nav-layering-fixes')) {
101
- return;
102
- }
103
- function checkAndSetState() {
104
- if (!openLayerObserver) {
105
- return;
106
- }
107
- setHasOpenPopup(openLayerObserver.getCount({
108
- namespace: openLayerObserverTopNavNamespace,
109
- type: 'popup'
110
- }) > 0);
111
- }
112
-
113
- // Initial check
114
- checkAndSetState();
115
-
116
- // Check again whenever number of layers in the top nav change
117
- return openLayerObserver.onChange(checkAndSetState, {
118
- namespace: openLayerObserverTopNavNamespace
119
- });
120
- }, [isFhsEnabled, openLayerObserver]);
105
+ const hasOpenPopup = useHasOpenLayers({
106
+ namespaces: topNavOpenLayerNamespaces,
107
+ type: 'popup'
108
+ });
121
109
  return /*#__PURE__*/React.createElement(HasCustomThemeContext.Provider, {
122
110
  value: customTheme.isEnabled
123
111
  }, isFhsEnabled && !fg('platform-dst-side-nav-layering-fixes') && /*#__PURE__*/React.createElement("div", {
@@ -150,7 +138,5 @@ export function TopNav({
150
138
  value: height
151
139
  })
152
140
  // ------ END UNSAFE STYLES ------
153
- , fg('platform-dst-side-nav-layering-fixes') ? /*#__PURE__*/React.createElement(OpenLayerObserverNamespaceProvider, {
154
- namespace: openLayerObserverTopNavNamespace
155
- }, children) : children));
141
+ , children));
156
142
  }
@@ -0,0 +1,44 @@
1
+ import { useEffect, useState } from 'react';
2
+ import { useOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
3
+ import { fg } from '@atlaskit/platform-feature-flags';
4
+ import { useIsFhsEnabled } from '../fhs-rollout/use-is-fhs-enabled';
5
+
6
+ /**
7
+ * Returns whether there are any open layers across the specified namespaces, optionally filtered by type.
8
+ */
9
+ export function useHasOpenLayers({
10
+ namespaces,
11
+ type
12
+ }) {
13
+ const isFhsEnabled = useIsFhsEnabled();
14
+ const openLayerObserver = useOpenLayerObserver();
15
+ // Setting the initial state to false, as it is unlikely that there would be any open layers when the app starts.
16
+ const [hasOpenLayers, setHasOpenLayers] = useState(false);
17
+ useEffect(() => {
18
+ if (!openLayerObserver || !isFhsEnabled || !fg('platform-dst-side-nav-layering-fixes')) {
19
+ return;
20
+ }
21
+ function updateState() {
22
+ if (!openLayerObserver) {
23
+ return;
24
+ }
25
+ const hasAnyOpenLayers = namespaces.some(namespace => openLayerObserver.getCount({
26
+ namespace,
27
+ type
28
+ }) > 0);
29
+ setHasOpenLayers(hasAnyOpenLayers);
30
+ }
31
+
32
+ // Initial check
33
+ updateState();
34
+
35
+ // Subscribe to each namespace
36
+ const cleanups = namespaces.map(namespace => openLayerObserver.onChange(updateState, {
37
+ namespace
38
+ }));
39
+ return function cleanupHook() {
40
+ cleanups.forEach(cleanup => cleanup());
41
+ };
42
+ }, [isFhsEnabled, openLayerObserver, namespaces, type]);
43
+ return hasOpenLayers;
44
+ }
@@ -5,7 +5,7 @@ import React, { useCallback, useContext } from 'react';
5
5
  import Heading from '@atlaskit/heading';
6
6
  import { Flex } from '@atlaskit/primitives/compiled';
7
7
  import { CloseButton } from './close-button';
8
- import { OnCloseContext, SetIsOpenContext } from './flyout-menu-item-context';
8
+ import { OnCloseContext, SetIsOpenContext, useTitleId } from './flyout-menu-item-context';
9
9
  var headerStyles = {
10
10
  root: "_zulp12x7 _bozg1b66 _85i512x7 _1e0c1txw _2lx21bp4",
11
11
  flex: "_zulppxbi _1bah1yb4 _2lx21sbv _4cvr1h6o _1bsb1osq _bozgv77o"
@@ -22,6 +22,7 @@ export var FlyoutHeader = function FlyoutHeader(props) {
22
22
  testId = props.testId,
23
23
  title = props.title,
24
24
  closeButtonLabel = props.closeButtonLabel;
25
+ var id = useTitleId();
25
26
  var setIsOpen = useContext(SetIsOpenContext);
26
27
  var onClose = useContext(OnCloseContext);
27
28
  var handleClose = useCallback(function () {
@@ -39,6 +40,7 @@ export var FlyoutHeader = function FlyoutHeader(props) {
39
40
  testId: testId && "".concat(testId, "--close-button")
40
41
  }), /*#__PURE__*/React.createElement(Heading, {
41
42
  size: "xsmall",
42
- as: "span"
43
+ as: "span",
44
+ id: id
43
45
  }, title)), children);
44
46
  };
@@ -2,11 +2,11 @@
2
2
  import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
3
3
  import "./flyout-menu-item-content.compiled.css";
4
4
  import { ax, ix } from "@compiled/react/runtime";
5
- import React, { forwardRef, useCallback, useContext, useEffect, useMemo, useRef, useState } from 'react';
5
+ import React, { forwardRef, useCallback, useContext, useEffect, useId, useMemo, useRef, useState } from 'react';
6
6
  import mergeRefs from '@atlaskit/ds-lib/merge-refs';
7
7
  import { fg } from '@atlaskit/platform-feature-flags';
8
8
  import { PopupContent } from '@atlaskit/popup/experimental';
9
- import { OnCloseProvider, SetIsOpenContext } from './flyout-menu-item-context';
9
+ import { OnCloseProvider, SetIsOpenContext, TitleIdContextProvider } from './flyout-menu-item-context';
10
10
 
11
11
  /**
12
12
  * The vertical offset in px to ensure the flyout container does not exceed the bounds of
@@ -42,6 +42,7 @@ export var FlyoutMenuItemContent = /*#__PURE__*/forwardRef(function (_ref, forwa
42
42
  onClose === null || onClose === void 0 || onClose();
43
43
  setIsOpen(false);
44
44
  }, [setIsOpen, onClose]);
45
+ var titleId = useId();
45
46
  return /*#__PURE__*/React.createElement(PopupContent, {
46
47
  appearance: "UNSAFE_modal-below-sm",
47
48
  onClose: handleClose,
@@ -54,7 +55,9 @@ export var FlyoutMenuItemContent = /*#__PURE__*/forwardRef(function (_ref, forwa
54
55
  shouldFitViewport: true,
55
56
  testId: containerTestId,
56
57
  xcss: flyoutMenuItemContentStyles.root,
57
- autoFocus: autoFocus
58
+ autoFocus: autoFocus,
59
+ role: fg("platform_dst_nav4_flyout_menu_slots_close_button") ? "dialog" : undefined,
60
+ titleId: fg("platform_dst_nav4_flyout_menu_slots_close_button") ? titleId : undefined
58
61
  /**
59
62
  * Disabling GPU acceleration removes the use of `transform` by popper.js for this popup.
60
63
  *
@@ -75,13 +78,15 @@ export var FlyoutMenuItemContent = /*#__PURE__*/forwardRef(function (_ref, forwa
75
78
  return /*#__PURE__*/React.createElement(UpdatePopperOnContentResize, {
76
79
  ref: forwardedRef,
77
80
  update: update
78
- }, fg("platform_dst_nav4_flyout_menu_slots_close_button") ? /*#__PURE__*/React.createElement(OnCloseProvider, {
81
+ }, fg("platform_dst_nav4_flyout_menu_slots_close_button") ? /*#__PURE__*/React.createElement(TitleIdContextProvider, {
82
+ value: titleId
83
+ }, /*#__PURE__*/React.createElement(OnCloseProvider, {
79
84
  value: function value() {
80
85
  return onClose;
81
86
  }
82
87
  }, /*#__PURE__*/React.createElement("div", {
83
88
  className: ax([flyoutMenuItemContentContainerStyles.container])
84
- }, children)) : children);
89
+ }, children))) : children);
85
90
  });
86
91
  });
87
92
  function createResizeObserver(update) {
@@ -33,4 +33,23 @@ export var OnCloseContext = /*#__PURE__*/createContext(null);
33
33
  *
34
34
  * A context provider for supplying the onClose function to the FlyoutHeader.
35
35
  */
36
- export var OnCloseProvider = OnCloseContext.Provider;
36
+ export var OnCloseProvider = OnCloseContext.Provider;
37
+
38
+ /**
39
+ * __Title id context__
40
+ *
41
+ * A context for storing the title id of the FlyoutMenuItem that is displayed in
42
+ * FlyoutHeader, and used as the aria-labelledby on the FlyoutMenuItemContent
43
+ * container.
44
+ */
45
+ export var TitleIdContext = /*#__PURE__*/createContext(undefined);
46
+ export var useTitleId = function useTitleId() {
47
+ return useContext(TitleIdContext);
48
+ };
49
+
50
+ /**
51
+ * __Title id provider__
52
+ *
53
+ * A context provider for supplying the title id to the FlyoutHeader.
54
+ */
55
+ export var TitleIdContextProvider = TitleIdContext.Provider;
@@ -2,6 +2,7 @@ import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
2
2
  import React, { forwardRef, useEffect } from 'react';
3
3
  import useControlled from '@atlaskit/ds-lib/use-controlled';
4
4
  import usePreviousValue from '@atlaskit/ds-lib/use-previous-value';
5
+ import { fg } from '@atlaskit/platform-feature-flags';
5
6
  import { Popup } from '@atlaskit/popup/experimental';
6
7
  import { MenuListItem } from '../menu-list-item';
7
8
  import { IsOpenContext, SetIsOpenContext } from './flyout-menu-item-context';
@@ -60,6 +61,7 @@ export var FlyoutMenuItem = /*#__PURE__*/forwardRef(function (_ref, forwardedRef
60
61
  ref: forwardedRef
61
62
  }, /*#__PURE__*/React.createElement(Popup, {
62
63
  id: id,
63
- isOpen: isOpen
64
+ isOpen: isOpen,
65
+ role: fg('platform_dst_nav4_flyout_menu_slots_close_button') ? 'dialog' : undefined
64
66
  }, children))));
65
67
  });
@@ -60,7 +60,13 @@ export var localSlotLayers = {
60
60
  panelSmallViewports: 1
61
61
  };
62
62
  export var openLayerObserverSideNavNamespace = 'side-nav';
63
- export var openLayerObserverTopNavNamespace = 'top-nav';
63
+ // We have separate OpenLayerObserver namespaces for each top nav layout area, instead of a single namespace for the entire top nav,
64
+ // as we need to know if there are open layers in TopNavStart specifically to prevent the side nav from peeking.
65
+ // The OpenLayerObserver doesn't support nested namespaces. We could update it, but for now it's simple enough to just have separate
66
+ // namespaces.
67
+ export var openLayerObserverTopNavStartNamespace = 'top-nav-start';
68
+ export var openLayerObserverTopNavMiddleNamespace = 'top-nav-middle';
69
+ export var openLayerObserverTopNavEndNamespace = 'top-nav-end';
64
70
 
65
71
  /**
66
72
  * CSS scroll timeline variable for the side nav content scroll indicator.
@@ -1,13 +1,27 @@
1
- import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
2
- import React, { useContext, useEffect, useState } from 'react';
1
+ import React, { useContext } from 'react';
3
2
  import invariant from 'tiny-invariant';
4
- import { useOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
5
3
  import { fg } from '@atlaskit/platform-feature-flags';
6
4
  import { useIsFhsEnabled } from '../../fhs-rollout/use-is-fhs-enabled';
7
- import { openLayerObserverSideNavNamespace, openLayerObserverTopNavNamespace, sideNavPanelSplitterId } from '../constants';
5
+ import { openLayerObserverSideNavNamespace, openLayerObserverTopNavEndNamespace, openLayerObserverTopNavMiddleNamespace, openLayerObserverTopNavStartNamespace, sideNavPanelSplitterId } from '../constants';
8
6
  import { useToggleSideNav } from '../side-nav/use-toggle-side-nav';
7
+ import { useHasOpenLayers } from '../use-open-layer-count';
9
8
  import { OnDoubleClickContext, PanelSplitterContext } from './context';
10
9
  import { PanelSplitter } from './panel-splitter';
10
+
11
+ /**
12
+ * Namespaces to check for open layers that would interfere with the panel splitter.
13
+ *
14
+ * Placed outside the component for stability, as the list is used as an effect dependency.
15
+ */
16
+ var openLayerNamespacesToCheck = [
17
+ // We don't technically need to check the side nav for open layers, as they wouldn't overlay the
18
+ // panel splitter, as it sits within the same stacking context as the side nav. For consistency however,
19
+ // we check it as well.
20
+ openLayerObserverSideNavNamespace,
21
+ // When there is an open layer in the top nav, the top nav is given a higher z-index than the side nav.
22
+ // This means the part of the side nav panel splitter that was sitting above the top nav will no longer
23
+ // be interactive (as it is now behind the top nav). So, we need to disable the entire panel splitter.
24
+ openLayerObserverTopNavStartNamespace, openLayerObserverTopNavMiddleNamespace, openLayerObserverTopNavEndNamespace];
11
25
  /**
12
26
  * _SideNavPanelSplitter_
13
27
  *
@@ -39,54 +53,11 @@ export var SideNavPanelSplitter = function SideNavPanelSplitter(_ref) {
39
53
  // The logic and state for disabling the panel splitter when there are open popups
40
54
  // in the side nav or top nav is being placed here, instead of in `SideNav`, to prevent
41
55
  // re-rendering the side nav anytime the number of open popups changes.
42
- var _useState = useState(true),
43
- _useState2 = _slicedToArray(_useState, 2),
44
- isEnabled = _useState2[0],
45
- setIsEnabled = _useState2[1];
46
- var openLayerObserver = useOpenLayerObserver();
47
- useEffect(function () {
48
- if (!openLayerObserver || !isFhsEnabled || !fg('platform-dst-side-nav-layering-fixes')) {
49
- return;
50
- }
51
- function checkAndSetState() {
52
- if (!openLayerObserver) {
53
- return;
54
- }
55
-
56
- // We don't technically need to check the side nav for open layers, as they wouldn't overlay the
57
- // panel splitter, as it sits within the same stacking context as the side nav. For consistency however,
58
- // we check it as well.
59
- var openPopupsInSideNav = openLayerObserver.getCount({
60
- namespace: openLayerObserverSideNavNamespace,
61
- type: 'popup'
62
- });
63
-
64
- // When there is an open layer in the top nav, the top nav is given a higher z-index than the side nav.
65
- // This means the part of the side nav panel splitter that was sitting above the top nav will no longer
66
- // be interactive (as it is now behind the top nav). So, we need to disable the entire panel splitter.
67
- var openPopupsInTopNav = openLayerObserver.getCount({
68
- namespace: openLayerObserverTopNavNamespace,
69
- type: 'popup'
70
- });
71
- setIsEnabled(openPopupsInSideNav + openPopupsInTopNav === 0);
72
- }
73
-
74
- // Initial check, in case the app has loaded with an open popup.
75
- checkAndSetState();
76
-
77
- // Creating separate listeners for each namespace, to avoid running them when layers in other parts of the app change.
78
- var cleanupSideNavListener = openLayerObserver.onChange(checkAndSetState, {
79
- namespace: openLayerObserverSideNavNamespace
80
- });
81
- var cleanupTopNavListener = openLayerObserver.onChange(checkAndSetState, {
82
- namespace: openLayerObserverTopNavNamespace
83
- });
84
- return function cleanup() {
85
- cleanupSideNavListener();
86
- cleanupTopNavListener();
87
- };
88
- }, [isFhsEnabled, openLayerObserver]);
89
- if (!isEnabled && isFhsEnabled && fg('platform-dst-side-nav-layering-fixes')) {
56
+ var hasOpenLayers = useHasOpenLayers({
57
+ namespaces: openLayerNamespacesToCheck,
58
+ type: 'popup'
59
+ });
60
+ if (hasOpenLayers && isFhsEnabled && fg('platform-dst-side-nav-layering-fixes')) {
90
61
  return null;
91
62
  }
92
63
  return /*#__PURE__*/React.createElement(OnDoubleClickContext.Provider, {
@@ -210,6 +210,13 @@ function SideNavInternal(_ref) {
210
210
  }
211
211
  }
212
212
  function open() {
213
+ // Prevent the flyout from being opened if there are any open layers in the top nav start
214
+ if (openLayerObserver && openLayerObserver.getCount({
215
+ namespace: 'top-nav-start',
216
+ type: 'popup'
217
+ }) > 0 && fg('platform_dst_nav4_side_nav_resize_tooltip_feedback')) {
218
+ return;
219
+ }
213
220
  var prevFlyoutState = flyoutStateRef.current;
214
221
  tryAbortPendingClose();
215
222
  flyoutStateRef.current = {
@@ -7,6 +7,7 @@ import React, { useState } from 'react';
7
7
  import { cx } from '@compiled/react';
8
8
  import { useLayoutEffect } from '@atlaskit/ds-lib/use-layout-effect';
9
9
  import ShowMoreHorizontalIcon from '@atlaskit/icon/core/show-more-horizontal';
10
+ import { OpenLayerObserverNamespaceProvider } from '@atlaskit/layering/experimental/open-layer-observer';
10
11
  import { fg } from '@atlaskit/platform-feature-flags';
11
12
  import Popup from '@atlaskit/popup';
12
13
  import { UNSAFE_useMediaQuery as useMediaQuery } from '@atlaskit/primitives/compiled';
@@ -14,6 +15,7 @@ import { List } from '../../../components/list';
14
15
  import { useIsFhsEnabled } from '../../fhs-rollout/use-is-fhs-enabled';
15
16
  import { HasCustomThemeContext } from '../../top-nav-items/themed/has-custom-theme-context';
16
17
  import { IconButton } from '../../top-nav-items/themed/migration';
18
+ import { openLayerObserverTopNavEndNamespace } from '../constants';
17
19
  var containerStyles = {
18
20
  root: "_yyhy11wp _1e0c1txw _1bahh9n0 _1ul9zwfg _1d2y1ris _glte1ris _15ri1mjv _1gs5usvi _ndwch9n0",
19
21
  jiraProductLogoUpdate: "_15rip2n4",
@@ -25,6 +27,12 @@ var listStyles = {
25
27
  hideOnSmallViewport: "_1e0cglyw _181n1txw",
26
28
  popupContainer: "_1yt4u2gc"
27
29
  };
30
+ function OpenLayerObserverNamespaceProviderBehindFG(_ref) {
31
+ var children = _ref.children;
32
+ return fg('platform-dst-side-nav-layering-fixes') ? /*#__PURE__*/React.createElement(OpenLayerObserverNamespaceProvider, {
33
+ namespace: openLayerObserverTopNavEndNamespace
34
+ }, children) : children;
35
+ }
28
36
 
29
37
  /**
30
38
  * __TopNavEnd__
@@ -34,12 +42,12 @@ var listStyles = {
34
42
  * On small viewports, the children will be placed inside a popup, and a button will be rendered to open the popup.
35
43
  * This is to prevent the actions from overflowing the top navigation.
36
44
  */
37
- export function TopNavEnd(_ref) {
38
- var children = _ref.children,
39
- _ref$label = _ref.label,
40
- label = _ref$label === void 0 ? 'Actions' : _ref$label,
41
- _ref$showMoreButtonLa = _ref.showMoreButtonLabel,
42
- showMoreButtonLabel = _ref$showMoreButtonLa === void 0 ? 'Show more' : _ref$showMoreButtonLa;
45
+ export function TopNavEnd(_ref2) {
46
+ var children = _ref2.children,
47
+ _ref2$label = _ref2.label,
48
+ label = _ref2$label === void 0 ? 'Actions' : _ref2$label,
49
+ _ref2$showMoreButtonL = _ref2.showMoreButtonLabel,
50
+ showMoreButtonLabel = _ref2$showMoreButtonL === void 0 ? 'Show more' : _ref2$showMoreButtonL;
43
51
  var isFhsEnabled = useIsFhsEnabled();
44
52
  var _useState = useState(false),
45
53
  _useState2 = _slicedToArray(_useState, 2),
@@ -78,7 +86,7 @@ export function TopNavEnd(_ref) {
78
86
  value: false
79
87
  }, /*#__PURE__*/React.createElement(List, {
80
88
  xcss: cx(listStyles.root, listStyles.popupContainer)
81
- }, children));
89
+ }, /*#__PURE__*/React.createElement(OpenLayerObserverNamespaceProviderBehindFG, null, children)));
82
90
  },
83
91
  trigger: function trigger(triggerProps) {
84
92
  return /*#__PURE__*/React.createElement(IconButton, _extends({}, triggerProps, {
@@ -93,5 +101,5 @@ export function TopNavEnd(_ref) {
93
101
  }
94
102
  }) : /*#__PURE__*/React.createElement(List, {
95
103
  xcss: cx(listStyles.root, listStyles.hideOnSmallViewport)
96
- }, children));
104
+ }, /*#__PURE__*/React.createElement(OpenLayerObserverNamespaceProviderBehindFG, null, children)));
97
105
  }