@atlaskit/navigation-system 4.0.0 → 4.2.0

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # @atlassian/navigation-system
 
+## 4.2.0
+
+### Minor Changes
+
+- [`5ab567cfb4d29`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/5ab567cfb4d29) -
+  Cleans up the `platform_dst_nav4_panel_splitter_guards` feature gate. Panel splitters will now use
+  a safe fallback default width if the provided default width is not an integer.
+
+### Patch Changes
+
+- Updated dependencies
+
+## 4.1.0
+
+### Minor Changes
+
+- [`d55bbfc88149b`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/d55bbfc88149b) -
+  Removes type support for `@atlaskit/temp-nav-app-icons` package
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 4.0.0
 
 ### Major Changes

package/dist/cjs/ui/page-layout/panel-splitter/get-width.js

@@ -4,7 +4,6 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.getWidthFromDragLocation = exports.getPixelWidth = void 0;
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var getWidthFromDragLocation = exports.getWidthFromDragLocation = function getWidthFromDragLocation(_ref) {
   var initialWidth = _ref.initialWidth,
     location = _ref.location,
@@ -26,11 +25,6 @@ var getWidthFromDragLocation = exports.getWidthFromDragLocation = function getWi
  * Returns the computed width of an element in pixels.
  */
 var getPixelWidth = exports.getPixelWidth = function getPixelWidth(element) {
-  if ((0, _platformFeatureFlags.fg)('platform_dst_nav4_panel_splitter_guards')) {
-    // Always returns an integer. Returns 0 if element is hidden / removed.
-    return element.offsetWidth;
-  }
-  var _window$getComputedSt = window.getComputedStyle(element),
-    width = _window$getComputedSt.width;
-  return parseInt(width);
+  // Always returns an integer. Returns 0 if element is hidden / removed.
+  return element.offsetWidth;
 };

package/dist/cjs/ui/page-layout/use-safe-default-width.js

@@ -4,29 +4,22 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.useSafeDefaultWidth = useSafeDefaultWidth;
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 /**
- * When `platform_dst_nav4_panel_splitter_guards` is disabled,
- * `useSafeDefaultWidth` returns the provided `defaultWidthProp`.
- *
- * When `platform_dst_nav4_panel_splitter_guards` is enabled,
- * `useSafeDefaultWidth` returns the `fallbackWidth` if the provided `defaultWidthProp` is not an integer value.
+ * Returns the `fallbackWidth` if the provided `defaultWidthProp` is not an integer value.
  */
 function useSafeDefaultWidth(_ref) {
   var defaultWidthProp = _ref.defaultWidthProp,
     fallbackDefaultWidth = _ref.fallbackDefaultWidth,
     slotName = _ref.slotName;
-  if ((0, _platformFeatureFlags.fg)('platform_dst_nav4_panel_splitter_guards')) {
-    // If the provided `defaultWidth` is invalid then we use our fallback.
-    // We are using a runtime check because some invalid numbers like `NaN` are not caught by types,
-    // and we saw some issues in products where our experience broke due to this.
-    if (!Number.isInteger(defaultWidthProp)) {
-      if (process.env.NODE_ENV !== 'production') {
-        // eslint-disable-next-line no-console
-        console.error("The defaultWidth value must be an integer, but '".concat(defaultWidthProp, "' was provided to ").concat(slotName, ". Falling back to ").concat(fallbackDefaultWidth, "px instead."));
-      }
-      return fallbackDefaultWidth;
+  // If the provided `defaultWidth` is invalid then we use our fallback.
+  // We are using a runtime check because some invalid numbers like `NaN` are not caught by types,
+  // and we saw some issues in products where our experience broke due to this.
+  if (!Number.isInteger(defaultWidthProp)) {
+    if (process.env.NODE_ENV !== 'production') {
+      // eslint-disable-next-line no-console
+      console.error("The defaultWidth value must be an integer, but '".concat(defaultWidthProp, "' was provided to ").concat(slotName, ". Falling back to ").concat(fallbackDefaultWidth, "px instead."));
     }
+    return fallbackDefaultWidth;
   }
   return defaultWidthProp;
 }

package/dist/es2019/ui/page-layout/panel-splitter/get-width.js

@@ -1,4 +1,3 @@
-import { fg } from '@atlaskit/platform-feature-flags';
 export const getWidthFromDragLocation = ({
   initialWidth,
   location,
@@ -21,12 +20,6 @@ export const getWidthFromDragLocation = ({
  * Returns the computed width of an element in pixels.
  */
 export const getPixelWidth = element => {
-  if (fg('platform_dst_nav4_panel_splitter_guards')) {
-    // Always returns an integer. Returns 0 if element is hidden / removed.
-    return element.offsetWidth;
-  }
-  const {
-    width
-  } = window.getComputedStyle(element);
-  return parseInt(width);
+  // Always returns an integer. Returns 0 if element is hidden / removed.
+  return element.offsetWidth;
 };

package/dist/es2019/ui/page-layout/use-safe-default-width.js

@@ -1,28 +1,20 @@
-import { fg } from '@atlaskit/platform-feature-flags';
-
 /**
- * When `platform_dst_nav4_panel_splitter_guards` is disabled,
- * `useSafeDefaultWidth` returns the provided `defaultWidthProp`.
- *
- * When `platform_dst_nav4_panel_splitter_guards` is enabled,
- * `useSafeDefaultWidth` returns the `fallbackWidth` if the provided `defaultWidthProp` is not an integer value.
+ * Returns the `fallbackWidth` if the provided `defaultWidthProp` is not an integer value.
  */
 export function useSafeDefaultWidth({
   defaultWidthProp,
   fallbackDefaultWidth,
   slotName
 }) {
-  if (fg('platform_dst_nav4_panel_splitter_guards')) {
-    // If the provided `defaultWidth` is invalid then we use our fallback.
-    // We are using a runtime check because some invalid numbers like `NaN` are not caught by types,
-    // and we saw some issues in products where our experience broke due to this.
-    if (!Number.isInteger(defaultWidthProp)) {
-      if (process.env.NODE_ENV !== 'production') {
-        // eslint-disable-next-line no-console
-        console.error(`The defaultWidth value must be an integer, but '${defaultWidthProp}' was provided to ${slotName}. Falling back to ${fallbackDefaultWidth}px instead.`);
-      }
-      return fallbackDefaultWidth;
+  // If the provided `defaultWidth` is invalid then we use our fallback.
+  // We are using a runtime check because some invalid numbers like `NaN` are not caught by types,
+  // and we saw some issues in products where our experience broke due to this.
+  if (!Number.isInteger(defaultWidthProp)) {
+    if (process.env.NODE_ENV !== 'production') {
+      // eslint-disable-next-line no-console
+      console.error(`The defaultWidth value must be an integer, but '${defaultWidthProp}' was provided to ${slotName}. Falling back to ${fallbackDefaultWidth}px instead.`);
     }
+    return fallbackDefaultWidth;
   }
   return defaultWidthProp;
 }

package/dist/esm/ui/page-layout/panel-splitter/get-width.js

@@ -1,4 +1,3 @@
-import { fg } from '@atlaskit/platform-feature-flags';
 export var getWidthFromDragLocation = function getWidthFromDragLocation(_ref) {
   var initialWidth = _ref.initialWidth,
     location = _ref.location,
@@ -20,11 +19,6 @@ export var getWidthFromDragLocation = function getWidthFromDragLocation(_ref) {
  * Returns the computed width of an element in pixels.
  */
 export var getPixelWidth = function getPixelWidth(element) {
-  if (fg('platform_dst_nav4_panel_splitter_guards')) {
-    // Always returns an integer. Returns 0 if element is hidden / removed.
-    return element.offsetWidth;
-  }
-  var _window$getComputedSt = window.getComputedStyle(element),
-    width = _window$getComputedSt.width;
-  return parseInt(width);
+  // Always returns an integer. Returns 0 if element is hidden / removed.
+  return element.offsetWidth;
 };

package/dist/esm/ui/page-layout/use-safe-default-width.js

@@ -1,27 +1,19 @@
-import { fg } from '@atlaskit/platform-feature-flags';
-
 /**
- * When `platform_dst_nav4_panel_splitter_guards` is disabled,
- * `useSafeDefaultWidth` returns the provided `defaultWidthProp`.
- *
- * When `platform_dst_nav4_panel_splitter_guards` is enabled,
- * `useSafeDefaultWidth` returns the `fallbackWidth` if the provided `defaultWidthProp` is not an integer value.
+ * Returns the `fallbackWidth` if the provided `defaultWidthProp` is not an integer value.
  */
 export function useSafeDefaultWidth(_ref) {
   var defaultWidthProp = _ref.defaultWidthProp,
     fallbackDefaultWidth = _ref.fallbackDefaultWidth,
     slotName = _ref.slotName;
-  if (fg('platform_dst_nav4_panel_splitter_guards')) {
-    // If the provided `defaultWidth` is invalid then we use our fallback.
-    // We are using a runtime check because some invalid numbers like `NaN` are not caught by types,
-    // and we saw some issues in products where our experience broke due to this.
-    if (!Number.isInteger(defaultWidthProp)) {
-      if (process.env.NODE_ENV !== 'production') {
-        // eslint-disable-next-line no-console
-        console.error("The defaultWidth value must be an integer, but '".concat(defaultWidthProp, "' was provided to ").concat(slotName, ". Falling back to ").concat(fallbackDefaultWidth, "px instead."));
-      }
-      return fallbackDefaultWidth;
+  // If the provided `defaultWidth` is invalid then we use our fallback.
+  // We are using a runtime check because some invalid numbers like `NaN` are not caught by types,
+  // and we saw some issues in products where our experience broke due to this.
+  if (!Number.isInteger(defaultWidthProp)) {
+    if (process.env.NODE_ENV !== 'production') {
+      // eslint-disable-next-line no-console
+      console.error("The defaultWidth value must be an integer, but '".concat(defaultWidthProp, "' was provided to ").concat(slotName, ". Falling back to ").concat(fallbackDefaultWidth, "px instead."));
     }
+    return fallbackDefaultWidth;
   }
   return defaultWidthProp;
 }

package/dist/types/ui/page-layout/use-safe-default-width.d.ts

@@ -1,9 +1,5 @@
 /**
- * When `platform_dst_nav4_panel_splitter_guards` is disabled,
- * `useSafeDefaultWidth` returns the provided `defaultWidthProp`.
- *
- * When `platform_dst_nav4_panel_splitter_guards` is enabled,
- * `useSafeDefaultWidth` returns the `fallbackWidth` if the provided `defaultWidthProp` is not an integer value.
+ * Returns the `fallbackWidth` if the provided `defaultWidthProp` is not an integer value.
  */
 export declare function useSafeDefaultWidth({ defaultWidthProp, fallbackDefaultWidth, slotName, }: {
     /**

package/dist/types/ui/top-nav-items/nav-logo/custom-logo.d.ts

@@ -4,7 +4,6 @@
  */
 import React from 'react';
 import type { LogoProps } from '@atlaskit/logo';
-import type { IconProps as TempIconProps, LogoProps as TempLogoProps } from '@atlaskit/temp-nav-app-icons/types';
 /**
  * __Custom logo__
  *
@@ -25,11 +24,11 @@ export declare const CustomLogo: ({ href, logo, icon, onClick, label, }: {
     /**
      * The logo component to render. It will be used for large viewports.
      */
-    logo: ((props: LogoProps) => JSX.Element) | ((props: TempLogoProps) => JSX.Element);
+    logo: (props: LogoProps) => JSX.Element;
     /**
      * The icon component to render. It will be used for small viewports.
      */
-    icon: ((props: LogoProps) => JSX.Element) | ((props: TempIconProps) => JSX.Element);
+    icon: (props: LogoProps) => JSX.Element;
     /**
      * Handler called on click.
      */

package/dist/types/ui/top-nav-items/nav-logo/logo-renderer.d.ts

@@ -4,12 +4,11 @@
  */
 import React from 'react';
 import type { LogoProps } from '@atlaskit/logo';
-import type { IconProps as TempIconProps, LogoProps as TempLogoProps } from '@atlaskit/temp-nav-app-icons/types';
 export declare const themedLogoIcon = "--ds-top-bar-logo-icon";
 export declare const themedLogoText = "--ds-top-bar-logo-text";
 export declare function LogoRenderer({ logoOrIcon, shouldUseNewLogoDesign, }: React.ComponentProps<typeof LogoRendererNoMemo>): JSX.Element;
 declare function LogoRendererNoMemo({ logoOrIcon: LogoOrIcon, shouldUseNewLogoDesign, }: {
-    logoOrIcon: ((props: LogoProps) => JSX.Element) | ((props: TempLogoProps) => JSX.Element) | ((props: TempIconProps) => JSX.Element);
+    logoOrIcon: (props: LogoProps) => JSX.Element;
     shouldUseNewLogoDesign?: boolean;
 }): JSX.Element;
 export {};

package/dist/types-ts4.5/ui/page-layout/use-safe-default-width.d.ts

@@ -1,9 +1,5 @@
 /**
- * When `platform_dst_nav4_panel_splitter_guards` is disabled,
- * `useSafeDefaultWidth` returns the provided `defaultWidthProp`.
- *
- * When `platform_dst_nav4_panel_splitter_guards` is enabled,
- * `useSafeDefaultWidth` returns the `fallbackWidth` if the provided `defaultWidthProp` is not an integer value.
+ * Returns the `fallbackWidth` if the provided `defaultWidthProp` is not an integer value.
  */
 export declare function useSafeDefaultWidth({ defaultWidthProp, fallbackDefaultWidth, slotName, }: {
     /**

package/dist/types-ts4.5/ui/top-nav-items/nav-logo/custom-logo.d.ts

@@ -4,7 +4,6 @@
  */
 import React from 'react';
 import type { LogoProps } from '@atlaskit/logo';
-import type { IconProps as TempIconProps, LogoProps as TempLogoProps } from '@atlaskit/temp-nav-app-icons/types';
 /**
  * __Custom logo__
  *
@@ -25,11 +24,11 @@ export declare const CustomLogo: ({ href, logo, icon, onClick, label, }: {
     /**
      * The logo component to render. It will be used for large viewports.
      */
-    logo: ((props: LogoProps) => JSX.Element) | ((props: TempLogoProps) => JSX.Element);
+    logo: (props: LogoProps) => JSX.Element;
     /**
      * The icon component to render. It will be used for small viewports.
      */
-    icon: ((props: LogoProps) => JSX.Element) | ((props: TempIconProps) => JSX.Element);
+    icon: (props: LogoProps) => JSX.Element;
     /**
      * Handler called on click.
      */

package/dist/types-ts4.5/ui/top-nav-items/nav-logo/logo-renderer.d.ts

@@ -4,12 +4,11 @@
  */
 import React from 'react';
 import type { LogoProps } from '@atlaskit/logo';
-import type { IconProps as TempIconProps, LogoProps as TempLogoProps } from '@atlaskit/temp-nav-app-icons/types';
 export declare const themedLogoIcon = "--ds-top-bar-logo-icon";
 export declare const themedLogoText = "--ds-top-bar-logo-text";
 export declare function LogoRenderer({ logoOrIcon, shouldUseNewLogoDesign, }: React.ComponentProps<typeof LogoRendererNoMemo>): JSX.Element;
 declare function LogoRendererNoMemo({ logoOrIcon: LogoOrIcon, shouldUseNewLogoDesign, }: {
-    logoOrIcon: ((props: LogoProps) => JSX.Element) | ((props: TempLogoProps) => JSX.Element) | ((props: TempIconProps) => JSX.Element);
+    logoOrIcon: (props: LogoProps) => JSX.Element;
     shouldUseNewLogoDesign?: boolean;
 }): JSX.Element;
 export {};

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/navigation-system",
-	"version": "4.0.0",
+	"version": "4.2.0",
 	"description": "The latest navigation system for Atlassian apps.",
 	"repository": "https://bitbucket.org/atlassian/atlassian-frontend-mirror",
 	"author": "Atlassian Pty Ltd",
@@ -67,7 +67,7 @@
 	},
 	"dependencies": {
 		"@atlaskit/analytics-next": "^11.1.0",
-		"@atlaskit/avatar": "^25.4.0",
+		"@atlaskit/avatar": "^25.5.0",
 		"@atlaskit/button": "^23.5.0",
 		"@atlaskit/css": "^0.15.0",
 		"@atlaskit/ds-lib": "^5.1.0",
@@ -113,7 +113,6 @@
 		"@atlaskit/pragmatic-drag-and-drop-auto-scroll": "^2.1.0",
 		"@atlaskit/select": "^21.3.0",
 		"@atlaskit/skeleton": "^2.1.0",
-		"@atlaskit/temp-nav-app-icons": "^0.14.0",
 		"@atlaskit/textfield": "^8.0.0",
 		"@atlassian/feature-flags-test-utils": "^1.0.0",
 		"@atlassian/gemini": "^1.20.0",
@@ -165,9 +164,6 @@
 		"platform_dst_nav4_flyoutmenuitem_render_to_parent": {
 			"type": "boolean"
 		},
-		"platform_dst_nav4_panel_splitter_guards": {
-			"type": "boolean"
-		},
 		"navx-full-height-sidebar": {
 			"type": "boolean"
 		},