@atlaskit/navigation-system 2.5.0 → 2.6.0

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlassian/navigation-system
 
+## 2.6.0
+
+### Minor Changes
+
+- [`e9ddf34435a22`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/e9ddf34435a22) -
+  Clicking dropdown menu items will no longer collapse the side navigation on mobile. This change is
+  behind a feature flag.
+
 ## 2.5.0
 
 ### Minor Changes

package/dist/cjs/ui/page-layout/side-nav/side-nav.js

@@ -342,6 +342,15 @@ function SideNavInternal(_ref) {
           // Ignore if our element references are invalid
           return;
         }
+        if (!event.target.isConnected && (0, _platformFeatureFlags.fg)('platform_dst_nav4_side_nav_click_outside_fix')) {
+          /**
+           * If the element that was clicked is no longer in the document, we should not collapse the side nav.
+           * This can happen when the user clicks on a dropdown menu item (such as one used in a `...` More menu),
+           * as the dropdown menu will close after being clicked. By the time this event listener runs, the clicked
+           * element will no longer be in the document, so the check below for `sideNav.contains(event.target)` will fail.
+           */
+          return;
+        }
         if (sideNav.contains(event.target)) {
           // Clicks inside the side nav should not close it
           return;

package/dist/es2019/ui/page-layout/side-nav/side-nav.js

@@ -327,6 +327,15 @@ function SideNavInternal({
           // Ignore if our element references are invalid
           return;
         }
+        if (!event.target.isConnected && fg('platform_dst_nav4_side_nav_click_outside_fix')) {
+          /**
+           * If the element that was clicked is no longer in the document, we should not collapse the side nav.
+           * This can happen when the user clicks on a dropdown menu item (such as one used in a `...` More menu),
+           * as the dropdown menu will close after being clicked. By the time this event listener runs, the clicked
+           * element will no longer be in the document, so the check below for `sideNav.contains(event.target)` will fail.
+           */
+          return;
+        }
         if (sideNav.contains(event.target)) {
           // Clicks inside the side nav should not close it
           return;

package/dist/esm/ui/page-layout/side-nav/side-nav.js

@@ -333,6 +333,15 @@ function SideNavInternal(_ref) {
           // Ignore if our element references are invalid
           return;
         }
+        if (!event.target.isConnected && fg('platform_dst_nav4_side_nav_click_outside_fix')) {
+          /**
+           * If the element that was clicked is no longer in the document, we should not collapse the side nav.
+           * This can happen when the user clicks on a dropdown menu item (such as one used in a `...` More menu),
+           * as the dropdown menu will close after being clicked. By the time this event listener runs, the clicked
+           * element will no longer be in the document, so the check below for `sideNav.contains(event.target)` will fail.
+           */
+          return;
+        }
         if (sideNav.contains(event.target)) {
           // Clicks inside the side nav should not close it
           return;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/navigation-system",
-	"version": "2.5.0",
+	"version": "2.6.0",
 	"description": "The latest navigation system for Atlassian apps.",
 	"repository": "https://bitbucket.org/atlassian/atlassian-frontend-mirror",
 	"author": "Atlassian Pty Ltd",
@@ -184,6 +184,9 @@
 		},
 		"platform_dst_nav4_menu_section_heading_a11y": {
 			"type": "boolean"
+		},
+		"platform_dst_nav4_side_nav_click_outside_fix": {
+			"type": "boolean"
 		}
 	},
 	"homepage": "https://atlassian.design/components/navigation-system"