@atlaskit/native-embeds-common 1.1.1 → 1.2.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,43 @@
|
|
|
1
1
|
# @atlaskit/native-embeds-common
|
|
2
2
|
|
|
3
|
+
## 1.2.0
|
|
4
|
+
|
|
5
|
+
### Minor Changes
|
|
6
|
+
|
|
7
|
+
- [`6909e71070730`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/6909e71070730) -
|
|
8
|
+
Show an AI generating overlay (rainbow loading bar) on the targeted native embed while Rovo is
|
|
9
|
+
processing an inline-edit prompt. Behind the `cc-maui-phase-2-loading` feature gate.
|
|
10
|
+
|
|
11
|
+
Two-stage commit pattern so the overlay only appears once the user has actually submitted a prompt
|
|
12
|
+
— not when the AI modal first opens:
|
|
13
|
+
- The toolbar handler for "Ask Rovo" (`maui:onAskRovoClick`) **stages** the embed `localId` via
|
|
14
|
+
the new `stageInlineRovoStreaming` action. The toolbar handler factory now propagates the
|
|
15
|
+
selected node's `localId` to manifest handlers via
|
|
16
|
+
`EditorToolbarHandlerContext.selectedNodeLocalId` so MAUI can stage the correct target before
|
|
17
|
+
opening the AI modal.
|
|
18
|
+
- `RovoPromptScreenWithLogic.onSubmit` **commits** the staged id via `commitInlineRovoStreaming`.
|
|
19
|
+
This is what triggers the consumer-visible loading overlay.
|
|
20
|
+
- `RovoPromptScreenWithLogic.onComplete` / `handleAbort` dispatches `endInlineRovoStreaming` to
|
|
21
|
+
clear it.
|
|
22
|
+
|
|
23
|
+
The native-embeds extension subscribes to the AI plugin's new `inlineRovoStreamingTargetId`
|
|
24
|
+
shared-state field and renders the overlay when its own `localId` matches.
|
|
25
|
+
|
|
26
|
+
The overlay component (`AIGeneratingOverlay`) is colocated inside `native-embeds-core` rather than
|
|
27
|
+
extracted to a shared package. Hosting it in `@atlaskit/editor-common` (the natural shared spot)
|
|
28
|
+
would create a TS6202 circular project reference because `editor-common` already depends on
|
|
29
|
+
`@atlaskit/media-card`. A new leaf-level package would force workspace registrations across every
|
|
30
|
+
product `package.json`, plus tsconfig project-reference updates and lockfile churn — large
|
|
31
|
+
unrelated review surface for a 130-line component. When the parallel media inline-edit branch
|
|
32
|
+
lands (PR #357140), the two implementations should be consolidated into a shared package below
|
|
33
|
+
both consumers in the dependency graph.
|
|
34
|
+
|
|
35
|
+
Includes reducer + consumer unit tests covering both gate-on and gate-off paths.
|
|
36
|
+
|
|
37
|
+
### Patch Changes
|
|
38
|
+
|
|
39
|
+
- Updated dependencies
|
|
40
|
+
|
|
3
41
|
## 1.1.1
|
|
4
42
|
|
|
5
43
|
### Patch Changes
|
|
@@ -30,6 +30,11 @@ export type NativeEmbedParameters = {
|
|
|
30
30
|
export type NativeEmbedParameterKey = keyof NonNullable<NativeEmbedParameters['macroParams']>;
|
|
31
31
|
export type EditorToolbarHandlerContext = {
|
|
32
32
|
editorApi?: PublicPluginAPI<[]>;
|
|
33
|
+
/**
|
|
34
|
+
* `localId` of the selected native-embed at toolbar click time. Set by
|
|
35
|
+
* the toolbar handler factory; manifest handlers use it to wire per-embed state.
|
|
36
|
+
*/
|
|
37
|
+
selectedNodeLocalId?: string;
|
|
33
38
|
};
|
|
34
39
|
/**
|
|
35
40
|
* A button action rendered in the editor floating toolbar.
|
|
@@ -31,6 +31,11 @@ export type NativeEmbedParameterKey = keyof NonNullable<NativeEmbedParameters['m
|
|
|
31
31
|
export type EditorToolbarHandlerContext = {
|
|
32
32
|
editorApi?: PublicPluginAPI<[
|
|
33
33
|
]>;
|
|
34
|
+
/**
|
|
35
|
+
* `localId` of the selected native-embed at toolbar click time. Set by
|
|
36
|
+
* the toolbar handler factory; manifest handlers use it to wire per-embed state.
|
|
37
|
+
*/
|
|
38
|
+
selectedNodeLocalId?: string;
|
|
34
39
|
};
|
|
35
40
|
/**
|
|
36
41
|
* A button action rendered in the editor floating toolbar.
|
package/package.json
CHANGED
|
@@ -25,7 +25,7 @@
|
|
|
25
25
|
"atlaskit:src": "src/index.ts",
|
|
26
26
|
"dependencies": {
|
|
27
27
|
"@atlaskit/button": "^23.11.0",
|
|
28
|
-
"@atlaskit/editor-common": "^114.
|
|
28
|
+
"@atlaskit/editor-common": "^114.16.0",
|
|
29
29
|
"@atlaskit/editor-plugin-local-id": "^8.0.0",
|
|
30
30
|
"@atlaskit/editor-prosemirror": "^7.3.0",
|
|
31
31
|
"@atlaskit/heading": "^5.4.0",
|
|
@@ -86,7 +86,7 @@
|
|
|
86
86
|
}
|
|
87
87
|
},
|
|
88
88
|
"name": "@atlaskit/native-embeds-common",
|
|
89
|
-
"version": "1.
|
|
89
|
+
"version": "1.2.0",
|
|
90
90
|
"description": "A shared package for native embeds to be used across experiences and plugin",
|
|
91
91
|
"author": "Atlassian Pty Ltd",
|
|
92
92
|
"license": "Apache-2.0",
|