@atlaskit/modal-dialog 14.12.0 → 14.13.0

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/modal-dialog
 
+## 14.13.0
+
+### Minor Changes
+
+- [`bbfd308f360d8`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/bbfd308f360d8) -
+  Add flag to remove internal focus lock from running when using `false` in `autoFocus`. This is in
+  service of eventually removing boolean `autoFocus` from the API.
+
 ## 14.12.0
 
 ### Minor Changes

package/dist/cjs/internal/components/modal-wrapper.js

@@ -20,6 +20,7 @@ var _noop = _interopRequireDefault(require("@atlaskit/ds-lib/noop"));
 var _layering = require("@atlaskit/layering");
 var _openLayerObserver = require("@atlaskit/layering/experimental/open-layer-observer");
 var _fadeIn = _interopRequireDefault(require("@atlaskit/motion/fade-in"));
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _portal = _interopRequireDefault(require("@atlaskit/portal"));
 var _constants = require("@atlaskit/theme/constants");
 var _useModalStack = _interopRequireDefault(require("../hooks/use-modal-stack"));
@@ -82,7 +83,9 @@ var InternalModalWrapper = function InternalModalWrapper(props) {
   var isForeground = stackIndex === 0;
 
   // When a user supplies a ref to focus we skip auto focus via react-focus-lock
-  var autoFocusLock = typeof autoFocus === 'boolean' ? autoFocus : false;
+  // When flag is true and a ref is not supplied, autofocus is true. See https://product-fabric.atlassian.net/browse/DSP-24307
+  // When we remove boolean `autoFocus`, we won't have to worry about this
+  var autoFocusLock = (0, _platformFeatureFlags.fg)('platform_dst_autofocus-never-false-2') ? typeof autoFocus === 'boolean' : typeof autoFocus === 'boolean' ? autoFocus : false;
   var onCloseHandler = (0, _analyticsNext.usePlatformLeafEventHandler)({
     fn: providedOnClose || _noop.default,
     action: 'closed',

package/dist/es2019/internal/components/modal-wrapper.js

@@ -12,6 +12,7 @@ import noop from '@atlaskit/ds-lib/noop';
 import { Layering } from '@atlaskit/layering';
 import { useNotifyOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
 import FadeIn from '@atlaskit/motion/fade-in';
+import { fg } from '@atlaskit/platform-feature-flags';
 import Portal from '@atlaskit/portal';
 import { layers } from '@atlaskit/theme/constants';
 import useModalStack from '../hooks/use-modal-stack';
@@ -69,7 +70,9 @@ const InternalModalWrapper = props => {
   const isForeground = stackIndex === 0;
 
   // When a user supplies a ref to focus we skip auto focus via react-focus-lock
-  const autoFocusLock = typeof autoFocus === 'boolean' ? autoFocus : false;
+  // When flag is true and a ref is not supplied, autofocus is true. See https://product-fabric.atlassian.net/browse/DSP-24307
+  // When we remove boolean `autoFocus`, we won't have to worry about this
+  const autoFocusLock = fg('platform_dst_autofocus-never-false-2') ? typeof autoFocus === 'boolean' : typeof autoFocus === 'boolean' ? autoFocus : false;
   const onCloseHandler = usePlatformLeafEventHandler({
     fn: providedOnClose || noop,
     action: 'closed',

package/dist/esm/internal/components/modal-wrapper.js

@@ -12,6 +12,7 @@ import noop from '@atlaskit/ds-lib/noop';
 import { Layering } from '@atlaskit/layering';
 import { useNotifyOpenLayerObserver } from '@atlaskit/layering/experimental/open-layer-observer';
 import FadeIn from '@atlaskit/motion/fade-in';
+import { fg } from '@atlaskit/platform-feature-flags';
 import Portal from '@atlaskit/portal';
 import { layers } from '@atlaskit/theme/constants';
 import useModalStack from '../hooks/use-modal-stack';
@@ -73,7 +74,9 @@ var InternalModalWrapper = function InternalModalWrapper(props) {
   var isForeground = stackIndex === 0;
 
   // When a user supplies a ref to focus we skip auto focus via react-focus-lock
-  var autoFocusLock = typeof autoFocus === 'boolean' ? autoFocus : false;
+  // When flag is true and a ref is not supplied, autofocus is true. See https://product-fabric.atlassian.net/browse/DSP-24307
+  // When we remove boolean `autoFocus`, we won't have to worry about this
+  var autoFocusLock = fg('platform_dst_autofocus-never-false-2') ? typeof autoFocus === 'boolean' : typeof autoFocus === 'boolean' ? autoFocus : false;
   var onCloseHandler = usePlatformLeafEventHandler({
     fn: providedOnClose || noop,
     action: 'closed',

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/modal-dialog",
-	"version": "14.12.0",
+	"version": "14.13.0",
 	"description": "A modal dialog displays content that requires user interaction, in a layer above the page.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -32,15 +32,15 @@
 		"@atlaskit/button": "^23.10.0",
 		"@atlaskit/css": "^0.19.0",
 		"@atlaskit/ds-lib": "^6.0.0",
-		"@atlaskit/icon": "^33.0.0",
+		"@atlaskit/icon": "^33.1.0",
 		"@atlaskit/layering": "^3.6.0",
 		"@atlaskit/motion": "^5.4.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/portal": "^5.2.0",
 		"@atlaskit/pragmatic-drag-and-drop": "^1.7.0",
-		"@atlaskit/primitives": "^18.0.0",
+		"@atlaskit/primitives": "^18.1.0",
 		"@atlaskit/theme": "^22.0.0",
-		"@atlaskit/tokens": "^11.2.0",
+		"@atlaskit/tokens": "^11.3.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^0.20.0",
 		"bind-event-listener": "^3.0.0",
@@ -75,8 +75,10 @@
 		"@atlaskit/spotlight": "^0.10.0",
 		"@atlaskit/textfield": "^8.2.0",
 		"@atlaskit/tooltip": "^21.0.0",
+		"@atlassian/feature-flags-test-utils": "^1.0.0",
 		"@atlassian/ssr-tests": "workspace:^",
 		"@atlassian/structured-docs-types": "workspace:^",
+		"@atlassian/testing-library": "^0.4.0",
 		"@testing-library/dom": "^10.1.0",
 		"@testing-library/react": "^16.3.0",
 		"@testing-library/user-event": "^14.4.3",
@@ -127,6 +129,9 @@
 		},
 		"platform-dst-shape-theme-default": {
 			"type": "boolean"
+		},
+		"platform_dst_autofocus-never-false-2": {
+			"type": "boolean"
 		}
 	},
 	"homepage": "https://atlassian.design/components/modal-dialog/"