@atlaskit/modal-dialog 12.13.1 → 12.13.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,20 @@
1
1
  # @atlaskit/modal-dialog
2
2
 
3
+ ## 12.13.3
4
+
5
+ ### Patch Changes
6
+
7
+ - [#100067](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/100067)
8
+ [`0601616da694`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/0601616da694) -
9
+ Internal changes to resolve an issue where global style overrides could break alignment between
10
+ the icon and title.
11
+
12
+ ## 12.13.2
13
+
14
+ ### Patch Changes
15
+
16
+ - Updated dependencies
17
+
3
18
  ## 12.13.1
4
19
 
5
20
  ### Patch Changes
@@ -30,7 +30,16 @@ var textStyles = (0, _react.css)({
30
30
  wordWrap: 'break-word'
31
31
  });
32
32
  var iconStyles = (0, _react.css)({
33
- flex: '0 0 auto'
33
+ flex: '0 0 auto',
34
+ // The following properties have been added purely to avoid a global style override in Jira breaking alignment between the icon and title text.
35
+ // https://stash.atlassian.com/projects/JIRACLOUD/repos/jira/browse/jira-components/jira-legacy-frontend/jira-atlaskit-module/src/main/resources/jira-atlaskit-module/css/adg3-general-overrides.less?at=master#24
36
+ // When the override is removed, these can be removed.
37
+ color: 'inherit',
38
+ fontSize: 'inherit',
39
+ fontStyle: 'inherit',
40
+ fontWeight: 'inherit',
41
+ letterSpacing: 'inherit',
42
+ lineHeight: 'inherit'
34
43
  });
35
44
  var truncatedTextStyles = (0, _react.css)({
36
45
  overflow: 'hidden',
@@ -95,7 +95,7 @@ var ModalWrapper = function ModalWrapper(props) {
95
95
  action: 'closed',
96
96
  componentName: 'modalDialog',
97
97
  packageName: "@atlaskit/modal-dialog",
98
- packageVersion: "12.13.1"
98
+ packageVersion: "12.13.3"
99
99
  });
100
100
  var onBlanketClicked = (0, _react.useCallback)(function (e) {
101
101
  if (shouldCloseOnOverlayClick) {
@@ -23,7 +23,16 @@ const textStyles = css({
23
23
  wordWrap: 'break-word'
24
24
  });
25
25
  const iconStyles = css({
26
- flex: '0 0 auto'
26
+ flex: '0 0 auto',
27
+ // The following properties have been added purely to avoid a global style override in Jira breaking alignment between the icon and title text.
28
+ // https://stash.atlassian.com/projects/JIRACLOUD/repos/jira/browse/jira-components/jira-legacy-frontend/jira-atlaskit-module/src/main/resources/jira-atlaskit-module/css/adg3-general-overrides.less?at=master#24
29
+ // When the override is removed, these can be removed.
30
+ color: 'inherit',
31
+ fontSize: 'inherit',
32
+ fontStyle: 'inherit',
33
+ fontWeight: 'inherit',
34
+ letterSpacing: 'inherit',
35
+ lineHeight: 'inherit'
27
36
  });
28
37
  const truncatedTextStyles = css({
29
38
  overflow: 'hidden',
@@ -80,7 +80,7 @@ const ModalWrapper = props => {
80
80
  action: 'closed',
81
81
  componentName: 'modalDialog',
82
82
  packageName: "@atlaskit/modal-dialog",
83
- packageVersion: "12.13.1"
83
+ packageVersion: "12.13.3"
84
84
  });
85
85
  const onBlanketClicked = useCallback(e => {
86
86
  if (shouldCloseOnOverlayClick) {
@@ -23,7 +23,16 @@ var textStyles = css({
23
23
  wordWrap: 'break-word'
24
24
  });
25
25
  var iconStyles = css({
26
- flex: '0 0 auto'
26
+ flex: '0 0 auto',
27
+ // The following properties have been added purely to avoid a global style override in Jira breaking alignment between the icon and title text.
28
+ // https://stash.atlassian.com/projects/JIRACLOUD/repos/jira/browse/jira-components/jira-legacy-frontend/jira-atlaskit-module/src/main/resources/jira-atlaskit-module/css/adg3-general-overrides.less?at=master#24
29
+ // When the override is removed, these can be removed.
30
+ color: 'inherit',
31
+ fontSize: 'inherit',
32
+ fontStyle: 'inherit',
33
+ fontWeight: 'inherit',
34
+ letterSpacing: 'inherit',
35
+ lineHeight: 'inherit'
27
36
  });
28
37
  var truncatedTextStyles = css({
29
38
  overflow: 'hidden',
@@ -85,7 +85,7 @@ var ModalWrapper = function ModalWrapper(props) {
85
85
  action: 'closed',
86
86
  componentName: 'modalDialog',
87
87
  packageName: "@atlaskit/modal-dialog",
88
- packageVersion: "12.13.1"
88
+ packageVersion: "12.13.3"
89
89
  });
90
90
  var onBlanketClicked = useCallback(function (e) {
91
91
  if (shouldCloseOnOverlayClick) {
@@ -1,7 +1,7 @@
1
1
  /** @jsx jsx */
2
- import { ReactNode } from 'react';
2
+ import { type ReactNode } from 'react';
3
3
  import { jsx } from '@emotion/react';
4
- import { Appearance } from './types';
4
+ import { type Appearance } from './types';
5
5
  export interface ModalTitleProps {
6
6
  /**
7
7
  * Appearance of the modal that changes the color of the primary action and adds an icon to the title.
@@ -95,16 +95,15 @@ export interface ModalDialogProps {
95
95
  * which is a unique string that appears as a data attribute `data-testid` in the rendered code,
96
96
  * serving as a hook for automated tests.
97
97
  *
98
- * If not overridden using `testId` prop in the respective components,
99
- * this will set `data-testid` on these elements when defined:
98
+ * If not overridden using `testId` prop in the respective components, this will set `data-testid` on these elements when defined:
100
99
  *
101
- * - Modal dialog - `{testId}`
102
- * - Modal header - `{testId}--header`
103
- * - Modal title - `{testId}--title`
104
- * - Modal body - `{testId}--body`
105
- * - Modal footer - `{testId}--footer`
106
- * - Scrollable element - `{testId}--scrollable`
107
- * - Blanket - `{testId}--blanket`
100
+ * Modal dialog: `{testId}`
101
+ * Modal header: `{testId}--header`
102
+ * Modal title: `{testId}--title`
103
+ * Modal body: `{testId}--body`
104
+ * Modal footer: `{testId}--footer`
105
+ * Scrollable element: `{testId}--scrollable`
106
+ * Blanket: `{testId}--blanket`
108
107
  */
109
108
  testId?: string;
110
109
  }
@@ -1,7 +1,7 @@
1
1
  /** @jsx jsx */
2
- import { ReactNode } from 'react';
2
+ import { type ReactNode } from 'react';
3
3
  import { jsx } from '@emotion/react';
4
- import { Appearance } from './types';
4
+ import { type Appearance } from './types';
5
5
  export interface ModalTitleProps {
6
6
  /**
7
7
  * Appearance of the modal that changes the color of the primary action and adds an icon to the title.
@@ -95,16 +95,15 @@ export interface ModalDialogProps {
95
95
  * which is a unique string that appears as a data attribute `data-testid` in the rendered code,
96
96
  * serving as a hook for automated tests.
97
97
  *
98
- * If not overridden using `testId` prop in the respective components,
99
- * this will set `data-testid` on these elements when defined:
98
+ * If not overridden using `testId` prop in the respective components, this will set `data-testid` on these elements when defined:
100
99
  *
101
- * - Modal dialog - `{testId}`
102
- * - Modal header - `{testId}--header`
103
- * - Modal title - `{testId}--title`
104
- * - Modal body - `{testId}--body`
105
- * - Modal footer - `{testId}--footer`
106
- * - Scrollable element - `{testId}--scrollable`
107
- * - Blanket - `{testId}--blanket`
100
+ * Modal dialog: `{testId}`
101
+ * Modal header: `{testId}--header`
102
+ * Modal title: `{testId}--title`
103
+ * Modal body: `{testId}--body`
104
+ * Modal footer: `{testId}--footer`
105
+ * Scrollable element: `{testId}--scrollable`
106
+ * Blanket: `{testId}--blanket`
108
107
  */
109
108
  testId?: string;
110
109
  }
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/modal-dialog",
3
- "version": "12.13.1",
3
+ "version": "12.13.3",
4
4
  "description": "A modal dialog displays content that requires user interaction, in a layer above the page.",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -34,15 +34,15 @@
34
34
  "@atlaskit/blanket": "^13.1.0",
35
35
  "@atlaskit/codemod-utils": "^4.2.0",
36
36
  "@atlaskit/ds-lib": "^2.3.0",
37
- "@atlaskit/focus-ring": "^1.3.9",
37
+ "@atlaskit/focus-ring": "^1.4.0",
38
38
  "@atlaskit/icon": "^22.1.0",
39
39
  "@atlaskit/layering": "^0.3.0",
40
- "@atlaskit/motion": "^1.5.0",
40
+ "@atlaskit/motion": "^1.6.0",
41
41
  "@atlaskit/platform-feature-flags": "^0.2.0",
42
- "@atlaskit/portal": "^4.4.0",
43
- "@atlaskit/primitives": "^5.7.0",
44
- "@atlaskit/theme": "^12.7.0",
45
- "@atlaskit/tokens": "^1.44.0",
42
+ "@atlaskit/portal": "^4.5.0",
43
+ "@atlaskit/primitives": "^6.1.0",
44
+ "@atlaskit/theme": "^12.8.0",
45
+ "@atlaskit/tokens": "^1.48.0",
46
46
  "@babel/runtime": "^7.0.0",
47
47
  "@emotion/react": "^11.7.1",
48
48
  "bind-event-listener": "^3.0.0",
@@ -59,12 +59,13 @@
59
59
  "@af/integration-testing": "*",
60
60
  "@af/visual-regression": "*",
61
61
  "@atlaskit/button": "*",
62
- "@atlaskit/checkbox": "^13.1.0",
63
- "@atlaskit/dropdown-menu": "^12.9.0",
64
- "@atlaskit/popup": "^1.15.0",
65
- "@atlaskit/radio": "^6.1.3",
66
- "@atlaskit/select": "^17.7.0",
62
+ "@atlaskit/checkbox": "^13.3.0",
63
+ "@atlaskit/dropdown-menu": "^12.10.0",
64
+ "@atlaskit/popup": "^1.17.0",
65
+ "@atlaskit/radio": "^6.3.0",
66
+ "@atlaskit/select": "^17.9.0",
67
67
  "@atlaskit/ssr": "*",
68
+ "@atlaskit/textfield": "^6.3.0",
68
69
  "@atlaskit/tooltip": "^18.3.0",
69
70
  "@atlaskit/visual-regression": "*",
70
71
  "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",