@atlaskit/menu 8.3.3 → 8.4.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,19 @@
1
1
  # @atlaskit/menu
2
2
 
3
+ ## 8.4.0
4
+
5
+ ### Minor Changes
6
+
7
+ - [`e2485470e4078`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/e2485470e4078) -
8
+ ButtonItem will convey its selected state to screen readers when isSelected. This is done through
9
+ the aria-current attribute.
10
+
11
+ This change was previously behind a feature flag, which has been removed.
12
+
13
+ ### Patch Changes
14
+
15
+ - Updated dependencies
16
+
3
17
  ## 8.3.3
4
18
 
5
19
  ### Patch Changes
@@ -13,7 +13,6 @@ var _runtime = require("@compiled/react/runtime");
13
13
  var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
14
14
  var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
15
15
  var _interactionContext = _interopRequireDefault(require("@atlaskit/interaction-context"));
16
- var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
17
16
  var _menuItemPrimitive = _interopRequireDefault(require("../internal/components/menu-item-primitive"));
18
17
  var _excluded = ["children", "description", "iconAfter", "iconBefore", "isDisabled", "isSelected", "onClick", "testId", "onMouseDown", "shouldTitleWrap", "shouldDescriptionWrap", "className", "interactionName"];
19
18
  function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
@@ -74,7 +73,7 @@ var ButtonItem = /*#__PURE__*/(0, _react.memo)( /*#__PURE__*/(0, _react.forwardR
74
73
  // This is intentionally placed before the `...rest` spread to prevent overriding existing usages of `aria-current`,
75
74
  // which are already being passed to the button element.
76
75
  ,
77
- "aria-current": isSelected && (0, _platformFeatureFlags.fg)('platform_dst_menu_item_button_aria_current') ? 'true' : undefined
76
+ "aria-current": isSelected ? 'true' : undefined
78
77
  }, rest, {
79
78
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
80
79
  className: className,
@@ -4,7 +4,6 @@ import * as React from 'react';
4
4
  import { ax, ix } from "@compiled/react/runtime";
5
5
  import { forwardRef, memo, useCallback, useContext } from 'react';
6
6
  import InteractionContext from '@atlaskit/interaction-context';
7
- import { fg } from '@atlaskit/platform-feature-flags';
8
7
  import MenuItemPrimitive from '../internal/components/menu-item-primitive';
9
8
  /**
10
9
  * __Button item__
@@ -63,7 +62,7 @@ const ButtonItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef((props, ref) => {
63
62
  // This is intentionally placed before the `...rest` spread to prevent overriding existing usages of `aria-current`,
64
63
  // which are already being passed to the button element.
65
64
  ,
66
- "aria-current": isSelected && fg('platform_dst_menu_item_button_aria_current') ? 'true' : undefined
65
+ "aria-current": isSelected ? 'true' : undefined
67
66
  }, rest, {
68
67
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
69
68
  className: className,
@@ -6,7 +6,6 @@ import * as React from 'react';
6
6
  import { ax, ix } from "@compiled/react/runtime";
7
7
  import { forwardRef, memo, useCallback, useContext } from 'react';
8
8
  import InteractionContext from '@atlaskit/interaction-context';
9
- import { fg } from '@atlaskit/platform-feature-flags';
10
9
  import MenuItemPrimitive from '../internal/components/menu-item-primitive';
11
10
  /**
12
11
  * __Button item__
@@ -65,7 +64,7 @@ var ButtonItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(function (props, ref
65
64
  // This is intentionally placed before the `...rest` spread to prevent overriding existing usages of `aria-current`,
66
65
  // which are already being passed to the button element.
67
66
  ,
68
- "aria-current": isSelected && fg('platform_dst_menu_item_button_aria_current') ? 'true' : undefined
67
+ "aria-current": isSelected ? 'true' : undefined
69
68
  }, rest, {
70
69
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
71
70
  className: className,
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/menu",
3
- "version": "8.3.3",
3
+ "version": "8.4.0",
4
4
  "description": "A list of options to help users navigate, or perform actions.",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -41,12 +41,12 @@
41
41
  },
42
42
  "dependencies": {
43
43
  "@atlaskit/app-provider": "^3.1.0",
44
- "@atlaskit/css": "^0.12.0",
44
+ "@atlaskit/css": "^0.13.0",
45
45
  "@atlaskit/interaction-context": "^3.0.0",
46
46
  "@atlaskit/platform-feature-flags": "^1.1.0",
47
- "@atlaskit/primitives": "^14.12.0",
47
+ "@atlaskit/primitives": "^14.13.0",
48
48
  "@atlaskit/theme": "^20.0.0",
49
- "@atlaskit/tokens": "^6.1.0",
49
+ "@atlaskit/tokens": "^6.2.0",
50
50
  "@babel/runtime": "^7.0.0",
51
51
  "@compiled/react": "^0.18.3"
52
52
  },
@@ -106,9 +106,6 @@
106
106
  "platform-feature-flags": {
107
107
  "platform_fix_a11y_selected_and_hovered_state_color": {
108
108
  "type": "boolean"
109
- },
110
- "platform_dst_menu_item_button_aria_current": {
111
- "type": "boolean"
112
109
  }
113
110
  },
114
111
  "homepage": "https://atlassian.design/components/menu/"