@atlaskit/menu 2.7.4 → 2.8.0

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/menu
 
+## 2.8.0
+
+### Minor Changes
+
+- [#120033](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/120033)
+  [`89fdaa528833e`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/89fdaa528833e) -
+  Added an UNSAFE_isDraggable prop to LinkItem and menu item that disable drag overrides within the
+  components
+
 ## 2.7.4
 
 ### Patch Changes

package/dist/cjs/menu-item/custom-item.js

@@ -13,7 +13,7 @@ var _deprecationWarning = require("@atlaskit/ds-lib/deprecation-warning");
 var _noop = _interopRequireDefault(require("@atlaskit/ds-lib/noop"));
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _menuItemPrimitive = _interopRequireDefault(require("../internal/components/menu-item-primitive"));
-var _excluded = ["component", "cssFn", "isDisabled", "isSelected", "onClick", "testId", "children", "description", "iconAfter", "iconBefore", "overrides", "onMouseDown", "shouldTitleWrap", "shouldDescriptionWrap", "className"];
+var _excluded = ["component", "cssFn", "isDisabled", "isSelected", "onClick", "testId", "children", "description", "iconAfter", "iconBefore", "overrides", "onMouseDown", "shouldTitleWrap", "shouldDescriptionWrap", "className", "UNSAFE_isDraggable"];
 /**
  * @jsxRuntime classic
  */
@@ -52,6 +52,7 @@ var CustomItem = /*#__PURE__*/(0, _react.memo)( /*#__PURE__*/(0, _react.forwardR
     shouldTitleWrap = _ref.shouldTitleWrap,
     shouldDescriptionWrap = _ref.shouldDescriptionWrap,
     UNSAFE_className = _ref.className,
+    UNSAFE_isDraggable = _ref.UNSAFE_isDraggable,
     rest = (0, _objectWithoutProperties2.default)(_ref, _excluded);
   var onMouseDownHandler = onMouseDown;
   if (!Component) {
@@ -92,7 +93,7 @@ var CustomItem = /*#__PURE__*/(0, _react.memo)( /*#__PURE__*/(0, _react.forwardR
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
       className: className,
       ref: ref
-    }, (0, _platformFeatureFlags.fg)('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
+    }, UNSAFE_isDraggable ? {} : {
       draggable: false,
       onDragStart: preventEvent
     }, {

package/dist/cjs/menu-item/link-item.js

@@ -14,7 +14,7 @@ var _deprecationWarning = require("@atlaskit/ds-lib/deprecation-warning");
 var _noop = _interopRequireDefault(require("@atlaskit/ds-lib/noop"));
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _menuItemPrimitive = _interopRequireDefault(require("../internal/components/menu-item-primitive"));
-var _excluded = ["children", "href", "cssFn", "description", "iconAfter", "iconBefore", "isDisabled", "isSelected", "onClick", "testId", "overrides", "onMouseDown", "shouldTitleWrap", "shouldDescriptionWrap", "className", "UNSAFE_shouldDisableRouterLink"];
+var _excluded = ["children", "href", "cssFn", "description", "iconAfter", "iconBefore", "isDisabled", "isSelected", "onClick", "testId", "overrides", "onMouseDown", "shouldTitleWrap", "shouldDescriptionWrap", "className", "UNSAFE_shouldDisableRouterLink", "UNSAFE_isDraggable"];
 /**
  * @jsxRuntime classic
  */
@@ -56,6 +56,7 @@ function (props, ref) {
     shouldDescriptionWrap = props.shouldDescriptionWrap,
     UNSAFE_className = props.className,
     UNSAFE_shouldDisableRouterLink = props.UNSAFE_shouldDisableRouterLink,
+    UNSAFE_isDraggable = props.UNSAFE_isDraggable,
     rest = (0, _objectWithoutProperties2.default)(props, _excluded);
   var onMouseDownHandler = onMouseDown;
   var RouterLink = (0, _appProvider.useRouterLink)();
@@ -109,7 +110,7 @@ function (props, ref) {
       // @ts-expect-error
       ,
       href: isDisabled ? undefined : href
-    }, (0, _platformFeatureFlags.fg)('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
+    }, UNSAFE_isDraggable ? {} : {
       draggable: false,
       onDragStart: preventEvent
     }, {

package/dist/es2019/menu-item/custom-item.js

@@ -46,6 +46,7 @@ const CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(({
   // picked it out and supressed the expected type error.
   // @ts-expect-error
   className: UNSAFE_className,
+  UNSAFE_isDraggable,
   ...rest
 }, ref) => {
   const onMouseDownHandler = onMouseDown;
@@ -87,7 +88,7 @@ const CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(({
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
     className: className,
     ref: ref
-  }, fg('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
+  }, UNSAFE_isDraggable ? {} : {
     draggable: false,
     onDragStart: preventEvent
   }, {

package/dist/es2019/menu-item/link-item.js

@@ -50,6 +50,7 @@ const LinkItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(
     // @ts-expect-error
     className: UNSAFE_className,
     UNSAFE_shouldDisableRouterLink,
+    UNSAFE_isDraggable,
     ...rest
   } = props;
   const onMouseDownHandler = onMouseDown;
@@ -104,7 +105,7 @@ const LinkItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(
     // @ts-expect-error
     ,
     href: isDisabled ? undefined : href
-  }, fg('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
+  }, UNSAFE_isDraggable ? {} : {
     draggable: false,
     onDragStart: preventEvent
   }, {

package/dist/esm/menu-item/custom-item.js

@@ -1,6 +1,6 @@
 import _extends from "@babel/runtime/helpers/extends";
 import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
-var _excluded = ["component", "cssFn", "isDisabled", "isSelected", "onClick", "testId", "children", "description", "iconAfter", "iconBefore", "overrides", "onMouseDown", "shouldTitleWrap", "shouldDescriptionWrap", "className"];
+var _excluded = ["component", "cssFn", "isDisabled", "isSelected", "onClick", "testId", "children", "description", "iconAfter", "iconBefore", "overrides", "onMouseDown", "shouldTitleWrap", "shouldDescriptionWrap", "className", "UNSAFE_isDraggable"];
 /**
  * @jsxRuntime classic
  */
@@ -47,6 +47,7 @@ var CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(function (_ref, ref)
     shouldTitleWrap = _ref.shouldTitleWrap,
     shouldDescriptionWrap = _ref.shouldDescriptionWrap,
     UNSAFE_className = _ref.className,
+    UNSAFE_isDraggable = _ref.UNSAFE_isDraggable,
     rest = _objectWithoutProperties(_ref, _excluded);
   var onMouseDownHandler = onMouseDown;
   if (!Component) {
@@ -87,7 +88,7 @@ var CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(function (_ref, ref)
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
       className: className,
       ref: ref
-    }, fg('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
+    }, UNSAFE_isDraggable ? {} : {
       draggable: false,
       onDragStart: preventEvent
     }, {

package/dist/esm/menu-item/link-item.js

@@ -1,6 +1,6 @@
 import _extends from "@babel/runtime/helpers/extends";
 import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
-var _excluded = ["children", "href", "cssFn", "description", "iconAfter", "iconBefore", "isDisabled", "isSelected", "onClick", "testId", "overrides", "onMouseDown", "shouldTitleWrap", "shouldDescriptionWrap", "className", "UNSAFE_shouldDisableRouterLink"];
+var _excluded = ["children", "href", "cssFn", "description", "iconAfter", "iconBefore", "isDisabled", "isSelected", "onClick", "testId", "overrides", "onMouseDown", "shouldTitleWrap", "shouldDescriptionWrap", "className", "UNSAFE_shouldDisableRouterLink", "UNSAFE_isDraggable"];
 /**
  * @jsxRuntime classic
  */
@@ -50,6 +50,7 @@ function (props, ref) {
     shouldDescriptionWrap = props.shouldDescriptionWrap,
     UNSAFE_className = props.className,
     UNSAFE_shouldDisableRouterLink = props.UNSAFE_shouldDisableRouterLink,
+    UNSAFE_isDraggable = props.UNSAFE_isDraggable,
     rest = _objectWithoutProperties(props, _excluded);
   var onMouseDownHandler = onMouseDown;
   var RouterLink = useRouterLink();
@@ -103,7 +104,7 @@ function (props, ref) {
       // @ts-expect-error
       ,
       href: isDisabled ? undefined : href
-    }, fg('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
+    }, UNSAFE_isDraggable ? {} : {
       draggable: false,
       onDragStart: preventEvent
     }, {

package/dist/types/types.d.ts

@@ -242,6 +242,11 @@ export interface LinkItemProps extends MenuItemProps {
      * Marked as "unsafe" because ideally, router links should be used for all internal links.
      */
     UNSAFE_shouldDisableRouterLink?: boolean;
+    /**
+     * Use this to prevent disable of drag functionality on the menu item.
+     * Marked as "unsafe" as this may break existing instances of drag handling.
+     */
+    UNSAFE_isDraggable?: boolean;
 }
 export interface CustomItemComponentProps {
     /**
@@ -302,6 +307,11 @@ export interface CustomItemProps<TCustomComponentProps = CustomItemComponentProp
      * __NOTE:__ Make sure the reference for this component does not change between renders else undefined behavior may happen.
      */
     component?: React.ComponentType<PropsWithChildren<TCustomComponentProps>>;
+    /**
+     * Use this to prevent disable of drag functionality on the menu item.
+     * Marked as "unsafe" as this may break existing instances of drag handling.
+     */
+    UNSAFE_isDraggable?: boolean;
 }
 export interface SkeletonItemProps {
     /**

package/dist/types-ts4.5/types.d.ts

@@ -242,6 +242,11 @@ export interface LinkItemProps extends MenuItemProps {
      * Marked as "unsafe" because ideally, router links should be used for all internal links.
      */
     UNSAFE_shouldDisableRouterLink?: boolean;
+    /**
+     * Use this to prevent disable of drag functionality on the menu item.
+     * Marked as "unsafe" as this may break existing instances of drag handling.
+     */
+    UNSAFE_isDraggable?: boolean;
 }
 export interface CustomItemComponentProps {
     /**
@@ -302,6 +307,11 @@ export interface CustomItemProps<TCustomComponentProps = CustomItemComponentProp
      * __NOTE:__ Make sure the reference for this component does not change between renders else undefined behavior may happen.
      */
     component?: React.ComponentType<PropsWithChildren<TCustomComponentProps>>;
+    /**
+     * Use this to prevent disable of drag functionality on the menu item.
+     * Marked as "unsafe" as this may break existing instances of drag handling.
+     */
+    UNSAFE_isDraggable?: boolean;
 }
 export interface SkeletonItemProps {
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/menu",
-	"version": "2.7.4",
+	"version": "2.8.0",
 	"description": "A list of options to help users navigate, or perform actions.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -49,7 +49,7 @@
 		"@atlaskit/platform-feature-flags": "^0.3.0",
 		"@atlaskit/primitives": "^11.0.0",
 		"@atlaskit/theme": "^12.11.0",
-		"@atlaskit/tokens": "^1.53.0",
+		"@atlaskit/tokens": "^1.54.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1"
 	},
@@ -132,9 +132,6 @@
 		},
 		"platform.wanjel.use-router-links-for-the-linkitem-component": {
 			"type": "boolean"
-		},
-		"platform.wanjel.remove-drag-override-in-menu-items_l1dib": {
-			"type": "boolean"
 		}
 	},
 	"homepage": "https://atlassian.design/components/menu/"