@atlaskit/menu 2.7.0 → 2.7.1

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/menu
 
+## 2.7.1
+
+### Patch Changes
+
+- [`89377ac3c7f25`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/89377ac3c7f25) -
+  Removed internal props from link item and custom item that prevent drag and drop functionality
+  from being applied
+
 ## 2.7.0
 
 ### Minor Changes

package/dist/cjs/menu-item/custom-item.js

@@ -62,7 +62,7 @@ var CustomItem = /*#__PURE__*/(0, _react.memo)( /*#__PURE__*/(0, _react.forwardR
   return (0, _react2.jsx)(_menuItemPrimitive.default
   // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
   , (0, _extends2.default)({
-    className: (0, _platformFeatureFlags.getBooleanFF)('platform.design-system-team.unsafe-overrides-killswitch_c8j9m') ? undefined : UNSAFE_className
+    className: (0, _platformFeatureFlags.fg)('platform.design-system-team.unsafe-overrides-killswitch_c8j9m') ? undefined : UNSAFE_className
   }, rest, {
     // eslint-disable-next-line @repo/internal/react/no-unsafe-overrides
     overrides: overrides,
@@ -91,9 +91,11 @@ var CustomItem = /*#__PURE__*/(0, _react.memo)( /*#__PURE__*/(0, _react.forwardR
     }, rest, {
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
       className: className,
-      ref: ref,
+      ref: ref
+    }, (0, _platformFeatureFlags.fg)('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
       draggable: false,
-      onDragStart: preventEvent,
+      onDragStart: preventEvent
+    }, {
       onMouseDown: isDisabled ? preventEvent : onMouseDownHandler,
       onClick: isDisabled ? preventEvent : onClick,
       tabIndex: isDisabled ? -1 : undefined,

package/dist/cjs/menu-item/link-item.js

@@ -108,11 +108,11 @@ function (props, ref) {
       className: className
       // @ts-expect-error
       ,
-      href: isDisabled ? undefined : href,
-      draggable: false
-      // eslint-disable-next-line @atlaskit/design-system/no-direct-use-of-web-platform-drag-and-drop
-      ,
-      onDragStart: preventEvent,
+      href: isDisabled ? undefined : href
+    }, (0, _platformFeatureFlags.fg)('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
+      draggable: false,
+      onDragStart: preventEvent
+    }, {
       onMouseDown: isDisabled ? preventEvent : onMouseDownHandler,
       onClick: isDisabled ? preventEvent : onClick,
       "aria-current": isSelected ? 'page' : undefined,

package/dist/es2019/menu-item/custom-item.js

@@ -10,7 +10,7 @@ import { forwardRef, memo } from 'react';
 import { css, jsx } from '@emotion/react';
 import { propDeprecationWarning } from '@atlaskit/ds-lib/deprecation-warning';
 import noop from '@atlaskit/ds-lib/noop';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
+import { fg } from '@atlaskit/platform-feature-flags';
 import MenuItemPrimitive from '../internal/components/menu-item-primitive';
 const preventEvent = e => {
   e.preventDefault();
@@ -57,7 +57,7 @@ const CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(({
   return jsx(MenuItemPrimitive
   // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
   , _extends({
-    className: getBooleanFF('platform.design-system-team.unsafe-overrides-killswitch_c8j9m') ? undefined : UNSAFE_className
+    className: fg('platform.design-system-team.unsafe-overrides-killswitch_c8j9m') ? undefined : UNSAFE_className
   }, rest, {
     // eslint-disable-next-line @repo/internal/react/no-unsafe-overrides
     overrides: overrides,
@@ -86,9 +86,11 @@ const CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(({
   }, rest, {
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
     className: className,
-    ref: ref,
+    ref: ref
+  }, fg('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
     draggable: false,
-    onDragStart: preventEvent,
+    onDragStart: preventEvent
+  }, {
     onMouseDown: isDisabled ? preventEvent : onMouseDownHandler,
     onClick: isDisabled ? preventEvent : onClick,
     tabIndex: isDisabled ? -1 : undefined,

package/dist/es2019/menu-item/link-item.js

@@ -103,11 +103,11 @@ const LinkItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(
     className: className
     // @ts-expect-error
     ,
-    href: isDisabled ? undefined : href,
-    draggable: false
-    // eslint-disable-next-line @atlaskit/design-system/no-direct-use-of-web-platform-drag-and-drop
-    ,
-    onDragStart: preventEvent,
+    href: isDisabled ? undefined : href
+  }, fg('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
+    draggable: false,
+    onDragStart: preventEvent
+  }, {
     onMouseDown: isDisabled ? preventEvent : onMouseDownHandler,
     onClick: isDisabled ? preventEvent : onClick,
     "aria-current": isSelected ? 'page' : undefined,

package/dist/esm/menu-item/custom-item.js

@@ -12,7 +12,7 @@ import { forwardRef, memo } from 'react';
 import { css, jsx } from '@emotion/react';
 import { propDeprecationWarning } from '@atlaskit/ds-lib/deprecation-warning';
 import noop from '@atlaskit/ds-lib/noop';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
+import { fg } from '@atlaskit/platform-feature-flags';
 import MenuItemPrimitive from '../internal/components/menu-item-primitive';
 var preventEvent = function preventEvent(e) {
   e.preventDefault();
@@ -57,7 +57,7 @@ var CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(function (_ref, ref)
   return jsx(MenuItemPrimitive
   // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
   , _extends({
-    className: getBooleanFF('platform.design-system-team.unsafe-overrides-killswitch_c8j9m') ? undefined : UNSAFE_className
+    className: fg('platform.design-system-team.unsafe-overrides-killswitch_c8j9m') ? undefined : UNSAFE_className
   }, rest, {
     // eslint-disable-next-line @repo/internal/react/no-unsafe-overrides
     overrides: overrides,
@@ -86,9 +86,11 @@ var CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(function (_ref, ref)
     }, rest, {
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
       className: className,
-      ref: ref,
+      ref: ref
+    }, fg('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
       draggable: false,
-      onDragStart: preventEvent,
+      onDragStart: preventEvent
+    }, {
       onMouseDown: isDisabled ? preventEvent : onMouseDownHandler,
       onClick: isDisabled ? preventEvent : onClick,
       tabIndex: isDisabled ? -1 : undefined,

package/dist/esm/menu-item/link-item.js

@@ -102,11 +102,11 @@ function (props, ref) {
       className: className
       // @ts-expect-error
       ,
-      href: isDisabled ? undefined : href,
-      draggable: false
-      // eslint-disable-next-line @atlaskit/design-system/no-direct-use-of-web-platform-drag-and-drop
-      ,
-      onDragStart: preventEvent,
+      href: isDisabled ? undefined : href
+    }, fg('platform.wanjel.remove-drag-override-in-menu-items_l1dib') ? {} : {
+      draggable: false,
+      onDragStart: preventEvent
+    }, {
       onMouseDown: isDisabled ? preventEvent : onMouseDownHandler,
       onClick: isDisabled ? preventEvent : onClick,
       "aria-current": isSelected ? 'page' : undefined,

package/dist/types/types.d.ts

@@ -273,7 +273,7 @@ export interface CustomItemComponentProps {
     /**
      * Turns off the element being draggable.
      */
-    draggable: boolean;
+    draggable?: boolean;
     /**
      * React ref for the raw DOM element,
      * make sure to place this on the outermost DOM element.

package/dist/types-ts4.5/types.d.ts

@@ -273,7 +273,7 @@ export interface CustomItemComponentProps {
     /**
      * Turns off the element being draggable.
      */
-    draggable: boolean;
+    draggable?: boolean;
     /**
      * React ref for the raw DOM element,
      * make sure to place this on the outermost DOM element.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/menu",
-	"version": "2.7.0",
+	"version": "2.7.1",
 	"description": "A list of options to help users navigate, or perform actions.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -64,7 +64,7 @@
 		"@atlaskit/visual-regression": "*",
 		"@atlassian/feature-flags-test-utils": "*",
 		"@emotion/jest": "^11.8.0",
-		"@testing-library/dom": "^8.17.1",
+		"@testing-library/dom": "^10.1.0",
 		"@testing-library/react": "^12.1.5",
 		"@types/react-router-dom": "^4.3.1",
 		"ast-types": "^0.13.3",
@@ -132,6 +132,9 @@
 		},
 		"platform.wanjel.use-router-links-for-the-linkitem-component": {
 			"type": "boolean"
+		},
+		"platform.wanjel.remove-drag-override-in-menu-items_l1dib": {
+			"type": "boolean"
 		}
 	},
 	"homepage": "https://atlassian.design/components/menu/"