@atlaskit/menu 2.1.0 → 2.1.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/menu
 
+## 2.1.1
+
+### Patch Changes
+
+- [#41915](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/41915) [`99b579bdc84`](https://bitbucket.org/atlassian/atlassian-frontend/commits/99b579bdc84) - Fix error in codemod
+
 ## 2.1.0
 
 ### Minor Changes

package/codemods/2.1.0-invalid-link-item-to-button-item.tsx

@@ -133,44 +133,6 @@ function convertInvalidLinkItemsToButtonItems(
   });
 }
 
-function removeLinkItemImportIfNoLinkItemsExist(
-  j: core.JSCodeshift,
-  source: ReturnType<typeof j>,
-  specifier: string,
-) {
-  // Get all instances of LinkItem
-  const linkItemInstances = source.findJSXElements(specifier);
-
-  // if none, delete from imports
-  if (linkItemInstances.length === 0) {
-    source
-      .find(j.ImportDeclaration)
-      .filter((path) => path.node.source.value === pkg)
-      .forEach((moduleImport) => {
-        j(moduleImport).replaceWith(
-          j.importDeclaration(
-            moduleImport.node.specifiers &&
-              moduleImport.node.specifiers
-                .filter(
-                  // This should be `ImportSpecifier | ImportDefaultSpecifier |
-                  // ImportNamespaceSpecifier` but it still throws even though
-                  // I'm filtering
-                  (
-                    currentSpecifier: any,
-                  ): currentSpecifier is ImportSpecifier =>
-                    currentSpecifier?.imported,
-                )
-                .filter(
-                  (currentSpecifier: ImportSpecifier) =>
-                    currentSpecifier.imported.name !== specifier,
-                ),
-            moduleImport.node.source,
-          ),
-        );
-      });
-  }
-}
-
 function hasImportDeclaration(
   j: core.JSCodeshift,
   source: ReturnType<typeof j>,
@@ -193,7 +155,6 @@ export default function transformer(
 
     if (importSpecifier != null) {
       convertInvalidLinkItemsToButtonItems(j, source, importSpecifier);
-      removeLinkItemImportIfNoLinkItemsExist(j, source, importSpecifier);
     }
 
     return source.toSource(

package/codemods/__tests__/next-invalid-link-item-to-button-item.tsx

@@ -89,7 +89,7 @@ describe('Converts link items with invalid or missing `href` to button items', (
       }
     `,
     `
-      import { ButtonItem } from '@atlaskit/menu';
+      import { LinkItem, ButtonItem } from '@atlaskit/menu';
 
       const App = () => {
         return <ButtonItem>test</ButtonItem>;
@@ -109,7 +109,7 @@ describe('Converts link items with invalid or missing `href` to button items', (
       }
     `,
     `
-      import { ButtonItem } from '@atlaskit/menu';
+      import { LinkItem, ButtonItem } from '@atlaskit/menu';
 
       const App = () => {
         return <ButtonItem id="test">test</ButtonItem>;
@@ -135,7 +135,7 @@ describe('Converts link items with invalid or missing `href` to button items', (
       }
     `,
     `
-      import { ButtonItem } from '@atlaskit/menu';
+      import { LinkItem, ButtonItem } from '@atlaskit/menu';
 
       const App = () => {
         return <ButtonItem>test</ButtonItem>;
@@ -155,7 +155,7 @@ describe('Converts link items with invalid or missing `href` to button items', (
       }
     `,
     `
-      import { ButtonItem } from '@atlaskit/menu';
+      import { LinkItem, ButtonItem } from '@atlaskit/menu';
 
       const App = () => {
         return <ButtonItem id="test">test</ButtonItem>;
@@ -175,7 +175,7 @@ describe('Converts link items with invalid or missing `href` to button items', (
       }
     `,
     `
-      import { ButtonItem } from '@atlaskit/menu';
+      import { LinkItem, ButtonItem } from '@atlaskit/menu';
 
       const App = () => {
         return <ButtonItem>test</ButtonItem>;
@@ -201,7 +201,7 @@ describe('Converts link items with invalid or missing `href` to button items', (
       }
     `,
     `
-      import { ButtonItem } from '@atlaskit/menu';
+      import { LinkItem, ButtonItem } from '@atlaskit/menu';
 
       const App = () => {
         return <ButtonItem>test</ButtonItem>;
@@ -232,7 +232,7 @@ describe('Converts link items with invalid or missing `href` to button items', (
       }
     `,
     `
-      import { ButtonItem } from '@atlaskit/menu';
+      import { LinkItem, ButtonItem } from '@atlaskit/menu';
 
       const App = () => {
         return (
@@ -262,7 +262,7 @@ describe('Converts link items with invalid or missing `href` to button items', (
       }
     `,
     `
-      import { CustomItem, ButtonItem } from '@atlaskit/menu';
+      import { LinkItem, CustomItem, ButtonItem } from '@atlaskit/menu';
 
       const App = () => {
         return (
@@ -273,7 +273,7 @@ describe('Converts link items with invalid or missing `href` to button items', (
         );
       }
   `,
-    'Should not delete other imports',
+    'Should not delete any imports',
   );
 
   defineInlineTest(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/menu",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "description": "A collection of composable menu components that can be used anywhere.",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -31,7 +31,7 @@
     "@atlaskit/platform-feature-flags": "^0.2.0",
     "@atlaskit/primitives": "^1.6.0",
     "@atlaskit/theme": "^12.6.0",
-    "@atlaskit/tokens": "^1.27.0",
+    "@atlaskit/tokens": "^1.28.0",
     "@babel/runtime": "^7.0.0",
     "@emotion/react": "^11.7.1"
   },