@atlaskit/menu 1.2.1 → 1.2.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/menu
 
+## 1.2.2
+
+### Patch Changes
+
+- [`2eeb5c46710`](https://bitbucket.org/atlassian/atlassian-frontend/commits/2eeb5c46710) - Menu items can take `data-testid` directly again however we recommend to still use the officially supported `testId` prop instead. The `data-testid` prop was unintentionally removed in a previous version however will be removed as a breaking change in a later major version and remains not officially typed.
+
 ## 1.2.1
 
 ### Patch Changes

package/dist/cjs/internal/components/menu-item-primitive.js

@@ -159,7 +159,6 @@ var MenuItemPrimitive = function MenuItemPrimitive(_ref) {
       iconAfter = _ref.iconAfter,
       iconBefore = _ref.iconBefore,
       overrides = _ref.overrides,
-      testId = _ref.testId,
       className = _ref.className,
       _ref$shouldTitleWrap = _ref.shouldTitleWrap,
       shouldTitleWrap = _ref$shouldTitleWrap === void 0 ? false : _ref$shouldTitleWrap,
@@ -176,7 +175,6 @@ var MenuItemPrimitive = function MenuItemPrimitive(_ref) {
     return (0, _core.jsx)(_focusRing.default, {
       isInset: true
     }, children({
-      'data-testid': testId,
       className: cx([cn([primitiveStyles, !isDisabled && !isSelected && unselectedStyles, !isDisabled && isSelected && selectedStyles, isDisabled ? disabledStyles : interactiveStyles]), className]),
       children: (0, _core.jsx)(_react.Fragment, null, iconBefore && (0, _core.jsx)("span", {
         "data-item-elem-before": true,

package/dist/cjs/menu-item/button-item.js

@@ -59,7 +59,6 @@ function (props, ref) {
   return (0, _core.jsx)(_menuItemPrimitive.default, (0, _extends2.default)({}, rest, {
     // eslint-disable-next-line @repo/internal/react/no-unsafe-overrides
     overrides: overrides,
-    testId: testId,
     iconBefore: iconBefore,
     iconAfter: iconAfter,
     isDisabled: isDisabled,
@@ -75,8 +74,11 @@ function (props, ref) {
     })
   }), function (_ref) {
     var children = _ref.children,
-        props = (0, _objectWithoutProperties2.default)(_ref, ["children"]);
-    return (0, _core.jsx)("button", (0, _extends2.default)({}, rest, props, {
+        className = _ref.className;
+    return (0, _core.jsx)("button", (0, _extends2.default)({
+      "data-testid": testId
+    }, rest, {
+      className: className,
       ref: ref,
       disabled: isDisabled,
       onClick: onClick,

package/dist/cjs/menu-item/custom-item.js

@@ -70,8 +70,7 @@ var CustomItem = /*#__PURE__*/(0, _react.memo)( /*#__PURE__*/(0, _react.forwardR
     isSelected: isSelected,
     isDisabled: isDisabled,
     shouldTitleWrap: shouldTitleWrap,
-    shouldDescriptionWrap: shouldDescriptionWrap,
-    testId: testId // eslint-disable-next-line @repo/internal/react/consistent-css-prop-usage
+    shouldDescriptionWrap: shouldDescriptionWrap // eslint-disable-next-line @repo/internal/react/consistent-css-prop-usage
     ,
     css: (0, _core.css)(cssFn({
       isDisabled: isDisabled,
@@ -79,10 +78,12 @@ var CustomItem = /*#__PURE__*/(0, _react.memo)( /*#__PURE__*/(0, _react.forwardR
     }))
   }), function (_ref2) {
     var children = _ref2.children,
-        props = (0, _objectWithoutProperties2.default)(_ref2, ["children"]);
-    return (0, _core.jsx)(Component, (0, _extends2.default)({}, rest, props, {
+        className = _ref2.className;
+    return (0, _core.jsx)(Component, (0, _extends2.default)({
+      "data-testid": testId
+    }, rest, {
+      className: className,
       ref: ref,
-      "data-testid": testId,
       draggable: false,
       onDragStart: preventEvent,
       onMouseDown: isDisabled ? preventEvent : onMouseDownHandler,

package/dist/cjs/menu-item/link-item.js

@@ -76,12 +76,14 @@ function (props, ref) {
       isSelected: isSelected,
       isDisabled: isDisabled
     }),
-    title: children,
-    testId: testId
+    title: children
   }), function (_ref) {
     var children = _ref.children,
-        props = (0, _objectWithoutProperties2.default)(_ref, ["children"]);
-    return (0, _core.jsx)("a", (0, _extends2.default)({}, rest, props, {
+        className = _ref.className;
+    return (0, _core.jsx)("a", (0, _extends2.default)({
+      "data-testid": testId
+    }, rest, {
+      className: className,
       href: isDisabled ? undefined : href,
       draggable: false,
       onDragStart: preventEvent,

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/menu",
-	"version": "1.2.1",
+	"version": "1.2.2",
 	"sideEffects": false
 }

package/dist/es2019/internal/components/menu-item-primitive.js

@@ -142,7 +142,6 @@ const MenuItemPrimitive = ({
   iconAfter,
   iconBefore,
   overrides,
-  testId,
   className,
   shouldTitleWrap = false,
   shouldDescriptionWrap = false,
@@ -157,7 +156,6 @@ const MenuItemPrimitive = ({
     return jsx(FocusRing, {
       isInset: true
     }, children({
-      'data-testid': testId,
       className: cx([cn([primitiveStyles, !isDisabled && !isSelected && unselectedStyles, !isDisabled && isSelected && selectedStyles, isDisabled ? disabledStyles : interactiveStyles]), className]),
       children: jsx(Fragment, null, iconBefore && jsx("span", {
         "data-item-elem-before": true,

package/dist/es2019/menu-item/button-item.js

@@ -42,7 +42,6 @@ const ButtonItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef( // Type needed on
   return jsx(MenuItemPrimitive, _extends({}, rest, {
     // eslint-disable-next-line @repo/internal/react/no-unsafe-overrides
     overrides: overrides,
-    testId: testId,
     iconBefore: iconBefore,
     iconAfter: iconAfter,
     isDisabled: isDisabled,
@@ -58,8 +57,11 @@ const ButtonItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef( // Type needed on
     })
   }), ({
     children,
-    ...props
-  }) => jsx("button", _extends({}, rest, props, {
+    className
+  }) => jsx("button", _extends({
+    "data-testid": testId
+  }, rest, {
+    className: className,
     ref: ref,
     disabled: isDisabled,
     onClick: onClick,

package/dist/es2019/menu-item/custom-item.js

@@ -53,8 +53,7 @@ const CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(({
     isSelected: isSelected,
     isDisabled: isDisabled,
     shouldTitleWrap: shouldTitleWrap,
-    shouldDescriptionWrap: shouldDescriptionWrap,
-    testId: testId // eslint-disable-next-line @repo/internal/react/consistent-css-prop-usage
+    shouldDescriptionWrap: shouldDescriptionWrap // eslint-disable-next-line @repo/internal/react/consistent-css-prop-usage
     ,
     css: css(cssFn({
       isDisabled,
@@ -62,10 +61,12 @@ const CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(({
     }))
   }), ({
     children,
-    ...props
-  }) => jsx(Component, _extends({}, rest, props, {
+    className
+  }) => jsx(Component, _extends({
+    "data-testid": testId
+  }, rest, {
+    className: className,
     ref: ref,
-    "data-testid": testId,
     draggable: false,
     onDragStart: preventEvent,
     onMouseDown: isDisabled ? preventEvent : onMouseDownHandler,

package/dist/es2019/menu-item/link-item.js

@@ -60,12 +60,14 @@ const LinkItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef( // Type needed on p
       isSelected,
       isDisabled
     }),
-    title: children,
-    testId: testId
+    title: children
   }), ({
     children,
-    ...props
-  }) => jsx("a", _extends({}, rest, props, {
+    className
+  }) => jsx("a", _extends({
+    "data-testid": testId
+  }, rest, {
+    className: className,
     href: isDisabled ? undefined : href,
     draggable: false,
     onDragStart: preventEvent,

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/menu",
-	"version": "1.2.1",
+	"version": "1.2.2",
 	"sideEffects": false
 }

package/dist/esm/internal/components/menu-item-primitive.js

@@ -144,7 +144,6 @@ var MenuItemPrimitive = function MenuItemPrimitive(_ref) {
       iconAfter = _ref.iconAfter,
       iconBefore = _ref.iconBefore,
       overrides = _ref.overrides,
-      testId = _ref.testId,
       className = _ref.className,
       _ref$shouldTitleWrap = _ref.shouldTitleWrap,
       shouldTitleWrap = _ref$shouldTitleWrap === void 0 ? false : _ref$shouldTitleWrap,
@@ -161,7 +160,6 @@ var MenuItemPrimitive = function MenuItemPrimitive(_ref) {
     return jsx(FocusRing, {
       isInset: true
     }, children({
-      'data-testid': testId,
       className: cx([cn([primitiveStyles, !isDisabled && !isSelected && unselectedStyles, !isDisabled && isSelected && selectedStyles, isDisabled ? disabledStyles : interactiveStyles]), className]),
       children: jsx(Fragment, null, iconBefore && jsx("span", {
         "data-item-elem-before": true,

package/dist/esm/menu-item/button-item.js

@@ -45,7 +45,6 @@ function (props, ref) {
   return jsx(MenuItemPrimitive, _extends({}, rest, {
     // eslint-disable-next-line @repo/internal/react/no-unsafe-overrides
     overrides: overrides,
-    testId: testId,
     iconBefore: iconBefore,
     iconAfter: iconAfter,
     isDisabled: isDisabled,
@@ -61,9 +60,11 @@ function (props, ref) {
     })
   }), function (_ref) {
     var children = _ref.children,
-        props = _objectWithoutProperties(_ref, ["children"]);
-
-    return jsx("button", _extends({}, rest, props, {
+        className = _ref.className;
+    return jsx("button", _extends({
+      "data-testid": testId
+    }, rest, {
+      className: className,
       ref: ref,
       disabled: isDisabled,
       onClick: onClick,

package/dist/esm/menu-item/custom-item.js

@@ -57,8 +57,7 @@ var CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(function (_ref, ref)
     isSelected: isSelected,
     isDisabled: isDisabled,
     shouldTitleWrap: shouldTitleWrap,
-    shouldDescriptionWrap: shouldDescriptionWrap,
-    testId: testId // eslint-disable-next-line @repo/internal/react/consistent-css-prop-usage
+    shouldDescriptionWrap: shouldDescriptionWrap // eslint-disable-next-line @repo/internal/react/consistent-css-prop-usage
     ,
     css: css(cssFn({
       isDisabled: isDisabled,
@@ -66,11 +65,12 @@ var CustomItem = /*#__PURE__*/memo( /*#__PURE__*/forwardRef(function (_ref, ref)
     }))
   }), function (_ref2) {
     var children = _ref2.children,
-        props = _objectWithoutProperties(_ref2, ["children"]);
-
-    return jsx(Component, _extends({}, rest, props, {
+        className = _ref2.className;
+    return jsx(Component, _extends({
+      "data-testid": testId
+    }, rest, {
+      className: className,
       ref: ref,
-      "data-testid": testId,
       draggable: false,
       onDragStart: preventEvent,
       onMouseDown: isDisabled ? preventEvent : onMouseDownHandler,

package/dist/esm/menu-item/link-item.js

@@ -63,13 +63,14 @@ function (props, ref) {
       isSelected: isSelected,
       isDisabled: isDisabled
     }),
-    title: children,
-    testId: testId
+    title: children
   }), function (_ref) {
     var children = _ref.children,
-        props = _objectWithoutProperties(_ref, ["children"]);
-
-    return jsx("a", _extends({}, rest, props, {
+        className = _ref.className;
+    return jsx("a", _extends({
+      "data-testid": testId
+    }, rest, {
+      className: className,
       href: isDisabled ? undefined : href,
       draggable: false,
       onDragStart: preventEvent,

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/menu",
-	"version": "1.2.1",
+	"version": "1.2.2",
 	"sideEffects": false
 }

package/dist/types/internal/components/menu-item-primitive.d.ts

@@ -13,5 +13,5 @@ import type { MenuItemPrimitiveProps } from '../../types';
  * </MenuItemPrimitive>
  * ```
  */
-declare const MenuItemPrimitive: ({ children, title, description, iconAfter, iconBefore, overrides, testId, className, shouldTitleWrap, shouldDescriptionWrap, isDisabled, isSelected, }: MenuItemPrimitiveProps) => JSX.Element;
+declare const MenuItemPrimitive: ({ children, title, description, iconAfter, iconBefore, overrides, className, shouldTitleWrap, shouldDescriptionWrap, isDisabled, isSelected, }: MenuItemPrimitiveProps) => JSX.Element;
 export default MenuItemPrimitive;

package/dist/types/types.d.ts

@@ -96,7 +96,6 @@ export interface SectionProps {
 export interface MenuItemPrimitiveProps {
     children: (props: {
         className: string;
-        'data-testid': string | undefined;
         children: React.ReactNode;
     }) => JSX.Element;
     title: React.ReactNode | undefined;
@@ -109,7 +108,6 @@ export interface MenuItemPrimitiveProps {
     isDisabled: boolean | undefined;
     isSelected: boolean | undefined;
     className?: string;
-    testId?: string;
 }
 export interface MenuItemProps {
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/menu",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "A collection of composable menu components that can be used anywhere.",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"