@atlaskit/media-ui 25.8.0 → 25.9.0

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/media-ui
 
+## 25.9.0
+
+### Minor Changes
+
+- [#93302](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/93302) [`c370864d9ece`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/c370864d9ece) - Improve image dimensions logic for better reliability
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 25.8.0
 
 ### Minor Changes

package/dist/cjs/customMediaPlayer/index.js

@@ -54,7 +54,7 @@ function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflec
 function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); } /* eslint-disable @atlaskit/design-system/ensure-design-token-usage */ // Keep media player components used in media-viewer to use static colors from the new color palette to
 // support the hybrid theming in media viewer https://product-fabric.atlassian.net/browse/DSP-6067
 var packageName = "@atlaskit/media-ui";
-var packageVersion = "25.8.0";
+var packageVersion = "25.9.0";
 var MEDIUM_VIDEO_MAX_WIDTH = 400;
 var SMALL_VIDEO_MAX_WIDTH = 160;
 var MINIMUM_DURATION_BEFORE_SAVING_TIME = 60;

package/dist/cjs/imageMetaData/index.js

@@ -30,6 +30,7 @@ Object.defineProperty(exports, "isRotated", {
 exports.readImageMetaData = readImageMetaData;
 var _regenerator = _interopRequireDefault(require("@babel/runtime/regenerator"));
 var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/asyncToGenerator"));
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _types = require("./types");
 var _metatags = require("./metatags");
 var _util = require("../util");
@@ -185,7 +186,14 @@ function _readImageMetaData() {
             naturalHeight: height,
             tags: tags
           };
-          if (!(isImageRotated || width === 0 && height === 0)) {
+          /*
+           * The PixelXDimension and PixelYDimension of image tags can mean something different than just width and height, especially when images are compressed or for other reasons.
+           * https://imagemagick.org/discourse-server/viewtopic.php?t=27037
+           * We've also received JAC tickets reporting incorrect dimensions because of this
+           * https://jira.atlassian.com/browse/CONFCLOUD-78275
+           * The best way to get accurate dimensions is by loading images into the HTML, which reflects the actual dimensions the browser will render
+           */
+          if (!((0, _platformFeatureFlags.getBooleanFF)('platform.corex.html-image-dimensions_18x3l') || isImageRotated || width === 0 && height === 0)) {
             _context3.next = 27;
             break;
           }

package/dist/es2019/customMediaPlayer/index.js

@@ -37,7 +37,7 @@ import { SkipTenBackwardIcon, SkipTenForwardIcon } from './icons';
 import { getControlsWrapperClassName } from './getControlsWrapperClassName';
 import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 const packageName = "@atlaskit/media-ui";
-const packageVersion = "25.8.0";
+const packageVersion = "25.9.0";
 const MEDIUM_VIDEO_MAX_WIDTH = 400;
 const SMALL_VIDEO_MAX_WIDTH = 160;
 const MINIMUM_DURATION_BEFORE_SAVING_TIME = 60;

package/dist/es2019/imageMetaData/index.js

@@ -1,3 +1,4 @@
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { SupportedImageMetaTag, ExifOrientation } from './types';
 import { readImageMetaTags } from './metatags';
 import { loadImage, readImageNaturalOrientationFromDOM } from '../util';
@@ -113,7 +114,15 @@ export async function readImageMetaData(fileInfo) {
     naturalHeight: height,
     tags
   };
-  if (isImageRotated || width === 0 && height === 0) {
+
+  /*
+   * The PixelXDimension and PixelYDimension of image tags can mean something different than just width and height, especially when images are compressed or for other reasons.
+   * https://imagemagick.org/discourse-server/viewtopic.php?t=27037
+   * We've also received JAC tickets reporting incorrect dimensions because of this
+   * https://jira.atlassian.com/browse/CONFCLOUD-78275
+   * The best way to get accurate dimensions is by loading images into the HTML, which reflects the actual dimensions the browser will render
+   */
+  if (getBooleanFF('platform.corex.html-image-dimensions_18x3l') || isImageRotated || width === 0 && height === 0) {
     try {
       const img = await loadImage(src);
       const {

package/dist/esm/customMediaPlayer/index.js

@@ -47,7 +47,7 @@ import { SkipTenBackwardIcon, SkipTenForwardIcon } from './icons';
 import { getControlsWrapperClassName } from './getControlsWrapperClassName';
 import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 var packageName = "@atlaskit/media-ui";
-var packageVersion = "25.8.0";
+var packageVersion = "25.9.0";
 var MEDIUM_VIDEO_MAX_WIDTH = 400;
 var SMALL_VIDEO_MAX_WIDTH = 160;
 var MINIMUM_DURATION_BEFORE_SAVING_TIME = 60;

package/dist/esm/imageMetaData/index.js

@@ -1,5 +1,6 @@
 import _asyncToGenerator from "@babel/runtime/helpers/asyncToGenerator";
 import _regeneratorRuntime from "@babel/runtime/regenerator";
+import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { SupportedImageMetaTag, ExifOrientation } from './types';
 import { readImageMetaTags } from './metatags';
 import { loadImage, readImageNaturalOrientationFromDOM } from '../util';
@@ -156,7 +157,14 @@ function _readImageMetaData() {
             naturalHeight: height,
             tags: tags
           };
-          if (!(isImageRotated || width === 0 && height === 0)) {
+          /*
+           * The PixelXDimension and PixelYDimension of image tags can mean something different than just width and height, especially when images are compressed or for other reasons.
+           * https://imagemagick.org/discourse-server/viewtopic.php?t=27037
+           * We've also received JAC tickets reporting incorrect dimensions because of this
+           * https://jira.atlassian.com/browse/CONFCLOUD-78275
+           * The best way to get accurate dimensions is by loading images into the HTML, which reflects the actual dimensions the browser will render
+           */
+          if (!(getBooleanFF('platform.corex.html-image-dimensions_18x3l') || isImageRotated || width === 0 && height === 0)) {
             _context3.next = 27;
             break;
           }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/media-ui",
-  "version": "25.8.0",
+  "version": "25.9.0",
   "description": "Includes common components and utilities used by other media packages",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -24,7 +24,7 @@
   },
   "dependencies": {
     "@atlaskit/analytics-next": "^9.2.0",
-    "@atlaskit/button": "^17.12.0",
+    "@atlaskit/button": "^17.13.0",
     "@atlaskit/code": "^15.1.0",
     "@atlaskit/icon": "^22.1.0",
     "@atlaskit/icon-file-type": "^6.4.0",
@@ -115,6 +115,9 @@
   },
   "prettier": "@atlassian/atlassian-frontend-prettier-config-1.0.1",
   "platform-feature-flags": {
+    "platform.corex.html-image-dimensions_18x3l": {
+      "type": "boolean"
+    },
     "platform.editor.a11y_video_controls_keyboard_support_yhcxh": {
       "type": "boolean"
     }