@atlaskit/media-picker 70.1.4 → 70.1.6

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlaskit/media-picker
 
+## 70.1.6
+
+### Patch Changes
+
+- [`fa42797c7c89f`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/fa42797c7c89f) -
+  Remove feature gate add_media_picker_error_detail - always include error detail in analytics
+
+## 70.1.5
+
+### Patch Changes
+
+- [`7b2a6c98563cb`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/7b2a6c98563cb) -
+  Icon entry point migration update
+- Updated dependencies
+
 ## 70.1.4
 
 ### Patch Changes

package/dist/cjs/components/errorFlagGroup/ErrorFlagGroup.js

@@ -8,7 +8,7 @@ exports.default = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _react = _interopRequireDefault(require("react"));
 var _flag = require("@atlaskit/flag");
-var _crossCircle = _interopRequireDefault(require("@atlaskit/icon/core/migration/cross-circle"));
+var _crossCircle = _interopRequireDefault(require("@atlaskit/icon/core/cross-circle"));
 var _colors = require("@atlaskit/theme/colors");
 var _messages = require("./messages");
 var _reactIntlNext = require("react-intl-next");

package/dist/cjs/components/localUploadReact.js

@@ -18,7 +18,6 @@ var _react = require("react");
 var _perfMarks = require("perf-marks");
 var _mediaClient = require("@atlaskit/media-client");
 var _mediaCommon = require("@atlaskit/media-common");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _component = require("./component");
 var _uploadServiceImpl = require("../service/uploadServiceImpl");
 var _analytics = require("../util/analytics");
@@ -106,16 +105,14 @@ var LocalUploadComponentReact = exports.LocalUploadComponentReact = /*#__PURE__*
     });
     (0, _defineProperty2.default)(_this, "fireUploadFailed", /*#__PURE__*/function () {
       var _ref2 = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee(payload) {
-        var fileId, _payload$error, errorName, rawError, traceContext, _end2, _end2$duration, uploadDurationMsec, errorDetail, _rawError$innerError, _rawError$innerError2, requestMetadata;
+        var _rawError$innerError, _rawError$innerError2;
+        var fileId, _payload$error, errorName, rawError, traceContext, _end2, _end2$duration, uploadDurationMsec, errorDetail, requestMetadata;
         return _regenerator.default.wrap(function _callee$(_context) {
           while (1) switch (_context.prev = _context.next) {
             case 0:
               fileId = payload.fileId, _payload$error = payload.error, errorName = _payload$error.name, rawError = _payload$error.rawError, traceContext = payload.traceContext;
               _end2 = (0, _perfMarks.end)("MediaPicker.fireUpload.".concat(fileId)), _end2$duration = _end2.duration, uploadDurationMsec = _end2$duration === void 0 ? -1 : _end2$duration;
-              errorDetail = 'unknown';
-              if ((0, _platformFeatureFlags.fg)('add_media_picker_error_detail')) {
-                errorDetail = rawError && (0, _mediaClient.isCommonMediaClientError)(rawError) && (_rawError$innerError = rawError.innerError) !== null && _rawError$innerError !== void 0 && _rawError$innerError.message ? (_rawError$innerError2 = rawError.innerError) === null || _rawError$innerError2 === void 0 ? void 0 : _rawError$innerError2.message : rawError instanceof Error ? rawError.message : payload.error.description;
-              }
+              errorDetail = rawError && (0, _mediaClient.isCommonMediaClientError)(rawError) && (_rawError$innerError = rawError.innerError) !== null && _rawError$innerError !== void 0 && _rawError$innerError.message ? (_rawError$innerError2 = rawError.innerError) === null || _rawError$innerError2 === void 0 ? void 0 : _rawError$innerError2.message : rawError instanceof Error ? rawError.message : payload.error.description;
               requestMetadata = !!rawError ? (0, _analytics.getRequestMetadata)(rawError) : undefined;
               _this.createAndFireAnalyticsEvent({
                 eventType: 'operational',
@@ -149,7 +146,7 @@ var LocalUploadComponentReact = exports.LocalUploadComponentReact = /*#__PURE__*
                 },
                 uploadDurationMsec: uploadDurationMsec
               });
-            case 7:
+            case 6:
             case "end":
               return _context.stop();
           }

package/dist/es2019/components/errorFlagGroup/ErrorFlagGroup.js

@@ -1,6 +1,6 @@
 import React from 'react';
 import { AutoDismissFlag, FlagGroup } from '@atlaskit/flag';
-import FailIcon from '@atlaskit/icon/core/migration/cross-circle';
+import FailIcon from '@atlaskit/icon/core/cross-circle';
 import { R300 } from '@atlaskit/theme/colors';
 import { errorFlagMessages } from './messages';
 import { injectIntl, IntlProvider, useIntl } from 'react-intl-next';

package/dist/es2019/components/localUploadReact.js

@@ -3,7 +3,6 @@ import { Component } from 'react';
 import { start, end } from 'perf-marks';
 import { getMediaClientErrorReason, isCommonMediaClientError } from '@atlaskit/media-client';
 import { ANALYTICS_MEDIA_CHANNEL } from '@atlaskit/media-common';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { UploadComponent } from './component';
 import { UploadServiceImpl } from '../service/uploadServiceImpl';
 import { getRequestMetadata } from '../util/analytics';
@@ -92,6 +91,7 @@ export class LocalUploadComponentReact extends Component {
       });
     });
     _defineProperty(this, "fireUploadFailed", async payload => {
+      var _rawError$innerError, _rawError$innerError2;
       const {
         fileId,
         error: {
@@ -103,11 +103,7 @@ export class LocalUploadComponentReact extends Component {
       const {
         duration: uploadDurationMsec = -1
       } = end(`MediaPicker.fireUpload.${fileId}`);
-      let errorDetail = 'unknown';
-      if (fg('add_media_picker_error_detail')) {
-        var _rawError$innerError, _rawError$innerError2;
-        errorDetail = rawError && isCommonMediaClientError(rawError) && (_rawError$innerError = rawError.innerError) !== null && _rawError$innerError !== void 0 && _rawError$innerError.message ? (_rawError$innerError2 = rawError.innerError) === null || _rawError$innerError2 === void 0 ? void 0 : _rawError$innerError2.message : rawError instanceof Error ? rawError.message : payload.error.description;
-      }
+      const errorDetail = rawError && isCommonMediaClientError(rawError) && (_rawError$innerError = rawError.innerError) !== null && _rawError$innerError !== void 0 && _rawError$innerError.message ? (_rawError$innerError2 = rawError.innerError) === null || _rawError$innerError2 === void 0 ? void 0 : _rawError$innerError2.message : rawError instanceof Error ? rawError.message : payload.error.description;
       const requestMetadata = !!rawError ? getRequestMetadata(rawError) : undefined;
       this.createAndFireAnalyticsEvent({
         eventType: 'operational',

package/dist/esm/components/errorFlagGroup/ErrorFlagGroup.js

@@ -3,7 +3,7 @@ function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbol
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import React from 'react';
 import { AutoDismissFlag, FlagGroup } from '@atlaskit/flag';
-import FailIcon from '@atlaskit/icon/core/migration/cross-circle';
+import FailIcon from '@atlaskit/icon/core/cross-circle';
 import { R300 } from '@atlaskit/theme/colors';
 import { errorFlagMessages } from './messages';
 import { injectIntl, IntlProvider, useIntl } from 'react-intl-next';

package/dist/esm/components/localUploadReact.js

@@ -13,7 +13,6 @@ import { Component } from 'react';
 import { start, end } from 'perf-marks';
 import { getMediaClientErrorReason, isCommonMediaClientError } from '@atlaskit/media-client';
 import { ANALYTICS_MEDIA_CHANNEL } from '@atlaskit/media-common';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { UploadComponent } from './component';
 import { UploadServiceImpl } from '../service/uploadServiceImpl';
 import { getRequestMetadata } from '../util/analytics';
@@ -99,16 +98,14 @@ export var LocalUploadComponentReact = /*#__PURE__*/function (_Component) {
     });
     _defineProperty(_this, "fireUploadFailed", /*#__PURE__*/function () {
       var _ref2 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee(payload) {
-        var fileId, _payload$error, errorName, rawError, traceContext, _end2, _end2$duration, uploadDurationMsec, errorDetail, _rawError$innerError, _rawError$innerError2, requestMetadata;
+        var _rawError$innerError, _rawError$innerError2;
+        var fileId, _payload$error, errorName, rawError, traceContext, _end2, _end2$duration, uploadDurationMsec, errorDetail, requestMetadata;
         return _regeneratorRuntime.wrap(function _callee$(_context) {
           while (1) switch (_context.prev = _context.next) {
             case 0:
               fileId = payload.fileId, _payload$error = payload.error, errorName = _payload$error.name, rawError = _payload$error.rawError, traceContext = payload.traceContext;
               _end2 = end("MediaPicker.fireUpload.".concat(fileId)), _end2$duration = _end2.duration, uploadDurationMsec = _end2$duration === void 0 ? -1 : _end2$duration;
-              errorDetail = 'unknown';
-              if (fg('add_media_picker_error_detail')) {
-                errorDetail = rawError && isCommonMediaClientError(rawError) && (_rawError$innerError = rawError.innerError) !== null && _rawError$innerError !== void 0 && _rawError$innerError.message ? (_rawError$innerError2 = rawError.innerError) === null || _rawError$innerError2 === void 0 ? void 0 : _rawError$innerError2.message : rawError instanceof Error ? rawError.message : payload.error.description;
-              }
+              errorDetail = rawError && isCommonMediaClientError(rawError) && (_rawError$innerError = rawError.innerError) !== null && _rawError$innerError !== void 0 && _rawError$innerError.message ? (_rawError$innerError2 = rawError.innerError) === null || _rawError$innerError2 === void 0 ? void 0 : _rawError$innerError2.message : rawError instanceof Error ? rawError.message : payload.error.description;
               requestMetadata = !!rawError ? getRequestMetadata(rawError) : undefined;
               _this.createAndFireAnalyticsEvent({
                 eventType: 'operational',
@@ -142,7 +139,7 @@ export var LocalUploadComponentReact = /*#__PURE__*/function (_Component) {
                 },
                 uploadDurationMsec: uploadDurationMsec
               });
-            case 7:
+            case 6:
             case "end":
               return _context.stop();
           }

package/example-helpers/stylesWrapper.tsx

@@ -22,22 +22,22 @@ import {
 	uploadPreviewsFlexRowStyles,
 } from './styles';
 
-export const PopupContainer = ({ children }: { children: ReactNode }) => {
+export const PopupContainer = ({ children }: { children: ReactNode }): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
 	return <div css={popupContainerStyles}>{children}</div>;
 };
 
-export const PopupHeader = ({ children }: { children: ReactNode }) => {
+export const PopupHeader = ({ children }: { children: ReactNode }): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
 	return <div css={popupHeaderStyles}>{children}</div>;
 };
 
-export const PreviewImageWrapper = ({ children }: { children: ReactNode }) => {
+export const PreviewImageWrapper = ({ children }: { children: ReactNode }): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
 	return <div css={previewImageWrapperStyles}>{children}</div>;
 };
 
-export const InfoWrapper = ({ children }: { children: ReactNode }) => {
+export const InfoWrapper = ({ children }: { children: ReactNode }): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
 	return <pre css={infoWrapperStyles}>{children}</pre>;
 };
@@ -49,27 +49,27 @@ export const DropzoneContainer = forwardRef(({ isActive }: { isActive: boolean }
 	);
 });
 
-export const DropzoneContentWrapper = ({ children }: { children: ReactNode }) => {
+export const DropzoneContentWrapper = ({ children }: { children: ReactNode }): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
 	return <div css={dropzoneContentWrapperStyles}>{children}</div>;
 };
 
-export const PreviewsWrapper = ({ children }: { children: ReactNode }) => {
+export const PreviewsWrapper = ({ children }: { children: ReactNode }): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
 	return <div css={previewsWrapperStyles}>{children}</div>;
 };
 
-export const PreviewsTitle = ({ children }: { children: ReactNode }) => {
+export const PreviewsTitle = ({ children }: { children: ReactNode }): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/use-heading -- Ignored via go/DSP-18766
 	return <h1 css={previewsTitleStyles}>{children}</h1>;
 };
 
-export const UploadPreviewsFlexRow = ({ children }: { children: ReactNode }) => {
+export const UploadPreviewsFlexRow = ({ children }: { children: ReactNode }): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
 	return <div css={uploadPreviewsFlexRowStyles}>{children}</div>;
 };
 
-export const DropzoneItemsInfo = ({ children }: { children: ReactNode }) => {
+export const DropzoneItemsInfo = ({ children }: { children: ReactNode }): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
 	return <div css={dropzoneItemsInfoStyles}>{children}</div>;
 };
@@ -80,12 +80,12 @@ export const ClipboardContainer = ({
 }: {
 	isWindowFocused: boolean;
 	children: ReactNode;
-}) => {
+}): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
 	return <div css={clipboardContainerStyles({ isWindowFocused })}>{children}</div>;
 };
 
-export const InfoContainer = ({ children }: { children: ReactNode }) => {
+export const InfoContainer = ({ children }: { children: ReactNode }): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values -- Ignored via go/DSP-18766
 	return <div css={infoContainerStyles}>{children}</div>;
 };
@@ -101,7 +101,7 @@ type PastedImageProps = {
 	style: PastedImageStyleType;
 };
 
-export const PastedImage = ({ src, style, title }: PastedImageProps) => {
+export const PastedImage = ({ src, style, title }: PastedImageProps): React.JSX.Element => {
 	// eslint-disable-next-line @atlaskit/design-system/consistent-css-prop-usage, @atlaskit/ui-styling-standard/no-imported-style-values, @atlassian/a11y/alt-text -- Ignored via go/DSP-18766
 	return <img src={src} title={title} css={pastedImageStyles(style)} />;
 };

package/example-helpers/upload-previews.tsx

@@ -27,7 +27,7 @@ export class UploadPreviews extends React.Component<PreviewsDataProps, PreviewsD
 		previewsData: [],
 	};
 
-	onUploadsStart = (event: UploadsStartEventPayload) => {
+	onUploadsStart = (event: UploadsStartEventPayload): void => {
 		const { previewsData } = this.state;
 		const { files } = event;
 
@@ -44,7 +44,7 @@ export class UploadPreviews extends React.Component<PreviewsDataProps, PreviewsD
 		});
 	};
 
-	onPreviewUpdate = (data: UploadPreviewUpdateEventPayload) => {
+	onPreviewUpdate = (data: UploadPreviewUpdateEventPayload): void => {
 		const { previewsData } = this.state;
 		const currentItem = previewsData[previewsData.length - 1];
 		currentItem.preview = data.preview;
@@ -53,7 +53,7 @@ export class UploadPreviews extends React.Component<PreviewsDataProps, PreviewsD
 		});
 	};
 
-	onError = (data: UploadErrorEventPayload) => {
+	onError = (data: UploadErrorEventPayload): void => {
 		console.log('upload error:', data);
 	};
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/media-picker",
-	"version": "70.1.4",
+	"version": "70.1.6",
 	"description": "Library for handling file uploads",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -38,7 +38,7 @@
 		"@atlaskit/media-ui": "^28.7.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/theme": "^21.0.0",
-		"@atlaskit/tokens": "^9.0.0",
+		"@atlaskit/tokens": "^9.1.0",
 		"@atlaskit/ufo": "^0.4.0",
 		"@babel/runtime": "^7.0.0",
 		"eventemitter2": "^4.1.0",
@@ -54,7 +54,7 @@
 		"react-intl-next": "npm:react-intl@^5.18.1"
 	},
 	"devDependencies": {
-		"@atlaskit/analytics-listeners": "^9.1.0",
+		"@atlaskit/analytics-listeners": "^9.2.0",
 		"@atlaskit/analytics-namespaced-context": "^7.2.0",
 		"@atlaskit/button": "^23.9.0",
 		"@atlaskit/media-core": "^37.0.0",
@@ -90,9 +90,6 @@
 		"should-render-to-parent-should-be-true-media-exif": {
 			"type": "boolean"
 		},
-		"add_media_picker_error_detail": {
-			"type": "boolean"
-		},
 		"jfp-magma-media-clipboard-init-after-mount": {
 			"type": "boolean"
 		}