@atlaskit/media-common 2.19.2 → 3.0.0

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/media-common
 
+## 3.0.0
+
+### Major Changes
+
+- [`c2bc38829e1`](https://bitbucket.org/atlassian/atlassian-frontend/commits/c2bc38829e1) - Removed mediaUploadApiV2 feature flag (now as a breaking change)
+
+### Minor Changes
+
+- [`8a0a92b2885`](https://bitbucket.org/atlassian/atlassian-frontend/commits/8a0a92b2885) - MEX-2210 improve inconsistent behaviour on timestampOnVideo playback
+
 ## 2.19.2
 
 ### Patch Changes

package/dist/cjs/index.js

@@ -117,6 +117,12 @@ Object.defineProperty(exports, "isUnknownMimeTypeSupportedByServer", {
     return _mediaTypeUtils.isUnknownMimeTypeSupportedByServer;
   }
 });
+Object.defineProperty(exports, "isVideoMimeTypeSupportedByBrowser", {
+  enumerable: true,
+  get: function get() {
+    return _mediaTypeUtils.isVideoMimeTypeSupportedByBrowser;
+  }
+});
 Object.defineProperty(exports, "isVideoMimeTypeSupportedByServer", {
   enumerable: true,
   get: function get() {

package/dist/cjs/mediaFeatureFlags/mediaFeatureFlags.js

@@ -26,8 +26,6 @@ var areEqualFeatureFlags = function areEqualFeatureFlags(ffA, ffB) {
     folderUploads: ffA.folderUploads === ffB.folderUploads,
     observedWidth: ffA.observedWidth === ffB.observedWidth,
     timestampOnVideo: ffA.timestampOnVideo === ffB.timestampOnVideo,
-    // @ts-ignore
-    mediaUploadApiV2: ffA.mediaUploadApiV2 === ffB.mediaUploadApiV2,
     memoryCacheLogging: ffA.memoryCacheLogging === ffB.memoryCacheLogging,
     fetchFileStateAfterUpload: ffA.fetchFileStateAfterUpload === ffB.fetchFileStateAfterUpload
   };
@@ -81,7 +79,17 @@ var filterFeatureFlagKeysAllProducts = function filterFeatureFlagKeysAllProducts
   });
 };
 
-// default values defined here, not necessary for components to know directly as they should use the function below
+/**
+ * defaultMediaFeatureFlags set default values used by the getter function getMediaFeatureFlag
+ *
+ * *************************************
+ * ************* IMPORTANT *************
+ * *************************************
+ * Only in exceptional cases a FF should be 'true' by default.
+ * Making a flag default to 'true' can lead to confusing and unexpected scenarios.
+ * If you must set a flag default = true, whenever you remove that flag
+ * that change should be released as a MAJOR, because it's a breaking change.
+ */
 exports.filterFeatureFlagKeysAllProducts = filterFeatureFlagKeysAllProducts;
 var defaultMediaFeatureFlags = {
   newCardExperience: false,
@@ -92,8 +100,6 @@ var defaultMediaFeatureFlags = {
   folderUploads: false,
   observedWidth: false,
   timestampOnVideo: false,
-  // @ts-ignore
-  mediaUploadApiV2: true,
   memoryCacheLogging: false,
   fetchFileStateAfterUpload: false
 };

package/dist/cjs/mediaFeatureFlags/productKeys.js

@@ -13,8 +13,6 @@ var productKeys = {
     //TODO fill the value after https://product-fabric.atlassian.net/browse/MEX-1593
     observedWidth: '',
     timestampOnVideo: 'confluence.frontend.media.timestamp.on.video',
-    // @ts-ignore
-    mediaUploadApiV2: 'confluence.enable.media.upload.api.v2',
     memoryCacheLogging: 'confluence-frontend-media-card-memory-cache-logging',
     fetchFileStateAfterUpload: 'confluence-frontend-media-client-fetch-file-state-after-upload'
   },
@@ -27,8 +25,6 @@ var productKeys = {
     //TODO fill the value after https://product-fabric.atlassian.net/browse/MEX-1593
     observedWidth: '',
     timestampOnVideo: 'issue.details.media-cards-timestamp-on-video',
-    // @ts-ignore
-    mediaUploadApiV2: 'issue.details.enable-media-upload-api-version-2',
     memoryCacheLogging: 'jira-frontend-media-card-memory-cache-logging',
     fetchFileStateAfterUpload: 'jira-frontend-media-client-fetch-file-state-after-upload'
   }

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/media-common",
-	"version": "2.19.2",
+	"version": "3.0.0",
 	"sideEffects": false
 }

package/dist/es2019/index.js

@@ -9,5 +9,5 @@ export { withMediaAnalyticsContext } from './analytics/withMediaAnalyticsContext
 
 // Analytics constants
 export { ANALYTICS_MEDIA_CHANNEL } from './analytics/constants';
-export { getMediaTypeFromMimeType, isImageMimeTypeSupportedByBrowser, isDocumentMimeTypeSupportedByBrowser, isMimeTypeSupportedByBrowser, isImageMimeTypeSupportedByServer, isDocumentMimeTypeSupportedByServer, isAudioMimeTypeSupportedByServer, isVideoMimeTypeSupportedByServer, isUnknownMimeTypeSupportedByServer, isMimeTypeSupportedByServer } from './mediaTypeUtils';
+export { getMediaTypeFromMimeType, isImageMimeTypeSupportedByBrowser, isDocumentMimeTypeSupportedByBrowser, isVideoMimeTypeSupportedByBrowser, isMimeTypeSupportedByBrowser, isImageMimeTypeSupportedByServer, isDocumentMimeTypeSupportedByServer, isAudioMimeTypeSupportedByServer, isVideoMimeTypeSupportedByServer, isUnknownMimeTypeSupportedByServer, isMimeTypeSupportedByServer } from './mediaTypeUtils';
 export { isUndefined, pick, omitBy, debounce, matches, getRandomHex } from './utils/helpers';

package/dist/es2019/mediaFeatureFlags/mediaFeatureFlags.js

@@ -16,8 +16,6 @@ export const areEqualFeatureFlags = (ffA, ffB) => {
     folderUploads: ffA.folderUploads === ffB.folderUploads,
     observedWidth: ffA.observedWidth === ffB.observedWidth,
     timestampOnVideo: ffA.timestampOnVideo === ffB.timestampOnVideo,
-    // @ts-ignore
-    mediaUploadApiV2: ffA.mediaUploadApiV2 === ffB.mediaUploadApiV2,
     memoryCacheLogging: ffA.memoryCacheLogging === ffB.memoryCacheLogging,
     fetchFileStateAfterUpload: ffA.fetchFileStateAfterUpload === ffB.fetchFileStateAfterUpload
   };
@@ -49,7 +47,17 @@ export const filterFeatureFlagKeysAllProducts = flags => {
   return ldFeatureFlags.filter(flag => flag !== '');
 };
 
-// default values defined here, not necessary for components to know directly as they should use the function below
+/**
+ * defaultMediaFeatureFlags set default values used by the getter function getMediaFeatureFlag
+ *
+ * *************************************
+ * ************* IMPORTANT *************
+ * *************************************
+ * Only in exceptional cases a FF should be 'true' by default.
+ * Making a flag default to 'true' can lead to confusing and unexpected scenarios.
+ * If you must set a flag default = true, whenever you remove that flag
+ * that change should be released as a MAJOR, because it's a breaking change.
+ */
 export const defaultMediaFeatureFlags = {
   newCardExperience: false,
   captions: false,
@@ -59,8 +67,6 @@ export const defaultMediaFeatureFlags = {
   folderUploads: false,
   observedWidth: false,
   timestampOnVideo: false,
-  // @ts-ignore
-  mediaUploadApiV2: true,
   memoryCacheLogging: false,
   fetchFileStateAfterUpload: false
 };

package/dist/es2019/mediaFeatureFlags/productKeys.js

@@ -7,8 +7,6 @@ const productKeys = {
     //TODO fill the value after https://product-fabric.atlassian.net/browse/MEX-1593
     observedWidth: '',
     timestampOnVideo: 'confluence.frontend.media.timestamp.on.video',
-    // @ts-ignore
-    mediaUploadApiV2: 'confluence.enable.media.upload.api.v2',
     memoryCacheLogging: 'confluence-frontend-media-card-memory-cache-logging',
     fetchFileStateAfterUpload: 'confluence-frontend-media-client-fetch-file-state-after-upload'
   },
@@ -21,8 +19,6 @@ const productKeys = {
     //TODO fill the value after https://product-fabric.atlassian.net/browse/MEX-1593
     observedWidth: '',
     timestampOnVideo: 'issue.details.media-cards-timestamp-on-video',
-    // @ts-ignore
-    mediaUploadApiV2: 'issue.details.enable-media-upload-api-version-2',
     memoryCacheLogging: 'jira-frontend-media-card-memory-cache-logging',
     fetchFileStateAfterUpload: 'jira-frontend-media-client-fetch-file-state-after-upload'
   }

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/media-common",
-	"version": "2.19.2",
+	"version": "3.0.0",
 	"sideEffects": false
 }

package/dist/esm/index.js

@@ -9,5 +9,5 @@ export { withMediaAnalyticsContext } from './analytics/withMediaAnalyticsContext
 
 // Analytics constants
 export { ANALYTICS_MEDIA_CHANNEL } from './analytics/constants';
-export { getMediaTypeFromMimeType, isImageMimeTypeSupportedByBrowser, isDocumentMimeTypeSupportedByBrowser, isMimeTypeSupportedByBrowser, isImageMimeTypeSupportedByServer, isDocumentMimeTypeSupportedByServer, isAudioMimeTypeSupportedByServer, isVideoMimeTypeSupportedByServer, isUnknownMimeTypeSupportedByServer, isMimeTypeSupportedByServer } from './mediaTypeUtils';
+export { getMediaTypeFromMimeType, isImageMimeTypeSupportedByBrowser, isDocumentMimeTypeSupportedByBrowser, isVideoMimeTypeSupportedByBrowser, isMimeTypeSupportedByBrowser, isImageMimeTypeSupportedByServer, isDocumentMimeTypeSupportedByServer, isAudioMimeTypeSupportedByServer, isVideoMimeTypeSupportedByServer, isUnknownMimeTypeSupportedByServer, isMimeTypeSupportedByServer } from './mediaTypeUtils';
 export { isUndefined, pick, omitBy, debounce, matches, getRandomHex } from './utils/helpers';

package/dist/esm/mediaFeatureFlags/mediaFeatureFlags.js

@@ -17,8 +17,6 @@ export var areEqualFeatureFlags = function areEqualFeatureFlags(ffA, ffB) {
     folderUploads: ffA.folderUploads === ffB.folderUploads,
     observedWidth: ffA.observedWidth === ffB.observedWidth,
     timestampOnVideo: ffA.timestampOnVideo === ffB.timestampOnVideo,
-    // @ts-ignore
-    mediaUploadApiV2: ffA.mediaUploadApiV2 === ffB.mediaUploadApiV2,
     memoryCacheLogging: ffA.memoryCacheLogging === ffB.memoryCacheLogging,
     fetchFileStateAfterUpload: ffA.fetchFileStateAfterUpload === ffB.fetchFileStateAfterUpload
   };
@@ -69,7 +67,17 @@ export var filterFeatureFlagKeysAllProducts = function filterFeatureFlagKeysAllP
   });
 };
 
-// default values defined here, not necessary for components to know directly as they should use the function below
+/**
+ * defaultMediaFeatureFlags set default values used by the getter function getMediaFeatureFlag
+ *
+ * *************************************
+ * ************* IMPORTANT *************
+ * *************************************
+ * Only in exceptional cases a FF should be 'true' by default.
+ * Making a flag default to 'true' can lead to confusing and unexpected scenarios.
+ * If you must set a flag default = true, whenever you remove that flag
+ * that change should be released as a MAJOR, because it's a breaking change.
+ */
 export var defaultMediaFeatureFlags = {
   newCardExperience: false,
   captions: false,
@@ -79,8 +87,6 @@ export var defaultMediaFeatureFlags = {
   folderUploads: false,
   observedWidth: false,
   timestampOnVideo: false,
-  // @ts-ignore
-  mediaUploadApiV2: true,
   memoryCacheLogging: false,
   fetchFileStateAfterUpload: false
 };

package/dist/esm/mediaFeatureFlags/productKeys.js

@@ -7,8 +7,6 @@ var productKeys = {
     //TODO fill the value after https://product-fabric.atlassian.net/browse/MEX-1593
     observedWidth: '',
     timestampOnVideo: 'confluence.frontend.media.timestamp.on.video',
-    // @ts-ignore
-    mediaUploadApiV2: 'confluence.enable.media.upload.api.v2',
     memoryCacheLogging: 'confluence-frontend-media-card-memory-cache-logging',
     fetchFileStateAfterUpload: 'confluence-frontend-media-client-fetch-file-state-after-upload'
   },
@@ -21,8 +19,6 @@ var productKeys = {
     //TODO fill the value after https://product-fabric.atlassian.net/browse/MEX-1593
     observedWidth: '',
     timestampOnVideo: 'issue.details.media-cards-timestamp-on-video',
-    // @ts-ignore
-    mediaUploadApiV2: 'issue.details.enable-media-upload-api-version-2',
     memoryCacheLogging: 'jira-frontend-media-card-memory-cache-logging',
     fetchFileStateAfterUpload: 'jira-frontend-media-client-fetch-file-state-after-upload'
   }

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/media-common",
-	"version": "2.19.2",
+	"version": "3.0.0",
 	"sideEffects": false
 }

package/dist/types/index.d.ts

@@ -10,7 +10,7 @@ export interface NumericalCardDimensions {
 export type { PackageAttributes, WithFileAttributes, WithPerformanceAttributes, WithTraceContext, FileAttributes, PerformanceAttributes, SuccessAttributes, FailureAttributes, OperationalAttributes, OperationalEventPayload, UIAttributes, UIEventPayload, ScreenAttributes, ScreenEventPayload, TrackAttributes, TrackEventPayload, ContextPublicAttributes, ContextStaticProps, } from './analytics/types';
 export { withMediaAnalyticsContext } from './analytics/withMediaAnalyticsContext';
 export { ANALYTICS_MEDIA_CHANNEL } from './analytics/constants';
-export { getMediaTypeFromMimeType, isImageMimeTypeSupportedByBrowser, isDocumentMimeTypeSupportedByBrowser, isMimeTypeSupportedByBrowser, isImageMimeTypeSupportedByServer, isDocumentMimeTypeSupportedByServer, isAudioMimeTypeSupportedByServer, isVideoMimeTypeSupportedByServer, isUnknownMimeTypeSupportedByServer, isMimeTypeSupportedByServer, } from './mediaTypeUtils';
+export { getMediaTypeFromMimeType, isImageMimeTypeSupportedByBrowser, isDocumentMimeTypeSupportedByBrowser, isVideoMimeTypeSupportedByBrowser, isMimeTypeSupportedByBrowser, isImageMimeTypeSupportedByServer, isDocumentMimeTypeSupportedByServer, isAudioMimeTypeSupportedByServer, isVideoMimeTypeSupportedByServer, isUnknownMimeTypeSupportedByServer, isMimeTypeSupportedByServer, } from './mediaTypeUtils';
 export declare type SSR = 'client' | 'server';
 export { isUndefined, pick, omitBy, debounce, matches, getRandomHex, } from './utils/helpers';
 export declare type MediaTraceContext = {

package/dist/types/mediaFeatureFlags/mediaFeatureFlags.d.ts

@@ -11,6 +11,17 @@ export declare const mapAndFilterFeatureFlagNames: (flags: RequiredMediaFeatureF
  * Returns the Launch Darkly Keys from all products for each of the flags set as true in the input record.
  * */
 export declare const filterFeatureFlagKeysAllProducts: (flags: RequiredMediaFeatureFlags) => Array<string>;
+/**
+ * defaultMediaFeatureFlags set default values used by the getter function getMediaFeatureFlag
+ *
+ * *************************************
+ * ************* IMPORTANT *************
+ * *************************************
+ * Only in exceptional cases a FF should be 'true' by default.
+ * Making a flag default to 'true' can lead to confusing and unexpected scenarios.
+ * If you must set a flag default = true, whenever you remove that flag
+ * that change should be released as a MAJOR, because it's a breaking change.
+ */
 export declare const defaultMediaFeatureFlags: Required<MediaFeatureFlags>;
 /**
  * Public accessor from components to fallback to defaults if flags not passed,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/media-common",
-  "version": "2.19.2",
+  "version": "3.0.0",
   "description": "Includes common utilities used by other media packages",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"

package/report.api.md

@@ -50,7 +50,7 @@ export const debounce: (
   wait: number,
 ) => (...args: any[]) => void;
 
-// @public (undocumented)
+// @public
 export const defaultMediaFeatureFlags: Required<MediaFeatureFlags>;
 
 // @public (undocumented)
@@ -142,6 +142,9 @@ export const isUndefined: (value: any) => boolean;
 // @public (undocumented)
 export const isUnknownMimeTypeSupportedByServer: (mimeType: string) => boolean;
 
+// @public
+export const isVideoMimeTypeSupportedByBrowser: (mimeType: string) => boolean;
+
 // @public (undocumented)
 export const isVideoMimeTypeSupportedByServer: (mimeType: string) => boolean;