@atlaskit/media-client 37.7.6 → 38.0.0

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/media-client
 
+## 38.0.0
+
+### Major Changes
+
+- [`59efe37532b46`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/59efe37532b46) -
+  `UploadableFile.size` is now a required field instead of optional, and the size is consistently
+  forwarded to downstream services.
+
+  Because `size` is now always available, `createFileFromUpload` sends `conditions.size` in the
+  request body unconditionally, instead of only sending it when the size happened to be truthy. This
+  lets downstream services validate the number of bytes they received against the size the client
+  declared, rather than accepting an upload whose expected size is unknown.
+
+  Accordingly, `MediaStoreCreateFileFromUploadBody.conditions` and its `size` are now required
+  rather than optional.
+
 ## 37.7.6
 
 ### Patch Changes

package/dist/cjs/uploader/index.js

@@ -99,28 +99,23 @@ var createProcessingFunction = function createProcessingFunction(store, deferred
 };
 var createFileFromUpload = /*#__PURE__*/function () {
   var _ref4 = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee4(file, store, uploadableFileUpfrontIds, uploadId, traceContext) {
-    var collection, name, mimeType, content, id, occurrenceKey, body;
+    var collection, name, mimeType, content, id, occurrenceKey;
     return _regenerator.default.wrap(function (_context4) {
       while (1) switch (_context4.prev = _context4.next) {
         case 0:
           collection = file.collection, name = file.name, mimeType = file.mimeType, content = file.content;
           id = uploadableFileUpfrontIds.id, occurrenceKey = uploadableFileUpfrontIds.occurrenceKey; // If the file is a Blob and the size is not passed from consumer, set the file size from file content
           if (content instanceof Blob && !file.size) {
-            file.size = content === null || content === void 0 ? void 0 : content.size;
+            file.size = content.size;
           }
-          body = file.size ? {
+          return _context4.abrupt("return", store.createFileFromUpload({
             uploadId: uploadId,
             name: name,
             mimeType: mimeType,
             conditions: {
               size: file.size
             }
-          } : {
-            uploadId: uploadId,
-            name: name,
-            mimeType: mimeType
-          };
-          return _context4.abrupt("return", store.createFileFromUpload(body, {
+          }, {
             occurrenceKey: occurrenceKey,
             collection: collection,
             replaceFileId: id

package/dist/es2019/uploader/index.js

@@ -41,21 +41,16 @@ const createFileFromUpload = async (file, store, uploadableFileUpfrontIds, uploa
 
   // If the file is a Blob and the size is not passed from consumer, set the file size from file content
   if (content instanceof Blob && !file.size) {
-    file.size = content === null || content === void 0 ? void 0 : content.size;
+    file.size = content.size;
   }
-  const body = file.size ? {
+  return store.createFileFromUpload({
     uploadId,
     name,
     mimeType,
     conditions: {
       size: file.size
     }
-  } : {
-    uploadId,
-    name,
-    mimeType
-  };
-  return store.createFileFromUpload(body, {
+  }, {
     occurrenceKey,
     collection,
     replaceFileId: id

package/dist/esm/uploader/index.js

@@ -93,28 +93,23 @@ var createProcessingFunction = function createProcessingFunction(store, deferred
 };
 var createFileFromUpload = /*#__PURE__*/function () {
   var _ref4 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee4(file, store, uploadableFileUpfrontIds, uploadId, traceContext) {
-    var collection, name, mimeType, content, id, occurrenceKey, body;
+    var collection, name, mimeType, content, id, occurrenceKey;
     return _regeneratorRuntime.wrap(function (_context4) {
       while (1) switch (_context4.prev = _context4.next) {
         case 0:
           collection = file.collection, name = file.name, mimeType = file.mimeType, content = file.content;
           id = uploadableFileUpfrontIds.id, occurrenceKey = uploadableFileUpfrontIds.occurrenceKey; // If the file is a Blob and the size is not passed from consumer, set the file size from file content
           if (content instanceof Blob && !file.size) {
-            file.size = content === null || content === void 0 ? void 0 : content.size;
+            file.size = content.size;
           }
-          body = file.size ? {
+          return _context4.abrupt("return", store.createFileFromUpload({
             uploadId: uploadId,
             name: name,
             mimeType: mimeType,
             conditions: {
               size: file.size
             }
-          } : {
-            uploadId: uploadId,
-            name: name,
-            mimeType: mimeType
-          };
-          return _context4.abrupt("return", store.createFileFromUpload(body, {
+          }, {
             occurrenceKey: occurrenceKey,
             collection: collection,
             replaceFileId: id

package/dist/types/client/media-store/types.d.ts

@@ -82,13 +82,13 @@ export type MediaStoreCreateFileFromBinaryParams = {
 };
 export type MediaStoreCreateFileFromUploadConditions = {
     readonly hash?: string;
-    readonly size?: number;
+    readonly size: number;
 };
 export type MediaStoreCreateFileFromUploadBody = {
     readonly uploadId: string;
     readonly name?: string;
     readonly mimeType?: string;
-    readonly conditions?: MediaStoreCreateFileFromUploadConditions;
+    readonly conditions: MediaStoreCreateFileFromUploadConditions;
 };
 export type MediaStoreGetFileParams = {
     readonly version?: number;

package/dist/types/uploader/index.d.ts

@@ -6,7 +6,7 @@ export type UploadableFile = {
     name?: string;
     mimeType?: string;
     collection?: string;
-    size?: number;
+    size: number;
 };
 export type UploadableFileUpfrontIds = {
     id: string;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/media-client",
-	"version": "37.7.6",
+	"version": "38.0.0",
 	"description": "Media API Web Client Library",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"