@atlaskit/media-client 37.1.0 → 37.1.2

package/AGENTS.md

@@ -26,11 +26,11 @@
 > codebase and the docs after any code change. Use the `generate` subcommand to bootstrap the index
 > in a new repository.
 
-**Entry point:** `.agents/knowledge-index/INDEX.md` **Unit doc:**
-`.agents/knowledge-index/domains/media/units/atlaskit-media-client.md` **CLI:**
-`python3 .agents/skills/knowledge-index/scripts/kg.py {find,read,edit,investigate,validate,init,explore,generate} …`
-**Refresh protocol:** never silently bump `Last verified` — always re-read the listed `Sources`
-first, edit, then `kg.py edit <path> --message "<reason>"`.
+**Entry point:** `.agents/knowledge-index/INDEX.md`
+**Unit doc:** `.agents/knowledge-index/domains/media/units/atlaskit-media-client.md`
+**Standards page:** `.agents/knowledge-index/domains/media/units/atlaskit-media-client/standards-and-patterns.md`
+**CLI:** `python3 .agents/skills/knowledge-index/scripts/kg.py {find,read,edit,investigate,validate,init,explore,generate} …`
+**Refresh protocol:** never silently bump `Last verified` — always re-read the listed `Sources` first, edit, then `kg.py edit <path> --message "<reason>"`.
 
 ## Key source files
 

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/media-client
 
+## 37.1.2
+
+### Patch Changes
+
+- [`c16e1619c15f1`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/c16e1619c15f1) -
+  Clean up platform_media_upload_external_anonymize_filename feature flag; anonymizing the external
+  upload filename is now controlled solely by the anonymizeFilename argument
+
+## 37.1.1
+
+### Patch Changes
+
+- [`8bac4be486285`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/8bac4be486285) -
+  Adds a client-side validation guard in media-client's resolveAuth that rejects an auth resolving
+  to neither a valid clientId nor a valid asapIssuer, behind the platform_media_validate_client_id
+
 ## 37.1.0
 
 ### Minor Changes

package/dist/cjs/client/file-fetcher/index.js

@@ -26,7 +26,6 @@ var _Subscription = require("rxjs/Subscription");
 var _map = require("rxjs/operators/map");
 var _v = _interopRequireDefault(require("uuid/v4"));
 var _mediaCore = require("@atlaskit/media-core");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _isValidUuid = require("@atlaskit/media-common/isValidUuid");
 var _downloadUrl = require("@atlaskit/media-common/downloadUrl");
 var _mediaStore = require("../media-store");
@@ -599,7 +598,7 @@ var FileFetcherImpl = exports.FileFetcherImpl = /*#__PURE__*/function () {
                   return _ref0.apply(this, arguments);
                 };
               }());
-              name = anonymizeFilename && (0, _platformFeatureFlags.fg)('platform_media_upload_external_anonymize_filename') ? crypto.randomUUID() : url.split('/').pop() || ''; // we create a initial fileState with the minimum info that we have at this point
+              name = anonymizeFilename ? crypto.randomUUID() : url.split('/').pop() || ''; // we create a initial fileState with the minimum info that we have at this point
               fileState = {
                 status: 'processing',
                 name: name,

package/dist/cjs/client/media-store/resolveAuth.js

@@ -87,8 +87,14 @@ var resolveAuth = exports.resolveAuth = /*#__PURE__*/function () {
           }
           throw new _error.MediaStoreError('emptyAuth');
         case 6:
-          return _context.abrupt("return", auth);
+          if (!('clientId' in auth && !auth.clientId && (0, _platformFeatureFlags.fg)('platform_media_validate_client_id'))) {
+            _context.next = 7;
+            break;
+          }
+          throw new _error.MediaStoreError('emptyClientId');
         case 7:
+          return _context.abrupt("return", auth);
+        case 8:
         case "end":
           return _context.stop();
       }

package/dist/es2019/client/file-fetcher/index.js

@@ -4,7 +4,6 @@ import { map } from 'rxjs/operators/map';
 // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
 import uuid from 'uuid/v4';
 import { authToOwner } from '@atlaskit/media-core';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { isValidUuid } from '@atlaskit/media-common/isValidUuid';
 import { downloadUrl } from '@atlaskit/media-common/downloadUrl';
 import { MediaStore as MediaApi } from '../media-store';
@@ -369,7 +368,7 @@ export class FileFetcherImpl {
         origin: 'remote'
       });
     });
-    const name = anonymizeFilename && fg('platform_media_upload_external_anonymize_filename') ? crypto.randomUUID() : url.split('/').pop() || '';
+    const name = anonymizeFilename ? crypto.randomUUID() : url.split('/').pop() || '';
     // we create a initial fileState with the minimum info that we have at this point
     const fileState = {
       status: 'processing',

package/dist/es2019/client/media-store/resolveAuth.js

@@ -58,6 +58,14 @@ export const resolveAuth = async (authProvider, authContext, authProviderTimeout
     throw new MediaStoreError('emptyAuth');
   }
 
+  /*
+  Only client-based auth carries a clientId. Fail fast when it is present but empty, instead of
+  letting the request reach dt-auth and get rejected with `Client id "" is invalid`.
+   */
+  if ('clientId' in auth && !auth.clientId && fg('platform_media_validate_client_id')) {
+    throw new MediaStoreError('emptyClientId');
+  }
+
   /*
      We added a token expiration check here in the past, and then we had to revert due to edge cases in the client that we can't control.
      Token expiration check in the frontend is a bad idea. Don't do it!

package/dist/esm/client/file-fetcher/index.js

@@ -10,7 +10,6 @@ import { map } from 'rxjs/operators/map';
 // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
 import uuid from 'uuid/v4';
 import { authToOwner } from '@atlaskit/media-core';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { isValidUuid } from '@atlaskit/media-common/isValidUuid';
 import { downloadUrl } from '@atlaskit/media-common/downloadUrl';
 import { MediaStore as MediaApi } from '../media-store';
@@ -582,7 +581,7 @@ export var FileFetcherImpl = /*#__PURE__*/function () {
                   return _ref0.apply(this, arguments);
                 };
               }());
-              name = anonymizeFilename && fg('platform_media_upload_external_anonymize_filename') ? crypto.randomUUID() : url.split('/').pop() || ''; // we create a initial fileState with the minimum info that we have at this point
+              name = anonymizeFilename ? crypto.randomUUID() : url.split('/').pop() || ''; // we create a initial fileState with the minimum info that we have at this point
               fileState = {
                 status: 'processing',
                 name: name,

package/dist/esm/client/media-store/resolveAuth.js

@@ -80,8 +80,14 @@ export var resolveAuth = /*#__PURE__*/function () {
           }
           throw new MediaStoreError('emptyAuth');
         case 6:
-          return _context.abrupt("return", auth);
+          if (!('clientId' in auth && !auth.clientId && fg('platform_media_validate_client_id'))) {
+            _context.next = 7;
+            break;
+          }
+          throw new MediaStoreError('emptyClientId');
         case 7:
+          return _context.abrupt("return", auth);
+        case 8:
         case "end":
           return _context.stop();
       }

package/dist/types/client/media-store/error.d.ts

@@ -1,5 +1,5 @@
 import { BaseMediaClientError } from '../../models/errors';
-export type MediaStoreErrorReason = 'failedAuthProvider' | 'tokenExpired' | 'missingInitialAuth' | 'emptyAuth' | 'authProviderTimedOut';
+export type MediaStoreErrorReason = 'failedAuthProvider' | 'tokenExpired' | 'missingInitialAuth' | 'emptyAuth' | 'emptyClientId' | 'authProviderTimedOut';
 export type MediaStoreErrorAttributes = {
     readonly reason: MediaStoreErrorReason;
     readonly innerError?: Error;

package/dist/types/models/errors/types.d.ts

@@ -2,7 +2,7 @@ import { type MediaTraceContext } from '@atlaskit/media-common';
 export interface SerializableObject {
     [key: string]: string | number | boolean | null | undefined | SerializableObject;
 }
-export type MediaClientErrorReason = 'clientOffline' | 'clientAbortedRequest' | 'clientTimeoutRequest' | 'serverInvalidBody' | 'serverBadRequest' | 'serverUnauthorized' | 'serverForbidden' | 'serverNotFound' | 'serverRateLimited' | 'serverInternalError' | 'serverBadGateway' | 'serverUnexpectedError' | 'serverUnprocessableEntity' | 'serverEntityLocked' | 'failedAuthProvider' | 'tokenExpired' | 'missingInitialAuth' | 'emptyAuth' | 'authProviderTimedOut' | 'invalidFileId' | 'emptyItems' | 'zeroVersionFile' | 'emptyFileName' | 'pollingMaxAttemptsExceeded' | 'fileSizeExceedsLimit' | 'deprecatedEndpoint';
+export type MediaClientErrorReason = 'clientOffline' | 'clientAbortedRequest' | 'clientTimeoutRequest' | 'serverInvalidBody' | 'serverBadRequest' | 'serverUnauthorized' | 'serverForbidden' | 'serverNotFound' | 'serverRateLimited' | 'serverInternalError' | 'serverBadGateway' | 'serverUnexpectedError' | 'serverUnprocessableEntity' | 'serverEntityLocked' | 'failedAuthProvider' | 'tokenExpired' | 'missingInitialAuth' | 'emptyAuth' | 'authProviderTimedOut' | 'emptyClientId' | 'invalidFileId' | 'emptyItems' | 'zeroVersionFile' | 'emptyFileName' | 'pollingMaxAttemptsExceeded' | 'fileSizeExceedsLimit' | 'deprecatedEndpoint';
 export type MediaClientErrorMetadata = SerializableObject & {
     traceContext?: MediaTraceContext;
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/media-client",
-	"version": "37.1.0",
+	"version": "37.1.2",
 	"description": "Media API Web Client Library",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -44,8 +44,8 @@
 		"@atlaskit/media-core": "^38.0.0",
 		"@atlaskit/media-state": "^3.0.0",
 		"@atlaskit/ssr": "workspace:^",
-		"@atlaskit/tokens": "^14.0.0",
-		"@atlassian/a11y-jest-testing": "^0.12.0",
+		"@atlaskit/tokens": "^15.0.0",
+		"@atlassian/a11y-jest-testing": "^0.13.0",
 		"@atlassian/feature-flags-test-utils": "^1.1.0",
 		"@emotion/react": "^11.7.1",
 		"@types/deep-equal": "^1.0.1",
@@ -67,9 +67,6 @@
 		}
 	},
 	"platform-feature-flags": {
-		"platform_media_upload_external_anonymize_filename": {
-			"type": "boolean"
-		},
 		"platform_media_cdn_single_host": {
 			"type": "boolean"
 		},
@@ -85,6 +82,9 @@
 		"platform_media_auth_provider_analytics": {
 			"type": "boolean"
 		},
+		"platform_media_validate_client_id": {
+			"type": "boolean"
+		},
 		"confluence_watermark_admin_ui": {
 			"type": "boolean"
 		},