@atlaskit/media-card 79.6.4 → 79.7.0

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaskit/media-card
 
+## 79.7.0
+
+### Minor Changes
+
+- [`7ecc830bdd14e`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/7ecc830bdd14e) -
+  Updated the image renderer to maintain ssr dimensions if the returned image is the same ratio as
+  the parent, and maintained the native "lazy" attribute for images that are in view to avoid late
+  mutation
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 79.6.4
 
 ### Patch Changes

package/dist/cjs/card/card.js

@@ -20,7 +20,7 @@ var _label = _interopRequireDefault(require("@atlaskit/react-ufo/label"));
 var _excluded = ["identifier"];
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var packageName = "@atlaskit/media-card";
-var packageVersion = "79.6.3";
+var packageVersion = "79.6.4";
 var CardBase = exports.CardBase = function CardBase(_ref) {
   var identifier = _ref.identifier,
     otherProps = (0, _objectWithoutProperties2.default)(_ref, _excluded);

package/dist/cjs/card/fileCard.js

@@ -600,7 +600,7 @@ var FileCard = exports.FileCard = function FileCard(_ref) {
     // Side note: We should not lazy load if the cardPreview is available from local cache,
     // in order to avoid flickers during re-mount of the component
     // CXP-2723 TODO: Create test cases for the above scenarios
-    var nativeLazyLoad = isLazyWithOverride && !isCardVisible && preview && (0, _types.isSSRPreview)(preview);
+    var nativeLazyLoad = isLazyWithOverride && ((0, _platformFeatureFlags.fg)('media-perf-uplift-mutation-fix') || !isCardVisible) && preview && (0, _types.isSSRPreview)(preview);
     // Force Media Image to always display img for SSR
     var forceSyncDisplay = !!ssr;
     var card = /*#__PURE__*/_react.default.createElement(_cardView.CardView, {

package/dist/cjs/card/media-card-analytics-error-boundary.js

@@ -87,7 +87,7 @@ var WrappedMediaCardAnalyticsErrorBoundary = /*#__PURE__*/function (_React$Compo
 }(_react.default.Component);
 (0, _defineProperty2.default)(WrappedMediaCardAnalyticsErrorBoundary, "displayName", 'MediaCardAnalyticsErrorBoundary');
 var packageName = "@atlaskit/media-card";
-var packageVersion = "79.6.3";
+var packageVersion = "79.6.4";
 
 // @ts-ignore: [PIT-1685] Fails in post-office due to backwards incompatibility issue with React 18
 var MediaCardAnalyticsErrorBoundary = (0, _mediaCommon.withMediaAnalyticsContext)({

package/dist/cjs/card/ui/imageRenderer/helpers.js

@@ -4,6 +4,17 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.calculateInitialDimensions = exports.calculateDimensions = void 0;
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
+var roundedRatio = function roundedRatio(ratio) {
+  return Math.round(ratio * 100) / 100;
+};
+var DEFAULT_CROP_DIMENSIONS = {
+  maxWidth: '100%'
+};
+var DEFAULT_STRETCHY_FIT_DIMENSIONS = {
+  width: '100%',
+  maxHeight: '100%'
+};
 var calculateDimensions = exports.calculateDimensions = function calculateDimensions(imgElement, parentElement, resizeMode) {
   var naturalWidth = imgElement.naturalWidth,
     width = imgElement.width,
@@ -24,6 +35,15 @@ var calculateDimensions = exports.calculateDimensions = function calculateDimens
   }
   var imgRatio = imgWidth / imgHeight;
   var cardRatio = parentWidth / parentHeight;
+  if ((0, _platformFeatureFlags.fg)('media-perf-uplift-mutation-fix')) {
+    var isSameRatio = roundedRatio(imgWidth / parentWidth) === roundedRatio(imgHeight / parentHeight);
+    if (isSameRatio) {
+      if (resizeMode === 'stretchy-fit') {
+        return DEFAULT_STRETCHY_FIT_DIMENSIONS;
+      }
+      return DEFAULT_CROP_DIMENSIONS;
+    }
+  }
   var isImageLandscapier = imgRatio > cardRatio;
   if (resizeMode === 'stretchy-fit') {
     if (isImageLandscapier) {
@@ -62,15 +82,12 @@ var calculateInitialDimensions = exports.calculateInitialDimensions = function c
   }
   if (resizeMode === 'stretchy-fit') {
     // assume the image is landscape
-    return {
-      width: '100%',
-      maxHeight: '100%'
-    };
+    return DEFAULT_STRETCHY_FIT_DIMENSIONS;
   }
 
   // resizeMode === 'crop'
   // assume the image is landscape
-  return {
+  return (0, _platformFeatureFlags.fg)('media-perf-uplift-mutation-fix') ? DEFAULT_CROP_DIMENSIONS : {
     width: '100%'
   };
 };

package/dist/cjs/card/ui/imageRenderer/imageRendererV2.js

@@ -80,7 +80,19 @@ var ImageRenderer = exports.ImageRenderer = function ImageRenderer(_ref) {
       hasMediaComponent: true
     }
   }), /*#__PURE__*/_react.default.createElement("img", {
-    ref: imgRef,
+    ref: function ref(_ref2) {
+      if ((0, _platformFeatureFlags.fg)('media-perf-uplift-mutation-fix')) {
+        if (!imgRef.current && _ref2 !== null && _ref2 !== void 0 && _ref2.complete) {
+          // we need to set the imgRef before calling onLoad to avoid recursive rendering
+          imgRef.current = _ref2;
+          onLoad({
+            currentTarget: _ref2
+          });
+        }
+      } else {
+        imgRef.current = _ref2;
+      }
+    },
     "data-testid": testId,
     "data-fileid": (0, _mediaClient.isFileIdentifier)(identifier) ? identifier.id : null,
     "data-filecollection": (0, _mediaClient.isFileIdentifier)(identifier) ? identifier.collectionName : null,

package/dist/cjs/inline/loader.js

@@ -116,7 +116,7 @@ var MediaInlineCardLoader = exports.default = /*#__PURE__*/function (_React$Pure
         ErrorBoundary = _this$state.ErrorBoundary;
       var analyticsContext = {
         packageVersion: "@atlaskit/media-card",
-        packageName: "79.6.3",
+        packageName: "79.6.4",
         componentName: 'mediaInlineCard',
         component: 'mediaInlineCard'
       };

package/dist/cjs/utils/ufoExperiences.js

@@ -15,7 +15,7 @@ var _mediaClient = require("@atlaskit/media-client");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 var packageName = "@atlaskit/media-card";
-var packageVersion = "79.6.3";
+var packageVersion = "79.6.4";
 var SAMPLE_RATE = 0.05;
 var concurrentExperience;
 var getExperience = function getExperience(id) {

package/dist/es2019/card/card.js

@@ -9,7 +9,7 @@ import { startResourceObserver, setAnalyticsContext } from '../utils/mediaPerfor
 import { useAnalyticsEvents } from '@atlaskit/analytics-next';
 import UFOLabel from '@atlaskit/react-ufo/label';
 const packageName = "@atlaskit/media-card";
-const packageVersion = "79.6.3";
+const packageVersion = "79.6.4";
 export const CardBase = ({
   identifier,
   ...otherProps

package/dist/es2019/card/fileCard.js

@@ -523,7 +523,7 @@ export const FileCard = ({
     // Side note: We should not lazy load if the cardPreview is available from local cache,
     // in order to avoid flickers during re-mount of the component
     // CXP-2723 TODO: Create test cases for the above scenarios
-    const nativeLazyLoad = isLazyWithOverride && !isCardVisible && preview && isSSRPreview(preview);
+    const nativeLazyLoad = isLazyWithOverride && (fg('media-perf-uplift-mutation-fix') || !isCardVisible) && preview && isSSRPreview(preview);
     // Force Media Image to always display img for SSR
     const forceSyncDisplay = !!ssr;
     const card = /*#__PURE__*/React.createElement(CardView, {

package/dist/es2019/card/media-card-analytics-error-boundary.js

@@ -66,7 +66,7 @@ class WrappedMediaCardAnalyticsErrorBoundary extends React.Component {
 }
 _defineProperty(WrappedMediaCardAnalyticsErrorBoundary, "displayName", 'MediaCardAnalyticsErrorBoundary');
 const packageName = "@atlaskit/media-card";
-const packageVersion = "79.6.3";
+const packageVersion = "79.6.4";
 
 // @ts-ignore: [PIT-1685] Fails in post-office due to backwards incompatibility issue with React 18
 const MediaCardAnalyticsErrorBoundary = withMediaAnalyticsContext({

package/dist/es2019/card/ui/imageRenderer/helpers.js

@@ -1,3 +1,14 @@
+import { fg } from '@atlaskit/platform-feature-flags';
+const roundedRatio = ratio => {
+  return Math.round(ratio * 100) / 100;
+};
+const DEFAULT_CROP_DIMENSIONS = {
+  maxWidth: '100%'
+};
+const DEFAULT_STRETCHY_FIT_DIMENSIONS = {
+  width: '100%',
+  maxHeight: '100%'
+};
 export const calculateDimensions = (imgElement, parentElement, resizeMode) => {
   const {
     naturalWidth,
@@ -21,6 +32,15 @@ export const calculateDimensions = (imgElement, parentElement, resizeMode) => {
   }
   const imgRatio = imgWidth / imgHeight;
   const cardRatio = parentWidth / parentHeight;
+  if (fg('media-perf-uplift-mutation-fix')) {
+    const isSameRatio = roundedRatio(imgWidth / parentWidth) === roundedRatio(imgHeight / parentHeight);
+    if (isSameRatio) {
+      if (resizeMode === 'stretchy-fit') {
+        return DEFAULT_STRETCHY_FIT_DIMENSIONS;
+      }
+      return DEFAULT_CROP_DIMENSIONS;
+    }
+  }
   const isImageLandscapier = imgRatio > cardRatio;
   if (resizeMode === 'stretchy-fit') {
     if (isImageLandscapier) {
@@ -59,15 +79,12 @@ export const calculateInitialDimensions = resizeMode => {
   }
   if (resizeMode === 'stretchy-fit') {
     // assume the image is landscape
-    return {
-      width: '100%',
-      maxHeight: '100%'
-    };
+    return DEFAULT_STRETCHY_FIT_DIMENSIONS;
   }
 
   // resizeMode === 'crop'
   // assume the image is landscape
-  return {
+  return fg('media-perf-uplift-mutation-fix') ? DEFAULT_CROP_DIMENSIONS : {
     width: '100%'
   };
 };

package/dist/es2019/card/ui/imageRenderer/imageRendererV2.js

@@ -60,7 +60,19 @@ export const ImageRenderer = ({
       hasMediaComponent: true
     }
   }), /*#__PURE__*/React.createElement("img", {
-    ref: imgRef,
+    ref: ref => {
+      if (fg('media-perf-uplift-mutation-fix')) {
+        if (!imgRef.current && ref !== null && ref !== void 0 && ref.complete) {
+          // we need to set the imgRef before calling onLoad to avoid recursive rendering
+          imgRef.current = ref;
+          onLoad({
+            currentTarget: ref
+          });
+        }
+      } else {
+        imgRef.current = ref;
+      }
+    },
     "data-testid": testId,
     "data-fileid": isFileIdentifier(identifier) ? identifier.id : null,
     "data-filecollection": isFileIdentifier(identifier) ? identifier.collectionName : null,

package/dist/es2019/inline/loader.js

@@ -37,7 +37,7 @@ export default class MediaInlineCardLoader extends React.PureComponent {
     } = this.state;
     const analyticsContext = {
       packageVersion: "@atlaskit/media-card",
-      packageName: "79.6.3",
+      packageName: "79.6.4",
       componentName: 'mediaInlineCard',
       component: 'mediaInlineCard'
     };

package/dist/es2019/utils/ufoExperiences.js

@@ -5,7 +5,7 @@ import { extractErrorInfo, getRenderErrorRequestMetadata } from './analytics';
 import { MediaCardError } from '../errors';
 import { getMediaEnvironment, getMediaRegion } from '@atlaskit/media-client';
 const packageName = "@atlaskit/media-card";
-const packageVersion = "79.6.3";
+const packageVersion = "79.6.4";
 const SAMPLE_RATE = 0.05;
 let concurrentExperience;
 const getExperience = id => {

package/dist/esm/card/card.js

@@ -11,7 +11,7 @@ import { startResourceObserver, setAnalyticsContext } from '../utils/mediaPerfor
 import { useAnalyticsEvents } from '@atlaskit/analytics-next';
 import UFOLabel from '@atlaskit/react-ufo/label';
 var packageName = "@atlaskit/media-card";
-var packageVersion = "79.6.3";
+var packageVersion = "79.6.4";
 export var CardBase = function CardBase(_ref) {
   var identifier = _ref.identifier,
     otherProps = _objectWithoutProperties(_ref, _excluded);

package/dist/esm/card/fileCard.js

@@ -592,7 +592,7 @@ export var FileCard = function FileCard(_ref) {
     // Side note: We should not lazy load if the cardPreview is available from local cache,
     // in order to avoid flickers during re-mount of the component
     // CXP-2723 TODO: Create test cases for the above scenarios
-    var nativeLazyLoad = isLazyWithOverride && !isCardVisible && preview && isSSRPreview(preview);
+    var nativeLazyLoad = isLazyWithOverride && (fg('media-perf-uplift-mutation-fix') || !isCardVisible) && preview && isSSRPreview(preview);
     // Force Media Image to always display img for SSR
     var forceSyncDisplay = !!ssr;
     var card = /*#__PURE__*/React.createElement(CardView, {

package/dist/esm/card/media-card-analytics-error-boundary.js

@@ -80,7 +80,7 @@ var WrappedMediaCardAnalyticsErrorBoundary = /*#__PURE__*/function (_React$Compo
 }(React.Component);
 _defineProperty(WrappedMediaCardAnalyticsErrorBoundary, "displayName", 'MediaCardAnalyticsErrorBoundary');
 var packageName = "@atlaskit/media-card";
-var packageVersion = "79.6.3";
+var packageVersion = "79.6.4";
 
 // @ts-ignore: [PIT-1685] Fails in post-office due to backwards incompatibility issue with React 18
 var MediaCardAnalyticsErrorBoundary = withMediaAnalyticsContext({

package/dist/esm/card/ui/imageRenderer/helpers.js

@@ -1,3 +1,14 @@
+import { fg } from '@atlaskit/platform-feature-flags';
+var roundedRatio = function roundedRatio(ratio) {
+  return Math.round(ratio * 100) / 100;
+};
+var DEFAULT_CROP_DIMENSIONS = {
+  maxWidth: '100%'
+};
+var DEFAULT_STRETCHY_FIT_DIMENSIONS = {
+  width: '100%',
+  maxHeight: '100%'
+};
 export var calculateDimensions = function calculateDimensions(imgElement, parentElement, resizeMode) {
   var naturalWidth = imgElement.naturalWidth,
     width = imgElement.width,
@@ -18,6 +29,15 @@ export var calculateDimensions = function calculateDimensions(imgElement, parent
   }
   var imgRatio = imgWidth / imgHeight;
   var cardRatio = parentWidth / parentHeight;
+  if (fg('media-perf-uplift-mutation-fix')) {
+    var isSameRatio = roundedRatio(imgWidth / parentWidth) === roundedRatio(imgHeight / parentHeight);
+    if (isSameRatio) {
+      if (resizeMode === 'stretchy-fit') {
+        return DEFAULT_STRETCHY_FIT_DIMENSIONS;
+      }
+      return DEFAULT_CROP_DIMENSIONS;
+    }
+  }
   var isImageLandscapier = imgRatio > cardRatio;
   if (resizeMode === 'stretchy-fit') {
     if (isImageLandscapier) {
@@ -56,15 +76,12 @@ export var calculateInitialDimensions = function calculateInitialDimensions(resi
   }
   if (resizeMode === 'stretchy-fit') {
     // assume the image is landscape
-    return {
-      width: '100%',
-      maxHeight: '100%'
-    };
+    return DEFAULT_STRETCHY_FIT_DIMENSIONS;
   }
 
   // resizeMode === 'crop'
   // assume the image is landscape
-  return {
+  return fg('media-perf-uplift-mutation-fix') ? DEFAULT_CROP_DIMENSIONS : {
     width: '100%'
   };
 };

package/dist/esm/card/ui/imageRenderer/imageRendererV2.js

@@ -71,7 +71,19 @@ export var ImageRenderer = function ImageRenderer(_ref) {
       hasMediaComponent: true
     }
   }), /*#__PURE__*/React.createElement("img", {
-    ref: imgRef,
+    ref: function ref(_ref2) {
+      if (fg('media-perf-uplift-mutation-fix')) {
+        if (!imgRef.current && _ref2 !== null && _ref2 !== void 0 && _ref2.complete) {
+          // we need to set the imgRef before calling onLoad to avoid recursive rendering
+          imgRef.current = _ref2;
+          onLoad({
+            currentTarget: _ref2
+          });
+        }
+      } else {
+        imgRef.current = _ref2;
+      }
+    },
     "data-testid": testId,
     "data-fileid": isFileIdentifier(identifier) ? identifier.id : null,
     "data-filecollection": isFileIdentifier(identifier) ? identifier.collectionName : null,

package/dist/esm/inline/loader.js

@@ -101,7 +101,7 @@ var MediaInlineCardLoader = /*#__PURE__*/function (_React$PureComponent) {
         ErrorBoundary = _this$state.ErrorBoundary;
       var analyticsContext = {
         packageVersion: "@atlaskit/media-card",
-        packageName: "79.6.3",
+        packageName: "79.6.4",
         componentName: 'mediaInlineCard',
         component: 'mediaInlineCard'
       };

package/dist/esm/utils/ufoExperiences.js

@@ -8,7 +8,7 @@ import { extractErrorInfo, getRenderErrorRequestMetadata } from './analytics';
 import { MediaCardError } from '../errors';
 import { getMediaEnvironment, getMediaRegion } from '@atlaskit/media-client';
 var packageName = "@atlaskit/media-card";
-var packageVersion = "79.6.3";
+var packageVersion = "79.6.4";
 var SAMPLE_RATE = 0.05;
 var concurrentExperience;
 var getExperience = function getExperience(id) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/media-card",
-	"version": "79.6.4",
+	"version": "79.7.0",
 	"description": "Includes all media card related components, CardView, CardViewSmall, Card...",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -39,7 +39,7 @@
 		"@atlaskit/media-client": "^35.6.0",
 		"@atlaskit/media-client-react": "^4.1.0",
 		"@atlaskit/media-common": "^12.3.0",
-		"@atlaskit/media-file-preview": "^0.12.0",
+		"@atlaskit/media-file-preview": "^0.13.0",
 		"@atlaskit/media-svg": "^2.1.0",
 		"@atlaskit/media-ui": "^28.7.0",
 		"@atlaskit/media-viewer": "^52.4.0",
@@ -131,6 +131,9 @@
 		},
 		"platfrom_close_blindspot_for_img": {
 			"type": "boolean"
+		},
+		"media-perf-uplift-mutation-fix": {
+			"type": "boolean"
 		}
 	},
 	"techstack": {