@atlaskit/link-datasource 6.9.0 → 6.10.0

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/link-datasource
 
+## 6.10.0
+
+### Minor Changes
+
+- [`63d9eb9c7a7bd`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/63d9eb9c7a7bd) -
+  [ux] Behind `platform-dst-top-layer-tooltip`, merge the ref from `@atlaskit/tooltip`'s render prop
+  with the trigger's own ref instead of letting the later spread replace it, so the tooltip resolves
+  an anchor element. With the gate off the trigger keeps the ref it had before. Adds
+  `use-callback-ref` as a runtime dependency.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 6.9.0
 
 ### Minor Changes

package/dist/cjs/ui/issue-like-table/column-picker/index.js

@@ -15,6 +15,7 @@ var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = _interopRequireWildcard(require("react"));
 var _reactIntl = require("react-intl");
+var _useCallbackRef = require("use-callback-ref");
 var _button = _interopRequireDefault(require("@atlaskit/button/default/button"));
 var _button2 = _interopRequireDefault(require("@atlaskit/button/icon/button"));
 var _chevronDown = _interopRequireDefault(require("@atlaskit/icon/core/chevron-down"));
@@ -169,6 +170,11 @@ var ColumnPicker = exports.ColumnPicker = function ColumnPicker(_ref) {
         content: intl.formatMessage(_messages.columnPickerMessages.tooltip)
       }, function (tooltipProps) {
         return /*#__PURE__*/_react.default.createElement(_button.default, (0, _extends2.default)({}, tooltipProps, triggerProps, {
+          // `tooltipProps.ref` must be included: spreading `triggerProps` after
+          // `tooltipProps` drops the tooltip's ref, leaving Tooltip without an
+          // anchor element. Gate off leaves `triggerProps.ref` winning, exactly as
+          // master does.
+          ref: (0, _fg.fg)('platform-dst-top-layer-tooltip') ? (0, _useCallbackRef.mergeRefs)([triggerProps.ref, tooltipProps.ref]) : triggerProps.ref,
           isSelected: isOpen,
           spacing: "compact",
           appearance: 'default',

package/dist/es2019/ui/issue-like-table/column-picker/index.js

@@ -4,6 +4,7 @@ import "./index.compiled.css";
 import { ax, ix } from "@compiled/react/runtime";
 import React, { useCallback, useEffect, useRef, useState } from 'react';
 import { useIntl } from 'react-intl';
+import { mergeRefs } from 'use-callback-ref';
 import Button from '@atlaskit/button/default/button';
 import IconButton from '@atlaskit/button/icon/button';
 import ChevronDownIcon from '@atlaskit/icon/core/chevron-down';
@@ -142,6 +143,11 @@ export const ColumnPicker = ({
       return /*#__PURE__*/React.createElement(Tooltip, {
         content: intl.formatMessage(columnPickerMessages.tooltip)
       }, tooltipProps => /*#__PURE__*/React.createElement(Button, _extends({}, tooltipProps, triggerProps, {
+        // `tooltipProps.ref` must be included: spreading `triggerProps` after
+        // `tooltipProps` drops the tooltip's ref, leaving Tooltip without an
+        // anchor element. Gate off leaves `triggerProps.ref` winning, exactly as
+        // master does.
+        ref: fg('platform-dst-top-layer-tooltip') ? mergeRefs([triggerProps.ref, tooltipProps.ref]) : triggerProps.ref,
         isSelected: isOpen,
         spacing: "compact",
         appearance: 'default',

package/dist/esm/ui/issue-like-table/column-picker/index.js

@@ -8,6 +8,7 @@ import "./index.compiled.css";
 import { ax, ix } from "@compiled/react/runtime";
 import React, { useCallback, useEffect, useRef, useState } from 'react';
 import { useIntl } from 'react-intl';
+import { mergeRefs } from 'use-callback-ref';
 import Button from '@atlaskit/button/default/button';
 import IconButton from '@atlaskit/button/icon/button';
 import ChevronDownIcon from '@atlaskit/icon/core/chevron-down';
@@ -160,6 +161,11 @@ export var ColumnPicker = function ColumnPicker(_ref) {
         content: intl.formatMessage(columnPickerMessages.tooltip)
       }, function (tooltipProps) {
         return /*#__PURE__*/React.createElement(Button, _extends({}, tooltipProps, triggerProps, {
+          // `tooltipProps.ref` must be included: spreading `triggerProps` after
+          // `tooltipProps` drops the tooltip's ref, leaving Tooltip without an
+          // anchor element. Gate off leaves `triggerProps.ref` winning, exactly as
+          // master does.
+          ref: fg('platform-dst-top-layer-tooltip') ? mergeRefs([triggerProps.ref, tooltipProps.ref]) : triggerProps.ref,
           isSelected: isOpen,
           spacing: "compact",
           appearance: 'default',

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/link-datasource",
-	"version": "6.9.0",
+	"version": "6.10.0",
 	"description": "UI Components to support linking platform dataset feature",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -103,6 +103,7 @@
 		"lodash": "^4.17.21",
 		"react-sweet-state": "^2.6.5",
 		"tiny-invariant": "^1.2.0",
+		"use-callback-ref": "^1.2.3",
 		"use-debounce": "^3.4.0",
 		"uuid": "^3.1.0"
 	},
@@ -172,6 +173,10 @@
 		},
 		"electric_issue_like_table_xpc_url_wrapping": {
 			"type": "boolean"
+		},
+		"platform-dst-top-layer-tooltip": {
+			"type": "boolean",
+			"referenceOnly": true
 		}
 	},
 	"compassUnitTestMetricSourceId": "ari:cloud:compass:a436116f-02ce-4520-8fbb-7301462a1674:metric-source/c5751cc6-3513-4070-9deb-af31e86aed34/9c893299-a527-4457-9b46-f3bc4c828766"