@atlaskit/link-datasource 4.30.12 → 4.30.13

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (5) hide show
  1. package/CHANGELOG.md +7 -0
  2. package/dist/cjs/ui/datasource-table-view/datasourceTableView.js +12 -21
  3. package/dist/es2019/ui/datasource-table-view/datasourceTableView.js +12 -21
  4. package/dist/esm/ui/datasource-table-view/datasourceTableView.js +12 -21
  5. package/package.json +9 -12
package/CHANGELOG.md CHANGED
@@ -1,5 +1,12 @@
1
1
  # @atlaskit/link-datasource
2
2
 
3
+ ## 4.30.13
4
+
5
+ ### Patch Changes
6
+
7
+ - [`a5c4fbb84f7a8`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/a5c4fbb84f7a8) -
8
+ Feature gate cleanup: navx-1334-datasource-deep-compare-params
9
+
3
10
  ## 4.30.12
4
11
 
5
12
  ### Patch Changes
package/dist/cjs/ui/datasource-table-view/datasourceTableView.js CHANGED
@@ -87,27 +87,18 @@ var DatasourceTableViewWithoutAnalytics = function DatasourceTableViewWithoutAna
87
87
  var hasColumns = !!columns.length;
88
88
  var isDataReady = hasColumns && responseItems.length > 0 && totalCount && totalCount > 0;
89
89
  visibleColumnCount.current = (visibleColumnKeys === null || visibleColumnKeys === void 0 ? void 0 : visibleColumnKeys.length) || 0;
90
- if ((0, _platformFeatureFlags.fg)('navx-1334-datasource-deep-compare-params')) {
91
- // parameters is an object that we want to track, and when something inside it changes we want to
92
- // call effect callback. Normal useEffect will not do deep comparison, but only reference one.
93
- // This hook will do deep comparison making sure we don't call reset() when only reference to an object
94
- // has changed but not the content.
95
- // eslint-disable-next-line react-hooks/rules-of-hooks
96
- (0, _useDeepEffect.useDeepEffect)(function () {
97
- if (!isInitialRender.current) {
98
- reset();
99
- }
100
- isInitialRender.current = false;
101
- }, [reset, parameters]);
102
- } else {
103
- // eslint-disable-next-line react-hooks/rules-of-hooks
104
- (0, _react.useEffect)(function () {
105
- if (!isInitialRender.current) {
106
- reset();
107
- }
108
- isInitialRender.current = false;
109
- }, [reset, parameters]);
110
- }
90
+
91
+ // parameters is an object that we want to track, and when something inside it changes we want to
92
+ // call effect callback. Normal useEffect will not do deep comparison, but only reference one.
93
+ // This hook will do deep comparison making sure we don't call reset() when only reference to an object
94
+ // has changed but not the content.
95
+ // eslint-disable-next-line react-hooks/rules-of-hooks
96
+ (0, _useDeepEffect.useDeepEffect)(function () {
97
+ if (!isInitialRender.current) {
98
+ reset();
99
+ }
100
+ isInitialRender.current = false;
101
+ }, [reset, parameters]);
111
102
  (0, _react.useEffect)(function () {
112
103
  if (onVisibleColumnKeysChange && (visibleColumnKeys || []).length === 0 && defaultVisibleColumnKeys.length > 0) {
113
104
  onVisibleColumnKeysChange(defaultVisibleColumnKeys);
package/dist/es2019/ui/datasource-table-view/datasourceTableView.js CHANGED
@@ -79,27 +79,18 @@ const DatasourceTableViewWithoutAnalytics = ({
79
79
  const hasColumns = !!columns.length;
80
80
  const isDataReady = hasColumns && responseItems.length > 0 && totalCount && totalCount > 0;
81
81
  visibleColumnCount.current = (visibleColumnKeys === null || visibleColumnKeys === void 0 ? void 0 : visibleColumnKeys.length) || 0;
82
- if (fg('navx-1334-datasource-deep-compare-params')) {
83
- // parameters is an object that we want to track, and when something inside it changes we want to
84
- // call effect callback. Normal useEffect will not do deep comparison, but only reference one.
85
- // This hook will do deep comparison making sure we don't call reset() when only reference to an object
86
- // has changed but not the content.
87
- // eslint-disable-next-line react-hooks/rules-of-hooks
88
- useDeepEffect(() => {
89
- if (!isInitialRender.current) {
90
- reset();
91
- }
92
- isInitialRender.current = false;
93
- }, [reset, parameters]);
94
- } else {
95
- // eslint-disable-next-line react-hooks/rules-of-hooks
96
- useEffect(() => {
97
- if (!isInitialRender.current) {
98
- reset();
99
- }
100
- isInitialRender.current = false;
101
- }, [reset, parameters]);
102
- }
82
+
83
+ // parameters is an object that we want to track, and when something inside it changes we want to
84
+ // call effect callback. Normal useEffect will not do deep comparison, but only reference one.
85
+ // This hook will do deep comparison making sure we don't call reset() when only reference to an object
86
+ // has changed but not the content.
87
+ // eslint-disable-next-line react-hooks/rules-of-hooks
88
+ useDeepEffect(() => {
89
+ if (!isInitialRender.current) {
90
+ reset();
91
+ }
92
+ isInitialRender.current = false;
93
+ }, [reset, parameters]);
103
94
  useEffect(() => {
104
95
  if (onVisibleColumnKeysChange && (visibleColumnKeys || []).length === 0 && defaultVisibleColumnKeys.length > 0) {
105
96
  onVisibleColumnKeysChange(defaultVisibleColumnKeys);
package/dist/esm/ui/datasource-table-view/datasourceTableView.js CHANGED
@@ -78,27 +78,18 @@ var DatasourceTableViewWithoutAnalytics = function DatasourceTableViewWithoutAna
78
78
  var hasColumns = !!columns.length;
79
79
  var isDataReady = hasColumns && responseItems.length > 0 && totalCount && totalCount > 0;
80
80
  visibleColumnCount.current = (visibleColumnKeys === null || visibleColumnKeys === void 0 ? void 0 : visibleColumnKeys.length) || 0;
81
- if (fg('navx-1334-datasource-deep-compare-params')) {
82
- // parameters is an object that we want to track, and when something inside it changes we want to
83
- // call effect callback. Normal useEffect will not do deep comparison, but only reference one.
84
- // This hook will do deep comparison making sure we don't call reset() when only reference to an object
85
- // has changed but not the content.
86
- // eslint-disable-next-line react-hooks/rules-of-hooks
87
- useDeepEffect(function () {
88
- if (!isInitialRender.current) {
89
- reset();
90
- }
91
- isInitialRender.current = false;
92
- }, [reset, parameters]);
93
- } else {
94
- // eslint-disable-next-line react-hooks/rules-of-hooks
95
- useEffect(function () {
96
- if (!isInitialRender.current) {
97
- reset();
98
- }
99
- isInitialRender.current = false;
100
- }, [reset, parameters]);
101
- }
81
+
82
+ // parameters is an object that we want to track, and when something inside it changes we want to
83
+ // call effect callback. Normal useEffect will not do deep comparison, but only reference one.
84
+ // This hook will do deep comparison making sure we don't call reset() when only reference to an object
85
+ // has changed but not the content.
86
+ // eslint-disable-next-line react-hooks/rules-of-hooks
87
+ useDeepEffect(function () {
88
+ if (!isInitialRender.current) {
89
+ reset();
90
+ }
91
+ isInitialRender.current = false;
92
+ }, [reset, parameters]);
102
93
  useEffect(function () {
103
94
  if (onVisibleColumnKeysChange && (visibleColumnKeys || []).length === 0 && defaultVisibleColumnKeys.length > 0) {
104
95
  onVisibleColumnKeysChange(defaultVisibleColumnKeys);
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/link-datasource",
3
- "version": "4.30.12",
3
+ "version": "4.30.13",
4
4
  "description": "UI Components to support linking platform dataset feature",
5
5
  "author": "Atlassian Pty Ltd",
6
6
  "license": "Apache-2.0",
@@ -43,14 +43,14 @@
43
43
  "@atlaskit/avatar": "^25.5.0",
44
44
  "@atlaskit/avatar-group": "^12.4.0",
45
45
  "@atlaskit/badge": "^18.2.0",
46
- "@atlaskit/button": "^23.6.0",
46
+ "@atlaskit/button": "^23.7.0",
47
47
  "@atlaskit/css": "^0.17.0",
48
- "@atlaskit/datetime-picker": "^17.1.0",
48
+ "@atlaskit/datetime-picker": "^17.2.0",
49
49
  "@atlaskit/dropdown-menu": "^16.3.0",
50
50
  "@atlaskit/editor-prosemirror": "7.0.0",
51
51
  "@atlaskit/empty-state": "^10.1.0",
52
52
  "@atlaskit/feature-gate-js-client": "^5.5.0",
53
- "@atlaskit/flag": "^17.5.0",
53
+ "@atlaskit/flag": "^17.6.0",
54
54
  "@atlaskit/form": "^14.3.0",
55
55
  "@atlaskit/heading": "^5.2.0",
56
56
  "@atlaskit/icon": "^29.0.0",
@@ -69,22 +69,22 @@
69
69
  "@atlaskit/linking-types": "^14.2.0",
70
70
  "@atlaskit/logo": "^19.9.0",
71
71
  "@atlaskit/lozenge": "^13.1.0",
72
- "@atlaskit/modal-dialog": "^14.7.0",
72
+ "@atlaskit/modal-dialog": "^14.8.0",
73
73
  "@atlaskit/outbound-auth-flow-client": "^3.4.0",
74
74
  "@atlaskit/platform-feature-flags": "^1.1.0",
75
- "@atlaskit/popup": "^4.6.0",
75
+ "@atlaskit/popup": "^4.7.0",
76
76
  "@atlaskit/pragmatic-drag-and-drop": "^1.7.0",
77
77
  "@atlaskit/pragmatic-drag-and-drop-hitbox": "^1.1.0",
78
78
  "@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-autoscroll": "^2.0.0",
79
79
  "@atlaskit/pragmatic-drag-and-drop-react-drop-indicator": "^3.2.0",
80
80
  "@atlaskit/primitives": "^16.4.0",
81
- "@atlaskit/react-select": "^3.9.0",
82
- "@atlaskit/select": "^21.4.0",
81
+ "@atlaskit/react-select": "^3.10.0",
82
+ "@atlaskit/select": "^21.5.0",
83
83
  "@atlaskit/smart-card": "^43.14.0",
84
84
  "@atlaskit/smart-user-picker": "^8.5.0",
85
85
  "@atlaskit/spinner": "^19.0.0",
86
86
  "@atlaskit/tag": "^14.1.0",
87
- "@atlaskit/textfield": "^8.1.0",
87
+ "@atlaskit/textfield": "^8.2.0",
88
88
  "@atlaskit/theme": "^21.0.0",
89
89
  "@atlaskit/tokens": "^8.4.0",
90
90
  "@atlaskit/tooltip": "^20.11.0",
@@ -176,9 +176,6 @@
176
176
  "lp_enable_datasource-table-view_height_override": {
177
177
  "type": "boolean"
178
178
  },
179
- "navx-1334-datasource-deep-compare-params": {
180
- "type": "boolean"
181
- },
182
179
  "navx-1895-new-logo-design": {
183
180
  "type": "boolean"
184
181
  },