@atlaskit/link-datasource 4.14.6 → 4.16.0

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/link-datasource
 
+## 4.16.0
+
+### Minor Changes
+
+- [#191067](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/191067)
+  [`ede531b6a7c94`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ede531b6a7c94) -
+  Clean up platform-datasources-inline-edit-id-checks ff
+
+## 4.15.0
+
+### Minor Changes
+
+- [#191152](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/191152)
+  [`a3d8c4e7ad18a`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/a3d8c4e7ad18a) -
+  Removing FG that set shouldShowCalendarButton on a modal
+
 ## 4.14.6
 
 ### Patch Changes

package/dist/cjs/ui/confluence-search-modal/basic-filters/filters/date-range-picker/index.js

@@ -17,7 +17,6 @@ var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/h
 var _reactIntlNext = require("react-intl-next");
 var _datetimePicker = require("@atlaskit/datetime-picker");
 var _statusErrorError = _interopRequireDefault(require("@atlaskit/icon/core/migration/status-error--error"));
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _popup = _interopRequireDefault(require("@atlaskit/popup"));
 var _colors = require("@atlaskit/theme/colors");
 var _constants = require("@atlaskit/theme/constants");
@@ -204,7 +203,7 @@ var DateRangePicker = exports.DateRangePicker = function DateRangePicker(_ref6)
         }
       }, (0, _utils.getDropdownLabel)(option, formatMessage));
     }), isPickerOpen && isCustomSelected && /*#__PURE__*/_react.default.createElement(CustomDateWrapper, null, /*#__PURE__*/_react.default.createElement(DatePickersWrapper, null, /*#__PURE__*/_react.default.createElement(_datetimePicker.DatePicker, {
-      shouldShowCalendarButton: (0, _platformFeatureFlags.fg)('platform_linking_set_should_show_calender_button'),
+      shouldShowCalendarButton: true,
       maxDate: todayDate,
       innerProps: {
         style: {
@@ -228,7 +227,7 @@ var DateRangePicker = exports.DateRangePicker = function DateRangePicker(_ref6)
         }
       }
     }), /*#__PURE__*/_react.default.createElement(_reactIntlNext.FormattedMessage, _messages.dateRangeMessages.dateRangeToLabel), /*#__PURE__*/_react.default.createElement(_datetimePicker.DatePicker, {
-      shouldShowCalendarButton: (0, _platformFeatureFlags.fg)('platform_linking_set_should_show_calender_button'),
+      shouldShowCalendarButton: true,
       maxDate: todayDate,
       innerProps: {
         style: {

package/dist/cjs/ui/issue-like-table/edit-type/icon/index.js

@@ -9,7 +9,6 @@ exports.default = void 0;
 var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 var _react = _interopRequireWildcard(require("react"));
 var _layering = require("@atlaskit/layering");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _select = _interopRequireDefault(require("@atlaskit/select"));
 var _tooltip = _interopRequireDefault(require("@atlaskit/tooltip"));
 var _ufoExperiences = require("../../../../analytics/ufoExperiences");
@@ -54,9 +53,9 @@ var IconEditType = function IconEditType(props) {
     // We can't update this field if we don't have an ID - however the ID
     // is typed optional.
     ,
-    options: (0, _platformFeatureFlags.fg)('platform-datasources-inline-edit-id-checks') ? options.filter(function (option) {
+    options: options.filter(function (option) {
       return option.id;
-    }) : options,
+    }),
     menuPlacement: "auto",
     isLoading: isLoading,
     filterOption: filterOption,

package/dist/cjs/ui/issue-like-table/table-cell-content/inline-edit.js

@@ -16,7 +16,6 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _react = _interopRequireWildcard(require("react"));
 var _reactIntlNext = require("react-intl-next");
 var _inlineEdit = _interopRequireDefault(require("@atlaskit/inline-edit"));
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _compiled = require("@atlaskit/primitives/compiled");
 var _hooks = require("@atlaskit/smart-card/hooks");
 var _analytics = require("../../../analytics");
@@ -174,25 +173,20 @@ var InlineEdit = exports.InlineEdit = function InlineEdit(_ref) {
     onUpdateItem(ari, newItem);
     fireEvent('ui.form.submitted.inlineEdit', {});
     var updateValue;
-    if ((0, _platformFeatureFlags.fg)('platform-datasources-inline-edit-id-checks')) {
-      try {
-        // TODO: Refactor types so that valid update values are guaranteed for
-        // all object types. Invalid options should be filtered out of options -
-        // this frontend error flag is a last resort.
-        updateValue = newGetBackendUpdateValue(newValue);
-      } catch (_unused) {
-        // Show an error as the new value that was going to be sent to the
-        // backend is invalid (and would have failed anyway, silently to the user)
-        showErrorFlag({});
-        onUpdateItem(ari, existingData);
-        setIsEditing(false);
-        return;
-      }
+    try {
+      // TODO: Refactor types so that valid update values are guaranteed for
+      // all object types. Invalid options should be filtered out of options -
+      // this frontend error flag is a last resort.
+      updateValue = newGetBackendUpdateValue(newValue);
+    } catch (_unused) {
+      // Show an error as the new value that was going to be sent to the
+      // backend is invalid (and would have failed anyway, silently to the user)
+      showErrorFlag({});
+      onUpdateItem(ari, existingData);
+      setIsEditing(false);
+      return;
     }
-    execute(updateValue !== undefined && (0, _platformFeatureFlags.fg)('platform-datasources-inline-edit-id-checks') ? updateValue :
-    // Old behaviour is preserved in non-FFed path: errors thrown by getBackendUpdateValue are caught by
-    // the error boundary, _not_ by the catch block & frontend flag here.
-    getBackendUpdateValue(newValue)).then(refreshDatasourceItem).catch(function (error) {
+    execute(updateValue !== undefined ? updateValue : getBackendUpdateValue(newValue)).then(refreshDatasourceItem).catch(function (error) {
       var status = error && (0, _typeof2.default)(error) === 'object' ? error.status : undefined;
       showErrorFlag({
         status: status

package/dist/es2019/ui/confluence-search-modal/basic-filters/filters/date-range-picker/index.js

@@ -7,7 +7,6 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react';
 import { FormattedMessage, useIntl } from 'react-intl-next';
 import { DatePicker } from '@atlaskit/datetime-picker';
 import ErrorIcon from '@atlaskit/icon/core/migration/status-error--error';
-import { fg } from '@atlaskit/platform-feature-flags';
 import Popup from '@atlaskit/popup';
 import { N0, N20, N30, R400 } from '@atlaskit/theme/colors';
 import { layers } from '@atlaskit/theme/constants';
@@ -172,7 +171,7 @@ export const DateRangePicker = ({
       isSelected: selectedValue ? option === selectedValue : option === defaultOptionValue,
       onClick: () => handleClickFilterOption(option)
     }, getDropdownLabel(option, formatMessage))), isPickerOpen && isCustomSelected && /*#__PURE__*/React.createElement(CustomDateWrapper, null, /*#__PURE__*/React.createElement(DatePickersWrapper, null, /*#__PURE__*/React.createElement(DatePicker, {
-      shouldShowCalendarButton: fg('platform_linking_set_should_show_calender_button'),
+      shouldShowCalendarButton: true,
       maxDate: todayDate,
       innerProps: {
         style: {
@@ -195,7 +194,7 @@ export const DateRangePicker = ({
         }
       }
     }), /*#__PURE__*/React.createElement(FormattedMessage, dateRangeMessages.dateRangeToLabel), /*#__PURE__*/React.createElement(DatePicker, {
-      shouldShowCalendarButton: fg('platform_linking_set_should_show_calender_button'),
+      shouldShowCalendarButton: true,
       maxDate: todayDate,
       innerProps: {
         style: {

package/dist/es2019/ui/issue-like-table/edit-type/icon/index.js

@@ -1,7 +1,6 @@
 import _extends from "@babel/runtime/helpers/extends";
 import React, { useEffect } from 'react';
 import { Layering } from '@atlaskit/layering';
-import { fg } from '@atlaskit/platform-feature-flags';
 import Select from '@atlaskit/select';
 import Tooltip from '@atlaskit/tooltip';
 import { failUfoExperience, succeedUfoExperience } from '../../../../analytics/ufoExperiences';
@@ -48,7 +47,7 @@ const IconEditType = props => {
     // We can't update this field if we don't have an ID - however the ID
     // is typed optional.
     ,
-    options: fg('platform-datasources-inline-edit-id-checks') ? options.filter(option => option.id) : options,
+    options: options.filter(option => option.id),
     menuPlacement: "auto",
     isLoading: isLoading,
     filterOption: filterOption,

package/dist/es2019/ui/issue-like-table/table-cell-content/inline-edit.js

@@ -5,7 +5,6 @@ import { ax, ix } from "@compiled/react/runtime";
 import React, { useCallback, useMemo, useState } from 'react';
 import { useIntl } from 'react-intl-next';
 import AKInlineEdit from '@atlaskit/inline-edit';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { Box } from '@atlaskit/primitives/compiled';
 import { useSmartLinkReload } from '@atlaskit/smart-card/hooks';
 import { useDatasourceAnalyticsEvents } from '../../../analytics';
@@ -171,25 +170,20 @@ export const InlineEdit = ({
     onUpdateItem(ari, newItem);
     fireEvent('ui.form.submitted.inlineEdit', {});
     let updateValue;
-    if (fg('platform-datasources-inline-edit-id-checks')) {
-      try {
-        // TODO: Refactor types so that valid update values are guaranteed for
-        // all object types. Invalid options should be filtered out of options -
-        // this frontend error flag is a last resort.
-        updateValue = newGetBackendUpdateValue(newValue);
-      } catch {
-        // Show an error as the new value that was going to be sent to the
-        // backend is invalid (and would have failed anyway, silently to the user)
-        showErrorFlag({});
-        onUpdateItem(ari, existingData);
-        setIsEditing(false);
-        return;
-      }
+    try {
+      // TODO: Refactor types so that valid update values are guaranteed for
+      // all object types. Invalid options should be filtered out of options -
+      // this frontend error flag is a last resort.
+      updateValue = newGetBackendUpdateValue(newValue);
+    } catch {
+      // Show an error as the new value that was going to be sent to the
+      // backend is invalid (and would have failed anyway, silently to the user)
+      showErrorFlag({});
+      onUpdateItem(ari, existingData);
+      setIsEditing(false);
+      return;
     }
-    execute(updateValue !== undefined && fg('platform-datasources-inline-edit-id-checks') ? updateValue :
-    // Old behaviour is preserved in non-FFed path: errors thrown by getBackendUpdateValue are caught by
-    // the error boundary, _not_ by the catch block & frontend flag here.
-    getBackendUpdateValue(newValue)).then(refreshDatasourceItem).catch(error => {
+    execute(updateValue !== undefined ? updateValue : getBackendUpdateValue(newValue)).then(refreshDatasourceItem).catch(error => {
       const status = error && typeof error === 'object' ? error.status : undefined;
       showErrorFlag({
         status

package/dist/esm/ui/confluence-search-modal/basic-filters/filters/date-range-picker/index.js

@@ -17,7 +17,6 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react';
 import { FormattedMessage, useIntl } from 'react-intl-next';
 import { DatePicker } from '@atlaskit/datetime-picker';
 import ErrorIcon from '@atlaskit/icon/core/migration/status-error--error';
-import { fg } from '@atlaskit/platform-feature-flags';
 import Popup from '@atlaskit/popup';
 import { N0, N20, N30, R400 } from '@atlaskit/theme/colors';
 import { layers } from '@atlaskit/theme/constants';
@@ -197,7 +196,7 @@ export var DateRangePicker = function DateRangePicker(_ref6) {
         }
       }, getDropdownLabel(option, formatMessage));
     }), isPickerOpen && isCustomSelected && /*#__PURE__*/React.createElement(CustomDateWrapper, null, /*#__PURE__*/React.createElement(DatePickersWrapper, null, /*#__PURE__*/React.createElement(DatePicker, {
-      shouldShowCalendarButton: fg('platform_linking_set_should_show_calender_button'),
+      shouldShowCalendarButton: true,
       maxDate: todayDate,
       innerProps: {
         style: {
@@ -221,7 +220,7 @@ export var DateRangePicker = function DateRangePicker(_ref6) {
         }
       }
     }), /*#__PURE__*/React.createElement(FormattedMessage, dateRangeMessages.dateRangeToLabel), /*#__PURE__*/React.createElement(DatePicker, {
-      shouldShowCalendarButton: fg('platform_linking_set_should_show_calender_button'),
+      shouldShowCalendarButton: true,
       maxDate: todayDate,
       innerProps: {
         style: {

package/dist/esm/ui/issue-like-table/edit-type/icon/index.js

@@ -1,7 +1,6 @@
 import _extends from "@babel/runtime/helpers/extends";
 import React, { useEffect } from 'react';
 import { Layering } from '@atlaskit/layering';
-import { fg } from '@atlaskit/platform-feature-flags';
 import Select from '@atlaskit/select';
 import Tooltip from '@atlaskit/tooltip';
 import { failUfoExperience, succeedUfoExperience } from '../../../../analytics/ufoExperiences';
@@ -45,9 +44,9 @@ var IconEditType = function IconEditType(props) {
     // We can't update this field if we don't have an ID - however the ID
     // is typed optional.
     ,
-    options: fg('platform-datasources-inline-edit-id-checks') ? options.filter(function (option) {
+    options: options.filter(function (option) {
       return option.id;
-    }) : options,
+    }),
     menuPlacement: "auto",
     isLoading: isLoading,
     filterOption: filterOption,

package/dist/esm/ui/issue-like-table/table-cell-content/inline-edit.js

@@ -10,7 +10,6 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import React, { useCallback, useMemo, useState } from 'react';
 import { useIntl } from 'react-intl-next';
 import AKInlineEdit from '@atlaskit/inline-edit';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { Box } from '@atlaskit/primitives/compiled';
 import { useSmartLinkReload } from '@atlaskit/smart-card/hooks';
 import { useDatasourceAnalyticsEvents } from '../../../analytics';
@@ -165,25 +164,20 @@ export var InlineEdit = function InlineEdit(_ref) {
     onUpdateItem(ari, newItem);
     fireEvent('ui.form.submitted.inlineEdit', {});
     var updateValue;
-    if (fg('platform-datasources-inline-edit-id-checks')) {
-      try {
-        // TODO: Refactor types so that valid update values are guaranteed for
-        // all object types. Invalid options should be filtered out of options -
-        // this frontend error flag is a last resort.
-        updateValue = newGetBackendUpdateValue(newValue);
-      } catch (_unused) {
-        // Show an error as the new value that was going to be sent to the
-        // backend is invalid (and would have failed anyway, silently to the user)
-        showErrorFlag({});
-        onUpdateItem(ari, existingData);
-        setIsEditing(false);
-        return;
-      }
+    try {
+      // TODO: Refactor types so that valid update values are guaranteed for
+      // all object types. Invalid options should be filtered out of options -
+      // this frontend error flag is a last resort.
+      updateValue = newGetBackendUpdateValue(newValue);
+    } catch (_unused) {
+      // Show an error as the new value that was going to be sent to the
+      // backend is invalid (and would have failed anyway, silently to the user)
+      showErrorFlag({});
+      onUpdateItem(ari, existingData);
+      setIsEditing(false);
+      return;
     }
-    execute(updateValue !== undefined && fg('platform-datasources-inline-edit-id-checks') ? updateValue :
-    // Old behaviour is preserved in non-FFed path: errors thrown by getBackendUpdateValue are caught by
-    // the error boundary, _not_ by the catch block & frontend flag here.
-    getBackendUpdateValue(newValue)).then(refreshDatasourceItem).catch(function (error) {
+    execute(updateValue !== undefined ? updateValue : getBackendUpdateValue(newValue)).then(refreshDatasourceItem).catch(function (error) {
       var status = error && _typeof(error) === 'object' ? error.status : undefined;
       showErrorFlag({
         status: status

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/link-datasource",
-	"version": "4.14.6",
+	"version": "4.16.0",
 	"description": "UI Components to support linking platform dataset feature",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -42,7 +42,7 @@
 		"@atlaskit/avatar": "^25.1.0",
 		"@atlaskit/avatar-group": "^12.1.0",
 		"@atlaskit/badge": "^18.1.0",
-		"@atlaskit/button": "^23.2.0",
+		"@atlaskit/button": "^23.3.0",
 		"@atlaskit/css": "^0.12.0",
 		"@atlaskit/datetime-picker": "^17.0.0",
 		"@atlaskit/dropdown-menu": "^16.3.0",
@@ -64,7 +64,7 @@
 		"@atlaskit/link-client-extension": "^5.0.0",
 		"@atlaskit/linking-common": "^9.2.0",
 		"@atlaskit/linking-types": "^14.0.0",
-		"@atlaskit/logo": "^19.5.0",
+		"@atlaskit/logo": "^19.6.0",
 		"@atlaskit/lozenge": "^13.0.0",
 		"@atlaskit/modal-dialog": "^14.3.0",
 		"@atlaskit/outbound-auth-flow-client": "^3.4.0",
@@ -75,12 +75,12 @@
 		"@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-autoscroll": "^2.0.0",
 		"@atlaskit/pragmatic-drag-and-drop-react-drop-indicator": "^3.2.0",
 		"@atlaskit/primitives": "^14.10.0",
-		"@atlaskit/react-select": "^3.2.0",
+		"@atlaskit/react-select": "^3.3.0",
 		"@atlaskit/select": "^21.2.0",
 		"@atlaskit/smart-card": "^40.5.0",
 		"@atlaskit/smart-user-picker": "^8.0.0",
 		"@atlaskit/spinner": "^18.0.0",
-		"@atlaskit/tag": "^14.0.0",
+		"@atlaskit/tag": "^14.1.0",
 		"@atlaskit/temp-nav-app-icons": "^0.9.0",
 		"@atlaskit/textfield": "^8.0.0",
 		"@atlaskit/theme": "^19.0.0",
@@ -107,7 +107,7 @@
 		"@af/visual-regression": "workspace:^",
 		"@atlaskit/json-ld-types": "^1.4.0",
 		"@atlaskit/link-provider": "^3.4.0",
-		"@atlaskit/link-test-helpers": "^8.2.0",
+		"@atlaskit/link-test-helpers": "^8.3.0",
 		"@atlaskit/ssr": "workspace:^",
 		"@atlaskit/visual-regression": "workspace:^",
 		"@atlassian/feature-flags-test-utils": "^0.3.0",
@@ -160,9 +160,6 @@
 		"./elements": "./src/elements.ts"
 	},
 	"platform-feature-flags": {
-		"platform-datasources-inline-edit-id-checks": {
-			"type": "boolean"
-		},
 		"platform-datasources-enable-two-way-sync-assignee": {
 			"type": "boolean"
 		},
@@ -187,9 +184,6 @@
 		"should-render-to-parent-should-be-true-linking-pla": {
 			"type": "boolean"
 		},
-		"platform_linking_set_should_show_calender_button": {
-			"type": "boolean"
-		},
 		"linking-platform-assests-schema-selector-refresh": {
 			"type": "boolean"
 		},