@atlaskit/link-datasource 4.11.2 → 4.11.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,20 @@
1
1
  # @atlaskit/link-datasource
2
2
 
3
+ ## 4.11.4
4
+
5
+ ### Patch Changes
6
+
7
+ - Updated dependencies
8
+
9
+ ## 4.11.3
10
+
11
+ ### Patch Changes
12
+
13
+ - [#160622](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/160622)
14
+ [`05cddd227d5d8`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/05cddd227d5d8) -
15
+ EDM-12325 fixing all level a11y violations in link-datasource
16
+ - Updated dependencies
17
+
3
18
  ## 4.11.2
4
19
 
5
20
  ### Patch Changes
package/compass.yml CHANGED
@@ -28,4 +28,10 @@ links:
28
28
  type: REPOSITORY
29
29
  url: 'https://bitbucket.org/atlassian/atlassian-frontend-monorepo/src/master/platform/packages/linking-platform/link-datasource'
30
30
  customFields: []
31
- relationships: {}
31
+ relationships:
32
+ DEPENDS_ON:
33
+ - 'ari:cloud:compass:a436116f-02ce-4520-8fbb-7301462a1674:component/c5751cc6-3513-4070-9deb-af31e86aed34/1ae351ab-13bb-4886-8e48-1bbd835fc8ff' # json-ld-types
34
+ - 'ari:cloud:compass:a436116f-02ce-4520-8fbb-7301462a1674:component/c5751cc6-3513-4070-9deb-af31e86aed34/37dc08cd-d81c-4bbb-9b26-5d6d8a417ea3' # link-client-extension
35
+ - 'ari:cloud:compass:a436116f-02ce-4520-8fbb-7301462a1674:component/c5751cc6-3513-4070-9deb-af31e86aed34/18157dad-b7fb-4cde-8b74-e905b5757611' # link-provider
36
+ - 'ari:cloud:compass:a436116f-02ce-4520-8fbb-7301462a1674:component/c5751cc6-3513-4070-9deb-af31e86aed34/3d229125-4f9d-4091-a303-84ae4eb643fb' # linking-common
37
+ - 'ari:cloud:compass:a436116f-02ce-4520-8fbb-7301462a1674:component/c5751cc6-3513-4070-9deb-af31e86aed34/c9898540-33b1-4cd4-9399-16e575bcedae' # smart-card
@@ -160,6 +160,8 @@ var AqlSearchInput = exports.AqlSearchInput = function AqlSearchInput(_ref2) {
160
160
  })),
161
161
  placeholder: formatMessage(_messages.searchInputMessages.placeholder),
162
162
  testId: testId
163
+ }, (0, _platformFeatureFlags.fg)('fix_a11y_issues_inline_edit') && {
164
+ 'aria-label': formatMessage(_messages.searchInputMessages.placeholder)
163
165
  })), lastValidationResult.type === 'invalid' && lastValidationResult.error && /*#__PURE__*/React.createElement(_form.ErrorMessage, null, lastValidationResult.error));
164
166
  }));
165
167
  };
@@ -89,7 +89,7 @@ var renderItem = function renderItem(_ref2, _ref3) {
89
89
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-styled
90
90
  var TableHeading = (0, _react.forwardRef)(function (_ref4, __cmplr) {
91
91
  var _ref4$as = _ref4.as,
92
- C = _ref4$as === void 0 ? "th" : _ref4$as,
92
+ C = _ref4$as === void 0 ? "td" : _ref4$as,
93
93
  __cmpls = _ref4.style,
94
94
  __cmplp = (0, _objectWithoutProperties2.default)(_ref4, _excluded);
95
95
  return /*#__PURE__*/React.createElement(C, (0, _extends2.default)({}, __cmplp, {
@@ -12,6 +12,7 @@ var _react = _interopRequireWildcard(require("react"));
12
12
  var _runtime = require("@compiled/react/runtime");
13
13
  var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
14
14
  var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
15
+ var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
15
16
  var _compiled = require("@atlaskit/primitives/compiled");
16
17
  var _text = _interopRequireDefault(require("../text"));
17
18
  var _excluded = ["as", "style"];
@@ -44,11 +45,13 @@ var ICON_TYPE_TEXT_TEST_ID = exports.ICON_TYPE_TEXT_TEST_ID = "".concat(ICON_TYP
44
45
  */
45
46
  var IconRenderType = function IconRenderType(_ref2) {
46
47
  var _ref2$label = _ref2.label,
47
- label = _ref2$label === void 0 ? '' : _ref2$label,
48
+ propLabel = _ref2$label === void 0 ? '' : _ref2$label,
48
49
  text = _ref2.text,
49
50
  source = _ref2.source,
50
51
  _ref2$testId = _ref2.testId,
51
52
  testId = _ref2$testId === void 0 ? ICON_TYPE_TEST_ID : _ref2$testId;
53
+ // image-redundant-alt - icon does not need label if the text is the same as the label
54
+ var label = propLabel.toLowerCase() !== (text === null || text === void 0 ? void 0 : text.toLowerCase()) || !(0, _platformFeatureFlags.fg)('fix_a11y_issues_inline_edit') ? propLabel : '';
52
55
  return /*#__PURE__*/_react.default.createElement(IconWrapper, null, /*#__PURE__*/_react.default.createElement("img", {
53
56
  src: source,
54
57
  alt: label,
@@ -150,5 +150,7 @@ export const AqlSearchInput = ({
150
150
  })),
151
151
  placeholder: formatMessage(searchInputMessages.placeholder),
152
152
  testId: testId
153
+ }, fg('fix_a11y_issues_inline_edit') && {
154
+ 'aria-label': formatMessage(searchInputMessages.placeholder)
153
155
  })), lastValidationResult.type === 'invalid' && lastValidationResult.error && /*#__PURE__*/React.createElement(ErrorMessage, null, lastValidationResult.error))));
154
156
  };
@@ -78,7 +78,7 @@ const renderItem = ({
78
78
  };
79
79
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-styled
80
80
  const TableHeading = forwardRef(({
81
- as: C = "th",
81
+ as: C = "td",
82
82
  style: __cmpls,
83
83
  ...__cmplp
84
84
  }, __cmplr) => {
@@ -4,6 +4,7 @@ import "./index.compiled.css";
4
4
  import { forwardRef } from 'react';
5
5
  import { ax, ix } from "@compiled/react/runtime";
6
6
  import React from 'react';
7
+ import { fg } from '@atlaskit/platform-feature-flags';
7
8
  import { Box } from '@atlaskit/primitives/compiled';
8
9
  import TextRenderType from '../text';
9
10
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-styled -- To migrate as part of go/ui-styling-standard
@@ -32,11 +33,13 @@ export const ICON_TYPE_TEXT_TEST_ID = `${ICON_TYPE_TEST_ID}-text`;
32
33
  * `platform-datasources-enable-two-way-sync-priority` rollout.
33
34
  */
34
35
  const IconRenderType = ({
35
- label = '',
36
+ label: propLabel = '',
36
37
  text,
37
38
  source,
38
39
  testId = ICON_TYPE_TEST_ID
39
40
  }) => {
41
+ // image-redundant-alt - icon does not need label if the text is the same as the label
42
+ const label = propLabel.toLowerCase() !== (text === null || text === void 0 ? void 0 : text.toLowerCase()) || !fg('fix_a11y_issues_inline_edit') ? propLabel : '';
40
43
  return /*#__PURE__*/React.createElement(IconWrapper, null, /*#__PURE__*/React.createElement("img", {
41
44
  src: source,
42
45
  alt: label,
@@ -152,6 +152,8 @@ export var AqlSearchInput = function AqlSearchInput(_ref2) {
152
152
  })),
153
153
  placeholder: formatMessage(searchInputMessages.placeholder),
154
154
  testId: testId
155
+ }, fg('fix_a11y_issues_inline_edit') && {
156
+ 'aria-label': formatMessage(searchInputMessages.placeholder)
155
157
  })), lastValidationResult.type === 'invalid' && lastValidationResult.error && /*#__PURE__*/React.createElement(ErrorMessage, null, lastValidationResult.error));
156
158
  }));
157
159
  };
@@ -80,7 +80,7 @@ var renderItem = function renderItem(_ref2, _ref3) {
80
80
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-styled
81
81
  var TableHeading = forwardRef(function (_ref4, __cmplr) {
82
82
  var _ref4$as = _ref4.as,
83
- C = _ref4$as === void 0 ? "th" : _ref4$as,
83
+ C = _ref4$as === void 0 ? "td" : _ref4$as,
84
84
  __cmpls = _ref4.style,
85
85
  __cmplp = _objectWithoutProperties(_ref4, _excluded);
86
86
  return /*#__PURE__*/React.createElement(C, _extends({}, __cmplp, {
@@ -6,6 +6,7 @@ import "./index.compiled.css";
6
6
  import { forwardRef } from 'react';
7
7
  import { ax, ix } from "@compiled/react/runtime";
8
8
  import React from 'react';
9
+ import { fg } from '@atlaskit/platform-feature-flags';
9
10
  import { Box } from '@atlaskit/primitives/compiled';
10
11
  import TextRenderType from '../text';
11
12
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-styled -- To migrate as part of go/ui-styling-standard
@@ -35,11 +36,13 @@ export var ICON_TYPE_TEXT_TEST_ID = "".concat(ICON_TYPE_TEST_ID, "-text");
35
36
  */
36
37
  var IconRenderType = function IconRenderType(_ref2) {
37
38
  var _ref2$label = _ref2.label,
38
- label = _ref2$label === void 0 ? '' : _ref2$label,
39
+ propLabel = _ref2$label === void 0 ? '' : _ref2$label,
39
40
  text = _ref2.text,
40
41
  source = _ref2.source,
41
42
  _ref2$testId = _ref2.testId,
42
43
  testId = _ref2$testId === void 0 ? ICON_TYPE_TEST_ID : _ref2$testId;
44
+ // image-redundant-alt - icon does not need label if the text is the same as the label
45
+ var label = propLabel.toLowerCase() !== (text === null || text === void 0 ? void 0 : text.toLowerCase()) || !fg('fix_a11y_issues_inline_edit') ? propLabel : '';
43
46
  return /*#__PURE__*/React.createElement(IconWrapper, null, /*#__PURE__*/React.createElement("img", {
44
47
  src: source,
45
48
  alt: label,
@@ -9,5 +9,5 @@ export declare const ICON_TYPE_TEXT_TEST_ID = "link-datasource-render-type--icon
9
9
  * @deprecated: To be cleaned up and replaced with new-icon after
10
10
  * `platform-datasources-enable-two-way-sync-priority` rollout.
11
11
  */
12
- declare const IconRenderType: ({ label, text, source, testId }: IconProps) => React.JSX.Element;
12
+ declare const IconRenderType: ({ label: propLabel, text, source, testId, }: IconProps) => React.JSX.Element;
13
13
  export default IconRenderType;
@@ -9,5 +9,5 @@ export declare const ICON_TYPE_TEXT_TEST_ID = "link-datasource-render-type--icon
9
9
  * @deprecated: To be cleaned up and replaced with new-icon after
10
10
  * `platform-datasources-enable-two-way-sync-priority` rollout.
11
11
  */
12
- declare const IconRenderType: ({ label, text, source, testId }: IconProps) => React.JSX.Element;
12
+ declare const IconRenderType: ({ label: propLabel, text, source, testId, }: IconProps) => React.JSX.Element;
13
13
  export default IconRenderType;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/link-datasource",
3
- "version": "4.11.2",
3
+ "version": "4.11.4",
4
4
  "description": "UI Components to support linking platform dataset feature",
5
5
  "author": "Atlassian Pty Ltd",
6
6
  "license": "Apache-2.0",
@@ -52,7 +52,7 @@
52
52
  "@atlaskit/flag": "^17.1.0",
53
53
  "@atlaskit/form": "^12.0.0",
54
54
  "@atlaskit/heading": "^5.2.0",
55
- "@atlaskit/icon": "^26.1.0",
55
+ "@atlaskit/icon": "^26.4.0",
56
56
  "@atlaskit/icon-object": "^7.1.0",
57
57
  "@atlaskit/image": "^3.0.0",
58
58
  "@atlaskit/inline-edit": "^15.2.0",
@@ -65,12 +65,12 @@
65
65
  "@atlaskit/link-client-extension": "^5.0.0",
66
66
  "@atlaskit/linking-common": "^9.0.0",
67
67
  "@atlaskit/linking-types": "^9.10.0",
68
- "@atlaskit/logo": "^18.1.0",
68
+ "@atlaskit/logo": "^18.2.0",
69
69
  "@atlaskit/lozenge": "^12.2.0",
70
70
  "@atlaskit/modal-dialog": "^14.2.0",
71
71
  "@atlaskit/outbound-auth-flow-client": "^3.4.0",
72
72
  "@atlaskit/platform-feature-flags": "^1.1.0",
73
- "@atlaskit/popup": "^4.2.0",
73
+ "@atlaskit/popup": "^4.3.0",
74
74
  "@atlaskit/pragmatic-drag-and-drop": "^1.7.0",
75
75
  "@atlaskit/pragmatic-drag-and-drop-hitbox": "^1.1.0",
76
76
  "@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-autoscroll": "^2.0.0",
@@ -78,15 +78,15 @@
78
78
  "@atlaskit/primitives": "^14.8.0",
79
79
  "@atlaskit/react-select": "^2.6.0",
80
80
  "@atlaskit/select": "^20.6.0",
81
- "@atlaskit/smart-card": "^38.4.0",
81
+ "@atlaskit/smart-card": "^38.5.0",
82
82
  "@atlaskit/smart-user-picker": "^8.0.0",
83
83
  "@atlaskit/spinner": "^18.0.0",
84
84
  "@atlaskit/tag": "^14.0.0",
85
- "@atlaskit/temp-nav-app-icons": "^0.7.0",
85
+ "@atlaskit/temp-nav-app-icons": "^0.8.0",
86
86
  "@atlaskit/textfield": "^8.0.0",
87
87
  "@atlaskit/theme": "^18.0.0",
88
88
  "@atlaskit/tokens": "^4.9.0",
89
- "@atlaskit/tooltip": "^20.0.0",
89
+ "@atlaskit/tooltip": "^20.2.0",
90
90
  "@atlaskit/ufo": "^0.4.0",
91
91
  "@atlaskit/width-detector": "^5.0.0",
92
92
  "@babel/runtime": "^7.0.0",
@@ -107,7 +107,7 @@
107
107
  "@af/integration-testing": "workspace:^",
108
108
  "@af/visual-regression": "workspace:^",
109
109
  "@atlaskit/json-ld-types": "^1.2.0",
110
- "@atlaskit/link-provider": "^3.0.0",
110
+ "@atlaskit/link-provider": "^3.2.0",
111
111
  "@atlaskit/link-test-helpers": "^8.0.0",
112
112
  "@atlaskit/ssr": "workspace:^",
113
113
  "@atlaskit/visual-regression": "workspace:^",
@@ -197,6 +197,9 @@
197
197
  },
198
198
  "compiled-react-select": {
199
199
  "type": "boolean"
200
+ },
201
+ "fix_a11y_issues_inline_edit": {
202
+ "type": "boolean"
200
203
  }
201
204
  },
202
205
  "compassUnitTestMetricSourceId": "ari:cloud:compass:a436116f-02ce-4520-8fbb-7301462a1674:metric-source/c5751cc6-3513-4070-9deb-af31e86aed34/9c893299-a527-4457-9b46-f3bc4c828766"