@atlaskit/link-datasource 3.8.9 → 3.8.10

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/link-datasource
 
+## 3.8.10
+
+### Patch Changes
+
+- [#164025](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/164025)
+  [`1eb78af6a417e`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/1eb78af6a417e) -
+  Prevent inline edit on dropdown fields without executeFetch
+
 ## 3.8.9
 
 ### Patch Changes

package/dist/cjs/ui/issue-like-table/edit-type/index.js

@@ -5,7 +5,7 @@ var _typeof = require("@babel/runtime/helpers/typeof");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.isEditTypeSupported = exports.editType = void 0;
+exports.isEditTypeSupported = exports.isEditTypeSelectable = exports.editType = void 0;
 var _objectDestructuringEmpty2 = _interopRequireDefault(require("@babel/runtime/helpers/objectDestructuringEmpty"));
 var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 var _react = _interopRequireDefault(require("react"));
@@ -59,4 +59,8 @@ var editType = exports.editType = function editType(_ref) {
 var isEditTypeSupported = exports.isEditTypeSupported = function isEditTypeSupported(type) {
   var supportedEditType = (0, _platformFeatureFlags.fg)('platform-datasources-enable-two-way-sync-statuses') ? ['string', 'status'] : ['string'];
   return supportedEditType.includes(type);
+};
+var isEditTypeSelectable = exports.isEditTypeSelectable = function isEditTypeSelectable(type) {
+  var selectEditTypes = ['status', 'icon', 'user'];
+  return selectEditTypes.includes(type);
 };

package/dist/cjs/ui/issue-like-table/table-cell-content/index.js

@@ -7,6 +7,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.TableCellContent = exports.ReadOnlyCell = void 0;
 var _react = _interopRequireDefault(require("react"));
 var _reactIntlNext = require("react-intl-next");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _primitives = require("@atlaskit/primitives");
 var _tooltip = _interopRequireDefault(require("@atlaskit/tooltip"));
 var _state = require("../../../state");
@@ -85,7 +86,7 @@ var InlineEditableCell = function InlineEditableCell(_ref3) {
     renderItem = _ref3.renderItem,
     integrationKey = _ref3.integrationKey,
     wrappedColumnKeys = _ref3.wrappedColumnKeys;
-  // Execute fn is only returned when the field is editable and the action schema exists
+  // Callbacks are returned only when the ari is editable and the action schemas exist in the store
   var _useExecuteAtomicActi = (0, _actions.useExecuteAtomicAction)({
       ari: ari,
       fieldKey: columnKey,
@@ -93,7 +94,10 @@ var InlineEditableCell = function InlineEditableCell(_ref3) {
     }),
     execute = _useExecuteAtomicActi.execute,
     executeFetch = _useExecuteAtomicActi.executeFetch;
-  var isEditable = !!execute;
+
+  // A field is editable when `execute` is returned from the store
+  // if the field requires to fetch options to execute, then is editable only if `executeFetch` is also returned
+  var isEditable = !!execute && ((0, _editType.isEditTypeSelectable)(values.type) && (0, _platformFeatureFlags.fg)('enable_datasource_supporting_actions') ? !!executeFetch : true);
   var readView = /*#__PURE__*/_react.default.createElement(TooltipWrapper, {
     columnKey: columnKey,
     datasourceTypeWithValues: values,

package/dist/es2019/ui/issue-like-table/edit-type/index.js

@@ -46,4 +46,8 @@ export const editType = ({
 export const isEditTypeSupported = type => {
   const supportedEditType = fg('platform-datasources-enable-two-way-sync-statuses') ? ['string', 'status'] : ['string'];
   return supportedEditType.includes(type);
+};
+export const isEditTypeSelectable = type => {
+  const selectEditTypes = ['status', 'icon', 'user'];
+  return selectEditTypes.includes(type);
 };

package/dist/es2019/ui/issue-like-table/edit-type/status/index.js

@@ -3,9 +3,9 @@ import React, { useEffect, useState } from 'react';
 import { ActionOperationStatus } from '@atlaskit/linking-types';
 import Lozenge from '@atlaskit/lozenge';
 import Select from '@atlaskit/select';
-import { failUfoExperience, succeedUfoExperience } from "../../../../analytics/ufoExperiences";
-import { useDatasourceExperienceId } from "../../../../contexts/datasource-experience-id";
-import { InlineEditUFOExperience } from "../../table-cell-content/inline-edit";
+import { failUfoExperience, succeedUfoExperience } from '../../../../analytics/ufoExperiences';
+import { useDatasourceExperienceId } from '../../../../contexts/datasource-experience-id';
+import { InlineEditUFOExperience } from '../../table-cell-content/inline-edit';
 const StatusEditType = props => {
   var _currentValue$values;
   const {

package/dist/es2019/ui/issue-like-table/edit-type/text/index.js

@@ -2,8 +2,8 @@ import _extends from "@babel/runtime/helpers/extends";
 import React, { useEffect } from 'react';
 import { Layering } from '@atlaskit/layering';
 import Textfield from '@atlaskit/textfield';
-import { succeedUfoExperience } from "../../../../analytics/ufoExperiences";
-import { useDatasourceExperienceId } from "../../../../contexts/datasource-experience-id";
+import { succeedUfoExperience } from '../../../../analytics/ufoExperiences';
+import { useDatasourceExperienceId } from '../../../../contexts/datasource-experience-id';
 export const toTextValue = typeWithValues => {
   var _ref, _typeWithValues$value;
   return (_ref = (_typeWithValues$value = typeWithValues.values) === null || _typeWithValues$value === void 0 ? void 0 : _typeWithValues$value[0]) !== null && _ref !== void 0 ? _ref : '';

package/dist/es2019/ui/issue-like-table/table-cell-content/index.js

@@ -1,10 +1,11 @@
 import React from 'react';
 import { useIntl } from 'react-intl-next';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { Box, xcss } from '@atlaskit/primitives';
 import Tooltip from '@atlaskit/tooltip';
 import { useDatasourceItem } from '../../../state';
 import { useExecuteAtomicAction } from '../../../state/actions';
-import { isEditTypeSupported } from '../edit-type';
+import { isEditTypeSelectable, isEditTypeSupported } from '../edit-type';
 import { stringifyType } from '../render-type';
 import { TruncateTextTag } from '../truncate-text-tag';
 import { InlineEdit } from './inline-edit';
@@ -77,7 +78,7 @@ const InlineEditableCell = ({
   integrationKey,
   wrappedColumnKeys
 }) => {
-  // Execute fn is only returned when the field is editable and the action schema exists
+  // Callbacks are returned only when the ari is editable and the action schemas exist in the store
   const {
     execute,
     executeFetch
@@ -86,7 +87,10 @@ const InlineEditableCell = ({
     fieldKey: columnKey,
     integrationKey
   });
-  const isEditable = !!execute;
+
+  // A field is editable when `execute` is returned from the store
+  // if the field requires to fetch options to execute, then is editable only if `executeFetch` is also returned
+  const isEditable = !!execute && (isEditTypeSelectable(values.type) && fg('enable_datasource_supporting_actions') ? !!executeFetch : true);
   const readView = /*#__PURE__*/React.createElement(TooltipWrapper, {
     columnKey: columnKey,
     datasourceTypeWithValues: values,

package/dist/es2019/ui/issue-like-table/table-cell-content/inline-edit.js

@@ -4,8 +4,8 @@ import AKInlineEdit from '@atlaskit/inline-edit';
 import { Box, xcss } from '@atlaskit/primitives';
 import { useSmartLinkReload } from '@atlaskit/smart-card/hooks';
 import { useDatasourceAnalyticsEvents } from '../../../analytics';
-import { startUfoExperience } from "../../../analytics/ufoExperiences";
-import { useDatasourceExperienceId } from "../../../contexts/datasource-experience-id";
+import { startUfoExperience } from '../../../analytics/ufoExperiences';
+import { useDatasourceExperienceId } from '../../../contexts/datasource-experience-id';
 import { useDatasourceTableFlag } from '../../../hooks/useDatasourceTableFlag';
 import { useDatasourceActions, useDatasourceItem } from '../../../state';
 import { editType } from '../edit-type';

package/dist/esm/ui/issue-like-table/edit-type/index.js

@@ -50,4 +50,8 @@ export var editType = function editType(_ref) {
 export var isEditTypeSupported = function isEditTypeSupported(type) {
   var supportedEditType = fg('platform-datasources-enable-two-way-sync-statuses') ? ['string', 'status'] : ['string'];
   return supportedEditType.includes(type);
+};
+export var isEditTypeSelectable = function isEditTypeSelectable(type) {
+  var selectEditTypes = ['status', 'icon', 'user'];
+  return selectEditTypes.includes(type);
 };

package/dist/esm/ui/issue-like-table/edit-type/status/index.js

@@ -6,9 +6,9 @@ import React, { useEffect, useState } from 'react';
 import { ActionOperationStatus } from '@atlaskit/linking-types';
 import Lozenge from '@atlaskit/lozenge';
 import Select from '@atlaskit/select';
-import { failUfoExperience, succeedUfoExperience } from "../../../../analytics/ufoExperiences";
-import { useDatasourceExperienceId } from "../../../../contexts/datasource-experience-id";
-import { InlineEditUFOExperience } from "../../table-cell-content/inline-edit";
+import { failUfoExperience, succeedUfoExperience } from '../../../../analytics/ufoExperiences';
+import { useDatasourceExperienceId } from '../../../../contexts/datasource-experience-id';
+import { InlineEditUFOExperience } from '../../table-cell-content/inline-edit';
 var StatusEditType = function StatusEditType(props) {
   var _currentValue$values;
   var currentValue = props.currentValue,

package/dist/esm/ui/issue-like-table/edit-type/text/index.js

@@ -2,8 +2,8 @@ import _extends from "@babel/runtime/helpers/extends";
 import React, { useEffect } from 'react';
 import { Layering } from '@atlaskit/layering';
 import Textfield from '@atlaskit/textfield';
-import { succeedUfoExperience } from "../../../../analytics/ufoExperiences";
-import { useDatasourceExperienceId } from "../../../../contexts/datasource-experience-id";
+import { succeedUfoExperience } from '../../../../analytics/ufoExperiences';
+import { useDatasourceExperienceId } from '../../../../contexts/datasource-experience-id';
 export var toTextValue = function toTextValue(typeWithValues) {
   var _ref, _typeWithValues$value;
   return (_ref = (_typeWithValues$value = typeWithValues.values) === null || _typeWithValues$value === void 0 ? void 0 : _typeWithValues$value[0]) !== null && _ref !== void 0 ? _ref : '';

package/dist/esm/ui/issue-like-table/table-cell-content/index.js

@@ -1,10 +1,11 @@
 import React from 'react';
 import { useIntl } from 'react-intl-next';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { Box, xcss } from '@atlaskit/primitives';
 import Tooltip from '@atlaskit/tooltip';
 import { useDatasourceItem } from '../../../state';
 import { useExecuteAtomicAction } from '../../../state/actions';
-import { isEditTypeSupported } from '../edit-type';
+import { isEditTypeSelectable, isEditTypeSupported } from '../edit-type';
 import { stringifyType } from '../render-type';
 import { TruncateTextTag } from '../truncate-text-tag';
 import { InlineEdit } from './inline-edit';
@@ -78,7 +79,7 @@ var InlineEditableCell = function InlineEditableCell(_ref3) {
     renderItem = _ref3.renderItem,
     integrationKey = _ref3.integrationKey,
     wrappedColumnKeys = _ref3.wrappedColumnKeys;
-  // Execute fn is only returned when the field is editable and the action schema exists
+  // Callbacks are returned only when the ari is editable and the action schemas exist in the store
   var _useExecuteAtomicActi = useExecuteAtomicAction({
       ari: ari,
       fieldKey: columnKey,
@@ -86,7 +87,10 @@ var InlineEditableCell = function InlineEditableCell(_ref3) {
     }),
     execute = _useExecuteAtomicActi.execute,
     executeFetch = _useExecuteAtomicActi.executeFetch;
-  var isEditable = !!execute;
+
+  // A field is editable when `execute` is returned from the store
+  // if the field requires to fetch options to execute, then is editable only if `executeFetch` is also returned
+  var isEditable = !!execute && (isEditTypeSelectable(values.type) && fg('enable_datasource_supporting_actions') ? !!executeFetch : true);
   var readView = /*#__PURE__*/React.createElement(TooltipWrapper, {
     columnKey: columnKey,
     datasourceTypeWithValues: values,

package/dist/esm/ui/issue-like-table/table-cell-content/inline-edit.js

@@ -9,8 +9,8 @@ import AKInlineEdit from '@atlaskit/inline-edit';
 import { Box, xcss } from '@atlaskit/primitives';
 import { useSmartLinkReload } from '@atlaskit/smart-card/hooks';
 import { useDatasourceAnalyticsEvents } from '../../../analytics';
-import { startUfoExperience } from "../../../analytics/ufoExperiences";
-import { useDatasourceExperienceId } from "../../../contexts/datasource-experience-id";
+import { startUfoExperience } from '../../../analytics/ufoExperiences';
+import { useDatasourceExperienceId } from '../../../contexts/datasource-experience-id';
 import { useDatasourceTableFlag } from '../../../hooks/useDatasourceTableFlag';
 import { useDatasourceActions, useDatasourceItem } from '../../../state';
 import { editType } from '../edit-type';

package/dist/types/ui/issue-like-table/edit-type/index.d.ts

@@ -9,3 +9,4 @@ export declare const editType: ({ defaultValue, currentValue, setEditValues, exe
     executeFetch?: (<E>(inputs: any) => Promise<E>) | undefined;
 }) => Pick<React.ComponentProps<typeof InlineEdit>, 'defaultValue' | 'editView'>;
 export declare const isEditTypeSupported: (type: DatasourceType['type']) => boolean;
+export declare const isEditTypeSelectable: (type: DatasourceType['type']) => boolean;

package/dist/types-ts4.5/ui/issue-like-table/edit-type/index.d.ts

@@ -9,3 +9,4 @@ export declare const editType: ({ defaultValue, currentValue, setEditValues, exe
     executeFetch?: (<E>(inputs: any) => Promise<E>) | undefined;
 }) => Pick<React.ComponentProps<typeof InlineEdit>, 'defaultValue' | 'editView'>;
 export declare const isEditTypeSupported: (type: DatasourceType['type']) => boolean;
+export declare const isEditTypeSelectable: (type: DatasourceType['type']) => boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/link-datasource",
-	"version": "3.8.9",
+	"version": "3.8.10",
 	"description": "UI Components to support linking platform dataset feature",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",