@atlaskit/link-datasource 3.15.13 → 3.16.1

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # @atlaskit/link-datasource
 
+## 3.16.1
+
+### Patch Changes
+
+- Updated dependencies
+
+## 3.16.0
+
+### Minor Changes
+
+- [#103370](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/103370)
+  [`8e2f83c636875`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/8e2f83c636875) -
+  Cleans up feature flag enable_datasource_react_sweet_state to release react sweet state which now
+  handles the state and creation of IssueLikeTable in datasources
+
+### Patch Changes
+
+- [#104950](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/104950)
+  [`39e7768169d56`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/39e7768169d56) -
+  EDM-11475 Validate datasources inline-edit update ID
+- Updated dependencies
+
 ## 3.15.13
 
 ### Patch Changes

package/dist/cjs/hooks/useDatasourceTableState.js

@@ -13,7 +13,6 @@ var _react = require("react");
 var _isEqual = _interopRequireDefault(require("lodash/isEqual"));
 var _atlassianContext = require("@atlaskit/atlassian-context");
 var _linkClientExtension = require("@atlaskit/link-client-extension");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _analytics = require("../analytics");
 var _state = require("../state");
 var _actions = require("../state/actions");
@@ -312,33 +311,32 @@ var useDatasourceTableState = exports.useDatasourceTableState = function useData
             }
             return [].concat((0, _toConsumableArray2.default)(currentResponseItems), (0, _toConsumableArray2.default)(items));
           });
-          if ((0, _platformFeatureFlags.fg)('enable_datasource_react_sweet_state')) {
-            /**
-             * Product is typed as any.
-             */
-            integrationKey = product;
-            /**
-             * When `entityType` is undefined, we should not discover actions it prevents unnecessary requests to Actions service
-             */
-            entityType = objectTypesEntity;
-            newIds = onAddItems(items, typeof integrationKey === 'string' ? integrationKey : undefined, entityType);
-            setResponseItemIds(function (currentIds) {
-              return [].concat((0, _toConsumableArray2.default)(currentIds), (0, _toConsumableArray2.default)(newIds));
-            });
-            if (!(0, _atlassianContext.isFedRamp)()) {
-              if (typeof integrationKey === 'string') {
-                aris = items.reduce(function (acc, item) {
-                  var _item$ari;
-                  return typeof ((_item$ari = item.ari) === null || _item$ari === void 0 ? void 0 : _item$ari.data) === 'string' ? [].concat((0, _toConsumableArray2.default)(acc), [item.ari.data]) : acc;
-                }, []);
-                if (aris.length && entityType) {
-                  discoverActions({
-                    aris: aris,
-                    integrationKey: integrationKey,
-                    fieldKeys: fieldKeys,
-                    entityType: entityType
-                  });
-                }
+
+          /**
+           * Product is typed as any.
+           */
+          integrationKey = product;
+          /**
+           * When `entityType` is undefined, we should not discover actions it prevents unnecessary requests to Actions service
+           */
+          entityType = objectTypesEntity;
+          newIds = onAddItems(items, typeof integrationKey === 'string' ? integrationKey : undefined, entityType);
+          setResponseItemIds(function (currentIds) {
+            return [].concat((0, _toConsumableArray2.default)(currentIds), (0, _toConsumableArray2.default)(newIds));
+          });
+          if (!(0, _atlassianContext.isFedRamp)()) {
+            if (typeof integrationKey === 'string') {
+              aris = items.reduce(function (acc, item) {
+                var _item$ari;
+                return typeof ((_item$ari = item.ari) === null || _item$ari === void 0 ? void 0 : _item$ari.data) === 'string' ? [].concat((0, _toConsumableArray2.default)(acc), [item.ari.data]) : acc;
+              }, []);
+              if (aris.length && entityType) {
+                discoverActions({
+                  aris: aris,
+                  integrationKey: integrationKey,
+                  fieldKeys: fieldKeys,
+                  entityType: entityType
+                });
               }
             }
           }
@@ -360,38 +358,38 @@ var useDatasourceTableState = exports.useDatasourceTableState = function useData
             });
           }
           setStatus('resolved');
-          _context2.next = 60;
+          _context2.next = 64;
           break;
-        case 48:
-          _context2.prev = 48;
+        case 52:
+          _context2.prev = 52;
           _context2.t0 = _context2["catch"](10);
           if (!(_context2.t0.message === 'Aborted')) {
-            _context2.next = 52;
+            _context2.next = 56;
             break;
           }
           return _context2.abrupt("return");
-        case 52:
+        case 56:
           captureError('onNextPage', _context2.t0);
           if (!(_context2.t0 instanceof Response && _context2.t0.status === 401)) {
-            _context2.next = 56;
+            _context2.next = 60;
             break;
           }
           setStatus('unauthorized');
           return _context2.abrupt("return");
-        case 56:
+        case 60:
           if (!(_context2.t0 instanceof Response && _context2.t0.status === 403)) {
-            _context2.next = 59;
+            _context2.next = 63;
             break;
           }
           setStatus('forbidden');
           return _context2.abrupt("return");
-        case 59:
+        case 63:
           setStatus('rejected');
-        case 60:
+        case 64:
         case "end":
           return _context2.stop();
       }
-    }, _callee2, null, [[10, 48]]);
+    }, _callee2, null, [[10, 52]]);
   })), [captureError, parameters, fieldKeys, nextCursor, responseItems, setResponseItemIds, onAddItems, getDatasourceData, datasourceId, applySchemaProperties, fireEvent, fullSchema, initialEmptyArray, discoverActions]);
   var reset = (0, _react.useCallback)(function (options) {
     setResponseItems(initialEmptyArray);

package/dist/cjs/state/index.js

@@ -11,7 +11,6 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _react = _interopRequireDefault(require("react"));
 var _reactSweetState = require("react-sweet-state");
 var _uuid = require("uuid");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 var getInitialState = function getInitialState() {
@@ -82,10 +81,7 @@ var useDatasourceActions = exports.useDatasourceActions = (0, _reactSweetState.c
 var Container = (0, _reactSweetState.createContainer)(Store);
 var StoreContainer = exports.StoreContainer = function StoreContainer(_ref6) {
   var children = _ref6.children;
-  if ((0, _platformFeatureFlags.fg)('enable_datasource_react_sweet_state')) {
-    return /*#__PURE__*/_react.default.createElement(Container, {
-      scope: "datasource"
-    }, children);
-  }
-  return children;
+  return /*#__PURE__*/_react.default.createElement(Container, {
+    scope: "datasource"
+  }, children);
 };

package/dist/cjs/ui/issue-like-table/edit-type/icon/index.js

@@ -9,6 +9,7 @@ exports.default = void 0;
 var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 var _react = _interopRequireWildcard(require("react"));
 var _layering = require("@atlaskit/layering");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _select = _interopRequireDefault(require("@atlaskit/select"));
 var _tooltip = _interopRequireDefault(require("@atlaskit/tooltip"));
 var _ufoExperiences = require("../../../../analytics/ufoExperiences");
@@ -53,8 +54,13 @@ var IconEditType = function IconEditType(props) {
   }, /*#__PURE__*/_react.default.createElement(_select.default, (0, _extends2.default)({}, (0, _utils.getCleanedSelectProps)(props), {
     autoFocus: true,
     blurInputOnSelect: true,
-    defaultMenuIsOpen: true,
-    options: options,
+    defaultMenuIsOpen: true
+    // We can't update the status if we don't have an ID - however the ID
+    // is typed optional.
+    ,
+    options: (0, _platformFeatureFlags.fg)('platform-datasources-inline-edit-id-checks') ? options.filter(function (option) {
+      return option.id;
+    }) : options,
     menuPlacement: "auto",
     isLoading: isLoading,
     filterOption: filterOption,

package/dist/cjs/ui/issue-like-table/index.js

@@ -14,11 +14,9 @@ var _react = require("react");
 var _react2 = require("@emotion/react");
 var _styled = _interopRequireDefault(require("@emotion/styled"));
 var _debounce = _interopRequireDefault(require("lodash/debounce"));
-var _reactIntlNext = require("react-intl-next");
 var _tinyInvariant = _interopRequireDefault(require("tiny-invariant"));
 var _flag = require("@atlaskit/flag");
 var _linkingCommon = require("@atlaskit/linking-common");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _closestEdge = require("@atlaskit/pragmatic-drag-and-drop-hitbox/closest-edge");
 var _reorderWithEdge = require("@atlaskit/pragmatic-drag-and-drop-hitbox/util/reorder-with-edge");
 var _pragmaticDragAndDropReactBeautifulDndAutoscroll = require("@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-autoscroll");
@@ -39,7 +37,6 @@ var _emptyState = _interopRequireDefault(require("./empty-state"));
 var _renderType = require("./render-type");
 var _styled2 = require("./styled");
 var _tableCellContent = require("./table-cell-content");
-var _truncateTextTag = require("./truncate-text-tag");
 var _useIsOnScreen = require("./useIsOnScreen");
 var _utils = require("./utils");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
@@ -276,7 +273,6 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
   var tableId = (0, _react.useMemo)(function () {
     return Symbol('unique-id');
   }, []);
-  var intl = (0, _reactIntlNext.useIntl)();
   var experienceId = (0, _datasourceExperienceId.useDatasourceExperienceId)();
   var tableHeaderRowRef = (0, _react.useRef)(null);
   var _useState = (0, _react.useState)(null),
@@ -332,8 +328,6 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
   // TODO seems like this component can't handle some combination of incremental data retrieval.
   // If data comes first, then columns and then visibleColumnKeys it blows up,
   // or some other combination.
-
-  var identityColumnKey = 'id';
   var columnsWidthsSum = (0, _react.useMemo)(function () {
     return visibleSortedColumns.map(function (_ref7) {
       var key = _ref7.key,
@@ -464,76 +458,34 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
     }));
   }, [visibleColumnKeys, onVisibleColumnKeysChange, tableId, hasData]);
   var tableRows = (0, _react.useMemo)(function () {
-    return (
-      // eslint-disable-next-line @atlaskit/platform/ensure-feature-flag-prefix
-      (0, _platformFeatureFlags.fg)('enable_datasource_react_sweet_state') ? itemIds.map(function (id, rowIndex) {
-        return {
-          key: id,
-          cells: visibleSortedColumns.map(function (_ref12, cellIndex) {
-            var key = _ref12.key,
-              type = _ref12.type,
-              title = _ref12.title;
-            return {
-              key: key,
+    return itemIds.map(function (id, rowIndex) {
+      return {
+        key: id,
+        cells: visibleSortedColumns.map(function (_ref12, cellIndex) {
+          var key = _ref12.key,
+            type = _ref12.type,
+            title = _ref12.title;
+          return {
+            key: key,
+            columnKey: key,
+            // eslint-disable-next-line @atlaskit/platform/ensure-feature-flag-prefix
+            content: (0, _react2.jsx)(_tableCellContent.TableCellContent, {
+              id: id,
               columnKey: key,
-              // eslint-disable-next-line @atlaskit/platform/ensure-feature-flag-prefix
-              content: (0, _react2.jsx)(_tableCellContent.TableCellContent, {
-                id: id,
-                columnKey: key,
-                columnType: type,
-                columnTitle: title,
-                wrappedColumnKeys: wrappedColumnKeys,
-                renderItem: renderItem
-              }),
-              width: getColumnWidth(key, type, cellIndex === visibleSortedColumns.length - 1)
-            };
-          }),
-          ref: rowIndex === items.length - 1 ? function (el) {
-            return setLastRowElement(el);
-          } : undefined
-        };
-      }) : items.map(function (newRowData, rowIndex) {
-        return {
-          key: "".concat(identityColumnKey && newRowData[identityColumnKey] && newRowData[identityColumnKey].data || rowIndex),
-          cells: visibleSortedColumns.map(function (_ref13, cellIndex) {
-            var _newRowData$key;
-            var key = _ref13.key,
-              type = _ref13.type;
-            // Need to make sure we keep falsy values like 0 and '', as well as the boolean false.
-            var value = (_newRowData$key = newRowData[key]) === null || _newRowData$key === void 0 ? void 0 : _newRowData$key.data;
-            var values = Array.isArray(value) ? value : [value];
-            var renderedValues = renderItem({
-              type: type,
-              values: values
-            });
-            var stringifiedContent = values.map(function (value) {
-              return (0, _renderType.stringifyType)({
-                type: type,
-                value: value
-              }, intl.formatMessage, intl.formatDate);
-            }).filter(function (value) {
-              return value !== '';
-            }).join(', ');
-            var contentComponent = stringifiedContent && !(wrappedColumnKeys !== null && wrappedColumnKeys !== void 0 && wrappedColumnKeys.includes(key)) ? (0, _react2.jsx)(_tooltip.default
-            // @ts-ignore: [PIT-1685] Fails in post-office due to backwards incompatibility issue with React 18
-            , {
-              tag: _truncateTextTag.TruncateTextTag,
-              content: stringifiedContent,
-              testId: "issues-table-cell-tooltip"
-            }, renderedValues) : renderedValues;
-            return {
-              key: key,
-              content: contentComponent,
-              width: getColumnWidth(key, type, cellIndex === visibleSortedColumns.length - 1)
-            };
-          }),
-          ref: rowIndex === items.length - 1 ? function (el) {
-            return setLastRowElement(el);
-          } : undefined
-        };
-      })
-    );
-  }, [items, itemIds, renderItem, wrappedColumnKeys, visibleSortedColumns, getColumnWidth, intl.formatMessage, intl.formatDate]);
+              columnType: type,
+              columnTitle: title,
+              wrappedColumnKeys: wrappedColumnKeys,
+              renderItem: renderItem
+            }),
+            width: getColumnWidth(key, type, cellIndex === visibleSortedColumns.length - 1)
+          };
+        }),
+        ref: rowIndex === items.length - 1 ? function (el) {
+          return setLastRowElement(el);
+        } : undefined
+      };
+    });
+  }, [items, itemIds, renderItem, wrappedColumnKeys, visibleSortedColumns, getColumnWidth]);
   var rows = (0, _react.useMemo)(function () {
     if (status !== 'loading') {
       return tableRows;
@@ -626,10 +578,10 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
     className: !!onVisibleColumnKeysChange ? 'has-column-picker' : ''
   }, (0, _react2.jsx)("tr", {
     ref: tableHeaderRowRef
-  }, headerColumns.map(function (_ref15, cellIndex) {
-    var key = _ref15.key,
-      content = _ref15.content,
-      width = _ref15.width;
+  }, headerColumns.map(function (_ref14, cellIndex) {
+    var key = _ref14.key,
+      content = _ref14.content,
+      width = _ref14.width;
     var heading = (0, _react2.jsx)(_tooltip.default, {
       content: content,
       tag: "span",
@@ -647,10 +599,10 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
     }
     if (isEditable) {
       var _containerRef$current3;
-      var previewRows = tableRows.map(function (_ref16) {
-        var cells = _ref16.cells;
-        var cell = cells.find(function (_ref17) {
-          var cellKey = _ref17.key;
+      var previewRows = tableRows.map(function (_ref15) {
+        var cells = _ref15.cells;
+        var cell = cells.find(function (_ref16) {
+          var cellKey = _ref16.key;
           return cellKey === key;
         });
         if (cell) {
@@ -693,43 +645,24 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
   })))), (0, _react2.jsx)("tbody", {
     css: noDefaultBorderStyles,
     "data-testid": testId && "".concat(testId, "--body")
-  }, rows.map(function (_ref18) {
-    var key = _ref18.key,
-      cells = _ref18.cells,
-      ref = _ref18.ref;
+  }, rows.map(function (_ref17) {
+    var key = _ref17.key,
+      cells = _ref17.cells,
+      ref = _ref17.ref;
     return (0, _react2.jsx)("tr", {
       key: key,
       "data-testid": testId && "".concat(testId, "--row-").concat(key),
       ref: ref
-    }, cells.map(function (_ref19, cellIndex) {
-      var cellKey = _ref19.key,
-        content = _ref19.content,
-        width = _ref19.width;
+    }, cells.map(function (_ref18, cellIndex) {
+      var cellKey = _ref18.key,
+        content = _ref18.content,
+        width = _ref18.width;
       var isLastCell = cellIndex === cells.length - 1;
       var loadingRowStyle = (0, _utils.getWidthCss)({
         shouldUseWidth: shouldUseWidth,
         width: width
       });
-      // eslint-disable-next-line @atlaskit/platform/ensure-feature-flag-prefix
-      if ((0, _platformFeatureFlags.fg)('enable_datasource_react_sweet_state')) {
-        return (0, _react2.jsx)(_styled2.InlineEditableTableCell, {
-          key: cellKey,
-          "data-testid": testId && "".concat(testId, "--cell-").concat(cellIndex),
-          colSpan: isEditable && isLastCell ? 2 : undefined
-          // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
-          ,
-          style: loadingRowStyle,
-          css: [wrappedColumnKeys !== null && wrappedColumnKeys !== void 0 && wrappedColumnKeys.includes(cellKey) ? null : truncateStyles]
-        }, content);
-      }
-
-      // extra padding is required around skeleton loader to avoid vertical jumps when data loads
-      if (key !== null && key !== void 0 && key.includes('loading')) {
-        loadingRowStyle = _objectSpread(_objectSpread({}, loadingRowStyle), {}, {
-          paddingBlock: "var(--ds-space-100, 8px)"
-        });
-      }
-      return (0, _react2.jsx)(_styled2.TableCell, {
+      return (0, _react2.jsx)(_styled2.InlineEditableTableCell, {
         key: cellKey,
         "data-testid": testId && "".concat(testId, "--cell-").concat(cellIndex),
         colSpan: isEditable && isLastCell ? 2 : undefined

package/dist/cjs/ui/issue-like-table/styled.js

@@ -4,7 +4,7 @@ var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefau
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.withTablePluginPrefix = exports.withTablePluginHeaderPrefix = exports.withTablePluginBodyPrefix = exports.TableHeading = exports.TableCell = exports.Table = exports.ScrollableContainerHeight = exports.InlineEditableTableCell = void 0;
+exports.withTablePluginPrefix = exports.withTablePluginHeaderPrefix = exports.withTablePluginBodyPrefix = exports.TableHeading = exports.Table = exports.ScrollableContainerHeight = exports.InlineEditableTableCell = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _styled = _interopRequireDefault(require("@emotion/styled"));
 var _colors = require("@atlaskit/theme/colors");
@@ -74,29 +74,6 @@ var TableHeading = exports.TableHeading = _styled.default.th((0, _defineProperty
   wordWrap: 'break-word'
 }));
 
-// eslint-disable-next-line @atlaskit/ui-styling-standard/no-exported-styles, @atlaskit/ui-styling-standard/no-styled -- To migrate as part of go/ui-styling-standard
-var TableCell = exports.TableCell = _styled.default.td((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)({}, "".concat(withTablePluginBodyPrefix()), {
-  /* First section here is to override things editor table plugin css defines */
-  font: "var(--ds-font-body, normal 400 14px/20px ui-sans-serif, -apple-system, BlinkMacSystemFont, \"Segoe UI\", Ubuntu, system-ui, \"Helvetica Neue\", sans-serif)",
-  padding: "var(--ds-space-050, 4px)".concat(" ", "var(--ds-space-100, 8px)"),
-  border: 0,
-  minWidth: 'auto',
-  height: '32px',
-  verticalAlign: 'inherit',
-  boxSizing: 'content-box',
-  // Due to padding, content-box makes td height 40px equal to InlineEdit on height of 32px
-  borderRight: "var(--ds-border-width, 1px)".concat(" solid ", "var(--ds-border, ".concat(_colors.N40, ")")),
-  borderBottom: "var(--ds-border-width, 1px)".concat(" solid ", "var(--ds-border, ".concat(_colors.N40, ")")),
-  overflow: 'hidden'
-}), "".concat(withTablePluginBodyPrefix('&:first-child')), {
-  paddingLeft: "var(--ds-space-100, 8px)"
-}), "".concat(withTablePluginBodyPrefix('&:last-child')), {
-  borderRight: 0,
-  paddingRight: "var(--ds-space-100, 8px)"
-}), "& [data-testid='inline-card-icon-and-title'], " + "& [data-testid='button-connect-account'] > span", {
-  whiteSpace: 'unset'
-}));
-
 // eslint-disable-next-line @atlaskit/ui-styling-standard/no-styled, @atlaskit/ui-styling-standard/no-exported-styles -- To migrate as part of go/ui-styling-standard
 var InlineEditableTableCell = exports.InlineEditableTableCell = _styled.default.td((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)({}, "".concat(withTablePluginBodyPrefix()), {
   /* First section here is to override things editor table plugin css defines */

package/dist/cjs/ui/issue-like-table/table-cell-content/inline-edit.js

@@ -5,7 +5,7 @@ var _typeof3 = require("@babel/runtime/helpers/typeof");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.InlineEditUFOExperience = exports.InlineEdit = void 0;
+exports.newGetBackendUpdateValue = exports.InlineEditUFOExperience = exports.InlineEdit = void 0;
 var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 var _typeof2 = _interopRequireDefault(require("@babel/runtime/helpers/typeof"));
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
@@ -13,6 +13,7 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _react = _interopRequireWildcard(require("react"));
 var _reactIntlNext = require("react-intl-next");
 var _inlineEdit = _interopRequireDefault(require("@atlaskit/inline-edit"));
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _primitives = require("@atlaskit/primitives");
 var _hooks = require("@atlaskit/smart-card/hooks");
 var _analytics = require("../../../analytics");
@@ -32,6 +33,38 @@ var InlineEditUFOExperience = exports.InlineEditUFOExperience = 'inline-edit-ren
 var editContainerStyles = (0, _primitives.xcss)({
   marginBlockStart: 'space.negative.100'
 });
+/**
+ * @returns String of the new field value, or ID of status transition / atlassian user ID / priority ID.
+ * @throws Error if the value is not supplied.
+ */
+var newGetBackendUpdateValue = exports.newGetBackendUpdateValue = function newGetBackendUpdateValue(typedNewValue) {
+  if (typedNewValue.values.length === 0) {
+    throw new Error("Datasource 2 way sync: Backend update value or value ID not supplied for type ".concat(typedNewValue.type));
+  }
+  switch (typedNewValue.type) {
+    case 'string':
+      return typedNewValue.values[0];
+    case 'status':
+      var transitionId = typedNewValue.values[0].transitionId;
+      if (transitionId === undefined || transitionId === '') {
+        throw new Error("Datasource 2 way sync: Backend status transition ID not supplied for type transition");
+      }
+      return transitionId;
+    case 'user':
+      var atlassianUserId = typedNewValue.values[0].atlassianUserId;
+      if (atlassianUserId === undefined || atlassianUserId === '') {
+        throw new Error("Datasource 2 way sync: Backend atlasian user ID not supplied for type user");
+      }
+      return atlassianUserId;
+    case 'icon':
+      var id = typedNewValue.values[0].id;
+      if (id === undefined || id === '') {
+        throw new Error("Datasource 2 way sync: Backend update ID not supplied for type icon");
+      }
+      return id;
+  }
+  throw new Error("Datasource 2 way sync Backend update value not implemented for type ".concat(typedNewValue.type));
+};
 var getBackendUpdateValue = function getBackendUpdateValue(typedNewValue) {
   var _typedNewValue$values, _typedNewValue$values2, _typedNewValue$values3;
   switch (typedNewValue.type) {
@@ -138,7 +171,26 @@ var InlineEdit = exports.InlineEdit = function InlineEdit(_ref) {
     }
     onUpdateItem(ari, newItem);
     fireEvent('ui.form.submitted.inlineEdit', {});
-    execute(getBackendUpdateValue(newValue)).then(refreshDatasourceItem).catch(function (error) {
+    var updateValue;
+    if ((0, _platformFeatureFlags.fg)('platform-datasources-inline-edit-id-checks')) {
+      try {
+        // TODO: Refactor types so that valid update values are guaranteed for
+        // all object types. Invalid options should be filtered out of options -
+        // this frontend error flag is a last resort.
+        updateValue = newGetBackendUpdateValue(newValue);
+      } catch (_unused) {
+        // Show an error as the new value that was going to be sent to the
+        // backend is invalid (and would have failed anyway, silently to the user)
+        showErrorFlag({});
+        onUpdateItem(ari, existingData);
+        setIsEditing(false);
+        return;
+      }
+    }
+    execute(updateValue !== undefined && (0, _platformFeatureFlags.fg)('platform-datasources-inline-edit-id-checks') ? updateValue :
+    // Old behaviour is preserved in non-FFed path: errors thrown by getBackendUpdateValue are caught by
+    // the error boundary, _not_ by the catch block & frontend flag here.
+    getBackendUpdateValue(newValue)).then(refreshDatasourceItem).catch(function (error) {
       var status = error && (0, _typeof2.default)(error) === 'object' ? error.status : undefined;
       showErrorFlag({
         status: status

package/dist/es2019/hooks/useDatasourceTableState.js

@@ -2,7 +2,6 @@ import { useCallback, useEffect, useRef, useState } from 'react';
 import isEqual from 'lodash/isEqual';
 import { isFedRamp } from '@atlaskit/atlassian-context';
 import { DEFAULT_GET_DATASOURCE_DATA_PAGE_SIZE, useDatasourceClientExtension } from '@atlaskit/link-client-extension';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { useDatasourceAnalyticsEvents } from '../analytics';
 import { useDatasourceActions } from '../state';
 import { useDiscoverActions } from '../state/actions';
@@ -196,32 +195,31 @@ export const useDatasourceTableState = ({
         }
         return [...currentResponseItems, ...items];
       });
-      if (fg('enable_datasource_react_sweet_state')) {
-        /**
-         * Product is typed as any.
-         */
-        const integrationKey = product;
 
-        /**
-         * When `entityType` is undefined, we should not discover actions it prevents unnecessary requests to Actions service
-         */
-        const entityType = objectTypesEntity;
-        const newIds = onAddItems(items, typeof integrationKey === 'string' ? integrationKey : undefined, entityType);
-        setResponseItemIds(currentIds => [...currentIds, ...newIds]);
-        if (!isFedRamp()) {
-          if (typeof integrationKey === 'string') {
-            const aris = items.reduce((acc, item) => {
-              var _item$ari;
-              return typeof ((_item$ari = item.ari) === null || _item$ari === void 0 ? void 0 : _item$ari.data) === 'string' ? [...acc, item.ari.data] : acc;
-            }, []);
-            if (aris.length && entityType) {
-              discoverActions({
-                aris,
-                integrationKey,
-                fieldKeys,
-                entityType
-              });
-            }
+      /**
+       * Product is typed as any.
+       */
+      const integrationKey = product;
+
+      /**
+       * When `entityType` is undefined, we should not discover actions it prevents unnecessary requests to Actions service
+       */
+      const entityType = objectTypesEntity;
+      const newIds = onAddItems(items, typeof integrationKey === 'string' ? integrationKey : undefined, entityType);
+      setResponseItemIds(currentIds => [...currentIds, ...newIds]);
+      if (!isFedRamp()) {
+        if (typeof integrationKey === 'string') {
+          const aris = items.reduce((acc, item) => {
+            var _item$ari;
+            return typeof ((_item$ari = item.ari) === null || _item$ari === void 0 ? void 0 : _item$ari.data) === 'string' ? [...acc, item.ari.data] : acc;
+          }, []);
+          if (aris.length && entityType) {
+            discoverActions({
+              aris,
+              integrationKey,
+              fieldKeys,
+              entityType
+            });
           }
         }
       }

package/dist/es2019/state/index.js

@@ -1,7 +1,6 @@
 import React from 'react';
 import { createActionsHook, createContainer, createStateHook, createStore } from 'react-sweet-state';
 import { v4 as uuidv4 } from 'uuid';
-import { fg } from '@atlaskit/platform-feature-flags';
 const getInitialState = () => ({
   items: {}
 });
@@ -75,10 +74,7 @@ const Container = createContainer(Store);
 export const StoreContainer = ({
   children
 }) => {
-  if (fg('enable_datasource_react_sweet_state')) {
-    return /*#__PURE__*/React.createElement(Container, {
-      scope: "datasource"
-    }, children);
-  }
-  return children;
+  return /*#__PURE__*/React.createElement(Container, {
+    scope: "datasource"
+  }, children);
 };

package/dist/es2019/ui/issue-like-table/edit-type/icon/index.js

@@ -1,6 +1,7 @@
 import _extends from "@babel/runtime/helpers/extends";
 import React, { useEffect } from 'react';
 import { Layering } from '@atlaskit/layering';
+import { fg } from '@atlaskit/platform-feature-flags';
 import Select from '@atlaskit/select';
 import Tooltip from '@atlaskit/tooltip';
 import { failUfoExperience, succeedUfoExperience } from '../../../../analytics/ufoExperiences';
@@ -46,8 +47,11 @@ const IconEditType = props => {
   }, /*#__PURE__*/React.createElement(Select, _extends({}, getCleanedSelectProps(props), {
     autoFocus: true,
     blurInputOnSelect: true,
-    defaultMenuIsOpen: true,
-    options: options,
+    defaultMenuIsOpen: true
+    // We can't update the status if we don't have an ID - however the ID
+    // is typed optional.
+    ,
+    options: fg('platform-datasources-inline-edit-id-checks') ? options.filter(option => option.id) : options,
     menuPlacement: "auto",
     isLoading: isLoading,
     filterOption: filterOption,