@atlaskit/link-datasource 3.15.13 → 3.16.0

package/dist/esm/ui/issue-like-table/styled.js

@@ -66,29 +66,6 @@ export var TableHeading = styled.th(_defineProperty(_defineProperty(_definePrope
   wordWrap: 'break-word'
 }));
 
-// eslint-disable-next-line @atlaskit/ui-styling-standard/no-exported-styles, @atlaskit/ui-styling-standard/no-styled -- To migrate as part of go/ui-styling-standard
-export var TableCell = styled.td(_defineProperty(_defineProperty(_defineProperty(_defineProperty({}, "".concat(withTablePluginBodyPrefix()), {
-  /* First section here is to override things editor table plugin css defines */
-  font: "var(--ds-font-body, normal 400 14px/20px ui-sans-serif, -apple-system, BlinkMacSystemFont, \"Segoe UI\", Ubuntu, system-ui, \"Helvetica Neue\", sans-serif)",
-  padding: "var(--ds-space-050, 4px)".concat(" ", "var(--ds-space-100, 8px)"),
-  border: 0,
-  minWidth: 'auto',
-  height: '32px',
-  verticalAlign: 'inherit',
-  boxSizing: 'content-box',
-  // Due to padding, content-box makes td height 40px equal to InlineEdit on height of 32px
-  borderRight: "var(--ds-border-width, 1px)".concat(" solid ", "var(--ds-border, ".concat(N40, ")")),
-  borderBottom: "var(--ds-border-width, 1px)".concat(" solid ", "var(--ds-border, ".concat(N40, ")")),
-  overflow: 'hidden'
-}), "".concat(withTablePluginBodyPrefix('&:first-child')), {
-  paddingLeft: "var(--ds-space-100, 8px)"
-}), "".concat(withTablePluginBodyPrefix('&:last-child')), {
-  borderRight: 0,
-  paddingRight: "var(--ds-space-100, 8px)"
-}), "& [data-testid='inline-card-icon-and-title'], " + "& [data-testid='button-connect-account'] > span", {
-  whiteSpace: 'unset'
-}));
-
 // eslint-disable-next-line @atlaskit/ui-styling-standard/no-styled, @atlaskit/ui-styling-standard/no-exported-styles -- To migrate as part of go/ui-styling-standard
 export var InlineEditableTableCell = styled.td(_defineProperty(_defineProperty(_defineProperty({}, "".concat(withTablePluginBodyPrefix()), {
   /* First section here is to override things editor table plugin css defines */

package/dist/esm/ui/issue-like-table/table-cell-content/inline-edit.js

@@ -7,6 +7,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import React, { useCallback, useMemo, useState } from 'react';
 import { useIntl } from 'react-intl-next';
 import AKInlineEdit from '@atlaskit/inline-edit';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { Box, xcss } from '@atlaskit/primitives';
 import { useSmartLinkReload } from '@atlaskit/smart-card/hooks';
 import { useDatasourceAnalyticsEvents } from '../../../analytics';
@@ -22,6 +23,38 @@ export var InlineEditUFOExperience = 'inline-edit-rendered';
 var editContainerStyles = xcss({
   marginBlockStart: 'space.negative.100'
 });
+/**
+ * @returns String of the new field value, or ID of status transition / atlassian user ID / priority ID.
+ * @throws Error if the value is not supplied.
+ */
+export var newGetBackendUpdateValue = function newGetBackendUpdateValue(typedNewValue) {
+  if (typedNewValue.values.length === 0) {
+    throw new Error("Datasource 2 way sync: Backend update value or value ID not supplied for type ".concat(typedNewValue.type));
+  }
+  switch (typedNewValue.type) {
+    case 'string':
+      return typedNewValue.values[0];
+    case 'status':
+      var transitionId = typedNewValue.values[0].transitionId;
+      if (transitionId === undefined || transitionId === '') {
+        throw new Error("Datasource 2 way sync: Backend status transition ID not supplied for type transition");
+      }
+      return transitionId;
+    case 'user':
+      var atlassianUserId = typedNewValue.values[0].atlassianUserId;
+      if (atlassianUserId === undefined || atlassianUserId === '') {
+        throw new Error("Datasource 2 way sync: Backend atlasian user ID not supplied for type user");
+      }
+      return atlassianUserId;
+    case 'icon':
+      var id = typedNewValue.values[0].id;
+      if (id === undefined || id === '') {
+        throw new Error("Datasource 2 way sync: Backend update ID not supplied for type icon");
+      }
+      return id;
+  }
+  throw new Error("Datasource 2 way sync Backend update value not implemented for type ".concat(typedNewValue.type));
+};
 var getBackendUpdateValue = function getBackendUpdateValue(typedNewValue) {
   var _typedNewValue$values, _typedNewValue$values2, _typedNewValue$values3;
   switch (typedNewValue.type) {
@@ -128,7 +161,26 @@ export var InlineEdit = function InlineEdit(_ref) {
     }
     onUpdateItem(ari, newItem);
     fireEvent('ui.form.submitted.inlineEdit', {});
-    execute(getBackendUpdateValue(newValue)).then(refreshDatasourceItem).catch(function (error) {
+    var updateValue;
+    if (fg('platform-datasources-inline-edit-id-checks')) {
+      try {
+        // TODO: Refactor types so that valid update values are guaranteed for
+        // all object types. Invalid options should be filtered out of options -
+        // this frontend error flag is a last resort.
+        updateValue = newGetBackendUpdateValue(newValue);
+      } catch (_unused) {
+        // Show an error as the new value that was going to be sent to the
+        // backend is invalid (and would have failed anyway, silently to the user)
+        showErrorFlag({});
+        onUpdateItem(ari, existingData);
+        setIsEditing(false);
+        return;
+      }
+    }
+    execute(updateValue !== undefined && fg('platform-datasources-inline-edit-id-checks') ? updateValue :
+    // Old behaviour is preserved in non-FFed path: errors thrown by getBackendUpdateValue are caught by
+    // the error boundary, _not_ by the catch block & frontend flag here.
+    getBackendUpdateValue(newValue)).then(refreshDatasourceItem).catch(function (error) {
       var status = error && _typeof(error) === 'object' ? error.status : undefined;
       showErrorFlag({
         status: status

package/dist/types/ui/issue-like-table/styled.d.ts

@@ -17,10 +17,6 @@ export declare const TableHeading: import("@emotion/styled").StyledComponent<{
     theme?: import("@emotion/react").Theme | undefined;
     as?: import("react").ElementType<any> | undefined;
 }, import("react").DetailedHTMLProps<import("react").ThHTMLAttributes<HTMLTableHeaderCellElement>, HTMLTableHeaderCellElement>, {}>;
-export declare const TableCell: import("@emotion/styled").StyledComponent<{
-    theme?: import("@emotion/react").Theme | undefined;
-    as?: import("react").ElementType<any> | undefined;
-}, import("react").DetailedHTMLProps<import("react").TdHTMLAttributes<HTMLTableDataCellElement>, HTMLTableDataCellElement>, {}>;
 export declare const InlineEditableTableCell: import("@emotion/styled").StyledComponent<{
     theme?: import("@emotion/react").Theme | undefined;
     as?: import("react").ElementType<any> | undefined;

package/dist/types/ui/issue-like-table/table-cell-content/inline-edit.d.ts

@@ -11,5 +11,10 @@ interface InlineEditProps {
     execute: (value: string | number) => Promise<AtomicActionExecuteResponse>;
     executeFetch?: <E>(inputs: any) => Promise<E>;
 }
+/**
+ * @returns String of the new field value, or ID of status transition / atlassian user ID / priority ID.
+ * @throws Error if the value is not supplied.
+ */
+export declare const newGetBackendUpdateValue: (typedNewValue: DatasourceTypeWithOnlyValues) => string;
 export declare const InlineEdit: ({ ari, execute, executeFetch, readView, columnKey, columnTitle, datasourceTypeWithValues, }: InlineEditProps) => JSX.Element;
 export {};

package/dist/types-ts4.5/ui/issue-like-table/styled.d.ts

@@ -17,10 +17,6 @@ export declare const TableHeading: import("@emotion/styled").StyledComponent<{
     theme?: import("@emotion/react").Theme | undefined;
     as?: import("react").ElementType<any> | undefined;
 }, import("react").DetailedHTMLProps<import("react").ThHTMLAttributes<HTMLTableHeaderCellElement>, HTMLTableHeaderCellElement>, {}>;
-export declare const TableCell: import("@emotion/styled").StyledComponent<{
-    theme?: import("@emotion/react").Theme | undefined;
-    as?: import("react").ElementType<any> | undefined;
-}, import("react").DetailedHTMLProps<import("react").TdHTMLAttributes<HTMLTableDataCellElement>, HTMLTableDataCellElement>, {}>;
 export declare const InlineEditableTableCell: import("@emotion/styled").StyledComponent<{
     theme?: import("@emotion/react").Theme | undefined;
     as?: import("react").ElementType<any> | undefined;

package/dist/types-ts4.5/ui/issue-like-table/table-cell-content/inline-edit.d.ts

@@ -11,5 +11,10 @@ interface InlineEditProps {
     execute: (value: string | number) => Promise<AtomicActionExecuteResponse>;
     executeFetch?: <E>(inputs: any) => Promise<E>;
 }
+/**
+ * @returns String of the new field value, or ID of status transition / atlassian user ID / priority ID.
+ * @throws Error if the value is not supplied.
+ */
+export declare const newGetBackendUpdateValue: (typedNewValue: DatasourceTypeWithOnlyValues) => string;
 export declare const InlineEdit: ({ ari, execute, executeFetch, readView, columnKey, columnTitle, datasourceTypeWithValues, }: InlineEditProps) => JSX.Element;
 export {};

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/link-datasource",
-	"version": "3.15.13",
+	"version": "3.16.0",
 	"description": "UI Components to support linking platform dataset feature",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -42,7 +42,7 @@
 		"@atlaskit/badge": "^17.0.0",
 		"@atlaskit/button": "^20.3.0",
 		"@atlaskit/datetime-picker": "^15.11.0",
-		"@atlaskit/dropdown-menu": "^12.24.0",
+		"@atlaskit/dropdown-menu": "^12.25.0",
 		"@atlaskit/editor-prosemirror": "6.2.1",
 		"@atlaskit/empty-state": "^8.1.0",
 		"@atlaskit/flag": "^15.8.0",
@@ -73,13 +73,13 @@
 		"@atlaskit/primitives": "^13.3.0",
 		"@atlaskit/react-select": "^1.6.0",
 		"@atlaskit/select": "^18.9.0",
-		"@atlaskit/smart-card": "^34.4.0",
+		"@atlaskit/smart-card": "^34.6.0",
 		"@atlaskit/smart-user-picker": "6.11.2",
 		"@atlaskit/spinner": "^16.3.0",
 		"@atlaskit/tag": "^12.6.0",
 		"@atlaskit/textfield": "6.7.2",
 		"@atlaskit/theme": "^14.0.0",
-		"@atlaskit/tokens": "^3.1.0",
+		"@atlaskit/tokens": "^3.2.0",
 		"@atlaskit/tooltip": "^19.0.0",
 		"@atlaskit/ufo": "^0.3.0",
 		"@atlaskit/width-detector": "^4.3.0",
@@ -156,9 +156,6 @@
 		"./elements": "./src/elements.ts"
 	},
 	"platform-feature-flags": {
-		"enable_datasource_react_sweet_state": {
-			"type": "boolean"
-		},
 		"enable_datasource_supporting_actions": {
 			"type": "boolean"
 		},
@@ -168,6 +165,9 @@
 		"platform-datasources-enable-two-way-sync-priority": {
 			"type": "boolean"
 		},
+		"platform-datasources-inline-edit-id-checks": {
+			"type": "boolean"
+		},
 		"platform-datasources-enable-two-way-sync-assignee": {
 			"type": "boolean"
 		},