@atlaskit/link-datasource 2.5.10 → 2.5.11

package/dist/es2019/ui/common/modal/mode-switcher/useViewModeContext.js

@@ -0,0 +1,26 @@
+/** @jsx jsx */
+import React, { createContext, useContext, useMemo, useState } from 'react';
+
+// eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
+import { jsx } from '@emotion/react';
+const ViewModeContext = /*#__PURE__*/createContext(null);
+export const DatasourceViewModeProvider = ({
+  viewMode: initialViewMode,
+  children
+}) => {
+  const [currentViewMode, setCurrentViewMode] = useState(initialViewMode);
+  const value = useMemo(() => ({
+    currentViewMode,
+    setCurrentViewMode
+  }), [currentViewMode, setCurrentViewMode]);
+  return jsx(ViewModeContext.Provider, {
+    value: value
+  }, children);
+};
+export const useViewModeContext = () => {
+  const value = useContext(ViewModeContext);
+  if (!value) {
+    throw new Error('useViewModeContext must be called within DatasourceViewModeProvider');
+  }
+  return value;
+};

package/dist/es2019/ui/confluence-search-modal/modal/ModalOld.js

@@ -26,12 +26,12 @@ import { CancelButton } from '../../common/modal/cancel-button';
 import { ContentContainer } from '../../common/modal/content-container';
 import { SmartCardPlaceholder, SmartLink } from '../../common/modal/count-view-smart-link';
 import { DatasourceModal } from '../../common/modal/datasource-modal';
+import { useColumnResize } from '../../common/modal/datasources-table-in-modal-preview/use-column-resize';
+import { useColumnWrapping } from '../../common/modal/datasources-table-in-modal-preview/use-column-wrapping';
 import { DisplayViewDropDown } from '../../common/modal/display-view-dropdown/display-view-drop-down';
 import TableSearchCount from '../../common/modal/search-count';
 import { SiteSelector } from '../../common/modal/site-selector';
 import { EmptyState, IssueLikeDataTableView } from '../../issue-like-table';
-import { useColumnResize } from '../../issue-like-table/use-column-resize';
-import { useColumnWrapping } from '../../issue-like-table/use-column-wrapping';
 import { getColumnAction } from '../../issue-like-table/utils';
 import ConfluenceSearchContainer from '../confluence-search-container';
 import { ConfluenceSearchInitialStateSVG } from './confluence-search-initial-state-svg';

package/dist/es2019/ui/confluence-search-modal/modal/index.js

@@ -1,3 +1,4 @@
+/* eslint-disable @atlaskit/platform/ensure-feature-flag-prefix */
 /** @jsx jsx */
 import { Fragment, useCallback, useEffect, useMemo, useRef, useState } from 'react';
 
@@ -17,7 +18,6 @@ import { buildDatasourceAdf } from '../../../common/utils/adf';
 import { fetchMessagesForLocale } from '../../../common/utils/locale/fetch-messages-for-locale';
 import { DatasourceExperienceIdProvider } from '../../../contexts/datasource-experience-id';
 import { UserInteractionsProvider, useUserInteractions } from '../../../contexts/user-interactions';
-import { useDatasourceTableState } from '../../../hooks/useDatasourceTableState';
 import i18nEN from '../../../i18n/en';
 import { useAvailableSites } from '../../../services/useAvailableSites';
 import { AccessRequired } from '../../common/error-state/access-required';
@@ -28,44 +28,66 @@ import { InitialStateView } from '../../common/initial-state-view';
 import { CancelButton } from '../../common/modal/cancel-button';
 import { ContentContainer } from '../../common/modal/content-container';
 import { SmartCardPlaceholder, SmartLink } from '../../common/modal/count-view-smart-link';
-import { useDatasourceContext } from '../../common/modal/datasource-context/DatasourceContext';
-import { DatasourceContextProvider } from '../../common/modal/datasource-context/DatasourceContextProvider';
+import { DatasourceContextProvider, useDatasourceContext } from '../../common/modal/datasource-context';
 import { DatasourceModal } from '../../common/modal/datasource-modal';
-import { DisplayViewDropDown } from '../../common/modal/display-view-dropdown/display-view-drop-down';
+import DatasourcesTableInModalPreview from '../../common/modal/datasources-table-in-modal-preview';
+import { DatasourceViewModeDropDown } from '../../common/modal/mode-switcher';
+import { DatasourceViewModeProvider, useViewModeContext } from '../../common/modal/mode-switcher/useViewModeContext';
 import TableSearchCount from '../../common/modal/search-count';
 import { SiteSelector } from '../../common/modal/site-selector';
-import DatasourcesTableUsingContext from '../../datasources-table-in-modal-preview';
 import { EmptyState } from '../../issue-like-table';
-import { getColumnAction } from '../../issue-like-table/utils';
 import ConfluenceSearchContainer from '../confluence-search-container';
 import { ConfluenceSearchInitialStateSVG } from './confluence-search-initial-state-svg';
 import { confluenceSearchModalMessages } from './messages';
 import { PlainConfluenceSearchConfigModal as PlainConfluenceSearchConfigModalOld } from './ModalOld';
+const DEFAULT_VIEW_MODE = 'table';
 const inputContainerStyles = xcss({
   alignItems: 'baseline',
   display: 'flex',
   minHeight: '72px'
 });
+const isValidParameters = parameters => {
+  var _parameters$contribut;
+  return !!(parameters && parameters.cloudId && (parameters.searchString !== undefined || (_parameters$contribut = parameters.contributorAccountIds) !== null && _parameters$contribut !== void 0 && _parameters$contribut.length || parameters.lastModified || parameters.lastModifiedFrom || parameters.lastModifiedTo));
+};
+const useUpdateParametersOnFormUpdate = (cloudId, searchString, lastModified, contributorAccountIds, overrideParameters) => {
+  const {
+    setParameters
+  } = useDatasourceContext();
+  useEffect(() => {
+    setParameters(parameters => {
+      return {
+        ...parameters,
+        cloudId: cloudId || '',
+        searchString,
+        lastModified: lastModified === null || lastModified === void 0 ? void 0 : lastModified.value,
+        lastModifiedFrom: lastModified === null || lastModified === void 0 ? void 0 : lastModified.from,
+        lastModifiedTo: lastModified === null || lastModified === void 0 ? void 0 : lastModified.to,
+        contributorAccountIds: contributorAccountIds.length > 0 ? contributorAccountIds : undefined,
+        ...(overrideParameters !== null && overrideParameters !== void 0 ? overrideParameters : {})
+      };
+    });
+  }, [cloudId, searchString, lastModified, contributorAccountIds, setParameters, overrideParameters]);
+};
 export const PlainConfluenceSearchConfigModal = props => {
   const {
     datasourceId,
     onCancel,
     onInsert,
-    viewMode = 'table',
     parameters: initialParameters,
     url: urlBeingEdited,
-    visibleColumnKeys: initialVisibleColumnKeys,
     disableDisplayDropdown = false,
     overrideParameters
   } = props;
-  const [currentViewMode, setCurrentViewMode] = useState(viewMode);
+  const {
+    currentViewMode
+  } = useViewModeContext();
   const [cloudId, setCloudId] = useState(initialParameters === null || initialParameters === void 0 ? void 0 : initialParameters.cloudId);
   const {
     availableSites,
     selectedSite: selectedConfluenceSite
   } = useAvailableSites('confluence', cloudId);
   const [searchString, setSearchString] = useState(initialParameters === null || initialParameters === void 0 ? void 0 : initialParameters.searchString);
-  const [visibleColumnKeys, setVisibleColumnKeys] = useState(initialVisibleColumnKeys);
   const [contributorAccountIds, setContributorAccountIds] = useState((initialParameters === null || initialParameters === void 0 ? void 0 : initialParameters.contributorAccountIds) || []);
   const [lastModified, setLastModified] = useState(initialParameters !== null && initialParameters !== void 0 && initialParameters.lastModified ? {
     value: initialParameters === null || initialParameters === void 0 ? void 0 : initialParameters.lastModified,
@@ -76,43 +98,21 @@ export const PlainConfluenceSearchConfigModal = props => {
   // analytics related parameters
   const searchCount = useRef(0);
   const userInteractions = useUserInteractions();
-  const visibleColumnCount = useRef((visibleColumnKeys === null || visibleColumnKeys === void 0 ? void 0 : visibleColumnKeys.length) || 0);
-  const parameters = useMemo(() => ({
-    ...initialParameters,
-    cloudId: cloudId || '',
-    searchString,
-    lastModified: lastModified === null || lastModified === void 0 ? void 0 : lastModified.value,
-    lastModifiedFrom: lastModified === null || lastModified === void 0 ? void 0 : lastModified.from,
-    lastModifiedTo: lastModified === null || lastModified === void 0 ? void 0 : lastModified.to,
-    contributorAccountIds: (contributorAccountIds === null || contributorAccountIds === void 0 ? void 0 : contributorAccountIds.length) > 0 ? contributorAccountIds : undefined
-  }), [initialParameters, cloudId, searchString, lastModified, contributorAccountIds]);
-  const isParametersSet = useMemo(() => !!cloudId && Object.values(parameters !== null && parameters !== void 0 ? parameters : {}).filter(v => v !== undefined).length > 1, [cloudId, parameters]);
-  const parametersToSend = useMemo(() => {
-    if (!isParametersSet) {
-      return undefined;
-    }
-    return {
-      ...parameters,
-      ...(overrideParameters !== null && overrideParameters !== void 0 ? overrideParameters : {})
-    };
-  }, [parameters, overrideParameters, isParametersSet]);
+  useUpdateParametersOnFormUpdate(cloudId, searchString, lastModified, contributorAccountIds, overrideParameters);
   const {
-    reset,
-    status,
-    onNextPage,
-    responseItems,
-    hasNextPage,
-    columns,
-    defaultVisibleColumnKeys,
-    loadDatasourceDetails,
-    totalCount,
-    extensionKey = null,
-    destinationObjectTypes
-  } = useDatasourceTableState({
-    datasourceId,
-    parameters: parametersToSend,
-    fieldKeys: visibleColumnKeys
-  });
+    visibleColumnKeys,
+    tableState: {
+      reset,
+      status,
+      responseItems,
+      extensionKey = null,
+      destinationObjectTypes,
+      totalCount,
+      columns
+    },
+    visibleColumnCount,
+    parameters
+  } = useDatasourceContext();
   const {
     fireEvent
   } = useDatasourceAnalyticsEvents();
@@ -146,36 +146,7 @@ export const PlainConfluenceSearchConfigModal = props => {
       shouldForceRequest: true
     });
   }, [reset, userInteractions]);
-  useEffect(() => {
-    const newVisibleColumnKeys = !initialVisibleColumnKeys || (initialVisibleColumnKeys || []).length === 0 ? defaultVisibleColumnKeys : initialVisibleColumnKeys;
-    visibleColumnCount.current = newVisibleColumnKeys.length;
-    setVisibleColumnKeys(newVisibleColumnKeys);
-  }, [initialVisibleColumnKeys, defaultVisibleColumnKeys]);
   const siteSelectorLabel = availableSites && availableSites.length > 1 ? confluenceSearchModalMessages.insertIssuesTitleManySites : confluenceSearchModalMessages.insertIssuesTitle;
-
-  // TODO: common functionality of all modals refactor in EDM-9573
-  const handleVisibleColumnKeysChange = useCallback((newVisibleColumnKeys = []) => {
-    const columnAction = getColumnAction(visibleColumnKeys || [], newVisibleColumnKeys);
-    userInteractions.add(columnAction);
-    visibleColumnCount.current = newVisibleColumnKeys.length;
-    setVisibleColumnKeys(newVisibleColumnKeys);
-  }, [visibleColumnKeys, userInteractions]);
-  const confluenceSearchTable = useMemo(() => {
-    return jsx(ContentContainer, {
-      withTableBorder: true
-    }, jsx(DatasourcesTableUsingContext, {
-      testId: "confluence-search-datasource-table",
-      status: status,
-      columns: columns,
-      items: responseItems,
-      hasNextPage: hasNextPage,
-      visibleColumnKeys: visibleColumnKeys || defaultVisibleColumnKeys,
-      onNextPage: onNextPage,
-      onLoadDatasourceDetails: loadDatasourceDetails,
-      onVisibleColumnKeysChange: handleVisibleColumnKeysChange,
-      extensionKey: extensionKey
-    }));
-  }, [status, columns, responseItems, hasNextPage, visibleColumnKeys, defaultVisibleColumnKeys, onNextPage, loadDatasourceDetails, handleVisibleColumnKeysChange, extensionKey]);
   const resolvedWithNoResults = status === 'resolved' && !responseItems.length;
   const hasConfluenceSearchParams = selectedConfluenceSite && searchString;
   const selectedConfluenceSiteUrl = selectedConfluenceSite === null || selectedConfluenceSite === void 0 ? void 0 : selectedConfluenceSite.url;
@@ -223,7 +194,7 @@ export const PlainConfluenceSearchConfigModal = props => {
         displayedColumnCount: visibleColumnCount.current
       });
     }
-  }, [analyticsPayload, fireEvent, totalCount, isDataReady]);
+  }, [isDataReady, fireEvent, analyticsPayload, totalCount, visibleColumnCount]);
   useEffect(() => {
     const isResolved = status === 'resolved';
     const isTableViewMode = currentViewMode === 'table';
@@ -259,8 +230,12 @@ export const PlainConfluenceSearchConfigModal = props => {
         description: confluenceSearchModalMessages.initialViewSearchDescription
       }));
     }
-    return confluenceSearchTable;
-  }, [columns.length, selectedConfluenceSiteUrl, confluenceSearchTable, resolvedWithNoResults, status, urlBeingEdited, hasConfluenceSearchParams]);
+    return jsx(ContentContainer, {
+      withTableBorder: true
+    }, jsx(DatasourcesTableInModalPreview, {
+      testId: "confluence-search-datasource-table"
+    }));
+  }, [columns.length, selectedConfluenceSiteUrl, resolvedWithNoResults, status, urlBeingEdited, hasConfluenceSearchParams]);
   const renderInlineLinkModalContent = useCallback(() => {
     if (status === 'unauthorized') {
       return jsx(AccessRequired, {
@@ -283,7 +258,7 @@ export const PlainConfluenceSearchConfigModal = props => {
   } = useDatasourceContext();
   const onInsertPressed = useCallback((e, analyticsEvent) => {
     var _insertButtonClickedE;
-    if (!isParametersSet || !cloudId || !confluenceSearchUrl) {
+    if (!parameters || !isValidParameters(parameters) || !confluenceSearchUrl) {
       return;
     }
     const insertButtonClickedEvent = analyticsEvent.update({
@@ -311,10 +286,7 @@ export const PlainConfluenceSearchConfigModal = props => {
     } else {
       onInsert(buildDatasourceAdf({
         id: datasourceId,
-        parameters: {
-          ...parametersToSend,
-          cloudId
-        },
+        parameters: parameters,
         views: [{
           type: 'table',
           properties: {
@@ -335,11 +307,7 @@ export const PlainConfluenceSearchConfigModal = props => {
         }]
       }, confluenceSearchUrl), consumerEvent);
     }
-  }, [isParametersSet, cloudId, analyticsPayload, totalCount, currentViewMode, onInsert, confluenceSearchUrl, datasourceId, parametersToSend, visibleColumnKeys, columnCustomSizes, wrappedColumnKeys, userInteractions]);
-  const handleViewModeChange = selectedMode => {
-    userInteractions.add(DatasourceAction.DISPLAY_VIEW_CHANGED);
-    setCurrentViewMode(selectedMode);
-  };
+  }, [parameters, confluenceSearchUrl, analyticsPayload, totalCount, visibleColumnCount, currentViewMode, userInteractions, onInsert, datasourceId, visibleColumnKeys, columnCustomSizes, wrappedColumnKeys]);
   const onSearch = useCallback((newSearchString, filters) => {
     searchCount.current++;
     userInteractions.add(DatasourceAction.QUERY_UPDATED);
@@ -368,7 +336,7 @@ export const PlainConfluenceSearchConfigModal = props => {
       shouldForceRequest: true
     });
   }, [reset, userInteractions]);
-  const isInsertDisabled = !isParametersSet || status === 'rejected' || status === 'unauthorized' || status === 'loading';
+  const isInsertDisabled = !isValidParameters(parameters) || status === 'rejected' || status === 'unauthorized' || status === 'loading';
   const getCancelButtonAnalyticsPayload = useCallback(() => {
     return {
       extensionKey,
@@ -389,15 +357,14 @@ export const PlainConfluenceSearchConfigModal = props => {
     selectedSite: selectedConfluenceSite,
     testId: "confluence-search-datasource-modal--site-selector",
     label: siteSelectorLabel
-  })), !hasNoConfluenceSites && !disableDisplayDropdown && jsx(DisplayViewDropDown, {
-    onViewModeChange: handleViewModeChange,
-    viewMode: currentViewMode
-  })), jsx(ModalBody, null, !hasNoConfluenceSites ? jsx(Fragment, null, jsx(Box, {
+  })), !hasNoConfluenceSites && !disableDisplayDropdown && jsx(DatasourceViewModeDropDown, null)), jsx(ModalBody, null, !hasNoConfluenceSites ? jsx(Fragment, null, jsx(Box, {
     xcss: inputContainerStyles
   }, jsx(ConfluenceSearchContainer, {
     isSearching: status === 'loading',
     onSearch: onSearch,
-    parameters: parameters
+    parameters: isValidParameters(parameters) ? parameters : {
+      cloudId: ''
+    }
   })), currentViewMode === 'inline' ? renderInlineLinkModalContent() : renderTableModalContent()) : jsx(NoInstancesView, {
     title: confluenceSearchModalMessages.noAccessToConfluenceSitesTitle,
     description: confluenceSearchModalMessages.noAccessToConfluenceSitesDescription,
@@ -431,9 +398,18 @@ const contextData = {
     ...analyticsContextAttributes
   }
 };
-export const ConfluenceSearchConfigModal = withAnalyticsContext(contextData)(props => jsx(DatasourceExperienceIdProvider, null, jsx(UserInteractionsProvider, null, fg('platform.linking-platform.datasources.use-refactored-config-modal') ? jsx(DatasourceContextProvider, {
-  initialColumnCustomSizes: props.columnCustomSizes,
-  initialWrappedColumnKeys: props.wrappedColumnKeys
-}, jsx(PlainConfluenceSearchConfigModal, props)) :
-// TODO on cleanup 'use-refactored-config-modal' ff, delete `ModalOld.tsx` as well
-jsx(PlainConfluenceSearchConfigModalOld, props))));
+export const ConfluenceSearchConfigModal = withAnalyticsContext(contextData)(props => {
+  var _props$viewMode;
+  return jsx(DatasourceExperienceIdProvider, null, jsx(UserInteractionsProvider, null, fg('platform-datasources-use-refactored-config-modal') ? jsx(DatasourceContextProvider, {
+    datasourceId: props.datasourceId,
+    initialVisibleColumnKeys: props.visibleColumnKeys,
+    initialColumnCustomSizes: props.columnCustomSizes,
+    initialWrappedColumnKeys: props.wrappedColumnKeys,
+    initialParameters: props.parameters,
+    isValidParameters: isValidParameters
+  }, jsx(DatasourceViewModeProvider, {
+    viewMode: (_props$viewMode = props.viewMode) !== null && _props$viewMode !== void 0 ? _props$viewMode : DEFAULT_VIEW_MODE
+  }, jsx(PlainConfluenceSearchConfigModal, props))) :
+  // TODO on cleanup 'use-refactored-config-modal' ff, delete `ModalOld.tsx` as well
+  jsx(PlainConfluenceSearchConfigModalOld, props)));
+});

package/dist/es2019/ui/jira-issues-modal/basic-filters/utils/isQueryTooComplex.js

@@ -1,7 +1,7 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 import mergeWith from 'lodash/mergeWith';
 import { AbstractJastVisitor, COMPOUND_OPERATOR_AND, COMPOUND_OPERATOR_OR, JastBuilder, OPERATOR_EQUALS, OPERATOR_IN, OPERATOR_LIKE } from '@atlaskit/jql-ast';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { ALLOWED_ORDER_BY_KEYS } from '../../jira-search-container';
 import { isClauseTooComplex } from './isClauseTooComplex';
 import { isValidJql } from './index';
@@ -83,7 +83,7 @@ class JqlClauseCollectingVisitor extends AbstractJastVisitor {
   }
 }
 export const isQueryTooComplex = jql => {
-  if (!getBooleanFF('platform.linking-platform.datasource.show-jlol-basic-filters') || !jql) {
+  if (!fg('platform.linking-platform.datasource.show-jlol-basic-filters') || !jql) {
     return false;
   }
   if (!isValidJql(jql)) {

package/dist/es2019/ui/jira-issues-modal/jira-search-container/index.js

@@ -5,17 +5,17 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react';
 import { css, jsx } from '@emotion/react';
 import { useIntl } from 'react-intl-next';
 import { useDebouncedCallback } from 'use-debounce';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { Flex, xcss } from '@atlaskit/primitives';
 import { useDatasourceAnalyticsEvents } from '../../../analytics';
 import { BasicSearchInput } from '../../common/modal/basic-search-input';
 import { basicSearchInputMessages } from '../../common/modal/basic-search-input/messages';
+import { ModeSwitcher } from '../../common/modal/mode-switcher';
 import { FILTER_SELECTION_DEBOUNCE_MS } from '../../common/modal/popup-select/constants';
 import { BasicFilters } from '../basic-filters';
 import { useHydrateJqlQuery } from '../basic-filters/hooks/useHydrateJqlQuery';
 import { isQueryTooComplex } from '../basic-filters/utils/isQueryTooComplex';
 import { JiraJQLEditor } from '../jql-editor';
-import { ModeSwitcher } from '../mode-switcher';
 import { buildJQL } from './buildJQL';
 import { modeSwitcherMessages } from './messages';
 const inputContainerStyles = css({
@@ -56,7 +56,7 @@ export const JiraSearchContainer = props => {
   const [orderDirection, setOrderDirection] = useState();
   const [filterSelections, setFilterSelections] = useState({});
   const showBasicFilters = useMemo(() => {
-    if (getBooleanFF('platform.linking-platform.datasource.show-jlol-basic-filters')) {
+    if (fg('platform.linking-platform.datasource.show-jlol-basic-filters')) {
       return true;
     }
     return false;