@atlaskit/link-datasource 2.3.1 → 2.3.2

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/link-datasource
 
+## 2.3.2
+
+### Patch Changes
+
+-   [#97435](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/97435)
+    [`74d425408d1e`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/74d425408d1e) -
+    [ux] Fix a bug where when sum of all column widths is less than container total width the
+    resizing is somewhat broken
+-   [#99133](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/99133)
+    [`2de9d30e7ac6`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/2de9d30e7ac6) -
+    Updates docs to include in atlaskit for use of smart link list view and configuration modals and
+    respective props and examples.
+-   Updated dependencies
+
 ## 2.3.1
 
 ### Patch Changes

package/dist/cjs/ui/issue-like-table/draggable-table-heading.js

@@ -124,6 +124,11 @@ var DraggableTableHeading = exports.DraggableTableHeading = function DraggableTa
     closestEdge = _useState6[0],
     setClosestEdge = _useState6[1];
   var dropTargetRef = (0, _react.useRef)(null);
+  /**
+   * When width is not set (or callback is not set) we assume not resizing is needed.
+   * In our case width won't be set for last cell when table container is bigger than sum of all columns
+   */
+  var resizeIsEnabled = !!onWidthChange && !!width;
   (0, _react.useEffect)(function () {
     var cell = mainHeaderCellRef.current;
     (0, _tinyInvariant.default)(cell);
@@ -231,7 +236,7 @@ var DraggableTableHeading = exports.DraggableTableHeading = function DraggableTa
 
   // Handling column resizing
   (0, _react.useEffect)(function () {
-    if (!onWidthChange) {
+    if (!resizeIsEnabled) {
       return;
     }
     var resizeHandle = columnResizeHandleRef.current;
@@ -287,7 +292,7 @@ var DraggableTableHeading = exports.DraggableTableHeading = function DraggableTa
         }
       }
     });
-  }, [id, index, onWidthChange, state, tableId, width]);
+  }, [id, index, onWidthChange, resizeIsEnabled, state, tableId, width]);
   var _useState7 = (0, _react.useState)(false),
     _useState8 = (0, _slicedToArray2.default)(_useState7, 2),
     buttonHovered = _useState8[0],
@@ -296,7 +301,9 @@ var DraggableTableHeading = exports.DraggableTableHeading = function DraggableTa
     _useState10 = (0, _slicedToArray2.default)(_useState9, 2),
     isDropdownOpen = _useState10[0],
     setIsDropdownOpen = _useState10[1];
-  var isWideEnoughToHaveChevron = width > 76;
+  // Width is not set when it is a last cell in a wide table.
+  // We make assumption thus that there is enough width for chevron.
+  var isWideEnoughToHaveChevron = !width || width > 76;
   var shouldShowTriggerIcon = (buttonHovered || isDropdownOpen) && isWideEnoughToHaveChevron;
   var triggerIcon = (0, _react.useMemo)(function () {
     return shouldShowTriggerIcon ? isDropdownOpen ? _chevronUp.default : _chevronDown.default : isWideEnoughToHaveChevron ? _customIcons.GlyphPlaceholder : undefined;
@@ -332,10 +339,10 @@ var DraggableTableHeading = exports.DraggableTableHeading = function DraggableTa
     style: _objectSpread({
       cursor: 'grab'
     }, (0, _utils.getWidthCss)({
-      shouldUseWidth: !!onWidthChange,
+      shouldUseWidth: resizeIsEnabled,
       width: width
     }))
-  }, onWidthChange ? (0, _react2.jsx)("div", {
+  }, resizeIsEnabled ? (0, _react2.jsx)("div", {
     ref: columnResizeHandleRef,
     css: [resizerStyles, state.type === 'resizing' && resizingStyles],
     style: {

package/dist/cjs/ui/issue-like-table/index.js

@@ -14,6 +14,7 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _react = require("react");
 var _react2 = require("@emotion/react");
 var _styled = _interopRequireDefault(require("@emotion/styled"));
+var _debounce = _interopRequireDefault(require("lodash/debounce"));
 var _reactIntlNext = require("react-intl-next");
 var _tinyInvariant = _interopRequireDefault(require("tiny-invariant"));
 var _linkingCommon = require("@atlaskit/linking-common");
@@ -25,6 +26,7 @@ var _adapter = require("@atlaskit/pragmatic-drag-and-drop/element/adapter");
 var _colors = require("@atlaskit/theme/colors");
 var _typography = require("@atlaskit/theme/typography");
 var _tooltip = _interopRequireDefault(require("@atlaskit/tooltip"));
+var _widthDetector = require("@atlaskit/width-detector");
 var _ufoExperiences = require("../../analytics/ufoExperiences");
 var _zindex = require("../../common/zindex");
 var _columnPicker = require("./column-picker");
@@ -35,7 +37,7 @@ var _renderType = require("./render-type");
 var _styled2 = require("./styled");
 var _useIsOnScreen = require("./useIsOnScreen");
 var _utils = require("./utils");
-var _styled$th, _styled$td;
+var _styled$td;
 /** @jsx jsx */
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
@@ -51,27 +53,30 @@ var truncateTextStyles = (0, _react2.css)({
   textOverflow: 'ellipsis',
   whiteSpace: 'nowrap'
 });
-var ColumnPickerHeader = _styled.default.th((_styled$th = {}, (0, _defineProperty2.default)(_styled$th, "".concat((0, _styled2.withTablePluginHeaderPrefix)()), {
-  boxSizing: 'content-box',
+var columnPickerWidth = 80;
+var ColumnPickerHeader = _styled.default.th((0, _defineProperty2.default)({}, "".concat((0, _styled2.withTablePluginHeaderPrefix)('&:last-of-type')), {
+  boxSizing: 'border-box',
   border: 0,
-  width: '56px',
+  width: "".concat(columnPickerWidth, "px"),
   zIndex: 10,
   position: 'sticky',
   right: "calc(-1 * ".concat(tableSidePadding, ")"),
   backgroundColor: "var(--ds-elevation-surface-current, #FFF)",
+  /* It is required to have solid (not half-transparent) color because of this gradient business below */
   borderBottom: "2px solid ".concat("var(--ds-border, ".concat(_colors.N40, ")")),
-  paddingRight: "var(--ds-space-100, 4px)",
+  paddingRight: tableSidePadding,
   background: "linear-gradient( 90deg, rgba(255, 255, 255, 0) 0%, ".concat("var(--ds-elevation-surface-current, #FFF)", " 10% )"),
+  /* Keeps dropdown button in the middle */
   verticalAlign: 'middle',
+  /* In case when TH itself is bigger we want to keep picker at the right side */
   textAlign: 'right'
-}), (0, _defineProperty2.default)(_styled$th, "".concat((0, _styled2.withTablePluginHeaderPrefix)('&:last-of-type')), {
-  paddingRight: tableSidePadding
-}), _styled$th));
+}));
 var truncateStyles = (0, _react2.css)({
   textOverflow: 'ellipsis',
   whiteSpace: 'nowrap'
 });
 var TableCell = _styled.default.td((_styled$td = {}, (0, _defineProperty2.default)(_styled$td, "".concat((0, _styled2.withTablePluginBodyPrefix)()), {
+  /* First section here is to override things editor table plugin css defines */
   font: _styled2.fieldTextFontSize,
   padding: "var(--ds-space-050, 4px)".concat(" ", "var(--ds-space-100, 8px)"),
   border: 0,
@@ -92,7 +97,8 @@ var TableCell = _styled.default.td((_styled$td = {}, (0, _defineProperty2.defaul
 var tableContainerStyles = (0, _react2.css)({
   borderRadius: 'inherit',
   borderBottomLeftRadius: 0,
-  borderBottomRightRadius: 0
+  borderBottomRightRadius: 0,
+  position: 'relative'
 });
 
 /**
@@ -189,7 +195,10 @@ var tableStyles = (0, _react2.css)({
   // These styles are needed to prevent thead bottom border from scrolling away.
   // This happens because it is sticky. https://stackoverflow.com/questions/50361698/border-style-do-not-work-with-sticky-position-element
   borderCollapse: 'separate',
-  borderSpacing: 0
+  borderSpacing: 0,
+  // There is a strange table:first-of-type rule that sets margin-top to 0 coming from container,
+  // but because our table is now not the first child (there is an empty div to measure width) we need to set it manually.
+  margin: 0
 });
 
 // By default tbody and thead have border-bottom: 2px ...
@@ -301,6 +310,19 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
     _useState6 = (0, _slicedToArray2.default)(_useState5, 2),
     orderedColumns = _useState6[0],
     setOrderedColumns = _useState6[1];
+
+  // Table container width is used to know if sum of all column widths is bigger of container or not.
+  // When sum of all columns is less than container size we make last column stretchable (width: undefined)
+  var _useState7 = (0, _react.useState)(),
+    _useState8 = (0, _slicedToArray2.default)(_useState7, 2),
+    tableContainerWidth = _useState8[0],
+    setTableContainerWidth = _useState8[1];
+  (0, _react.useEffect)(function () {
+    var current = containerRef.current;
+    if (containerRef && current) {
+      setTableContainerWidth(current.getBoundingClientRect().width);
+    }
+  }, [containerRef]);
   (0, _react.useEffect)(function () {
     if (!hasFullSchema) {
       setOrderedColumns(getOrderedColumns((0, _toConsumableArray2.default)(columns), (0, _toConsumableArray2.default)(visibleColumnKeys)));
@@ -327,19 +349,33 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
   // or some other combination.
 
   var identityColumnKey = 'id';
-  var getColumnWidth = (0, _react.useCallback)(function (key, type) {
-    return (columnCustomSizes === null || columnCustomSizes === void 0 ? void 0 : columnCustomSizes[key]) || getDefaultColumnWidth(key, type);
-  }, [columnCustomSizes]);
-  var headerColumns = (0, _react.useMemo)(function () {
+  var columnsWidthsSum = (0, _react.useMemo)(function () {
     return visibleSortedColumns.map(function (_ref7) {
       var key = _ref7.key,
-        title = _ref7.title,
         type = _ref7.type;
+      return (columnCustomSizes === null || columnCustomSizes === void 0 ? void 0 : columnCustomSizes[key]) || getDefaultColumnWidth(key, type);
+    }).reduce(function (sum, width) {
+      return width + sum;
+    }, 0) + (onVisibleColumnKeysChange ? columnPickerWidth : 0);
+  }, [columnCustomSizes, onVisibleColumnKeysChange, visibleSortedColumns]);
+  var shouldUseWidth = !!(onColumnResize || columnCustomSizes);
+  var getColumnWidth = (0, _react.useCallback)(function (key, type, isLastCell) {
+    if (isLastCell && shouldUseWidth && (!tableContainerWidth || tableContainerWidth > columnsWidthsSum)) {
+      return undefined;
+    } else {
+      return (columnCustomSizes === null || columnCustomSizes === void 0 ? void 0 : columnCustomSizes[key]) || getDefaultColumnWidth(key, type);
+    }
+  }, [columnCustomSizes, columnsWidthsSum, shouldUseWidth, tableContainerWidth]);
+  var headerColumns = (0, _react.useMemo)(function () {
+    return visibleSortedColumns.map(function (_ref8, index) {
+      var key = _ref8.key,
+        title = _ref8.title,
+        type = _ref8.type;
       return {
         key: key,
         content: title,
         shouldTruncate: true,
-        width: getColumnWidth(key, type)
+        width: getColumnWidth(key, type, index === visibleSortedColumns.length - 1)
       };
     });
   }, [getColumnWidth, visibleSortedColumns]);
@@ -376,9 +412,9 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
       return;
     }
     return (0, _combine.combine)((0, _adapter.monitorForElements)({
-      onDragStart: function onDragStart(_ref8) {
-        var location = _ref8.location,
-          source = _ref8.source;
+      onDragStart: function onDragStart(_ref9) {
+        var location = _ref9.location,
+          source = _ref9.source;
         initialAutoScrollerClientY.current = location.current.input.clientY;
         if (source.data.type === 'table-header') {
           var _containerRef$current;
@@ -394,9 +430,9 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
           });
         }
       },
-      onDrag: function onDrag(_ref9) {
-        var location = _ref9.location,
-          source = _ref9.source;
+      onDrag: function onDrag(_ref10) {
+        var location = _ref10.location,
+          source = _ref10.source;
         if (source.data.type === 'table-header') {
           var _containerRef$current2;
           _pragmaticDragAndDropReactBeautifulDndAutoscroll.autoScroller.updateInput({
@@ -406,9 +442,9 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
           });
         }
       },
-      onDrop: function onDrop(_ref10) {
-        var source = _ref10.source,
-          location = _ref10.location;
+      onDrop: function onDrop(_ref11) {
+        var source = _ref11.source,
+          location = _ref11.location;
         _pragmaticDragAndDropReactBeautifulDndAutoscroll.autoScroller.stop();
         if (location.current.dropTargets.length === 0) {
           return;
@@ -443,10 +479,10 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
     return items.map(function (newRowData, rowIndex) {
       return {
         key: "".concat(identityColumnKey && newRowData[identityColumnKey] && newRowData[identityColumnKey].data || rowIndex),
-        cells: visibleSortedColumns.map(function (_ref11) {
+        cells: visibleSortedColumns.map(function (_ref12, cellIndex) {
           var _newRowData$key;
-          var key = _ref11.key,
-            type = _ref11.type;
+          var key = _ref12.key,
+            type = _ref12.type;
           // Need to make sure we keep falsy values like 0 and '', as well as the boolean false.
           var value = (_newRowData$key = newRowData[key]) === null || _newRowData$key === void 0 ? void 0 : _newRowData$key.data;
           var values = Array.isArray(value) ? value : [value];
@@ -470,7 +506,7 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
           return {
             key: key,
             content: contentComponent,
-            width: getColumnWidth(key, type)
+            width: getColumnWidth(key, type, cellIndex === visibleSortedColumns.length - 1)
           };
         }),
         ref: rowIndex === items.length - 1 ? function (el) {
@@ -536,7 +572,6 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
       }
     }, _callee, null, [[3, 9]]);
   })), [parentContainerRenderInstanceId, extensionKey, hasFullSchema, onLoadDatasourceDetails]);
-  var shouldUseWidth = !!(onColumnResize || columnCustomSizes);
   var isEditable = onVisibleColumnKeysChange && hasData;
   return (0, _react2.jsx)("div", {
     /* There is required contentEditable={true} in editor-card-plugin
@@ -548,8 +583,11 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
     css: [tableContainerStyles, scrollableContainerHeight && scrollableContainerStyles],
     style: scrollableContainerHeight ? {
       maxHeight: "".concat(scrollableContainerHeight, "px")
-    } : undefined
-  }, (0, _react2.jsx)(_styled2.Table, {
+    } : undefined,
+    "data-testid": 'issue-like-table-container'
+  }, (0, _react2.jsx)(_widthDetector.WidthObserver, {
+    setWidth: (0, _debounce.default)(setTableContainerWidth, 100)
+  }), (0, _react2.jsx)(_styled2.Table, {
     css: tableStyles,
     "data-testid": testId,
     style: shouldUseWidth ? {
@@ -561,10 +599,10 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
     className: !!onVisibleColumnKeysChange ? 'has-column-picker' : ''
   }, (0, _react2.jsx)("tr", {
     ref: tableHeaderRowRef
-  }, headerColumns.map(function (_ref13, cellIndex) {
-    var key = _ref13.key,
-      content = _ref13.content,
-      width = _ref13.width;
+  }, headerColumns.map(function (_ref14, cellIndex) {
+    var key = _ref14.key,
+      content = _ref14.content,
+      width = _ref14.width;
     var heading = (0, _react2.jsx)(_tooltip.default, {
       content: content,
       tag: "span",
@@ -581,10 +619,10 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
     }
     if (isEditable) {
       var _containerRef$current3;
-      var previewRows = tableRows.map(function (_ref14) {
-        var cells = _ref14.cells;
-        var cell = cells.find(function (_ref15) {
-          var cellKey = _ref15.key;
+      var previewRows = tableRows.map(function (_ref15) {
+        var cells = _ref15.cells;
+        var cell = cells.find(function (_ref16) {
+          var cellKey = _ref16.key;
           return cellKey === key;
         });
         if (cell) {
@@ -626,18 +664,18 @@ var IssueLikeDataTableView = exports.IssueLikeDataTableView = function IssueLike
   })))), (0, _react2.jsx)("tbody", {
     css: noDefaultBorderStyles,
     "data-testid": testId && "".concat(testId, "--body")
-  }, rows.map(function (_ref16) {
-    var key = _ref16.key,
-      cells = _ref16.cells,
-      ref = _ref16.ref;
+  }, rows.map(function (_ref17) {
+    var key = _ref17.key,
+      cells = _ref17.cells,
+      ref = _ref17.ref;
     return (0, _react2.jsx)("tr", {
       key: key,
       "data-testid": testId && "".concat(testId, "--row-").concat(key),
       ref: ref
-    }, cells.map(function (_ref17, cellIndex) {
-      var cellKey = _ref17.key,
-        content = _ref17.content,
-        width = _ref17.width;
+    }, cells.map(function (_ref18, cellIndex) {
+      var cellKey = _ref18.key,
+        content = _ref18.content,
+        width = _ref18.width;
       var isLastCell = cellIndex === cells.length - 1;
       var loadingRowStyle = (0, _utils.getWidthCss)({
         shouldUseWidth: shouldUseWidth,

package/dist/cjs/ui/issue-like-table/render-type/richtext/index.js

@@ -14,8 +14,7 @@ var _model = require("@atlaskit/editor-prosemirror/model");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } /** @jsx jsx */
 var rootStyles = (0, _react2.css)({
-  position: 'relative',
-  display: 'block'
+  position: 'relative'
 });
 var smartLinkNodeToUrl = function smartLinkNodeToUrl(node) {
   var _node$attrs$url;
@@ -52,7 +51,7 @@ var RichTextType = function RichTextType(_ref) {
     return parseRichText(value);
   }, [value]);
   if (adfPlainText) {
-    return (0, _react2.jsx)("div", {
+    return (0, _react2.jsx)("span", {
       css: rootStyles,
       "data-testid": "richtext-plaintext"
     }, adfPlainText);

package/dist/cjs/ui/issue-like-table/styled.js

@@ -33,11 +33,19 @@ var withTablePluginBodyPrefix = exports.withTablePluginBodyPrefix = withTablePlu
 var TableHeading = exports.TableHeading = _styled.default.th((_styled$th = {}, (0, _defineProperty2.default)(_styled$th, "".concat(withTablePluginHeaderPrefix()), {
   border: 0,
   position: 'relative',
+  /* This makes resizing work with out jumping due to padding + changes overall width for same default values. */
   boxSizing: 'border-box',
   lineHeight: lineHeight,
   padding: "".concat(verticalPadding, " ", "var(--ds-space-050, 4px)"),
   borderRight: "0.5px solid ".concat("var(--ds-border, ".concat(_colors.N40, ")")),
   borderBottom: "2px solid ".concat("var(--ds-border, ".concat(_colors.N40, ")")),
+  /*
+    lineHeight * 2 -> Max height of two lined header
+    verticalPadding * 2 -> padding for this component itself
+    verticalPadding * 2 -> padding inside span (--container)
+    2px -> Bottom border
+    Last two terms are needed because of border-box box sizing.
+  */
   height: "calc(".concat(lineHeight, " * 2 + ").concat(verticalPadding, " * 4 + 2px)"),
   verticalAlign: 'bottom',
   backgroundColor: "var(--ds-elevation-surface-current, #FFF)"
@@ -49,6 +57,9 @@ var TableHeading = exports.TableHeading = _styled.default.th((_styled$th = {}, (
   borderRight: 0
 }), (0, _defineProperty2.default)(_styled$th, "& [data-testid='datasource-header-content--container']", {
   width: '100%',
+  /* With Button now being a parent for this component it adds its lineHeight value and spoils
+    `height` calculation above. */
+  lineHeight: lineHeight,
   padding: "".concat(verticalPadding, " ", "var(--ds-space-050, 4px)"),
   display: '-webkit-box',
   WebkitLineClamp: 2,

package/dist/cjs/ui/issue-like-table/utils.js

@@ -14,16 +14,23 @@ var COLUMN_MIN_WIDTH = exports.COLUMN_MIN_WIDTH = COLUMN_BASE_WIDTH * 3;
  * or rather default width that should be treated as a maximum width. When table inserted initially
  * and no user custom width defined we set this value to `false`. As soon as user changes any of the
  * column widths we treat all width as custom hardcoded widths.
- * @param width
+ * @param width Sometimes set to undefined for last column to make it occupy remainder of the table width
  */
 var getWidthCss = exports.getWidthCss = function getWidthCss(_ref) {
   var shouldUseWidth = _ref.shouldUseWidth,
     width = _ref.width;
-  return shouldUseWidth ? {
-    width: width
-  } : {
-    maxWidth: width
-  };
+  if (!width) {
+    return {};
+  }
+  if (shouldUseWidth) {
+    return {
+      width: width
+    };
+  } else {
+    return {
+      maxWidth: width
+    };
+  }
 };
 
 /**

package/dist/es2019/ui/issue-like-table/draggable-table-heading.js

@@ -100,6 +100,11 @@ export const DraggableTableHeading = ({
   const [isDraggingAnyColumn, setIsDraggingAnyColumn] = useState(false);
   const [closestEdge, setClosestEdge] = useState(null);
   const dropTargetRef = useRef(null);
+  /**
+   * When width is not set (or callback is not set) we assume not resizing is needed.
+   * In our case width won't be set for last cell when table container is bigger than sum of all columns
+   */
+  const resizeIsEnabled = !!onWidthChange && !!width;
   useEffect(() => {
     const cell = mainHeaderCellRef.current;
     invariant(cell);
@@ -209,7 +214,7 @@ export const DraggableTableHeading = ({
 
   // Handling column resizing
   useEffect(() => {
-    if (!onWidthChange) {
+    if (!resizeIsEnabled) {
       return;
     }
     const resizeHandle = columnResizeHandleRef.current;
@@ -269,10 +274,12 @@ export const DraggableTableHeading = ({
         }
       }
     });
-  }, [id, index, onWidthChange, state, tableId, width]);
+  }, [id, index, onWidthChange, resizeIsEnabled, state, tableId, width]);
   const [buttonHovered, setButtonHovered] = useState(false);
   const [isDropdownOpen, setIsDropdownOpen] = useState(false);
-  const isWideEnoughToHaveChevron = width > 76;
+  // Width is not set when it is a last cell in a wide table.
+  // We make assumption thus that there is enough width for chevron.
+  const isWideEnoughToHaveChevron = !width || width > 76;
   const shouldShowTriggerIcon = (buttonHovered || isDropdownOpen) && isWideEnoughToHaveChevron;
   const triggerIcon = useMemo(() => shouldShowTriggerIcon ? isDropdownOpen ? ChevronUp : ChevronDown : isWideEnoughToHaveChevron ? GlyphPlaceholder : undefined, [shouldShowTriggerIcon, isDropdownOpen, isWideEnoughToHaveChevron]);
   const getTriggerButton = useCallback(({
@@ -300,11 +307,11 @@ export const DraggableTableHeading = ({
     style: {
       cursor: 'grab',
       ...getWidthCss({
-        shouldUseWidth: !!onWidthChange,
+        shouldUseWidth: resizeIsEnabled,
         width
       })
     }
-  }, onWidthChange ? jsx("div", {
+  }, resizeIsEnabled ? jsx("div", {
     ref: columnResizeHandleRef,
     css: [resizerStyles, state.type === 'resizing' && resizingStyles],
     style: {

package/dist/es2019/ui/issue-like-table/index.js

@@ -3,6 +3,7 @@ import _extends from "@babel/runtime/helpers/extends";
 import { forwardRef, useCallback, useEffect, useMemo, useRef, useState } from 'react';
 import { css, jsx } from '@emotion/react';
 import styled from '@emotion/styled';
+import debounce from 'lodash/debounce';
 import { useIntl } from 'react-intl-next';
 import invariant from 'tiny-invariant';
 import { Skeleton } from '@atlaskit/linking-common';
@@ -14,6 +15,7 @@ import { monitorForElements } from '@atlaskit/pragmatic-drag-and-drop/element/ad
 import { N40 } from '@atlaskit/theme/colors';
 import { fontFallback } from '@atlaskit/theme/typography';
 import Tooltip from '@atlaskit/tooltip';
+import { WidthObserver } from '@atlaskit/width-detector';
 import { startUfoExperience, succeedUfoExperience } from '../../analytics/ufoExperiences';
 import { stickyTableHeadersIndex } from '../../common/zindex';
 import { ColumnPicker } from './column-picker';
@@ -36,23 +38,24 @@ const truncateTextStyles = css({
   textOverflow: 'ellipsis',
   whiteSpace: 'nowrap'
 });
+const columnPickerWidth = 80;
 const ColumnPickerHeader = styled.th({
-  [`${withTablePluginHeaderPrefix()}`]: {
-    boxSizing: 'content-box',
+  [`${withTablePluginHeaderPrefix('&:last-of-type')}`]: {
+    boxSizing: 'border-box',
     border: 0,
-    width: '56px',
+    width: `${columnPickerWidth}px`,
     zIndex: 10,
     position: 'sticky',
     right: `calc(-1 * ${tableSidePadding})`,
     backgroundColor: "var(--ds-elevation-surface-current, #FFF)",
+    /* It is required to have solid (not half-transparent) color because of this gradient business below */
     borderBottom: `2px solid ${`var(--ds-border, ${N40})`}`,
-    paddingRight: "var(--ds-space-100, 4px)",
+    paddingRight: tableSidePadding,
     background: `linear-gradient( 90deg, rgba(255, 255, 255, 0) 0%, ${"var(--ds-elevation-surface-current, #FFF)"} 10% )`,
+    /* Keeps dropdown button in the middle */
     verticalAlign: 'middle',
+    /* In case when TH itself is bigger we want to keep picker at the right side */
     textAlign: 'right'
-  },
-  [`${withTablePluginHeaderPrefix('&:last-of-type')}`]: {
-    paddingRight: tableSidePadding
   }
 });
 const truncateStyles = css({
@@ -61,6 +64,7 @@ const truncateStyles = css({
 });
 const TableCell = styled.td({
   [`${withTablePluginBodyPrefix()}`]: {
+    /* First section here is to override things editor table plugin css defines */
     font: fieldTextFontSize,
     padding: `${"var(--ds-space-050, 4px)"} ${"var(--ds-space-100, 8px)"}`,
     border: 0,
@@ -87,7 +91,8 @@ const TableCell = styled.td({
 const tableContainerStyles = css({
   borderRadius: 'inherit',
   borderBottomLeftRadius: 0,
-  borderBottomRightRadius: 0
+  borderBottomRightRadius: 0,
+  position: 'relative'
 });
 
 /**
@@ -220,7 +225,10 @@ const tableStyles = css({
   // These styles are needed to prevent thead bottom border from scrolling away.
   // This happens because it is sticky. https://stackoverflow.com/questions/50361698/border-style-do-not-work-with-sticky-position-element
   borderCollapse: 'separate',
-  borderSpacing: 0
+  borderSpacing: 0,
+  // There is a strange table:first-of-type rule that sets margin-top to 0 coming from container,
+  // but because our table is now not the first child (there is an empty div to measure width) we need to set it manually.
+  margin: 0
 });
 
 // By default tbody and thead have border-bottom: 2px ...
@@ -317,6 +325,18 @@ export const IssueLikeDataTableView = ({
   const isBottomOfTableVisibleRaw = useIsOnScreen(lastRowElement);
   const containerRef = useRef(null);
   const [orderedColumns, setOrderedColumns] = useState(() => getOrderedColumns([...columns], [...visibleColumnKeys]));
+
+  // Table container width is used to know if sum of all column widths is bigger of container or not.
+  // When sum of all columns is less than container size we make last column stretchable (width: undefined)
+  const [tableContainerWidth, setTableContainerWidth] = useState();
+  useEffect(() => {
+    const {
+      current
+    } = containerRef;
+    if (containerRef && current) {
+      setTableContainerWidth(current.getBoundingClientRect().width);
+    }
+  }, [containerRef]);
   useEffect(() => {
     if (!hasFullSchema) {
       setOrderedColumns(getOrderedColumns([...columns], [...visibleColumnKeys]));
@@ -338,16 +358,27 @@ export const IssueLikeDataTableView = ({
   // or some other combination.
 
   const identityColumnKey = 'id';
-  const getColumnWidth = useCallback((key, type) => (columnCustomSizes === null || columnCustomSizes === void 0 ? void 0 : columnCustomSizes[key]) || getDefaultColumnWidth(key, type), [columnCustomSizes]);
+  const columnsWidthsSum = useMemo(() => visibleSortedColumns.map(({
+    key,
+    type
+  }) => (columnCustomSizes === null || columnCustomSizes === void 0 ? void 0 : columnCustomSizes[key]) || getDefaultColumnWidth(key, type)).reduce((sum, width) => width + sum, 0) + (onVisibleColumnKeysChange ? columnPickerWidth : 0), [columnCustomSizes, onVisibleColumnKeysChange, visibleSortedColumns]);
+  const shouldUseWidth = !!(onColumnResize || columnCustomSizes);
+  const getColumnWidth = useCallback((key, type, isLastCell) => {
+    if (isLastCell && shouldUseWidth && (!tableContainerWidth || tableContainerWidth > columnsWidthsSum)) {
+      return undefined;
+    } else {
+      return (columnCustomSizes === null || columnCustomSizes === void 0 ? void 0 : columnCustomSizes[key]) || getDefaultColumnWidth(key, type);
+    }
+  }, [columnCustomSizes, columnsWidthsSum, shouldUseWidth, tableContainerWidth]);
   const headerColumns = useMemo(() => visibleSortedColumns.map(({
     key,
     title,
     type
-  }) => ({
+  }, index) => ({
     key,
     content: title,
     shouldTruncate: true,
-    width: getColumnWidth(key, type)
+    width: getColumnWidth(key, type, index === visibleSortedColumns.length - 1)
   })), [getColumnWidth, visibleSortedColumns]);
   const loadingRow = useMemo(() => ({
     key: 'loading',
@@ -450,7 +481,7 @@ export const IssueLikeDataTableView = ({
     cells: visibleSortedColumns.map(({
       key,
       type
-    }) => {
+    }, cellIndex) => {
       var _newRowData$key;
       // Need to make sure we keep falsy values like 0 and '', as well as the boolean false.
       const value = (_newRowData$key = newRowData[key]) === null || _newRowData$key === void 0 ? void 0 : _newRowData$key.data;
@@ -471,7 +502,7 @@ export const IssueLikeDataTableView = ({
       return {
         key,
         content: contentComponent,
-        width: getColumnWidth(key, type)
+        width: getColumnWidth(key, type, cellIndex === visibleSortedColumns.length - 1)
       };
     }),
     ref: rowIndex === items.length - 1 ? el => setLastRowElement(el) : undefined
@@ -517,7 +548,6 @@ export const IssueLikeDataTableView = ({
       setHasFullSchema(false);
     }
   }, [parentContainerRenderInstanceId, extensionKey, hasFullSchema, onLoadDatasourceDetails]);
-  const shouldUseWidth = !!(onColumnResize || columnCustomSizes);
   const isEditable = onVisibleColumnKeysChange && hasData;
   return jsx("div", {
     /* There is required contentEditable={true} in editor-card-plugin
@@ -529,8 +559,11 @@ export const IssueLikeDataTableView = ({
     css: [tableContainerStyles, scrollableContainerHeight && scrollableContainerStyles],
     style: scrollableContainerHeight ? {
       maxHeight: `${scrollableContainerHeight}px`
-    } : undefined
-  }, jsx(Table, {
+    } : undefined,
+    "data-testid": 'issue-like-table-container'
+  }, jsx(WidthObserver, {
+    setWidth: debounce(setTableContainerWidth, 100)
+  }), jsx(Table, {
     css: tableStyles,
     "data-testid": testId,
     style: shouldUseWidth ? {