@atlaskit/link-datasource 1.19.39 → 1.19.40

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (5) hide show
  1. package/CHANGELOG.md +6 -0
  2. package/dist/cjs/hooks/useDatasourceTableState.js +6 -2
  3. package/dist/es2019/hooks/useDatasourceTableState.js +6 -2
  4. package/dist/esm/hooks/useDatasourceTableState.js +6 -2
  5. package/package.json +1 -1
package/CHANGELOG.md CHANGED
@@ -1,5 +1,11 @@
1
1
  # @atlaskit/link-datasource
2
2
 
3
+ ## 1.19.40
4
+
5
+ ### Patch Changes
6
+
7
+ - [#64455](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/64455) [`fcb3bcdbead3`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/fcb3bcdbead3) - Fixes issue duplication in list of links after adding columns through the config modal by checking responseItems for duplications
8
+
3
9
  ## 1.19.39
4
10
 
5
11
  ### Patch Changes
package/dist/cjs/hooks/useDatasourceTableState.js CHANGED
@@ -258,7 +258,11 @@ var useDatasourceTableState = exports.useDatasourceTableState = function useData
258
258
  setTotalCount(_totalCount);
259
259
  setNextCursor(nextPageCursor);
260
260
  setResponseItems(function (currentResponseItems) {
261
- if (shouldRequestFirstPage) {
261
+ // FIXME EDM-8977 (https://product-fabric.atlassian.net/browse/EDM-8977)
262
+ // once the onNextPage and reset loop issue has been thoroughly investigated
263
+ // in the above card, remove this isEqual check, ensure onNextPage isn't called twice
264
+ var hasIdenticalResponseItems = (0, _isEqual.default)(currentResponseItems, items);
265
+ if (hasIdenticalResponseItems || shouldRequestFirstPage) {
262
266
  return items;
263
267
  }
264
268
  return [].concat((0, _toConsumableArray2.default)(currentResponseItems), (0, _toConsumableArray2.default)(items));
@@ -307,7 +311,7 @@ var useDatasourceTableState = exports.useDatasourceTableState = function useData
307
311
  return _context2.stop();
308
312
  }
309
313
  }, _callee2, null, [[7, 39]]);
310
- })), [captureError, parameters, fieldKeys, nextCursor, getDatasourceData, datasourceId, responseItems === null || responseItems === void 0 ? void 0 : responseItems.length, applySchemaProperties, fireEvent, fullSchema]);
314
+ })), [captureError, parameters, fieldKeys, nextCursor, getDatasourceData, datasourceId, responseItems, applySchemaProperties, fireEvent, fullSchema]);
311
315
  var reset = (0, _react.useCallback)(function (options) {
312
316
  setStatus('empty');
313
317
  setResponseItems([]);
package/dist/es2019/hooks/useDatasourceTableState.js CHANGED
@@ -153,7 +153,11 @@ export const useDatasourceTableState = ({
153
153
  setTotalCount(totalCount);
154
154
  setNextCursor(nextPageCursor);
155
155
  setResponseItems(currentResponseItems => {
156
- if (shouldRequestFirstPage) {
156
+ // FIXME EDM-8977 (https://product-fabric.atlassian.net/browse/EDM-8977)
157
+ // once the onNextPage and reset loop issue has been thoroughly investigated
158
+ // in the above card, remove this isEqual check, ensure onNextPage isn't called twice
159
+ const hasIdenticalResponseItems = isEqual(currentResponseItems, items);
160
+ if (hasIdenticalResponseItems || shouldRequestFirstPage) {
157
161
  return items;
158
162
  }
159
163
  return [...currentResponseItems, ...items];
@@ -188,7 +192,7 @@ export const useDatasourceTableState = ({
188
192
  }
189
193
  setStatus('rejected');
190
194
  }
191
- }, [captureError, parameters, fieldKeys, nextCursor, getDatasourceData, datasourceId, responseItems === null || responseItems === void 0 ? void 0 : responseItems.length, applySchemaProperties, fireEvent, fullSchema]);
195
+ }, [captureError, parameters, fieldKeys, nextCursor, getDatasourceData, datasourceId, responseItems, applySchemaProperties, fireEvent, fullSchema]);
192
196
  const reset = useCallback(options => {
193
197
  setStatus('empty');
194
198
  setResponseItems([]);
package/dist/esm/hooks/useDatasourceTableState.js CHANGED
@@ -251,7 +251,11 @@ export var useDatasourceTableState = function useDatasourceTableState(_ref) {
251
251
  setTotalCount(_totalCount);
252
252
  setNextCursor(nextPageCursor);
253
253
  setResponseItems(function (currentResponseItems) {
254
- if (shouldRequestFirstPage) {
254
+ // FIXME EDM-8977 (https://product-fabric.atlassian.net/browse/EDM-8977)
255
+ // once the onNextPage and reset loop issue has been thoroughly investigated
256
+ // in the above card, remove this isEqual check, ensure onNextPage isn't called twice
257
+ var hasIdenticalResponseItems = isEqual(currentResponseItems, items);
258
+ if (hasIdenticalResponseItems || shouldRequestFirstPage) {
255
259
  return items;
256
260
  }
257
261
  return [].concat(_toConsumableArray(currentResponseItems), _toConsumableArray(items));
@@ -300,7 +304,7 @@ export var useDatasourceTableState = function useDatasourceTableState(_ref) {
300
304
  return _context2.stop();
301
305
  }
302
306
  }, _callee2, null, [[7, 39]]);
303
- })), [captureError, parameters, fieldKeys, nextCursor, getDatasourceData, datasourceId, responseItems === null || responseItems === void 0 ? void 0 : responseItems.length, applySchemaProperties, fireEvent, fullSchema]);
307
+ })), [captureError, parameters, fieldKeys, nextCursor, getDatasourceData, datasourceId, responseItems, applySchemaProperties, fireEvent, fullSchema]);
304
308
  var reset = useCallback(function (options) {
305
309
  setStatus('empty');
306
310
  setResponseItems([]);
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/link-datasource",
3
- "version": "1.19.39",
3
+ "version": "1.19.40",
4
4
  "description": "UI Components to support linking platform dataset feature",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"