@atlaskit/link-datasource 0.33.11 → 0.33.12

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/link-datasource
 
+## 0.33.12
+
+### Patch Changes
+
+- [`0aadfa0dc26`](https://bitbucket.org/atlassian/atlassian-frontend/commits/0aadfa0dc26) - Fix double loading inside table view
+
 ## 0.33.11
 
 ### Patch Changes

package/dist/cjs/ui/datasource-table-view/datasourceTableView.js

@@ -36,9 +36,16 @@ var DatasourceTableView = function DatasourceTableView(_ref) {
     totalCount = _useDatasourceTableSt.totalCount,
     loadDatasourceDetails = _useDatasourceTableSt.loadDatasourceDetails;
 
-  // Need this to make sure that the datasource in the editor gets updated new info if any edits are made in the modal
+  /*  Need this to make sure that the datasource in the editor gets updated new info if any edits are made in the modal
+      But we don't want to call it on initial load. This screws up useDatasourceTableState's internal
+      mechanism of initial loading. Use of ref here makes it basically work as a `componentDidUpdate` but not `componentDidMount`
+   */
+  var isInitialRender = (0, _react.useRef)(true);
   (0, _react.useEffect)(function () {
-    reset();
+    if (!isInitialRender.current) {
+      reset();
+    }
+    isInitialRender.current = false;
   }, [reset, parameters]);
   (0, _react.useEffect)(function () {
     if (onVisibleColumnKeysChange && (visibleColumnKeys || []).length === 0 && defaultVisibleColumnKeys.length > 0) {

package/dist/cjs/ui/jira-issues-modal/modal/index.js

@@ -344,7 +344,7 @@ var analyticsContextAttributes = {
 };
 var analyticsContextData = {
   packageName: "@atlaskit/link-datasource",
-  packageVersion: "0.33.11",
+  packageVersion: "0.33.12",
   source: 'datasourceConfigModal'
 };
 var contextData = _objectSpread(_objectSpread({}, analyticsContextData), {}, {

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/link-datasource",
-	"version": "0.33.11",
+	"version": "0.33.12",
 	"sideEffects": false
 }

package/dist/es2019/ui/datasource-table-view/datasourceTableView.js

@@ -1,5 +1,5 @@
 /** @jsx jsx */
-import { useCallback, useEffect } from 'react';
+import { useCallback, useEffect, useRef } from 'react';
 import { jsx } from '@emotion/react';
 import { useDatasourceTableState } from '../../hooks/useDatasourceTableState';
 import { AccessRequired } from '../common/error-state/access-required';
@@ -30,9 +30,16 @@ export const DatasourceTableView = ({
     fieldKeys: visibleColumnKeys
   });
 
-  // Need this to make sure that the datasource in the editor gets updated new info if any edits are made in the modal
+  /*  Need this to make sure that the datasource in the editor gets updated new info if any edits are made in the modal
+      But we don't want to call it on initial load. This screws up useDatasourceTableState's internal
+      mechanism of initial loading. Use of ref here makes it basically work as a `componentDidUpdate` but not `componentDidMount`
+   */
+  const isInitialRender = useRef(true);
   useEffect(() => {
-    reset();
+    if (!isInitialRender.current) {
+      reset();
+    }
+    isInitialRender.current = false;
   }, [reset, parameters]);
   useEffect(() => {
     if (onVisibleColumnKeysChange && (visibleColumnKeys || []).length === 0 && defaultVisibleColumnKeys.length > 0) {

package/dist/es2019/ui/jira-issues-modal/modal/index.js

@@ -290,7 +290,7 @@ const analyticsContextAttributes = {
 };
 const analyticsContextData = {
   packageName: "@atlaskit/link-datasource",
-  packageVersion: "0.33.11",
+  packageVersion: "0.33.12",
   source: 'datasourceConfigModal'
 };
 const contextData = {

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/link-datasource",
-	"version": "0.33.11",
+	"version": "0.33.12",
 	"sideEffects": false
 }

package/dist/esm/ui/datasource-table-view/datasourceTableView.js

@@ -1,5 +1,5 @@
 /** @jsx jsx */
-import { useCallback, useEffect } from 'react';
+import { useCallback, useEffect, useRef } from 'react';
 import { jsx } from '@emotion/react';
 import { useDatasourceTableState } from '../../hooks/useDatasourceTableState';
 import { AccessRequired } from '../common/error-state/access-required';
@@ -28,9 +28,16 @@ export var DatasourceTableView = function DatasourceTableView(_ref) {
     totalCount = _useDatasourceTableSt.totalCount,
     loadDatasourceDetails = _useDatasourceTableSt.loadDatasourceDetails;
 
-  // Need this to make sure that the datasource in the editor gets updated new info if any edits are made in the modal
+  /*  Need this to make sure that the datasource in the editor gets updated new info if any edits are made in the modal
+      But we don't want to call it on initial load. This screws up useDatasourceTableState's internal
+      mechanism of initial loading. Use of ref here makes it basically work as a `componentDidUpdate` but not `componentDidMount`
+   */
+  var isInitialRender = useRef(true);
   useEffect(function () {
-    reset();
+    if (!isInitialRender.current) {
+      reset();
+    }
+    isInitialRender.current = false;
   }, [reset, parameters]);
   useEffect(function () {
     if (onVisibleColumnKeysChange && (visibleColumnKeys || []).length === 0 && defaultVisibleColumnKeys.length > 0) {

package/dist/esm/ui/jira-issues-modal/modal/index.js

@@ -334,7 +334,7 @@ var analyticsContextAttributes = {
 };
 var analyticsContextData = {
   packageName: "@atlaskit/link-datasource",
-  packageVersion: "0.33.11",
+  packageVersion: "0.33.12",
   source: 'datasourceConfigModal'
 };
 var contextData = _objectSpread(_objectSpread({}, analyticsContextData), {}, {

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/link-datasource",
-	"version": "0.33.11",
+	"version": "0.33.12",
 	"sideEffects": false
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/link-datasource",
-  "version": "0.33.11",
+  "version": "0.33.12",
   "description": "UI Components to support linking platform dataset feature",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"