@atlaskit/link-create 1.8.1 → 1.9.0

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/link-create
 
+## 1.9.0
+
+### Minor Changes
+
+- [#43068](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/43068) [`76817bfbd5d`](https://bitbucket.org/atlassian/atlassian-frontend/commits/76817bfbd5d) - EDM-8402: under a FF platform.linking-platform.link-create.enable-edit internally refactor onCloseComplete hook to be conditionally called when active prop is false
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 1.8.1
 
 ### Patch Changes

package/dist/cjs/ui/link-create/main.js

@@ -133,6 +133,17 @@ var LinkCreateWithModal = function LinkCreateWithModal(_ref3) {
 };
 var LinkCreateModal = function LinkCreateModal(props) {
   if ((0, _platformFeatureFlags.getBooleanFF)('platform.linking-platform.link-create.enable-edit')) {
+    // eslint-disable-next-line react-hooks/rules-of-hooks
+    var shouldCallCloseComplete = (0, _react.useRef)(!props.active);
+
+    // modal calls onCloseComplete in a useEffect(), so we can track whether
+    // or not we should execute it based on the active prop in a
+    // useLayoutEffect() which will be run before child useEffect()s
+    // eslint-disable-next-line react-hooks/rules-of-hooks
+    (0, _react.useLayoutEffect)(function () {
+      // onCloseComplete should only be called when it is not active
+      shouldCallCloseComplete.current = !props.active;
+    }, [props.active]);
     return (0, _react2.jsx)(_pluginContext.LinkCreatePluginsProvider, {
       plugins: props.plugins,
       entityKey: props.entityKey
@@ -177,7 +188,16 @@ var LinkCreateModal = function LinkCreateModal(props) {
             return function (_x2) {
               return _ref6.apply(this, arguments);
             };
-          }()
+          }(),
+          onCloseComplete: function onCloseComplete() {
+            if (shouldCallCloseComplete.current) {
+              var _props$onCloseComplet;
+              for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
+                args[_key] = arguments[_key];
+              }
+              (_props$onCloseComplet = props.onCloseComplete) === null || _props$onCloseComplet === void 0 || _props$onCloseComplet.call.apply(_props$onCloseComplet, [props].concat(args));
+            }
+          }
         }))));
       });
     });

package/dist/cjs/ui/main.js

@@ -35,7 +35,7 @@ var LinkCreateWithAnalyticsContext = (0, _analytics.withLinkCreateAnalyticsConte
 }));
 var PACKAGE_DATA = exports.PACKAGE_DATA = {
   packageName: "@atlaskit/link-create" || '',
-  packageVersion: "1.8.1" || '',
+  packageVersion: "1.9.0" || '',
   componentName: _constants.COMPONENT_NAME,
   source: _constants.COMPONENT_NAME
 };

package/dist/es2019/ui/link-create/main.js

@@ -1,6 +1,6 @@
 import _extends from "@babel/runtime/helpers/extends";
 /** @jsx jsx */
-import { Fragment, useCallback, useState } from 'react';
+import { Fragment, useCallback, useLayoutEffect, useRef, useState } from 'react';
 import { jsx } from '@emotion/react';
 import { useIntl } from 'react-intl-next';
 import Modal, { ModalBody, ModalHeader, ModalTitle, ModalTransition } from '@atlaskit/modal-dialog';
@@ -98,6 +98,17 @@ const LinkCreateWithModal = ({
 };
 const LinkCreateModal = props => {
   if (getBooleanFF('platform.linking-platform.link-create.enable-edit')) {
+    // eslint-disable-next-line react-hooks/rules-of-hooks
+    const shouldCallCloseComplete = useRef(!props.active);
+
+    // modal calls onCloseComplete in a useEffect(), so we can track whether
+    // or not we should execute it based on the active prop in a
+    // useLayoutEffect() which will be run before child useEffect()s
+    // eslint-disable-next-line react-hooks/rules-of-hooks
+    useLayoutEffect(() => {
+      // onCloseComplete should only be called when it is not active
+      shouldCallCloseComplete.current = !props.active;
+    }, [props.active]);
     return jsx(LinkCreatePluginsProvider, {
       plugins: props.plugins,
       entityKey: props.entityKey
@@ -128,6 +139,12 @@ const LinkCreateModal = props => {
               props.onComplete();
             }
           }
+        },
+        onCloseComplete: (...args) => {
+          if (shouldCallCloseComplete.current) {
+            var _props$onCloseComplet;
+            (_props$onCloseComplet = props.onCloseComplete) === null || _props$onCloseComplet === void 0 ? void 0 : _props$onCloseComplet.call(props, ...args);
+          }
         }
       }))));
     }));

package/dist/es2019/ui/main.js

@@ -26,7 +26,7 @@ const LinkCreateWithAnalyticsContext = withLinkCreateAnalyticsContext( /*#__PURE
 }));
 export const PACKAGE_DATA = {
   packageName: "@atlaskit/link-create" || '',
-  packageVersion: "1.8.1" || '',
+  packageVersion: "1.9.0" || '',
   componentName: COMPONENT_NAME,
   source: COMPONENT_NAME
 };

package/dist/esm/ui/link-create/main.js

@@ -6,7 +6,7 @@ var _excluded = ["testId", "triggeredFrom"],
   _excluded2 = ["active", "modalTitle", "onCreate", "onFailure", "onCancel", "onOpenComplete", "onCloseComplete"];
 import _regeneratorRuntime from "@babel/runtime/regenerator";
 /** @jsx jsx */
-import { Fragment, useCallback, useState } from 'react';
+import { Fragment, useCallback, useLayoutEffect, useRef, useState } from 'react';
 import { jsx } from '@emotion/react';
 import { useIntl } from 'react-intl-next';
 import Modal, { ModalBody, ModalHeader, ModalTitle, ModalTransition } from '@atlaskit/modal-dialog';
@@ -123,6 +123,17 @@ var LinkCreateWithModal = function LinkCreateWithModal(_ref3) {
 };
 var LinkCreateModal = function LinkCreateModal(props) {
   if (getBooleanFF('platform.linking-platform.link-create.enable-edit')) {
+    // eslint-disable-next-line react-hooks/rules-of-hooks
+    var shouldCallCloseComplete = useRef(!props.active);
+
+    // modal calls onCloseComplete in a useEffect(), so we can track whether
+    // or not we should execute it based on the active prop in a
+    // useLayoutEffect() which will be run before child useEffect()s
+    // eslint-disable-next-line react-hooks/rules-of-hooks
+    useLayoutEffect(function () {
+      // onCloseComplete should only be called when it is not active
+      shouldCallCloseComplete.current = !props.active;
+    }, [props.active]);
     return jsx(LinkCreatePluginsProvider, {
       plugins: props.plugins,
       entityKey: props.entityKey
@@ -167,7 +178,16 @@ var LinkCreateModal = function LinkCreateModal(props) {
             return function (_x2) {
               return _ref6.apply(this, arguments);
             };
-          }()
+          }(),
+          onCloseComplete: function onCloseComplete() {
+            if (shouldCallCloseComplete.current) {
+              var _props$onCloseComplet;
+              for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
+                args[_key] = arguments[_key];
+              }
+              (_props$onCloseComplet = props.onCloseComplete) === null || _props$onCloseComplet === void 0 || _props$onCloseComplet.call.apply(_props$onCloseComplet, [props].concat(args));
+            }
+          }
         }))));
       });
     });

package/dist/esm/ui/main.js

@@ -27,7 +27,7 @@ var LinkCreateWithAnalyticsContext = withLinkCreateAnalyticsContext( /*#__PURE__
 }));
 export var PACKAGE_DATA = {
   packageName: "@atlaskit/link-create" || '',
-  packageVersion: "1.8.1" || '',
+  packageVersion: "1.9.0" || '',
   componentName: COMPONENT_NAME,
   source: COMPONENT_NAME
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/link-create",
-  "version": "1.8.1",
+  "version": "1.9.0",
   "description": "The driver component of meta creation flow",
   "author": "Atlassian Pty Ltd",
   "license": "Apache-2.0",
@@ -40,7 +40,7 @@
     "@atlaskit/form": "^9.0.0",
     "@atlaskit/icon": "^21.12.0",
     "@atlaskit/intl-messages-provider": "^1.0.0",
-    "@atlaskit/linking-common": "^4.17.0",
+    "@atlaskit/linking-common": "^4.18.0",
     "@atlaskit/modal-dialog": "^12.8.0",
     "@atlaskit/platform-feature-flags": "^0.2.1",
     "@atlaskit/primitives": "^1.10.0",