@atlaskit/link-create 0.5.7 → 0.6.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,11 @@
1
1
  # @atlaskit/link-create
2
2
 
3
+ ## 0.6.0
4
+
5
+ ### Minor Changes
6
+
7
+ - [`ac3927f0650`](https://bitbucket.org/atlassian/atlassian-frontend/commits/ac3927f0650) - Make modal 480px wide, Update TextField to take isRequired prop w/o default browser validation, remove extra internal spacing in the create form
8
+
3
9
  ## 0.5.7
4
10
 
5
11
  ### Patch Changes
@@ -8,7 +8,7 @@ var ANALYTICS_CHANNEL = 'media';
8
8
  exports.ANALYTICS_CHANNEL = ANALYTICS_CHANNEL;
9
9
  var COMPONENT_NAME = 'linkCreate';
10
10
  exports.COMPONENT_NAME = COMPONENT_NAME;
11
- var CREATE_FORM_MAX_WIDTH_IN_PX = '600';
11
+ var CREATE_FORM_MAX_WIDTH_IN_PX = '480';
12
12
  exports.CREATE_FORM_MAX_WIDTH_IN_PX = CREATE_FORM_MAX_WIDTH_IN_PX;
13
13
  var CREATE_FORM_MIN_HEIGHT_IN_PX = '200';
14
14
  exports.CREATE_FORM_MIN_HEIGHT_IN_PX = CREATE_FORM_MIN_HEIGHT_IN_PX;
@@ -96,7 +96,7 @@ var CreateForm = function CreateForm(_ref) {
96
96
  name: "confluence-creation-form",
97
97
  "data-testid": testId,
98
98
  css: formStyles
99
- }), (0, _react2.jsx)(_form.FormSection, null, children), !hideFooter && (0, _react2.jsx)(_form.FormFooter, null, formErrorMessage && (0, _react2.jsx)("div", {
99
+ }), (0, _react2.jsx)("div", null, children), !hideFooter && (0, _react2.jsx)(_form.FormFooter, null, formErrorMessage && (0, _react2.jsx)("div", {
100
100
  css: errorStyles,
101
101
  "data-testid": "link-create-form-error"
102
102
  }, (0, _react2.jsx)(_error.default, {
@@ -13,7 +13,7 @@ var _form = require("@atlaskit/form");
13
13
  var _textfield = _interopRequireDefault(require("@atlaskit/textfield"));
14
14
  var _form2 = require("../../../common/utils/form");
15
15
  var _formContext = require("../../../controllers/form-context");
16
- var _excluded = ["label", "name", "validationHelpText", "validators", "defaultValue"];
16
+ var _excluded = ["label", "name", "validationHelpText", "validators", "defaultValue", "isRequired"];
17
17
  /** @jsx jsx */
18
18
  /**
19
19
  * A text field utilising the Atlaskit Textfield and Field objects from `@atlaskit/form`.
@@ -28,6 +28,7 @@ function TextField(_ref) {
28
28
  validationHelpText = _ref.validationHelpText,
29
29
  validators = _ref.validators,
30
30
  defaultValue = _ref.defaultValue,
31
+ isRequired = _ref.isRequired,
31
32
  restProps = (0, _objectWithoutProperties2.default)(_ref, _excluded);
32
33
  var _useFormContext = (0, _formContext.useFormContext)(),
33
34
  assignValidator = _useFormContext.assignValidator;
@@ -47,6 +48,7 @@ function TextField(_ref) {
47
48
  (0, _react2.jsx)(_form.Field, {
48
49
  name: name,
49
50
  label: label,
51
+ isRequired: isRequired,
50
52
  defaultValue: defaultValue !== null && defaultValue !== void 0 ? defaultValue : ''
51
53
  }, function (_ref2) {
52
54
  var fieldProps = _ref2.fieldProps,
@@ -54,7 +56,8 @@ function TextField(_ref) {
54
56
  error = _ref2.error;
55
57
  var isInvalid = (0, _form2.validateSubmitErrors)(meta);
56
58
  return (0, _react2.jsx)(_react.Fragment, null, (0, _react2.jsx)(_textfield.default, (0, _extends2.default)({}, fieldProps, restProps, {
57
- isInvalid: isInvalid
59
+ isInvalid: isInvalid,
60
+ isRequired: false // Remove the default browser validation
58
61
  })), !error && validationHelpText && (0, _react2.jsx)(_form.HelperMessage, null, validationHelpText), error && isInvalid && (0, _react2.jsx)(_form.ErrorMessage, {
59
62
  testId: "".concat(restProps.testId, "-error-message")
60
63
  }, error));
@@ -93,7 +93,8 @@ var LinkCreateWithModal = function LinkCreateWithModal(props) {
93
93
  testId: testId,
94
94
  shouldScrollInViewport: true,
95
95
  onOpenComplete: handleOpenComplete,
96
- onCloseComplete: handleCloseComplete
96
+ onCloseComplete: handleCloseComplete,
97
+ width: "".concat(_constants.CREATE_FORM_MAX_WIDTH_IN_PX, "px")
97
98
  }, (0, _react2.jsx)(_modalDialog.ModalHeader, null, (0, _react2.jsx)(_modalDialog.ModalTitle, null, intl.formatMessage(_messages.messages.heading))), (0, _react2.jsx)(_modalDialog.ModalBody, null, (0, _react2.jsx)(_errorBoundary.ErrorBoundary, null, (0, _react2.jsx)(_formContext.FormContextProvider, null, (0, _react2.jsx)(LinkCreate, props))))));
98
99
  };
99
100
  var LinkCreateWithAnalyticsContext = (0, _analytics.withLinkCreateAnalyticsContext)( /*#__PURE__*/(0, _react.memo)(function (_ref3) {
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "name": "@atlaskit/link-create",
3
- "version": "0.5.7",
3
+ "version": "0.6.0",
4
4
  "sideEffects": false
5
5
  }
@@ -1,4 +1,4 @@
1
1
  export const ANALYTICS_CHANNEL = 'media';
2
2
  export const COMPONENT_NAME = 'linkCreate';
3
- export const CREATE_FORM_MAX_WIDTH_IN_PX = '600';
3
+ export const CREATE_FORM_MAX_WIDTH_IN_PX = '480';
4
4
  export const CREATE_FORM_MIN_HEIGHT_IN_PX = '200';
@@ -7,7 +7,7 @@ import { useAnalyticsEvents } from '@atlaskit/analytics-next';
7
7
  import { ButtonGroup } from '@atlaskit/button';
8
8
  import LoadingButton from '@atlaskit/button/loading-button';
9
9
  import Button from '@atlaskit/button/standard-button';
10
- import Form, { FormFooter, FormSection } from '@atlaskit/form';
10
+ import Form, { FormFooter } from '@atlaskit/form';
11
11
  import ErrorIcon from '@atlaskit/icon/glyph/error';
12
12
  import { ANALYTICS_CHANNEL, CREATE_FORM_MAX_WIDTH_IN_PX } from '../../common/constants';
13
13
  import createEventPayload from '../../common/utils/analytics/analytics.codegen';
@@ -69,7 +69,7 @@ export const CreateForm = ({
69
69
  name: "confluence-creation-form",
70
70
  "data-testid": testId,
71
71
  css: formStyles
72
- }), jsx(FormSection, null, children), !hideFooter && jsx(FormFooter, null, formErrorMessage && jsx("div", {
72
+ }), jsx("div", null, children), !hideFooter && jsx(FormFooter, null, formErrorMessage && jsx("div", {
73
73
  css: errorStyles,
74
74
  "data-testid": "link-create-form-error"
75
75
  }, jsx(ErrorIcon, {
@@ -19,6 +19,7 @@ export function TextField({
19
19
  validationHelpText,
20
20
  validators,
21
21
  defaultValue,
22
+ isRequired,
22
23
  ...restProps
23
24
  }) {
24
25
  const {
@@ -40,6 +41,7 @@ export function TextField({
40
41
  jsx(Field, {
41
42
  name: name,
42
43
  label: label,
44
+ isRequired: isRequired,
43
45
  defaultValue: defaultValue !== null && defaultValue !== void 0 ? defaultValue : ''
44
46
  }, ({
45
47
  fieldProps,
@@ -48,7 +50,8 @@ export function TextField({
48
50
  }) => {
49
51
  const isInvalid = validateSubmitErrors(meta);
50
52
  return jsx(Fragment, null, jsx(AkTextfield, _extends({}, fieldProps, restProps, {
51
- isInvalid: isInvalid
53
+ isInvalid: isInvalid,
54
+ isRequired: false // Remove the default browser validation
52
55
  })), !error && validationHelpText && jsx(HelperMessage, null, validationHelpText), error && isInvalid && jsx(ErrorMessage, {
53
56
  testId: `${restProps.testId}-error-message`
54
57
  }, error));
@@ -4,7 +4,7 @@ import { jsx } from '@emotion/react';
4
4
  import { useIntl } from 'react-intl-next';
5
5
  import { AnalyticsContext, useAnalyticsEvents } from '@atlaskit/analytics-next';
6
6
  import Modal, { ModalBody, ModalHeader, ModalTitle, ModalTransition } from '@atlaskit/modal-dialog';
7
- import { ANALYTICS_CHANNEL, COMPONENT_NAME } from '../common/constants';
7
+ import { ANALYTICS_CHANNEL, COMPONENT_NAME, CREATE_FORM_MAX_WIDTH_IN_PX } from '../common/constants';
8
8
  import { withLinkCreateAnalyticsContext } from '../common/utils/analytics';
9
9
  import createEventPayload from '../common/utils/analytics/analytics.codegen';
10
10
  import { LinkCreateCallbackProvider } from '../controllers/callback-context';
@@ -65,7 +65,8 @@ const LinkCreateWithModal = props => {
65
65
  testId: testId,
66
66
  shouldScrollInViewport: true,
67
67
  onOpenComplete: handleOpenComplete,
68
- onCloseComplete: handleCloseComplete
68
+ onCloseComplete: handleCloseComplete,
69
+ width: `${CREATE_FORM_MAX_WIDTH_IN_PX}px`
69
70
  }, jsx(ModalHeader, null, jsx(ModalTitle, null, intl.formatMessage(messages.heading))), jsx(ModalBody, null, jsx(ErrorBoundary, null, jsx(FormContextProvider, null, jsx(LinkCreate, props))))));
70
71
  };
71
72
  const LinkCreateWithAnalyticsContext = withLinkCreateAnalyticsContext( /*#__PURE__*/memo(({
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "name": "@atlaskit/link-create",
3
- "version": "0.5.7",
3
+ "version": "0.6.0",
4
4
  "sideEffects": false
5
5
  }
@@ -1,4 +1,4 @@
1
1
  export var ANALYTICS_CHANNEL = 'media';
2
2
  export var COMPONENT_NAME = 'linkCreate';
3
- export var CREATE_FORM_MAX_WIDTH_IN_PX = '600';
3
+ export var CREATE_FORM_MAX_WIDTH_IN_PX = '480';
4
4
  export var CREATE_FORM_MIN_HEIGHT_IN_PX = '200';
@@ -9,7 +9,7 @@ import { useAnalyticsEvents } from '@atlaskit/analytics-next';
9
9
  import { ButtonGroup } from '@atlaskit/button';
10
10
  import LoadingButton from '@atlaskit/button/loading-button';
11
11
  import Button from '@atlaskit/button/standard-button';
12
- import Form, { FormFooter, FormSection } from '@atlaskit/form';
12
+ import Form, { FormFooter } from '@atlaskit/form';
13
13
  import ErrorIcon from '@atlaskit/icon/glyph/error';
14
14
  import { ANALYTICS_CHANNEL, CREATE_FORM_MAX_WIDTH_IN_PX } from '../../common/constants';
15
15
  import createEventPayload from '../../common/utils/analytics/analytics.codegen';
@@ -85,7 +85,7 @@ export var CreateForm = function CreateForm(_ref) {
85
85
  name: "confluence-creation-form",
86
86
  "data-testid": testId,
87
87
  css: formStyles
88
- }), jsx(FormSection, null, children), !hideFooter && jsx(FormFooter, null, formErrorMessage && jsx("div", {
88
+ }), jsx("div", null, children), !hideFooter && jsx(FormFooter, null, formErrorMessage && jsx("div", {
89
89
  css: errorStyles,
90
90
  "data-testid": "link-create-form-error"
91
91
  }, jsx(ErrorIcon, {
@@ -1,6 +1,6 @@
1
1
  import _extends from "@babel/runtime/helpers/extends";
2
2
  import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
3
- var _excluded = ["label", "name", "validationHelpText", "validators", "defaultValue"];
3
+ var _excluded = ["label", "name", "validationHelpText", "validators", "defaultValue", "isRequired"];
4
4
  /** @jsx jsx */
5
5
  import { Fragment, useEffect } from 'react';
6
6
  import { jsx } from '@emotion/react';
@@ -21,6 +21,7 @@ export function TextField(_ref) {
21
21
  validationHelpText = _ref.validationHelpText,
22
22
  validators = _ref.validators,
23
23
  defaultValue = _ref.defaultValue,
24
+ isRequired = _ref.isRequired,
24
25
  restProps = _objectWithoutProperties(_ref, _excluded);
25
26
  var _useFormContext = useFormContext(),
26
27
  assignValidator = _useFormContext.assignValidator;
@@ -40,6 +41,7 @@ export function TextField(_ref) {
40
41
  jsx(Field, {
41
42
  name: name,
42
43
  label: label,
44
+ isRequired: isRequired,
43
45
  defaultValue: defaultValue !== null && defaultValue !== void 0 ? defaultValue : ''
44
46
  }, function (_ref2) {
45
47
  var fieldProps = _ref2.fieldProps,
@@ -47,7 +49,8 @@ export function TextField(_ref) {
47
49
  error = _ref2.error;
48
50
  var isInvalid = validateSubmitErrors(meta);
49
51
  return jsx(Fragment, null, jsx(AkTextfield, _extends({}, fieldProps, restProps, {
50
- isInvalid: isInvalid
52
+ isInvalid: isInvalid,
53
+ isRequired: false // Remove the default browser validation
51
54
  })), !error && validationHelpText && jsx(HelperMessage, null, validationHelpText), error && isInvalid && jsx(ErrorMessage, {
52
55
  testId: "".concat(restProps.testId, "-error-message")
53
56
  }, error));
@@ -8,7 +8,7 @@ import { jsx } from '@emotion/react';
8
8
  import { useIntl } from 'react-intl-next';
9
9
  import { AnalyticsContext, useAnalyticsEvents } from '@atlaskit/analytics-next';
10
10
  import Modal, { ModalBody, ModalHeader, ModalTitle, ModalTransition } from '@atlaskit/modal-dialog';
11
- import { ANALYTICS_CHANNEL, COMPONENT_NAME } from '../common/constants';
11
+ import { ANALYTICS_CHANNEL, COMPONENT_NAME, CREATE_FORM_MAX_WIDTH_IN_PX } from '../common/constants';
12
12
  import { withLinkCreateAnalyticsContext } from '../common/utils/analytics';
13
13
  import createEventPayload from '../common/utils/analytics/analytics.codegen';
14
14
  import { LinkCreateCallbackProvider } from '../controllers/callback-context';
@@ -82,7 +82,8 @@ var LinkCreateWithModal = function LinkCreateWithModal(props) {
82
82
  testId: testId,
83
83
  shouldScrollInViewport: true,
84
84
  onOpenComplete: handleOpenComplete,
85
- onCloseComplete: handleCloseComplete
85
+ onCloseComplete: handleCloseComplete,
86
+ width: "".concat(CREATE_FORM_MAX_WIDTH_IN_PX, "px")
86
87
  }, jsx(ModalHeader, null, jsx(ModalTitle, null, intl.formatMessage(messages.heading))), jsx(ModalBody, null, jsx(ErrorBoundary, null, jsx(FormContextProvider, null, jsx(LinkCreate, props))))));
87
88
  };
88
89
  var LinkCreateWithAnalyticsContext = withLinkCreateAnalyticsContext( /*#__PURE__*/memo(function (_ref3) {
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "name": "@atlaskit/link-create",
3
- "version": "0.5.7",
3
+ "version": "0.6.0",
4
4
  "sideEffects": false
5
5
  }
@@ -1,4 +1,4 @@
1
1
  export declare const ANALYTICS_CHANNEL = "media";
2
2
  export declare const COMPONENT_NAME = "linkCreate";
3
- export declare const CREATE_FORM_MAX_WIDTH_IN_PX = "600";
3
+ export declare const CREATE_FORM_MAX_WIDTH_IN_PX = "480";
4
4
  export declare const CREATE_FORM_MIN_HEIGHT_IN_PX = "200";
@@ -6,4 +6,4 @@ import { TextFieldProps } from './types';
6
6
  * the handleSubmit function passed to the form <Form> that have a key matching the `name`
7
7
  * of this text field are shown above the field.
8
8
  */
9
- export declare function TextField({ label, name, validationHelpText, validators, defaultValue, ...restProps }: TextFieldProps): jsx.JSX.Element;
9
+ export declare function TextField({ label, name, validationHelpText, validators, defaultValue, isRequired, ...restProps }: TextFieldProps): jsx.JSX.Element;
@@ -1,6 +1,6 @@
1
1
  import { TextFieldProps as AKTextFieldProps } from '@atlaskit/textfield';
2
2
  import { Validator } from '../../../common/types';
3
- export type TextFieldProps = Omit<AKTextFieldProps, 'name' | 'isRequired'> & {
3
+ export type TextFieldProps = Omit<AKTextFieldProps, 'name'> & {
4
4
  /** Name passed to the <Field>.*/
5
5
  name: string;
6
6
  label?: string;
@@ -1,4 +1,4 @@
1
1
  export declare const ANALYTICS_CHANNEL = "media";
2
2
  export declare const COMPONENT_NAME = "linkCreate";
3
- export declare const CREATE_FORM_MAX_WIDTH_IN_PX = "600";
3
+ export declare const CREATE_FORM_MAX_WIDTH_IN_PX = "480";
4
4
  export declare const CREATE_FORM_MIN_HEIGHT_IN_PX = "200";
@@ -6,4 +6,4 @@ import { TextFieldProps } from './types';
6
6
  * the handleSubmit function passed to the form <Form> that have a key matching the `name`
7
7
  * of this text field are shown above the field.
8
8
  */
9
- export declare function TextField({ label, name, validationHelpText, validators, defaultValue, ...restProps }: TextFieldProps): jsx.JSX.Element;
9
+ export declare function TextField({ label, name, validationHelpText, validators, defaultValue, isRequired, ...restProps }: TextFieldProps): jsx.JSX.Element;
@@ -1,6 +1,6 @@
1
1
  import { TextFieldProps as AKTextFieldProps } from '@atlaskit/textfield';
2
2
  import { Validator } from '../../../common/types';
3
- export type TextFieldProps = Omit<AKTextFieldProps, 'name' | 'isRequired'> & {
3
+ export type TextFieldProps = Omit<AKTextFieldProps, 'name'> & {
4
4
  /** Name passed to the <Field>.*/
5
5
  name: string;
6
6
  label?: string;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/link-create",
3
- "version": "0.5.7",
3
+ "version": "0.6.0",
4
4
  "description": "The driver component of meta creation flow",
5
5
  "author": "Atlassian Pty Ltd",
6
6
  "license": "Apache-2.0",
@@ -53,14 +53,14 @@
53
53
  },
54
54
  "devDependencies": {
55
55
  "@atlaskit/docs": "*",
56
- "@atlaskit/link-picker": "^1.22.0",
56
+ "@atlaskit/link-picker": "^1.23.0",
57
57
  "@atlaskit/link-test-helpers": "^4.0.0",
58
58
  "@atlaskit/popup": "^1.6.0",
59
59
  "@atlaskit/visual-regression": "*",
60
60
  "@atlassian/atlassian-frontend-prettier-config-1.0.0": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.0",
61
- "@atlassian/link-create-confluence": "^6.1.0",
62
- "@atlassian/link-create-presets": "^4.0.0",
63
- "@atlassian/link-picker-atlassian-plugin": "^33.0.0",
61
+ "@atlassian/link-create-confluence": "^7.0.0",
62
+ "@atlassian/link-create-presets": "^5.0.0",
63
+ "@atlassian/link-picker-atlassian-plugin": "^33.3.0",
64
64
  "@testing-library/react": "^12.1.5",
65
65
  "@testing-library/user-event": "^14.4.3",
66
66
  "fetch-mock": "^8.0.0",
package/report.api.md CHANGED
@@ -158,11 +158,12 @@ export function TextField({
158
158
  validationHelpText,
159
159
  validators,
160
160
  defaultValue,
161
+ isRequired,
161
162
  ...restProps
162
163
  }: TextFieldProps): jsx.JSX.Element;
163
164
 
164
165
  // @public (undocumented)
165
- type TextFieldProps = Omit<TextFieldProps_2, 'isRequired' | 'name'> & {
166
+ type TextFieldProps = Omit<TextFieldProps_2, 'name'> & {
166
167
  name: string;
167
168
  label?: string;
168
169
  validationHelpText?: string;
@@ -121,10 +121,10 @@ interface Option_2 {
121
121
  export { Option_2 as Option }
122
122
 
123
123
  // @public
124
- export function TextField({ label, name, validationHelpText, validators, defaultValue, ...restProps }: TextFieldProps): jsx.JSX.Element;
124
+ export function TextField({ label, name, validationHelpText, validators, defaultValue, isRequired, ...restProps }: TextFieldProps): jsx.JSX.Element;
125
125
 
126
126
  // @public (undocumented)
127
- type TextFieldProps = Omit<TextFieldProps_2, 'isRequired' | 'name'> & {
127
+ type TextFieldProps = Omit<TextFieldProps_2, 'name'> & {
128
128
  name: string;
129
129
  label?: string;
130
130
  validationHelpText?: string;